The following patch fixes the problem.
The test fails on *-apple-darwin*: pr51916.
TIA
Dominique
Dominique or Iain, may I ask you to test this patch on darwin? I have a
sporadic access to a darwin machine.
The patch fixes the PR without regression on x86_64-apple-darwin10.
Bootstraping on powerpc-apple-darwin9 will finish in a couple hours.
Thanks for the debugging and the patch,
Revision 183457 breaks bootstrap on darwin (pr51985).
TIA
Dominique
Dear Tobias,
I have this patch in my working tree since Jan 22. It works as advertised
without regression. Note that it does not fix the ICE for the first test:
pr41600.f90:1:0: internal compiler error: in gfc_conv_component_ref, at
fortran/trans-expr.c:1131
Thanks,
Dominique
Thomas,
The test fails on powerpc-apple-darwin9 because double are not
vectorized. I think the following patch is required:
--- /opt/gcc/_gcc_clean/gcc/testsuite/gfortran.dg/vect/vect-8.f90
2012-02-05 23:32:31.0 +0100
+++ /opt/gcc/work/gcc/testsuite/gfortran.dg/vect/vect-8.f90
Committed as r202101.
This cause a bootstrap failure:
...
libtool: compile: /opt/gcc/build_w/./gcc/xg++ -B/opt/gcc/build_w/./gcc/
-nostdinc++ -nostdinc++
-I/opt/gcc/build_w/x86_64-apple-darwin10.8.0/libstdc++-v3/include/x86_64-apple-darwin10.8.0
I've just merged ubsan into trunk. Please send complaints my way.
Bootstrap is broken on x86_64-apple-darwin10:
Making all in ubsan
make[4]: *** No rule to make target `../interception/libinterception.la',
needed by `libubsan.la'. Stop.
make[3]: *** [all-recursive] Error 1
make[2]: ***
bootstrapped x86_64-darwin12 for c,c++ and fortran ...
Bootstrapped x86_64-apple-darwin10 for c,c++,fortran,java and
also tested asan.exp and ubsan.exp for gcc and g++.
Thanks for the patch,
Dominique
The test g++.dg/torture/pr58380.C fails:
FAIL: g++.dg/torture/pr58380.C -O0 (test for excess errors)
FAIL: g++.dg/torture/pr58380.C -O1 (test for excess errors)
FAIL: g++.dg/torture/pr58380.C -O2 (test for excess errors)
FAIL: g++.dg/torture/pr58380.C -O3 -fomit-frame-pointer (test for
Adam Butcher wrote:
From: abutcher abutcher@138bc75d-0d04-0410-961f-82ee72b054a4
* lambda.c (lambda_function): Return template result if call operator is
a template.
I believe that that patch causes the following build failure of cp/lambda.c:
...
PS: I am not positive since I
This is a followup on Thomas' proposal at
...
This commit (r202518) breaks bootstrap on x86_64-apple-darwin10
(I have bootstrapped r202538 with the commit reverted):
/opt/gcc/build_w/./gcc/xgcc -B/opt/gcc/build_w/./gcc/
-B/opt/gcc/gcc4.9w/x86_64-apple-darwin10.8.0/bin/
The bootstrap failure is fixed with the following patch:
[macbook] gcc/work% diff -up ../_clean/gcc/ada/gcc-interface/Makefile.in
gcc/ada/gcc-interface/Makefile.in
--- ../_clean/gcc/ada/gcc-interface/Makefile.in 2013-09-12 13:18:34.0
+0200
+++ gcc/ada/gcc-interface/Makefile.in
The new test gcc.dg/tree-ssa/slsr-39.c fails in 64 bit mode (see
http://gcc.gnu.org/ml/gcc-regression/2013-09/msg00455.html ).
Looking for MEM in the dump returns
_12 = MEM[(int[50] *)_17];
MEM[(int[50] *)_20] = _13;
TIA
Dominique
Sriraman,
The tests gcc.target/i386/funcspec-5.c and gcc.target/i386/pr57756.c fail
on targets for which -msse is the default (see
http://gcc.gnu.org/ml/gcc-testresults/2013-10/msg01365.html or
http://gcc.gnu.org/ml/gcc-testresults/2013-10/msg01345.html ).
This is fixed with the following
I see why pr57756.c could fail, if -msse4.2 is turned on by default. I
think this test needs {dg-options -mno-sse4.2}.
This change allows the test to pass. The failure of
gcc.target/i386/funcspec-5.c is
/opt/gcc/work/gcc/testsuite/gcc.target/i386/funcspec-5.c:34:1: warning: SSE
instruction
Paolo Carlini wrote:
Patch is Ok with me. Before committing you may want to test -m32 too.
Obviously, you did not!-(see
http://gcc.gnu.org/ml/gcc-testresults/2013-10/msg01471.html
FAIL: tr2/dynamic_bitset/pr58729.cc execution test
On x86_64-apple-darwin12, the failure is
Assertion failed:
I am seeing a bootstrap failure that seems related: ...
Me too,
Dominique
The tests introduced in revision 204544 fail with -m32
(see http://gcc.gnu.org/ml/gcc-regression/2013-11/msg00213.html
or http://gcc.gnu.org/ml/gcc-testresults/2013-11/msg00526.html ).
This revision may also causes the failures of
gfortran.dg/typebound_operator_9.f03 and
FAIL:
According to http://gcc.gnu.org/ml/gcc-regression/2013-11/msg00197.html
revision 204538 is breaking several tests. On x86_64-apple-darwin* the
failures I have looked at are of the kind
/opt/gcc/work/gcc/testsuite/gfortran.dg/typebound_operator_9.f03: In function
'nabla2_cart2d':
I doubt the patch affects Fortran (there are language-independent changes,
but they are fairly small and shouldn't affect code not using _Atomic
qualifiers).
The Fortran failures seem related to revision 204538.
Dominique
Thank you for the report. I have submitted a bug fix patch waiting to
be reviewed.
The patch fixes the fortran failures (tested on gfortran an libgomp only).
Thanks,
Dominique
I hope this patch will fix the issues people have seen with atomics
tests failing on 32-bit architectures with missing __atomic_*_16 (or
at least replace them by different problems). I'm running tests on
x86_64-unknown-linux-gnu; perhaps someone seeing the 32-bit problems
could test it
Typical very long run output:
[Book15] f90/bug% gcc49 -std=c11 -pedantic-errors -pthread
-D_POSIX_C_SOURCE=200809L
/opt/gcc/work/gcc/testsuite/gcc.dg/atomic/c11-atomic-exec-5.c
-L/opt/gcc/build_w/x86_64-apple-darwin13.0.0/i386/./libatomic/.libs -latomic
-m32
[Book15] f90/bug% time a.out
Nicola,
On x86_64-apple-darwin10 I have the following failures with -m32
FAIL: obj-c++.dg/threedotthree-abi-1.mm -fnext-runtime (test for excess errors)
FAIL: obj-c++.dg/torture/strings/const-str-10.mm -O0 -fnext-runtime (test for
excess errors)
FAIL:
... So, how do you test with -m32 ? ...
make -k check-obj-c++ RUNTESTFLAGS=--target_board=unix'{-m32,-m64}'
On x86_64-apple-darwin10 (Mac OS X 10.6) -m64 is the default and
could be omitted after the comma, but the above works also on ppc
for which the default is -m32.
The revamped patch in
Andi,
PR49344 occured between 174833 and 174836 which correspond to your commits
for this patch and the two other ones. Could you please have a look?
BTW what is the way to CC you in bugzilla?
TIA
Dominique
Mike, Sharad,
Committed in r192750.
Thanks for the review and the commit.
Dominique
I have now committed the attached patch.
This (r193204) breaks bootstrap on x86_64-apple-darwin10:
...
/opt/gcc/build_a/./prev-gcc/g++ -B/opt/gcc/build_a/./prev-gcc/
-B/opt/gcc/gcc4.8a/x86_64-apple-darwin10.8.0/bin/ -nostdinc++
Committed as attached. Thanks everyone.
This (r193267) breaks bootstrap on x86_64-apple-darwin10:
...
g++ -c -g -DIN_GCC -fno-exceptions -fno-rtti -fasynchronous-unwind-tables
-W -Wall -Wno-narrowing -Wwrite-strings -Wcast-qual -Wmissing-format-attribute
-pedantic -Wno-long-long
I'm testing the enclosed patch on my end. Does it happen to work for you?
I am now past the previous error. Full answer tomorrow morning.
Thanks
Dominique
This should be fixed by a patch I committed directly before you
sent your mail (which is why you did not see it yet). Can you
please verify?
Bootstrap has completed at revision 193278 (with the patch for
dwarf2out.c.
Thanks,
Dominique
Yes. And it shouldn't be just based on target CPU, but also based
on target OS, I don't think libsanitizer supports anything but linux (glibc
+ maybe android) right now, with some smaller or bigger tweaks it could
support darwin (but see the reports that it doesn't build there right now)
...
Did you notice that gcc.c-torture/compile/pr43186.c regressed? It now again
takes a while to compile, so times out on slow machines:
...
On a 2.5Ghz Core2Duo, compiling the test with revision 192891 (2012-10-28)
takes a small fraction of a second, while with revision 193270 (2012-11-06)
it
I think this should fix it. Can't test it right now, so help
appreciated (Honza: hint hint! ;-)
The change at
http://gcc.gnu.org/ml/gcc-patches/2012-10/msg01511/remove_dead_eq_notes.diff
(revision 192526) caused
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55006
Dominique
Hi Jan,
this is patch I will try to test once I have chance :)
It simply prevents unroller from analyzing loops when they are already too
large.
...
This patch breaks bootstrap with
...
/opt/gcc/p_build/./prev-gcc/g++ -B/opt/gcc/p_build/./prev-gcc/
... I believe I posted a patch?
Yes: http://gcc.gnu.org/ml/gcc-patches/2012-11/msg01799.html
I have found another fall out: I have some avatars of the polyhedron tests
where the REAL(8) have been replaced with REAL(10). Some of them are now
Should I open a new PR for that?
Cheers,
Dominique
My mailer has eaten a line in my previous mail. One should read:
I have found another fall out: I have some avatars of the polyhedron tests
where the REAL(8) have been replaced with REAL(10). Some of them are now ~50%
slower with the new value of max-completely-peeled-insns.
Should I open a new
Or rather this one. Same hammer, different color. It turns out that
the rtlanal.c change caused problems, so I've got to use a home-brewn
equivalent of remove_reg_equal_equiv_notes_for_regno...
This does not fix pr55006 on x86_64-apple-darwin10;-(while the patch in
Dominique, could you give this a try and see if it helps?
With the patch, the miscompilation of aermod.f90 is gone.
Thanks,
Dominique
And more band-aid, ...
The gcc_assert triggers at bootstrap when compiling gcc/ada/ali.adb:
+===GNAT BUG DETECTED==+
| 4.8.0 20121127 (experimental) [trunk revision 193848p10]
(x86_64-apple-darwin10.8.0) GCC error:|
| in
Of course, I also verified that the darwin10 and sparc issues that
spawned this long thread are fixed.
Confirmed: bootstrapped on top of r193939, aermod.f90 is now correctly
compiled.
Thanks,
Dominique
On Wed Nov 13 07:53:25 2013, Jeff Law wrote:
I'll have a patch going through testing overnight.
If you have a patch, could you post it please?
TIA
Dominique
The test c-c++-common/cilk-plus/PS/reduction-3.c fails on *-apple-darwin*
because it has no malloc.h header. Tested on x86_64-apple-darwin13.
OK?
Note that although I have the FSF papers signed, I don't have write access.
If approved, someone will have to commit the patch for me.
Dominique
Adjust the following tests to take into account the change of
Length of Public Names Info to Pub Info Length
in revision 203936. Tested on x86_64-apple-darwin13. OK?
Dominique
2013-11-18 Dominique d'Humieres domi...@lps.ens.fr
PR testsuite/59043
* g++.dg/pubtypes.C: Adjust the
Thanks: Committed revision 205038.
This seems to break several g++ tests: see
http://gcc.gnu.org/ml/gcc-testresults/2013-11/msg01482.html
On x86_64-apple-darwin13, the ICE is
cc1: error: cannot load plugin ./one_time_plugin.so
dlopen(./one_time_plugin.so, 10): image not found
Basile,
http://gcc.gnu.org/ml/gcc-testresults/2013-11/msg01482.html is for
x86_64-unknown-linux-gnu. However I cannot infer from the pointer
what is the ICE. Nevertheless I'll try your patch.
Thanks for the answer.
Dominique
Basile,
The patch fixes most of the plugin failures except:
FAIL: g++.dg/plugin/selfassign.c compilation
The error is
/opt/gcc/work/gcc/testsuite/g++.dg/plugin/selfassign.c: In function 'void
warn_self_assign(gimple)':
/opt/gcc/work/gcc/testsuite/g++.dg/plugin/selfassign.c:227:75: error:
... I bet strnlen isn't available everywhere.
You won!-(it is not available on darwin10) I had to change the strnlen
to strlen in order to bootstrap.
Dominique
A lot of failures in the test suite have appeared between revisions
191485 and 191494 see
http://gcc.gnu.org/ml/gcc-regression/2012-09/msg00327.html ).
I have looked at the failure of libgomp.fortran/reduction1.f90:
[macbook] f90/bug% gfc -O3 -g -fopenmp
This problem will be fixed by
http://gcc.gnu.org/ml/gcc-patches/2012-09/msg01491.html
Sorry, but its not (see pr54645 c#3).
Dominique
Hi Dehao,
You wrote:
4. http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54650
Failed one regression test in libgomp (I didn't know that there are
regression tests for libraries before...)
This error should be a bug exposed by this patch. I'll try to provide
a patch as soon as possible.
See
Jack,
The patch does not seem to work on powerpc-apple-darwin9:
Executing on host: /opt/gcc/darwin_buildw/gcc/xgcc
-B/opt/gcc/darwin_buildw/gcc/
/opt/gcc/work/gcc/testsuite/gcc.dg/torture/pr53922.c -fno-diagnostic
s-show-caret -O0 -Wl,-undefined,dynamic_lookup -lm -m32 -o ./pr53922.exe
On Thu, Sep 20, 2012 at 10:33 PM, Ian Lance Taylor i...@google.com wrote:
Ping.
The patch is the same, so I didn't attach it again. It may be found
at http://gcc.gnu.org/ml/gcc-patches/2012-09/msg01174.html . I think
I've replied to all comments.
It also breaks the building of the Ada
Hi Tobias,
I have tested your patch, mostly the added test cases.
I think the test gfortran.dg/class_optional_2.f90 should be split:
it has too much tests lumped together. In addition
the test gfortran.dg/class_optional_1.f90 does not compile
because symbol 'i' at (1) has no IMPLICIT type (three
It appears that the patch should also special case the scan-assembler
.internal.*Foo.methodEv
tests in g++.dg/ext/visibility/pragma-override1.C and
g++.dg/ext/visibility/pragma-override2.C
on darwin as well...
Done, thanks.
Jason,
These tests are still failing on darwin. I
The following patch fixes PR52945 on Darwin. It as beem approved
by Jan Hubicka in PR52945#c5. Since I don't have write permission,
could someone commit it for me?
TIA
Dominique
2012-10-08 Dominique d'Humieres domi...@lps.ens.fr
PR gcc/52945
*
These tests are still failing on darwin. I think tha
target { ! *-*-solaris2* } { ! *-*-darwin* }
sould be replaced with
target { ! { *-*-solaris2* *-*-darwin* } }
Could someone with a darwin box handy make the appropriate change?
I have never really understood the logic of the target
On x86_64-apple-darwin10 The following tests:
g++.dg/gomp/tls-5.C
g++.dg/tls/thread_local-cse.C
g++.dg/tls/thread_local-order*.C
g++.dg/tls/thread_local*g.C
fail with
sorry, unimplemented: dynamic initialization of non-function-local thread_local
variables not supported on this target
In
These don't work because of the lack of alias support; that's why I put
dg-require-alias in the tests. Do I need a different magic incantation?
I understand nothing about alias, weak, ... stuff, but from pr52945, if you need
weak-alias, then you have also to use
/* { dg-require-weak } */
FAIL: g++.dg/tls/thread_local3.C -std=gnu++11 execution test
FAIL: g++.dg/tls/thread_local4.C -std=gnu++11 execution test
These ought to work. Can you debug the problem?
Backtrace for thread_local4.C
Program received signal SIGSEGV, Segmentation fault.
[Switching to Thread 0x1503 of
Hi,
The tests gcc.dg/vect/vect-82_64.c and gcc.dg/vect/vect-83_64.c are
failing on powerpc*-*-* (see for instance
http://gcc.gnu.org/ml/gcc-testresults/2012-10/msg01054.html ).
This is fixed with the following patch
diff -up gcc/testsuite/gcc.dg/vect/vect-82_64.c
Jack,
That's PR 54407, so not a regression.
... The pthreads support is definitely improved in darwin11 and later.
Do you confirm that 30_threads/condition_variable/54185.cc is passing on
darwin11 and 12?
If yes, I'll test a patch to skip it on darwin10 and older.
Dominique
Hi Tobias,
I did not yet appied you latest patch to gfortran, but I ran the new tests
with gfortran patched with the previous patch and both pass (manual
testing without option, but -fcoarray=single). Note that for
class_optional_1.f90, valgrind --leak-check=full gives
==45665== 4 bytes in 1
Tobias,
The previous class_optional_2.f90 runs after your commit, but it takes
~168s (so it may have run with the previous patch also, but I was not
patient enough to see it). The culprits are given by the following
profile:
+ 100.0%, start, a.out
| + 100.0%, main, a.out
| | + 100.0%, MAIN__,
Janus,
Your patch works as advertised without disturbing my pet bugs.
Just a nit pick: the double parentheses in
+ if ((CLASS_DATA (select_type_stack-selector)-attr.dimension
|| CLASS_DATA (select_type_stack-selector)-attr.codimension))
do not seem necessary.
Note for Paul: I
2012-10-17 Michael Meissner meiss...@linux.vnet.ibm.com
* config/rs6000/rs6000.opt (rs6000_isa_flags): New flag word to
replace target_flags that gives us 63 possible switches.
(x_rs6000_isa_flags): Save area for rs6000_isa_flags.
(x_rs6000_isa_flags_explicit):
Eric and Dominique could you try it on your respective systems? Thanks in
advance.
It works for me, thanks.
It does not for me:
In file included from ../../work/gcc/config/rs6000/rs6000.c:1475:0:
../../work/gcc/config/rs6000/rs6000-cpus.def:54:0: error: MASK_STRICT_ALIGN
redefined
Could someone commit the patch at
http://gcc.gnu.org/ml/gcc-patches/2012-10/msg00758.html ?
TIA
Dominique
This patch (r192676) is probably causing
FAIL: gcc.c-torture/execute/builtins/memcpy-chk.c execution, -Os
FAIL: gcc.c-torture/execute/builtins/memmove-chk.c execution, -Os
FAIL: gcc.c-torture/execute/builtins/mempcpy-chk.c execution, -Os
FAIL: gcc.c-torture/execute/builtins/memset-chk.c
The test libgomp.graphite/force-parallel-6.c is not valid as it tries
to write Y[2*N] for Y defined as
int X[2*N], Y[2*N], B[2*N];
This patch fixes the bounds of the loops in order to make the test valid
Since I don't have write access, could someone commit the patch if it
is approved?
Following the changes in [PATCH] Add option for dumping to stderr (issue6190057)
the tests gcc.dg/vect/vect-8[23]_64.c fails on powerpc*-*-*.
This patch adjust the dump files and has been tested on powerpc-apple-darwin9.
If approved could someone commit it for me (no write access).
Note that
Uros,
I think the '\\' should be removed from
/* { dg-final { scan-assembler-times \\vec_concatv2di/3 1 } } */
TIA
Dominique
Can you please commit the fixup patch, I am away from my keyboard today.
Sorry, I don't have write access.
Dominique
Sure, will update the patch for that. ...
This cause pr57413.
Dominique
PS the escaping in the regexp seems strange: \[0-9]
Honza,
This caused/exposed pr57467.
TIA
Dominique
... This patch pasted below should fix that issue. ...
A quick test on darwin (no bootstrap, no full regtest) with
make -k check-gcc RUNTESTFLAGS=cilk-plus.exp --target_board=unix'{-m32,-m64}'
gives
=== gcc Summary for unix/-m64 ===
# of expected passes2904
Dear Tobias,
The test gfortran.dg/finalize_10.f90 fails in 32 bit mode (see
http://gcc.gnu.org/ml/gcc-testresults/2013-06/msg00842.html
FAIL: gfortran.dg/finalize_10.f90 -O scan-tree-dump-times original
__builtin_memcpy ((void .) y-_data, (void .)
y-_vptr-_def_init,
This patch packages the Steven G. Kargl's patch when MPFR 3.1.0 or newer
is available and fixes the original code for older versions using the
FX Coudert's machinery (see PR for details).
Tested on powerpc-apple-darwin9 and x86_64-apple-darwin10 without
regression.
OK for the trunk? If yes,
Tobias,
I have committed it as Rev. 200361.
Thanks for the quick commit. No backport?
Dominique
Dear Tobias,
Failures in 32 bit mode again!-(
With your patch, I get the following failures with -m32:
FAIL: gfortran.dg/class_48.f90 -O2 (test for excess errors)
FAIL: gfortran.dg/class_48.f90 -Os (test for excess errors)
FAIL: gfortran.dg/finalize_18.f90 -O scan-tree-dump-times original
Dear Tobias,
Nit pick: I find that '(\\(integer\\(kind=8\\)\\) )?' is easier to parse
than '(\\(integer\\(kind=8\\)\\) |)' (a matter of taste and I won't argue
about it).
/opt/gcc/work/gcc/testsuite/gfortran.dg/class_48.f90: In function
'__final_test2_T.2138.constprop.0':
Dear all,
The following patchlet fixes the ICE for the test case bellow and AFAICT
gives the right error. Regstrapped on x86_64-apple-darwin10.8.0.
OK for the trunk?
Dominiaue
2013-06-28 Dominique d'Humieres domi...@lps.ens.fr
PR fortran/54788
* array.c (spec_size):
Dear Tobias,
The patch itself seems obvious enough. I have just a nit pick
with the grammar of
Don't warn for unused dummy arguments when it is used in namelists
I think it should be either a dummy argument or when they are.
Probably something such as
Don't warn as unused for dummy arguments
Dear Tobias,
The patch is OK, but you may consider the following remarks:
(1) a comment before
+ c = gfc_simplify_conjg (a);
reminding the definition of the complex dot product.
(2) I don't like the scan-tree-dump: they are fragile and have a limited
coverage. I'ld prefer a test
Hi Marcus,
I also see pr57518.c failing on x86_64-apple-darwin10 (with -m64)
and powerpc-apple-darwin9 (both -m32 and -m64). Your patch
fixes them.
Thanks,
Dominique
Dear Tobias,
The following patch prevents the warning to generate a FAIL:
--- /opt/gcc/_clean/gcc/testsuite/gfortran.dg/class_48.f90 2012-02-05
22:03:27.0 +0100
+++ /opt/gcc/work/gcc/testsuite/gfortran.dg/class_48.f902013-07-01
19:44:06.0 +0200
@@ -158,4 +158,6 @@
Dear Tobias,
After this patch several tests related to pr20896 are now rejected,
it is probably right to issue an error for them, but I am not sure
that the message is right, e.g.
! { dg-do compile }
! Test the fix for PR20896 in which the ambiguous use
! of p was not detected.
!
! Contributed
Hi Martin,
I have applied the patch on top of r201441 and I still get the warning for
gcc/testsuite/gfortran.dg/class_48.f90 with -m32 -O(2|s):
/opt/gcc/work/gcc/testsuite/gfortran.dg/class_48.f90: In function
'__final_test2_T.2136.constprop.0':
Hence plugins that create passes will need to be built with RTTI
disabled in order to link against gcc, or they will fail to load, with
an error like: ...
The same holds for darwin, hence the following patch is needed:
--- ../_clean/gcc/testsuite/lib/plugin-support.exp 2013-08-05
Revision 201555 breaks boostrap on x86_64-apple-darwin10:
...
Checking multilib configuration for libvtv...
make all-recursive
Making all in testsuite
/bin/sh: line 0: cd: testsuite: No such file or directory
make[4]: *** [all-recursive] Error 1
make[3]: *** [all] Error 2
make[2]: ***
On x86_64-apple-darwin10, g++.dg/lookup/typedef2.C fails with
FAIL: g++.dg/lookup/typedef2.C -std=c++11 (test for excess errors)
Excess errors:
/opt/gcc/work/gcc/testsuite/g++.dg/lookup/typedef2.C:8:12: error: using
typedef-name 'Foo1::Bar' after 'struct'
Thomas,
The two lines
gfc_actual_arglist *args1;
gfc_actual_arglist *args2;
in gfc_dep_compare_expr must be removed. Otherwise
the compilation aborts with
.../../work/gcc/fortran/dependency.c: In function 'int
gfc_dep_compare_expr(gfc_expr*, gfc_expr*)':
The test gnat.dg/specs/linker_alias.ads fails on x86_64-apple-darwin10:
FAIL: gnat.dg/specs/linker_alias.ads (test for errors, line 5)
FAIL: gnat.dg/specs/linker_alias.ads (test for excess errors)
with
built-in:0:0: error: only weak aliases are supported in this configuration
gnatmake:
Can you try and add
pragma Weak_External (Var);
on line 8 and see whether it passes? If so, you can commit the patchlet.
The test still fails with the following change:
--- /opt/gcc/_clean/gcc/testsuite/gnat.dg/specs/linker_alias.ads
2013-08-18 17:39:22.0 +0200
+++
Could someone review and commit the patch at
http://gcc.gnu.org/ml/gcc-patches/2013-11/msg02105.html ?
TIA
Dominique
I think I blew by it the first time with the OK? at the end of the line?
maybe I thought you thought it was trivial and checked it in
The patch is indeed trivial, but I don't have write access to CVS, so
someone else has to commit it.
Dominique
:-) We stop using cvs a long time ago.
I meant SVN, just showing my age!-)
Be sure to attach patches to be applied instead of cut-n-paste if you use
Mail, it destroys the text cut and pasted.
I did not use Mail. Did you have troubles with Tabs? Apparently the post on the
list has them
Revision 205848 breaks bootstrap on x86_64-apple-darwin13: pr59445.
TIA
Dominique
Hi Uros,
This patch fix pr58630. However I still think that the tests
func-2a.c, func-indirect-2a.c, vaarg-4a.c, and vaarg-5a.c
should not be restricted to linux: they pass on darwin.
TIA
Dominique
OTOH, I can't test darwin properly, please provide the patch and I'll
commit it for you.
Basically the patch I have in my tree since the PR replace 'linux' with '*'
(see below).
Since I can only test darwin, there is no guarantee that the tests pass on
non-linux,
non-darwin platforms. So if
201 - 300 of 360 matches
Mail list logo
