Re: [PATCH] Optimize ASAN_CHECK checks

2014-11-14 Thread Jakub Jelinek
On Fri, Nov 14, 2014 at 12:25:37PM +0100, Dodji Seketeli wrote: + /* True if there is a block with HAS_FREEING_CALL_P flag set + on any a path between imm(BB) and BB. */ s/a//. Also, I'd rather say on any path between an immediate dominator of BB, denoted imm(BB), and BB. That

Re: [PATCH] Optimize ASAN_CHECK checks

2014-11-14 Thread Jakub Jelinek
On Fri, Nov 14, 2014 at 01:06:52PM +0100, Dodji Seketeli wrote: Jakub Jelinek ja...@redhat.com writes: I am not sure, but I am wondering if we shouldn't save the previous uid of 'stmt' here before setting it, and then restore it before getting out of this function. No, gimple uids

Re: [changes.html] Document -fdiagnostics-color= default changes

2014-11-14 Thread Jakub Jelinek
On Fri, Nov 14, 2014 at 01:14:02PM +0100, Manuel López-Ibáñez wrote: h3 id=c-familyC family/h3 ul +liThe code-fdiagnostics-color=/code option default is now +configurable at GCC configury time using +code--with-diagnostics-color=/code, can default to +

Re: [PATCH] Optimize ASAN_CHECK checks

2014-11-14 Thread Jakub Jelinek
On Fri, Nov 14, 2014 at 01:16:36PM +0100, Richard Biener wrote: That would be indeed nice (similarly for other stuff that we expect to be undefined on pass boundaries, or expect to be in certain state at pass boundaries; in the former case set before uses, and don't care about what state

Re: The nvptx port

2014-11-14 Thread Jakub Jelinek
On Fri, Nov 14, 2014 at 01:12:40PM +0100, Bernd Schmidt wrote: :(. So what other option one has to implement something like TLS, even using inline asm or similar? There is %tid, so perhaps indexing some array with %tid? That ought to work. For performance you'd want that array in .shared

Re: libsanitizer merge from upstream r221802

2014-11-14 Thread Jakub Jelinek
On Fri, Nov 14, 2014 at 03:11:16PM +0100, Uros Bizjak wrote: The missing definition in system's /usr/include/linux/types.h is protected with: typedef __u16 __bitwise __le16; typedef __u16 __bitwise __be16; typedef __u32 __bitwise __le32; typedef __u32 __bitwise __be32; #if

Re: The nvptx port

2014-11-14 Thread Jakub Jelinek
On Fri, Nov 14, 2014 at 07:37:49AM -0800, Cesar Philippidis wrote: Hmm. It's worthwhile to keep in mind that GPU threads really behave somewhat differently from CPUs (they don't really execute independently); the OMP model may just be a poor match for the architecture in general. One

Re: The nvptx port

2014-11-14 Thread Jakub Jelinek
On Fri, Nov 14, 2014 at 08:37:52AM -0800, Cesar Philippidis wrote: On 11/14/2014 08:18 AM, Jakub Jelinek wrote: Also, keep in mind that PTX doesn't have a global TID. The user needs to calculate it using ctaid/tid and friends. Ok. Is %gridid needed for that combo too? Eventually

Re: [PATCH, i686] Fix for asan test failures with -m32 happened after EBX enabling in PIC mode

2014-11-14 Thread Jakub Jelinek
On Fri, Nov 14, 2014 at 05:05:57PM +, Zamyatin, Igor wrote: --- /dev/null +++ b/gcc/testsuite/gcc.target/i386/pr63845.c @@ -0,0 +1,20 @@ +/* PR sanitizer/63845 */ +/* { dg-do compile } */ +/* { dg-require-effective-target ia32 } */ +/* { dg-require-effective-target fpic }

Re: [PATCH] DW_AT_APPLE_* DWARF extensions.

2014-11-14 Thread Jakub Jelinek
On Fri, Nov 14, 2014 at 03:48:22PM +0100, Andrew Burgess wrote: * Jakub Jelinek ja...@redhat.com [2014-11-13 14:13:42 +0100]: On Thu, Nov 13, 2014 at 01:21:21PM +0100, Andrew Burgess wrote: I had a look around and couldn't find anything helpful. The best I can offer would

Re: [PATCH] Optimize ASAN_CHECK checks

2014-11-14 Thread Jakub Jelinek
On Fri, Nov 14, 2014 at 01:06:52PM +0100, Dodji Seketeli wrote: Jakub Jelinek ja...@redhat.com writes: I am not sure, but I am wondering if we shouldn't save the previous uid of 'stmt' here before setting it, and then restore it before getting out of this function. No, gimple uids

[PATCH] Document --with-diagnostics-color=

2014-11-14 Thread Jakub Jelinek
On Fri, Nov 14, 2014 at 12:01:43PM +0100, Richard Biener wrote: doc/invoke.texi also talks about it, wonder if it shouldn't be mentioned elsewhere, install.texi? Sure - the configure option should be mentioned in install.texi as well. Here it is. Ok for trunk? 2014-11-14 Jakub Jelinek

[PATCH] DCE dead IFN_GOMP_SIMD_LANE

2014-11-14 Thread Jakub Jelinek
, bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk? 2014-11-14 Jakub Jelinek ja...@redhat.com * tree-ssa.dce.c (eliminate_unnecessary_stmts): Eliminate IFN_GOMP_SIMD_LANE without lhs as useless. --- gcc/tree-ssa-dce.c.jj 2014-11-12 13:28:47.0

Re: [PATCH] Propagate nonfreeing_call_p using ipa-pure-const (take 2)

2014-11-14 Thread Jakub Jelinek
On Thu, Nov 13, 2014 at 12:52:21PM +0100, Jakub Jelinek wrote: On Thu, Nov 13, 2014 at 09:39:42AM +0100, Jakub Jelinek wrote: What about the: I wonder if the nonfreeing_call_p function shouldn't be moved elsewhere though (suggestion where), so that gimple.c doesn't need the cgraph

Re: r217562 - in /trunk/libsanitizer: ChangeLog asa...

2014-11-14 Thread Jakub Jelinek
On Fri, Nov 14, 2014 at 11:29:07AM -0800, Konstantin Serebryany wrote: +gcc-patches On Fri, Nov 14, 2014 at 11:26 AM, Konstantin Serebryany konstantin.s.serebry...@gmail.com wrote: I am opposed to this change. Upstream code builds with -std=c++11. Building this code here with another

Re: [PATCH] gcc/testsuite: guality.exp: Fix `test_counts' restoration

2014-11-14 Thread Jakub Jelinek
On Fri, Nov 14, 2014 at 09:01:25PM +, Maciej W. Rozycki wrote: 2014-11-14 Maciej W. Rozycki ma...@codesourcery.com gcc/testsuite/ * g++.dg/guality/guality.exp (check_guality): Fix `test_counts' restoration. Ok, thanks. ---

Re: Fortran/C interfacing

2014-11-14 Thread Jakub Jelinek
On Fri, Nov 14, 2014 at 09:47:17PM +0100, Tobias Burnus wrote: Somebody recently suggested (for OpenMP) that we just should use bind(C) in the Fortran module, it is too late for OpenMP, as we have to keep the *_ entrypoints for compatibility anyway, but for OpenACC and new OpenMP functions

Re: [PATCH] Fix Cilk+ ICEs with overflow builtins (PR middle-end/63884)

2014-11-15 Thread Jakub Jelinek
On Sat, Nov 15, 2014 at 01:03:46PM +0100, Marek Polacek wrote: The problem here is that the Cilk+ code wasn't prepared to handle internal calls that the new overflow builtins entail. Fixed by checking that the CALL_EXPR_FN isn't NULL. Looking at cilk-plus.exp, I think this file will need

Re: [PATCH] Fix minimal alignment calculation for user-aligned types (PR63802)

2014-11-16 Thread Jakub Jelinek
On Fri, Nov 14, 2014 at 06:15:16PM +, Joseph Myers wrote: On Fri, 14 Nov 2014, Jakub Jelinek wrote: On Fri, Nov 14, 2014 at 09:46:14AM +0300, Yury Gribov wrote: Hi all, This patch fixes https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63802 by only limiting minimal type

Re: [PATCH] gcc/ubsan.c: Extend 'pretty_name' space to avoid memory overflow

2014-11-16 Thread Jakub Jelinek
On Mon, Nov 17, 2014 at 08:16:32AM +0100, Marek Polacek wrote: On Mon, Nov 17, 2014 at 06:40:26AM +0800, Chen Gang wrote: According to the next code, 'pretty_name' may need additional bytes more than 16. For simplify thinking and being extensible in future, extent it to 256 bytes, directly.

Re: [PATCH] Fix minimal alignment calculation for user-aligned types (PR63802)

2014-11-17 Thread Jakub Jelinek
On Mon, Nov 17, 2014 at 05:46:55PM +, Joseph Myers wrote: On Mon, 17 Nov 2014, Jakub Jelinek wrote: If it is true that a type satisfying TYPE_USER_ALIGN will never be allocated at an address less-aligned than its TYPE_ALIGN, even if that's greater than BIGGEST_ALIGNMENT

Re: [PATCH] -fsanitize-recover=list

2014-11-17 Thread Jakub Jelinek
On Mon, Nov 17, 2014 at 06:40:00PM -0800, Alexey Samsonov wrote: I've just prepared a patch implementing -fsanitize-recover=list in Clang (http://reviews.llvm.org/D6302), writing here to make sure we're on the same page w.r.t. flag semantics: * -fsanitize-recover: Enable recovery for all

Re: [PATCH] -fsanitize-recover=list

2014-11-17 Thread Jakub Jelinek
On Mon, Nov 17, 2014 at 11:39:47PM -0800, Alexey Samsonov wrote: That is not what I think we've agreed on and what is implemented in GCC. -fsanitize-recover only enables recovery of the undefined plus undefined-like sanitizers, in particular it doesn't enable recover from kernel-address,

Re: [PATCH] Fix PR63868 - Guard offloading with ifdef ENABLE_OFFLOADING

2014-11-18 Thread Jakub Jelinek
On Tue, Nov 18, 2014 at 06:31:59PM +0300, Ilya Verbin wrote: @@ -8287,7 +8289,9 @@ expand_omp_target (struct omp_region *region) if (kind == GF_OMP_TARGET_KIND_REGION) { unsigned srcidx, dstidx, num; +#ifdef ENABLE_OFFLOADING struct cgraph_node *node; +#endif Please

[PATCH] Fix -fsanitize=bool -fnon-call-exceptions (PR sanitizer/63913)

2014-11-18 Thread Jakub Jelinek
Hi! This patch fixes instrumentation of bool/enum loads if they could throw. We want to keep the EH on the load, and push further statements on the fallthru edge. Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk? 2014-11-18 Jakub Jelinek ja...@redhat.com PR

[PATCH] Fix ICEs in simplify_immed_subreg on OImode/XImode subregs (PR target/63910)

2014-11-18 Thread Jakub Jelinek
and i686-linux, ok for trunk? 2014-11-18 Jakub Jelinek ja...@redhat.com PR target/63910 * simplify-rtx.c (simplify_immed_subreg): For integer modes wider than MAX_BITSIZE_MODE_ANY_INT, handle all zeros and all ones and for other values return NULL_RTX

[C++ PATCH] Fix -fsanitize={null,alignment} reference instrumentation (PR sanitizer/63813)

2014-11-18 Thread Jakub Jelinek
or ICE. Fixed thusly, bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk? 2014-11-18 Jakub Jelinek ja...@redhat.com PR sanitizer/63813 * c-ubsan.c (ubsan_maybe_instrument_reference_or_call): Change type argument to ptype, set type to TREE_TYPE (ptype

[PATCH] Fix up r217118 - simplify_binary_operation_1 (PR rtl-optimization/63843)

2014-11-18 Thread Jakub Jelinek
Hi! The case ASHIFTRT: which is meant for this optimization is preceeded by /* FALLTHRU */ from ROTATE cases, which can't be optimized this way. Thus, this patch limits this optimization to ASHIFTRT. Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk? 2014-11-18 Jakub Jelinek

[PATCH] Fix ubsan -fsanitize=signed-integer-overflow expansion (PR sanitizer/63520)

2014-11-18 Thread Jakub Jelinek
-linux, ok for trunk? 2014-11-18 Jakub Jelinek ja...@redhat.com PR sanitizer/63520 * internal-fn.c (expand_ubsan_result_store): New function. (expand_addsub_overflow, expand_neg_overflow, expand_mul_overflow): Use it instead of just emit_move_insn. * c-c

[PATCH] Fix simd clone vectorization with EH (PR tree-optimization/63915)

2014-11-18 Thread Jakub Jelinek
/regtested on x86_64-linux and i686-linux, ok for trunk? 2014-11-18 Jakub Jelinek ja...@redhat.com PR tree-optimization/63915 * tree-vect-stmts.c (vectorizable_simd_clone_call): Pass true instead of false as last argument to gsi_replace. * c-c++-common/gomp/pr60823

[committed] Add testcase for PR tree-optimization/61042

2014-11-18 Thread Jakub Jelinek
Hi! This PR got fixed by a fix for another PR, but I've committed the testcase to the testsuite for better coverage. 2014-11-18 Jakub Jelinek ja...@redhat.com PR tree-optimization/61042 * gcc.c-torture/compile/pr61042.c: New test. --- gcc/testsuite/gcc.c-torture/compile

Re: [Patch] pr63937: TARGET_USE_BY_PIECES_INFRASTRUCTURE_P should take an unsigned HOST_WIDE_INT size argument

2014-11-18 Thread Jakub Jelinek
On Tue, Nov 18, 2014 at 09:57:37PM +, James Greenhalgh wrote: 2014-11-18 James Greenhalgh james.greenha...@arm.com PR target/63937 * target.def (use_by_pieces_infrastructure_p): Take unsigned HOST_WIDE_INT as the size parameter. * targhooks.c

Re: [PATCH] Fix ICEs in simplify_immed_subreg on OImode/XImode subregs (PR target/63910)

2014-11-18 Thread Jakub Jelinek
On Tue, Nov 18, 2014 at 03:30:56PM -0800, Mike Stump wrote: Before wide-int got merged, the testcase worked, though the code didn't bother checking anything, just created 0 or constm1_rtx for the two cases that could happen and if something else appeared, could just return what matched low

Re: [PATCH] Fix ICEs in simplify_immed_subreg on OImode/XImode subregs (PR target/63910)

2014-11-19 Thread Jakub Jelinek
On Tue, Nov 18, 2014 at 04:34:12PM -0800, Mike Stump wrote: On Nov 18, 2014, at 3:42 PM, Jakub Jelinek ja...@redhat.com wrote: No, I'm not touching tmp array at all in that case, only look at vp individual bytes. Either they are all 0, or all 0xff, or I return NULL. Oh, sorry, I misread

Re: [PATCH] Fix ubsan -fsanitize=signed-integer-overflow expansion (PR sanitizer/63520)

2014-11-19 Thread Jakub Jelinek
On Wed, Nov 19, 2014 at 10:02:18AM +0100, Richard Biener wrote: On Tue, 18 Nov 2014, Jakub Jelinek wrote: Apparently, expand_expr with EXPR_WRITE can return a SUBREG with SUBREG_PROMOTED_VAR_P set on it. For Huh, that looks bogus to me. But of course I know nothing (read: not enough

Re: [PATCH] Fix PR63844

2014-11-19 Thread Jakub Jelinek
On Wed, Nov 19, 2014 at 10:07:07AM +0100, Richard Biener wrote: The following improves code-generation for PR63844 by using a restrict qualified reference type for the OMP receiver decl. This improves alias analysis and points-to analysis enough to usually allow invariant and store motion

Re: [PATCH, libgomp]: Require vect_simd_clones effective target for examples-4/e.53.5.{c,f90}

2014-11-19 Thread Jakub Jelinek
On Wed, Nov 19, 2014 at 11:26:25AM +0100, Uros Bizjak wrote: 2014-11-19 Uros Bizjak ubiz...@gmail.com * testsuite/libgomp.c/examples-4/e.53.5.c: Require vect_simd_clones effective target. * testsuite/libgomp.fortran/examples-4/e.53.5.f90: Ditto. Tested on x86_64-linux-gnu

Re: [PATCH] Fix ICEs in simplify_immed_subreg on OImode/XImode subregs (PR target/63910)

2014-11-19 Thread Jakub Jelinek
? BTW, to Mike, the assert has been misplaced, there was first buffer overflow and only after that the assert. 2014-11-19 Jakub Jelinek ja...@redhat.com PR target/63910 * simplify-rtx.c (simplify_immed_subreg): Handle integer modes wider than MAX_BITSIZE_MODE_ANY_INT

Re: [PATCH] Fix ICEs in simplify_immed_subreg on OImode/XImode subregs (PR target/63910)

2014-11-19 Thread Jakub Jelinek
On Wed, Nov 19, 2014 at 12:59:06PM +0100, Richard Biener wrote: So perhaps something like this? Don't know how much more inefficient it is compared to what it used to do before. Yes, that looks good. Or just keep the existing code and just remove the assert and instead return NULL

Re: [PATCH] Fix sanitizer/63690

2014-11-19 Thread Jakub Jelinek
On Wed, Nov 19, 2014 at 02:51:11PM +0100, Marek Polacek wrote: As the testcase shows, we should really check first that we have a MEM_REF, otherwise subsequent TREE_OPERAND might ICE. On an invalid testcase we might get e.g. STRING_CST. Well, addr_object_size should handle STRING_CSTs just

Re: [PATCH] Fix sanitizer/63690

2014-11-19 Thread Jakub Jelinek
On Wed, Nov 19, 2014 at 03:12:05PM +0100, Jakub Jelinek wrote: On Wed, Nov 19, 2014 at 02:51:11PM +0100, Marek Polacek wrote: As the testcase shows, we should really check first that we have a MEM_REF, otherwise subsequent TREE_OPERAND might ICE. On an invalid testcase we might get e.g

[PATCH] gimple_{build_assign,assign_set_rhs}_with_ops* cleanup

2014-11-19 Thread Jakub Jelinek
to gimple_assign_set_rhs_with_ops so it becomes ternary op overload to the existing binary op one and 2) added unary op and adjusts all users that I found. Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk? 2014-11-19 Jakub Jelinek ja...@redhat.com * gimple.h

Re: [COMMITTED 1/3] Make TARGET_STATIC_CHAIN allow a function type

2014-11-19 Thread Jakub Jelinek
On Wed, Nov 19, 2014 at 03:58:50PM +0100, Richard Henderson wrote: As opposed to always being a decl. This is a prerequisite to allowing the static chain to be loaded for indirect calls. * targhooks.c (default_static_chain): Remove check for DECL_STATIC_CHAIN. *

[committed] Allow input and output to be both /dev/null (PR driver/36312, PR driver/63837)

2014-11-19 Thread Jakub Jelinek
Hi! I've bootstrapped/regtested this patch for Manuel (just small formatting changes from me), and committed to trunk. 2014-11-19 Manuel López-Ibáñez m...@gcc.gnu.org Jakub Jelinek ja...@redhat.com PR driver/36312 PR driver/63837 * gcc.c (process_command

Re: [PATCH] Fix ICEs in simplify_immed_subreg on OImode/XImode subregs (PR target/63910)

2014-11-19 Thread Jakub Jelinek
On Wed, Nov 19, 2014 at 10:38:57AM -0800, Mike Stump wrote: On Nov 19, 2014, at 4:24 AM, Richard Biener rguent...@suse.de wrote: On Wed, 19 Nov 2014, Jakub Jelinek wrote: For TARGET_SUPPORTS_WIDE_INT == 0 should be hopefully ok. Not sure about TARGET_SUPPORTS_WIDE_INT != 0, can it express

Re: OpenACC middle end changes

2014-11-19 Thread Jakub Jelinek
On Wed, Nov 19, 2014 at 08:52:40PM +0100, Bernd Schmidt wrote: Another change that's required is (something like) the following. For ptx, we need to know whether to output something as a .func (callable from ptx code) or a .kernel (callable from the host). That means we need to mark the kernel

Re: OpenACC middle end changes

2014-11-19 Thread Jakub Jelinek
On Thu, Nov 20, 2014 at 03:19:11AM +0100, Bernd Schmidt wrote: Thomas had apparently already pointed out an issue with the new gomp_target class (there are multiple similar types of statements we want to handle with OpenACC, they have different codes but we want to have function pointers

Re: [PATCH x86, PR60451] Expand even/odd permutation using pack insn.

2014-11-20 Thread Jakub Jelinek
On Thu, Nov 20, 2014 at 02:36:26PM +0300, Evgeny Stupachenko wrote: + /* Only V8HI, V16QI, V16HI and V32QI modes are more profitable than general + shuffles. */ I think switch (d-vmode) would be more readable. + op = gen_reg_rtx (d-vmode); + t = gen_reg_rtx (V4DImode); +

Re: [PATCH] PR63426 Fix various signed integer overflows

2014-11-20 Thread Jakub Jelinek
On Thu, Nov 20, 2014 at 02:27:52PM +0100, Markus Trippelsdorf wrote: 2014-11-20 Markus Trippelsdorf mar...@trippelsdorf.de * emit-rtl.c (const_wide_int_htab_hash): Likewise. * loop-iv.c (determine_max_iter): Likewise. (iv_number_of_iterations): Likewise. *

Re: [PATCH, i386] Add new arg values for __builtin_cpu_supports

2014-11-20 Thread Jakub Jelinek
On Thu, Nov 20, 2014 at 07:36:03PM +0300, Ilya Enkovich wrote: Hi, MPX runtime checks some feature bits in order to check MPX is fully supported. Runtime does it by cpuid calls but there is a __builtin_cpu_supports which may be used for that. Unfortunately currently it doesn't support

Re: [PATCH] Fix ubsan and C++14 constexpr ICEs (PR sanitizer/63956)

2014-11-20 Thread Jakub Jelinek
On Thu, Nov 20, 2014 at 06:14:52PM +0100, Marek Polacek wrote: This patch fixes a bunch of ICEs related to C++14 constexprs and -fsanitize=undefined. We should ignore ubsan internal functions and ubsan builtins in constexpr functions in cxx_eval_call_expression. Also add proper printing of

Re: [PATCH] Fix ICEs in simplify_immed_subreg on OImode/XImode subregs (PR target/63910)

2014-11-20 Thread Jakub Jelinek
On Wed, Nov 19, 2014 at 02:23:47PM -0800, Mike Stump wrote: On Nov 19, 2014, at 1:57 PM, Jakub Jelinek ja...@redhat.com wrote: Though, following patch is just fine for me too, I don't think it will make a significant difference: This version is fine by me. Richard, are you ok

[PATCH] Fix ICE with non-lvalue vector subscripts and make sure non-lvalue vector subscripts aren't used as lvalues (PR target/63764)

2014-11-20 Thread Jakub Jelinek
it into a NON_LVALUE_EXPR so that it is properly rejected if later used on the lhs. Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk? 2014-11-20 Jakub Jelinek ja...@redhat.com PR target/63764 c-family/ * c-common.h (convert_vector_to_pointer_for_subscript): Change

[PATCH] Fix tree-ssa-strlen ICE introduced by r211956 (PR tree-optimization/61773)

2014-11-20 Thread Jakub Jelinek
to stpcpy. So, this patch moves the assertion where it really is needed (for strcat/strcpy and their checking variants cases). Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk? 2014-11-20 Jakub Jelinek ja...@redhat.com PR tree-optimization/61773 * tree-ssa

[ia64 PATCH] Fix up ia64 attribute handling (PR target/61137)

2014-11-20 Thread Jakub Jelinek
on VMS?). 2014-11-20 Jakub Jelinek ja...@redhat.com PR target/61137 * config/ia64/ia64.c (ia64_attribute_takes_identifier_p): New function. (TARGET_ATTRIBUTE_TAKES_IDENTIFIER_P): Redefine to it. --- gcc/config/ia64/ia64.c.jj 2014-11-11 00:06:23.0 +0100 +++ gcc

Re: [PATCH] rs6000: Follow up for signed integer overflow fix

2014-11-20 Thread Jakub Jelinek
On Thu, Nov 20, 2014 at 07:41:43PM +0100, Markus Trippelsdorf wrote: 2014-11-20 Markus Trippelsdorf mar...@trippelsdorf.de * config/rs6000/rs6000.c (includes_rldic_lshift_p): Cast 0 to unsigned. (includes_rldicr_lshift_p): Likewise. diff --git a/gcc/config/rs6000/rs6000.c

Re: [PATCH 1/2] PR debug/38757 gcc does not emit DW_LANG_C99.

2014-11-20 Thread Jakub Jelinek
On Thu, Nov 20, 2014 at 11:30:11PM +0100, Mark Wielaard wrote: --- a/gcc/config/avr/avr-c.c +++ b/gcc/config/avr/avr-c.c @@ -386,7 +386,8 @@ avr_cpu_cpp_builtins (struct cpp_reader *pfile) (as mentioned in ISO/IEC DTR 18037; Annex F.2) which is not implemented in GCC up to now.

Re: [PATCH 2/2] PR debug/38757 continued. Handle C11, C++11 and C++14.

2014-11-21 Thread Jakub Jelinek
On Thu, Nov 20, 2014 at 11:30:12PM +0100, Mark Wielaard wrote: @@ -19592,13 +19597,28 @@ gen_compile_unit_die (const char *filename) language = DW_LANG_C; if (strncmp (language_string, GNU C++, 7) == 0) -language = DW_LANG_C_plus_plus; +{ + language =

Re: [PATCH] OpenACC for C front end

2014-11-21 Thread Jakub Jelinek
On Thu, Nov 20, 2014 at 05:50:33PM -0600, James Norris wrote: + case 'h': + if (!strcmp (host, p)) + result = PRAGMA_OMP_CLAUSE_SELF; + break; Shouldn't this be PRAGMA_OMP_CLAUSE_HOST (PRAGMA_OACC_CLAUSE_HOST) instead? It is _HOST in the C++ patch, are there no C tests with

Re: [PATCH] OpenACC for C++ front end

2014-11-21 Thread Jakub Jelinek
On Thu, Nov 20, 2014 at 05:33:57PM -0600, James Norris wrote: + t = OMP_CLAUSE_ASYNC_EXPR (c); + if (t == error_mark_node) + remove = true; + else if (!type_dependent_expression_p (t) + !INTEGRAL_TYPE_P (TREE_TYPE (t))) + { + error (%async%

Re: [PATCH 1/2] PR debug/38757 gcc does not emit DW_LANG_C99.

2014-11-21 Thread Jakub Jelinek
On Fri, Nov 21, 2014 at 02:01:55PM +0100, Mark Wielaard wrote: gcc/c-family/ChangeLog PR debug/38757 * c-opts.c (set_std_c89): Set lang_hooks.name. (set_std_c99): Likewise. (set_std_c11): Likewise. (set_std_cxx98): Likewise. (set_std_cxx11):

[committed] Cherry-pick a libsanitizer bugfix (PR sanitizer/64013)

2014-11-21 Thread Jakub Jelinek
Hi! I've committed this as obvious. 2014-11-21 Jakub Jelinek ja...@redhat.com PR sanitizer/64013 * sanitizer_common/sanitizer_linux.cc (FileExists): Cherry pick upstream r222532. --- libsanitizer/sanitizer_common/sanitizer_linux.cc(revision 222531

[PATCH] Fix VRP handling of {ADD,SUB,MUL}_OVERFLOW (PR tree-optimization/64006)

2014-11-21 Thread Jakub Jelinek
immediate uses would change or not). Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk? 2014-11-21 Jakub Jelinek ja...@redhat.com PR tree-optimization/64006 * tree-vrp.c (stmt_interesting_for_vrp): Return true for {ADD,SUB,MUL}_OVERFLOW internal calls

[PATCH] Fix up __builtin_*_overflow expansion on some targets (PR target/63848)

2014-11-21 Thread Jakub Jelinek
failed), ok for trunk? 2014-11-21 Jakub Jelinek ja...@redhat.com PR target/63848 PR target/63975 * internal-fn.c (expand_arith_overflow_result_store, expand_addsub_overflow, expand_neg_overflow, expand_mul_overflow): Use do_compare_rtx_and_jump instead

Re: [PATCH 4/4] OpenMP 4.0 offloading to Intel MIC: non-fallback testing

2014-11-21 Thread Jakub Jelinek
On Fri, Nov 21, 2014 at 10:14:21PM +0300, Ilya Verbin wrote: On Fri, 21 Nov 2014 21:44:40, Ilya Verbin wrote: You're right. This patch was rebased so many times, that we may forget to regenerate it before committing. Build with liboffloadmic passed. OK for trunk? -- Ilya

Re: [PATCH][OpenMP] Fix named critical sections inside target functions

2014-11-21 Thread Jakub Jelinek
On Fri, Nov 21, 2014 at 11:19:26PM +0300, Ilya Verbin wrote: Hi, '#pragma omp critical (name)' can be placed in the function, marked with '#pragma omp declare target', in this case the corresponding node should be marked as offloadable too. Bootstrapped/regtested on x86_64-linux and

Re: [PATCH][OpenMP] Fix named critical sections inside target functions

2014-11-21 Thread Jakub Jelinek
On Sat, Nov 22, 2014 at 12:08:38AM +0300, Ilya Verbin wrote: On 21 Nov 2014, at 23:36, Jakub Jelinek ja...@redhat.com wrote: On Fri, Nov 21, 2014 at 11:19:26PM +0300, Ilya Verbin wrote: Hi, '#pragma omp critical (name)' can be placed in the function, marked with '#pragma omp

Re: [PATCH v2] gcc/ubsan.c: Use 'pretty_print' for 'pretty_name' to avoid memory overflow

2014-11-21 Thread Jakub Jelinek
On Sat, Nov 22, 2014 at 05:03:37AM +0800, Chen Gang wrote: According to the next code, 'pretty_name' may need additional bytes more than 16 (may have unlimited length for array type). There is an easy way to fix it: use 'pretty_print' for 'pretty_name'. Let the code meet 2 white spaces

Re: [Patch,MIPS] Add default SYS_futex definition in libgomp

2014-11-21 Thread Jakub Jelinek
On Fri, Nov 21, 2014 at 02:30:06PM -0800, Steve Ellcey wrote: 2014-11-21 Steve Ellcey sell...@imgtec.com * config/linux/mips/futex.h (SYS_futex): Define if not already done. Ok. --- a/libgomp/config/linux/mips/futex.h +++ b/libgomp/config/linux/mips/futex.h @@ -25,6 +25,11 @@

Re: [PATCH, PR 63551] Use proper type in evaluate_conditions_for_known_args

2014-11-22 Thread Jakub Jelinek
On Sat, Nov 22, 2014 at 12:09:46PM +0100, Martin Jambor wrote: 2014-11-21 Martin Jambor mjam...@suse.cz PR ipa/63551 * ipa-inline-analysis.c (evaluate_conditions_for_known_args): Convert value of the argument to the type of the value in the condition. testsuite/

Re: [PATCH] Check for strtol, strtoul, strtoll and strtoull declarations

2014-11-22 Thread Jakub Jelinek
On Sat, Nov 22, 2014 at 09:40:58AM -0500, John David Anglin wrote: libiberty ChangeLog: 2014-11-22 John David Anglin dang...@gcc.gnu.org PR other/63694 * configure.ac: Check for strtol, strtoul, strtoll and strtoull declarations. * configure: Regenerated. gcc

Re: [PATCH] pr63856 - test case

2014-11-23 Thread Jakub Jelinek
On Sun, Nov 23, 2014 at 01:32:27PM -0500, tsaund...@mozilla.com wrote: bug was already fixed, so just add the test case. tested this only passes with r217909 where it is fixed, ok? Trev diff --git a/gcc/testsuite/gcc.dg/pr63856.c b/gcc/testsuite/gcc.dg/pr63856.c new file mode 100644

Re: [PATCH] pr63856 - test case

2014-11-23 Thread Jakub Jelinek
On Sun, Nov 23, 2014 at 03:42:43PM -0500, Trevor Saunders wrote: Vector arguments or return values often result in -Wpsabi warnings, so you certainly want -Wno-psabi in dg-options. On the other side, -fPIC should be only used for { target pic }, so better put that into

Re: [PATCH v3] gcc/ubsan.c: Use 'pretty_print' for 'pretty_name' to avoid memory overflow

2014-11-23 Thread Jakub Jelinek
On Sun, Nov 23, 2014 at 09:13:27AM +0800, Chen Gang wrote: 2014-11-23 Chen Gang gang.chen.5...@gmail.com * ubsan.c (ubsan_type_descriptor): Use 'pretty_print' for 'pretty_name' to avoid memory overflow. Ok, with a small nit below. gcc/ubsan.c | 63

Re: [PATCH v3] gcc/ubsan.c: Use 'pretty_print' for 'pretty_name' to avoid memory overflow

2014-11-24 Thread Jakub Jelinek
On Mon, Nov 24, 2014 at 04:28:10PM +0800, Chen Gang wrote: On 11/24/14 15:41, Jakub Jelinek wrote: On Sun, Nov 23, 2014 at 09:13:27AM +0800, Chen Gang wrote: [...] +else + pp_wide_int(pretty_name, + wi::add (wi::to_widest (TYPE_MAX_VALUE (dom

Re: [C++ PATCH] Detect UB in shifts in constexpr functions

2014-11-24 Thread Jakub Jelinek
On Mon, Nov 24, 2014 at 02:51:14PM +0100, Marek Polacek wrote: --- gcc/cp/constexpr.c +++ gcc/cp/constexpr.c @@ -1451,6 +1451,43 @@ verify_constant (tree t, bool allow_non_constant, bool *non_constant_p, return *non_constant_p; } +/* Return true if the shift operation on LHS and RHS

Re: [C++ PATCH] Detect UB in shifts in constexpr functions

2014-11-24 Thread Jakub Jelinek
On Mon, Nov 24, 2014 at 04:58:22PM +0100, Marek Polacek wrote: Consider say: constexpr int p = 1; constexpr int foo (int a) { return a (int) p; } constexpr int bar (int a) { return ((int) p) a; } constexpr int q = foo (5); constexpr int r = bar (2); constexpr int

[committed] Fix !$omp atomic handling (PR fortran/63938)

2014-11-24 Thread Jakub Jelinek
. 2014-11-24 Jakub Jelinek ja...@redhat.com PR fortran/63938 * trans-openmp.c (gfc_trans_omp_atomic): Make sure lhsaddr is simple enough for goa_lhs_expr_p. * libgomp.fortran/pr63938-1.f90: New test. * libgomp.fortran/pr63938-2.f90: New test. --- gcc

[PATCH] Fix linemap_line_start (PR preprocessor/60436)

2014-11-24 Thread Jakub Jelinek
256M lines give up on tracking locations, so this patch just makes sure we enter that path if going over those limits. Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk? 2014-11-24 Jakub Jelinek ja...@redhat.com PR preprocessor/60436 * line-map.c

[PATCH] Fix find_base_term in 32-bit -fpic code (PR lto/64025)

2014-11-24 Thread Jakub Jelinek
alias.c. Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk? 2014-11-24 Jakub Jelinek ja...@redhat.com PR lto/64025 * config/i386/i386.c (ix86_delegitimize_address): Ensure result comes before (addend - _GLOBAL_OFFSET_TABLE_) term. --- gcc/config/i386/i386

[PATCH] Fix building of gengtype

2014-11-24 Thread Jakub Jelinek
and i686-linux, ok for trunk? 2014-11-25 Jakub Jelinek ja...@redhat.com * Makefile.in (gengtype-lex.o): Drop dependency on $(BCONFIG_H). (CFLAGS-gengtype-lex.o, CFLAGS-gengtype-parse.o, CFLAGS-gengtype-state.o, CFLAGS-gengtype.o): Add -DHOST_GENGTYPE instead

Re: [PATCH] Fix find_base_term in 32-bit -fpic code (PR lto/64025)

2014-11-25 Thread Jakub Jelinek
On Tue, Nov 25, 2014 at 09:13:10AM +0100, Uros Bizjak wrote: On Tue, Nov 25, 2014 at 8:40 AM, Uros Bizjak ubiz...@gmail.com wrote: On Tue, Nov 25, 2014 at 12:25 AM, Jakub Jelinek ja...@redhat.com wrote: The fallback delegitimization I've added as last option mainly for debug info purposes

Re: [PATCH] Fix building of gengtype

2014-11-25 Thread Jakub Jelinek
On Tue, Nov 25, 2014 at 12:35:09AM +0100, Jakub Jelinek wrote: My last 2 bootstraps failed, both because of a race while building host gengtype (each time different gengtype*.o). Found bootstrap failures even with this patch (dunno what changed on my box that I started getting these last night

Re: [PATCH] Remove unnecessary calls to strchr.

2014-11-25 Thread Jakub Jelinek
On Tue, Nov 25, 2014 at 03:15:04PM +0300, Ilya Tocar wrote: As proposed in https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63853 this patch replaces some function calls with pointer arithmetic. I didn't mention PR in Changelog, as they are not actually related. Ok for trunk? @@ -3408,8 +3408,7

Re: Document __builtin_*_overflow

2014-11-25 Thread Jakub Jelinek
On Tue, Nov 25, 2014 at 07:50:02PM +0100, Gerald Pfeifer wrote: Hi Jakub, On Wednesday 2014-11-12 14:13, Jakub Jelinek wrote: This patch mentions __builtin_*_overflow in gcc-5/changes.html. Ok for CVS? I've fallen a bit behind with GCC patches, sorry. What do you think about

Re: [PATCH] gcc parallel make check

2014-11-25 Thread Jakub Jelinek
On Tue, Nov 25, 2014 at 03:27:40PM +0100, Tom de Vries wrote: This patch fixes that by ensuring that we print that unsupported message only once. The resulting test result comparison diff is: 2014-11-25 Tom de Vries t...@codesourcery.com *

Re: [PATCH v3] gcc/c-family/c-cppbuiltin.c: Let buffer enough to print host wide integer value

2014-11-25 Thread Jakub Jelinek
On Wed, Nov 26, 2014 at 09:41:16AM +0800, Chen Gang wrote: On 11/26/14 8:31, Joseph Myers wrote: On Wed, 26 Nov 2014, Chen Gang wrote: + gcc_assert (wi::fits_to_tree_p (value, char_type_node) +|| wi::fits_to_tree_p (value, short_integer_type_node) +||

Patch ping^2: [PATCH] -fsanitize=vptr instrumentation (take 2)

2014-11-26 Thread Jakub Jelinek
On Wed, Nov 12, 2014 at 03:05:46PM +0100, Jakub Jelinek wrote: On Tue, Oct 28, 2014 at 01:44:50PM +0100, Jakub Jelinek wrote: On Mon, Oct 27, 2014 at 05:16:05PM +0100, Jakub Jelinek wrote: Here is an updated patch, ok if bootstrap/testing passes (so far just checked with make -j16 -k

Re: [PATCH] Enhance ASAN_CHECK optimization

2014-11-26 Thread Jakub Jelinek
On Tue, Nov 25, 2014 at 08:06:00PM +0300, Yury Gribov wrote: +/* Traits class for tree hash maps below. */ + +struct tree_map_traits : default_hashmap_traits +{ + static inline hashval_t hash (const_tree ref) +{ + return iterative_hash_expr (ref, 0); +} + + static inline

Re: [PATCH 2/2] PR debug/38757 continued. Handle C11, C++11 and C++14.

2014-11-26 Thread Jakub Jelinek
On Wed, Nov 26, 2014 at 11:19:42AM +0100, Mark Wielaard wrote: Ping. Rebased patch attached. I have submitted patches for elfutils, valgrind, gdb and binutils for this. But they are pending till this patch hits GCC first. Ok, thanks. Jakub

Re: [PATCH] Fix PR bootstrap/63995

2014-11-26 Thread Jakub Jelinek
On Wed, Nov 26, 2014 at 03:41:46PM +0300, Ilya Enkovich wrote: Hi, This patch makes optimization for bounds lifetime reduction to ignore debug stetments. This fixes stage2 and stage3 comparision for instrumented boostrap. OK for trunk? Please add a small testcase (with -fcompare-debug

Re: [PATCH] Fix PR bootstrap/63995

2014-11-26 Thread Jakub Jelinek
On Wed, Nov 26, 2014 at 04:48:13PM +0300, Ilya Enkovich wrote: 2014-11-26 Ilya Enkovich ilya.enkov...@intel.com PR bootstrap/63995 * tree-chkp-opt.c (chkp_reduce_bounds_lifetime): Ignore debug statement when searching for a new position for bounds load/creation

Re: [PATCH] Fix sanitizer/63788

2014-11-26 Thread Jakub Jelinek
On Wed, Nov 26, 2014 at 02:57:20PM +0100, Marek Polacek wrote: Ping. Ok, thanks. On Wed, Nov 19, 2014 at 08:09:21PM +0100, Marek Polacek wrote: As discussed in the PR, the problem here is that when running gfortran, the __builtin_object_size decl isn't available, because c-family's

Re: [PATCH] Enhance array types debug info. for Ada

2014-11-26 Thread Jakub Jelinek
On Wed, Oct 08, 2014 at 09:05:30PM +0200, Pierre-Marie de Rodat wrote: gcc/ * dwarf2out.h (struct array_descr_info): Remove the base_decl field. * dwarf2out.c (enum dw_scalar_form): New. (struct loc_descr_context): New. (add_scalar_info): New. (add_bound_info):

Re: [C/C++ PATCH] Don't convert RHS of a shift-expression to int (PR c/63862)

2014-11-26 Thread Jakub Jelinek
On Wed, Nov 26, 2014 at 06:39:44PM +0100, Marek Polacek wrote: Both C11 and C++14 standards specify that integral promotions are performed on both operands of a shift-expression. This we do just fine. But then we convert the right operand to integer_type_node. Not only is this unnecessary,

Re: [PATCH] Enhance ASAN_CHECK optimization

2014-11-26 Thread Jakub Jelinek
On Wed, Nov 26, 2014 at 11:21:06AM -0700, ygribov wrote: Formatting. The {} should be indented like static and return 2 columns to the right of that. Right. For base_addr computation, you don't really need g or ptr_checks, do you? So why not move the: auto_vecgimple

Re: [C/C++ PATCH] Don't convert RHS of a shift-expression to int (PR c/63862)

2014-11-26 Thread Jakub Jelinek
On Wed, Nov 26, 2014 at 07:20:04PM +0100, Marek Polacek wrote: On Wed, Nov 26, 2014 at 06:50:29PM +0100, Jakub Jelinek wrote: On Wed, Nov 26, 2014 at 06:39:44PM +0100, Marek Polacek wrote: Both C11 and C++14 standards specify that integral promotions are performed on both operands

Re: [PATCH] Enhance ASAN_CHECK optimization

2014-11-26 Thread Jakub Jelinek
On Wed, Nov 26, 2014 at 11:42:57AM -0700, ygribov wrote: Testing SANITIZE_ADDRESS bit in flag_sanitize_recover doesn't make sense, testing it in flag_sanitize of course does, but for recover you care whether the SANITIZE_{KERNEL,USER}_ADDRESS bit in flag_sanitize_recover is set

[PATCH] Fix find_base_term in 32-bit -fpic code (PR lto/64025, take 2)

2014-11-26 Thread Jakub Jelinek
On Tue, Nov 25, 2014 at 09:20:13AM +0100, Jakub Jelinek wrote: Actually, thinking about it more, at least according to commutative_operand_precedence the canonical order is what we used to return (i.e. (something - _G_O_T_) + (symbol_ref) or (something - _G_O_T_) + (const (symbol_ref +- const

[PATCH] Fix simd clone vectorization (PR tree-optimization/64024)

2014-11-26 Thread Jakub Jelinek
analysis and uses them during transform phase (biased by what the peeling for alignment advanced of course). Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk? 2014-11-26 Jakub Jelinek ja...@redhat.com PR tree-optimization/64024 * tree-vectorizer.h (struct

<    1   2   3   4   5   6   7   8   9   10   >