[C++ PATCH] Fix __atomic_exchange (PR c++/60689)

2014-03-28 Thread Jakub Jelinek
current two calls to that function, which wouldn't recurse anymore, and we'd need to change add_atomic_size_parameter to push the argument. 2014-03-28 Jakub Jelinek ja...@redhat.com PR c++/60689 * typeck.c (build_function_call_vec): Call resolve_overloaded_builtin. * c

Re: Evident fix for copy_loops.

2014-03-28 Thread Jakub Jelinek
On Fri, Mar 28, 2014 at 02:41:26PM +0400, Yuri Rumyantsev wrote: Hi All, I found out that a field 'safelen of struct loop is not copied in copy_loops. Is it OK for trunk? Ok if it passes bootstrap/regtest. 2014-03-28 Yuri Rumyantsev ysrum...@gmail.com * tree-inline.c (copy_loops):

Re: [PATCH][ARM/AArch64][2/2] Crypto intrinsics tuning for Cortex-A53 - pipeline description

2014-03-28 Thread Jakub Jelinek
On Fri, Mar 28, 2014 at 04:52:39PM +, Marcus Shawcroft wrote: On 28 March 2014 14:52, Ramana Radhakrishnan ramana@googlemail.com wrote: To my mind on ARM / AArch64 this actually helps anyone using the crypto intrinsics on A53 hardware today and it would be good to get this into

Re: [PATCH, PR 60647] Check that actual argument types match those of formal parameters before IPA-SRA

2014-03-28 Thread Jakub Jelinek
On Fri, Mar 28, 2014 at 05:35:12PM +0100, Martin Jambor wrote: after much confusion on my part, this is the proper fix for PR 60647. IPA-SRA can get confused a lot when a formal parameter is a pointer but the corresponding actual argument is not. So this patch adds a check that their types

Re: [C++ PATCH] Fix __atomic_exchange (PR c++/60689)

2014-03-28 Thread Jakub Jelinek
On Fri, Mar 28, 2014 at 11:47:52AM +0100, Jakub Jelinek wrote: Yet another possibility would be to rename all calls in C FE to build_function_call_vec to say c_build_function_call_vec and add that function which would call resolve_overloaded_builtin and then tail call

[PATCH] Allow VOIDmode argument to ix86_copy_addr_to_reg (PR target/60693)

2014-03-28 Thread Jakub Jelinek
copy_addr_to_reg is IMHO the right thing and restores previous behavior. Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk? 2014-03-28 Jakub Jelinek ja...@redhat.com PR target/60693 * config/i386/i386.c (ix86_copy_addr_to_reg): Call copy_addr_to_reg also

Re: [RFA][PATCH][pr target/60648] Fix non-canonical RTL from x86 backend -- P1 regression

2014-03-28 Thread Jakub Jelinek
On Fri, Mar 28, 2014 at 12:04:00PM -0600, Jeff Law wrote: Here's the updated patch. It uses simplify_gen_binary in expr.c to simplify the address expression as we're building it. It also uses copy_addr_to_reg in the x86 backend to avoid the possibility of generating non-canonical RTL there

Re: [C++ PATCH] Fix __atomic_exchange (PR c++/60689)

2014-03-28 Thread Jakub Jelinek
On Fri, Mar 28, 2014 at 01:46:09PM -0400, Jason Merrill wrote: On 03/28/2014 06:47 AM, Jakub Jelinek wrote: * typeck.c (build_function_call_vec): Call resolve_overloaded_builtin. I expect this will break in templates if arguments are dependent. The only problem with this patch

Re: [PATCH] [4.8 branch] PR rtl-optimization/60700: Backport revision 201326

2014-03-29 Thread Jakub Jelinek
On Sat, Mar 29, 2014 at 09:38:38AM +0100, Eric Botcazou wrote: Revision 201326 fixes a shrink-wrap bug which is also a regression on 4.8 branch. This patch backports it to 4.8 branch. OK for 4.8 branch. Yes, thanks. I also include a testcase for PR rtl-optimization/60700. OK for

Re: [RFA][PATCH][pr target/60648] Fix non-canonical RTL from x86 backend -- P1 regression

2014-03-29 Thread Jakub Jelinek
On Fri, Mar 28, 2014 at 07:12:26PM +0100, Jakub Jelinek wrote: On Fri, Mar 28, 2014 at 12:04:00PM -0600, Jeff Law wrote: Here's the updated patch. It uses simplify_gen_binary in expr.c to simplify the address expression as we're building it. It also uses copy_addr_to_reg in the x86

Re: patch to fix PR 60650

2014-03-29 Thread Jakub Jelinek
On Thu, Mar 27, 2014 at 02:51:38PM -0400, Vladimir Makarov wrote: 2014-03-27 Vladimir Makarov vmaka...@redhat.com PR rtl-optimization/60650 * gcc.target/arm/pr60650.c: New. The test fails for me with: spawn -ignore SIGHUP

Re: [RFC][PATCH][MIPS] Patch to enable LRA for MIPS backend

2014-03-29 Thread Jakub Jelinek
On Sat, Mar 29, 2014 at 01:07:40AM +, Robert Suchanek wrote: This patch enables LRA by default for MIPS. The classic reload is still available and can be enabled via -mreload switch. FYI, all other targets that have LRA optionally selectable or deselectable use -mno-lra for this (even when

Re: Test failure: gcc.dg/tree-ssa/ssa-ifcombine-13.c

2014-04-08 Thread Jakub Jelinek
On Mon, Apr 07, 2014 at 01:23:57PM -0700, Steve Ellcey wrote: This test that you added on March 12th has always been failing for me on MIPS. It looks like you expect MIPS to optimize the if statement but mips.h has: #define LOGICAL_OP_NON_SHORT_CIRCUIT 0 I wasn't aware of this. So the

Re: [gomp4] Add tables generation

2014-04-08 Thread Jakub Jelinek
On Sat, Apr 05, 2014 at 05:22:09PM +0200, Bernd Schmidt wrote: On 04/05/2014 05:04 PM, Thomas Schwinge wrote: Is it a linker bug that I need to add something like the following? --- libgcc/ompstuff.c +++ libgcc/ompstuff.c @@ -40,6 +40,12 @@ see the files COPYING3 and COPYING.RUNTIME

Re: Fixing PR60773

2014-04-08 Thread Jakub Jelinek
On Mon, Apr 07, 2014 at 12:16:12PM -0700, Cong Hou wrote: --- a/gcc/testsuite/ChangeLog +++ b/gcc/testsuite/ChangeLog @@ -1,3 +1,11 @@ +2014-04-07 Cong Hou co...@google.com + + PR testsuite/60773 + * testsuite/lib/target-supports.exp: + Add

Re: [PATCH] Adjust builtin-bswap-6/7

2014-04-08 Thread Jakub Jelinek
On Mon, Apr 07, 2014 at 06:22:14PM +0200, Andreas Krebbel wrote: On Mon, Apr 07, 2014 at 04:19:06PM +0200, Richard Biener wrote: The adjusted testcases now fail on x86_64/i?86 at least. See PR60776. They seem to require at least -O2 on x86 with that change. Ok to apply? The reason why the

Re: [PATCH] Adjust builtin-bswap-6/7

2014-04-08 Thread Jakub Jelinek
On Tue, Apr 08, 2014 at 10:26:30AM +0200, Richard Biener wrote: On Mon, Apr 7, 2014 at 6:22 PM, Andreas Krebbel kreb...@linux.vnet.ibm.com wrote: On Mon, Apr 07, 2014 at 04:19:06PM +0200, Richard Biener wrote: The adjusted testcases now fail on x86_64/i?86 at least. See PR60776. They

Re: [PATCH] Adjust builtin-bswap-6/7

2014-04-08 Thread Jakub Jelinek
On Tue, Apr 08, 2014 at 10:53:19AM +0200, Andreas Krebbel wrote: On 04/08/2014 10:41 AM, Jakub Jelinek wrote: On Tue, Apr 08, 2014 at 10:26:30AM +0200, Richard Biener wrote: On Mon, Apr 7, 2014 at 6:22 PM, Andreas Krebbel kreb...@linux.vnet.ibm.com wrote: On Mon, Apr 07, 2014 at 04:19

Re: [PATCH] Adjust builtin-bswap-6/7

2014-04-08 Thread Jakub Jelinek
On Tue, Apr 08, 2014 at 11:21:56AM +0200, Andreas Krebbel wrote: On 04/08/2014 11:12 AM, Jakub Jelinek wrote: On Tue, Apr 08, 2014 at 10:53:19AM +0200, Andreas Krebbel wrote: On 04/08/2014 10:41 AM, Jakub Jelinek wrote: On Tue, Apr 08, 2014 at 10:26:30AM +0200, Richard Biener wrote

Re: [PATCH] Adjust builtin-bswap-6/7

2014-04-08 Thread Jakub Jelinek
On Tue, Apr 08, 2014 at 12:41:41PM +0200, Andreas Krebbel wrote: what about that one? Tested on x86_64, s390, and s390x. LGTM, thanks. 2014-04-08 Andreas Krebbel andreas.kreb...@de.ibm.com * gcc.dg/builtin-bswap-6.c: Use -mbranch-cost=0 for s390. *

Re: [PATCH][C++] Fix PR60761, diagnostics in clones

2014-04-08 Thread Jakub Jelinek
On Tue, Apr 08, 2014 at 01:58:06PM +0200, Richard Biener wrote: t.ii: In function 'void foo(int) clone': t.ii:14:13: warning: iteration 3u invokes undefined behavior [-Waggressive-loop-optimizations] z[i] = i; ^ Looks reasonable to me, but I'll defer this to Jason.

Re: [Patch, testsuite, mips] Fix gcc.dg/tree-ssa/ssa-ifcombine-13.c

2014-04-08 Thread Jakub Jelinek
On Tue, Apr 08, 2014 at 01:48:21PM -0700, Steve Ellcey wrote: The test gcc.dg/tree-ssa/ssa-ifcombine-13.c has been failing on MIPS ever since it was added because MIPS sets LOGICAL_OP_NON_SHORT_CIRCUIT to 0 and so the optimization being checked for is not done. This patch removes mips from

Re: Fixing PR60773

2014-04-08 Thread Jakub Jelinek
On Tue, Apr 08, 2014 at 07:40:09PM -0700, Cong Hou wrote: On Tue, Apr 8, 2014 at 12:07 AM, Jakub Jelinek ja...@redhat.com wrote: On Mon, Apr 07, 2014 at 12:16:12PM -0700, Cong Hou wrote: --- a/gcc/testsuite/ChangeLog +++ b/gcc/testsuite/ChangeLog @@ -1,3 +1,11 @@ +2014-04-07 Cong Hou

Re: [4.8, PATCH 0/26] Backport Power8 and LE support

2014-04-09 Thread Jakub Jelinek
On Fri, Apr 04, 2014 at 10:38:49AM -0500, Bill Schmidt wrote: Thanks to everyone who helped with development, testing, and review of the patch set! I've committed the changes to 4.8 this morning. Note that patch 15/26 was rejected as not really germane to this series and has been submitted

Re: [4.8, PATCH 0/26] Backport Power8 and LE support

2014-04-09 Thread Jakub Jelinek
On Wed, Apr 09, 2014 at 11:51:54AM +0200, Jakub Jelinek wrote: On Fri, Apr 04, 2014 at 10:38:49AM -0500, Bill Schmidt wrote: Thanks to everyone who helped with development, testing, and review of the patch set! I've committed the changes to 4.8 this morning. Note that patch 15/26

Re: Fix PR60644

2014-04-09 Thread Jakub Jelinek
On Wed, Apr 09, 2014 at 03:46:13PM +0400, Alexander Ivchenko wrote: ping.. I guess it really depends on whether the libcilkrts sources are going to be (semi?)regularly imported from some upstream repository or not, and if the upstream is willing to accept these changes. The alternative is to

Patch ping

2014-04-09 Thread Jakub Jelinek
Hi! I'd like to ping: - http://gcc.gnu.org/ml/gcc-patches/2014-03/msg01370.html PR sanitizer/56781 fix --with-build-config=bootstrap-ubsan bootstrap of lto-plugin - http://gcc.gnu.org/ml/gcc-patches/2014-03/msg01433.html PR sanitizer/56781 fix --with-build-config=bootstrap-asan

Re: Fix PR60644

2014-04-09 Thread Jakub Jelinek
On Wed, Apr 09, 2014 at 01:23:59PM +, Iyer, Balaji V wrote: -Original Message- From: Jakub Jelinek [mailto:ja...@redhat.com] Sent: Wednesday, April 9, 2014 8:06 AM To: Alexander Ivchenko Cc: Richard Biener; GCC Patches; Iyer, Balaji V Subject: Re: Fix PR60644

Re: [PATCH] Prevent out of bound access for multilib_options

2014-04-09 Thread Jakub Jelinek
On Wed, Apr 09, 2014 at 10:00:38PM +0800, Kito Cheng wrote: `q` will out of bound access if `*q` already reach the end of multilib_options, so check it before increment to prevent condition check part out of bound access. btw, this bug is detected by address sanitizer. Can you please expand

Re: [4.8, PATCH 0/26] Backport Power8 and LE support

2014-04-09 Thread Jakub Jelinek
On Wed, Apr 09, 2014 at 10:27:33AM -0500, Bill Schmidt wrote: Ah, right. I had meant to fix this before committing the patch set and dropped the ball. Thanks. One question: Where are ChangeLog entries supposed to go for libgo? There doesn't seem to be any kind of ChangeLog file for that

Re: [PATCH][C++] Fix PR60761, diagnostics in clones

2014-04-09 Thread Jakub Jelinek
On Wed, Apr 09, 2014 at 11:37:35AM +0200, Martin Jambor wrote: I think you should use DECL_ABSTRACT_ORIGIN instead of former_clone_of. Not only you avoid using cgraph stuff here but unlike this patch, it also works for IPA-CP clones of IPA-SRA clones (yeah, I know, but I bet I can cause the

Re: Patch ping

2014-04-10 Thread Jakub Jelinek
On Wed, Apr 09, 2014 at 06:29:48PM -0400, DJ Delorie wrote: - http://gcc.gnu.org/ml/gcc-patches/2014-03/msg01370.html PR sanitizer/56781 fix --with-build-config=bootstrap-ubsan bootstrap of lto-plugin I have no particular problem with this patch, although the build has gotten

Re: [PATCH] Update ia64 libstdc++ baseline symbols

2014-04-10 Thread Jakub Jelinek
On Thu, Apr 10, 2014 at 09:52:35AM +0200, Andreas Schwab wrote: Tested on ia64-suse-linux and installed as obvious. Please don't add the TLS symbols in there, they aren't included in any of the linux baselines so that there aren't failures in --disable-tls configurations or when using too old

[4.8] Backports from trunk for March

2014-04-10 Thread Jakub Jelinek
Hi! I've committed several backports patches from trunk to 4.8 branch after bootstrapping/regtesting them on x86_64-linux and i686-linux. Jakub 2014-04-10 Jakub Jelinek ja...@redhat.com Backport from mainline 2014-03-06 Jakub Jelinek ja...@redhat.com

[4.8] Reassoc fix (PR tree-optimization/60502)

2014-04-10 Thread Jakub Jelinek
and build_all_ones_cst functions (probably without adding any new uses of those functions, just define in tree.c and declare in tree.h) and then apply the r208507 change as is. What do you prefer? 2014-04-10 Jakub Jelinek ja...@redhat.com Backport from mainline 2014-03-12 Jakub Jelinek ja

Re: [PATCH] Update ia64 libstdc++ baseline symbols

2014-04-10 Thread Jakub Jelinek
On Thu, Apr 10, 2014 at 10:15:59AM +0200, Andreas Schwab wrote: Jakub Jelinek ja...@redhat.com writes: On Thu, Apr 10, 2014 at 09:52:35AM +0200, Andreas Schwab wrote: Tested on ia64-suse-linux and installed as obvious. Please don't add the TLS symbols in there, they aren't included

Re: [PATCH] Update ia64 libstdc++ baseline symbols

2014-04-10 Thread Jakub Jelinek
On Thu, Apr 10, 2014 at 10:42:28AM +0200, Andreas Schwab wrote: Jakub Jelinek ja...@redhat.com writes: I'd say so, perhaps with the exception of Solaris where I'd leave that to the target maintainer to decide. Done. The other alternative is to have the TLS symbols included everywhere

Re: [PATCH][C++] Fix PR60761, diagnostics in clones

2014-04-10 Thread Jakub Jelinek
Jakub Jelinek ja...@redhat.com PR ipa/60761 * error.c (dump_decl) case FUNCTION_DECL: If DECL_LANG_SPECIFIC is NULL, but DECL_ABSTRACT_ORIGIN is not, recurse on DECL_ABSTRACT_ORIGIN instead of printing built-in. --- gcc/cp/error.c.jj 2014-03

[PATCH] Fix ICE with -flto -fno-use-linker-plugin (PR lto/60567)

2014-04-10 Thread Jakub Jelinek
Hubicka hubi...@ucw.cz Jakub Jelinek ja...@redhat.com PR lto/60567 * method.c (use_thunk): Copy forced_by_abi flag from funcn to thunk_node. * g++.dg/lto/pr60567_0.C: New test. --- gcc/cp/method.c.jj 2014-03-27 08:06:11.0 +0100 +++ gcc/cp

Re: RFA: Testsuite PATCH to add support for dlopen tests

2014-04-10 Thread Jakub Jelinek
On Thu, Apr 10, 2014 at 03:23:43PM +0200, Rainer Orth wrote: I see failures from last night on aarch64-none-elf and arm-none-eabi (both bare-metal) configurations even after moving up to dejagnu 1.5.1. If this can't be fixed easily should we consider reverting this patch in the interest of

Re: [PATCH, PR60467, Cilk+] Fix for ICE with incorrect Cilk_spawn usage

2014-04-10 Thread Jakub Jelinek
On Thu, Apr 10, 2014 at 02:20:42PM +, Zamyatin, Igor wrote: Resending with correct Changelog. Is it OK? Thanks, Igor gcc/c-family/ChangeLog: 2014-04-10 Igor Zamyatin igor.zamya...@intel.com PR middle-end/60467 * cilk.c (cilk_set_spawn_marker): Remove

Re: [PATCH, PR60189, Cilk+] Fix for ICE with incorrect Cilk_sync usage

2014-04-10 Thread Jakub Jelinek
On Thu, Apr 10, 2014 at 02:23:16PM +, Zamyatin, Igor wrote: 2014-04-10 Igor Zamyatin igor.zamya...@intel.com PR c++/60189 * parser.c (cp_parser_postfix_expression): Make sure only semicolon can go after Cilk_sync. gcc/testsuite/ChangeLog: 2014-04-10 Igor Zamyatin

Re: [PING] [PATCH] Fix PR rtl-optimization/pr60663

2014-04-10 Thread Jakub Jelinek
this heuristics is even close to reality most of the time, more importantly, for no inputs, just outputs and clobbers it means *cost = 0; and that is why ARM is supposedly the only target now where CSE thinks it is worthwhile to break all inline asms without inputs appart. 2014-04-10 Jakub Jelinek ja

Re: [PATCH, PR60469, Cilk+] Fix ICE of using Cilk_spawn and Array Notation together

2014-04-10 Thread Jakub Jelinek
On Thu, Apr 10, 2014 at 05:19:33PM +, Zamyatin, Igor wrote: @@ -282,8 +283,7 @@ fix_builtin_array_notation_fn (tree an_builtin_fn, tree *new_var) for (ii = 0; ii rank; ii++) { - an_loop_info[ii].var = build_decl (location, VAR_DECL, NULL_TREE, -

Re: [PATCH, PR60469, Cilk+] Fix ICE of using Cilk_spawn and Array Notation together

2014-04-10 Thread Jakub Jelinek
On Thu, Apr 10, 2014 at 06:16:22PM +, Zamyatin, Igor wrote: Fixed patch is below. Just out of curiosity - why do you think this patch is not for 4.9? The one with just create_tmp_var (integer_type_node, NULL); is for 4.9. For the iterator var changes, I guess one needs to analyze all the

[committed] Fix IPA thunk handling (PR lto/60567)

2014-04-10 Thread Jakub Jelinek
Hi! Honza has acked this patch on IRC, so I've committed it to trunk after bootstrap/regtest on x86_64-linux and i686-linux. 2014-04-10 Jan Hubicka hubi...@ucw.cz Jakub Jelinek ja...@redhat.com PR lto/60567 * ipa.c (function_and_variable_visibility): Copy

Re: [PATCH, PR60469, Cilk+] Fix ICE of using Cilk_spawn and Array Notation together

2014-04-10 Thread Jakub Jelinek
On Thu, Apr 10, 2014 at 07:55:26PM +, Zamyatin, Igor wrote: So below is the patch for 4.9 trunk. Ok, thanks. Thanks, Igor gcc/c/Changelog: 2014-04-10 Igor Zamyatin igor.zamya...@intel.com PR middle-end/60469 * c-array-notation.c (fix_builtin_array_notation_fn):

Re: RFA: Testsuite PATCH to add support for dlopen tests

2014-04-11 Thread Jakub Jelinek
On Thu, Apr 10, 2014 at 02:18:26PM +0100, Ramana Radhakrishnan wrote: I see failures from last night on aarch64-none-elf and arm-none-eabi (both bare-metal) configurations even after moving up to dejagnu 1.5.1. If this can't be fixed easily should we consider reverting this patch in the

Re: [PATCH, PR 60556] Fix ICE on platforms with signed pointer extension.

2014-04-11 Thread Jakub Jelinek
and i686-linux, Steve, can you please test on mips? Ok for trunk if testing passes? 2014-04-11 Steve Ellcey sell...@mips.com Jakub Jelinek ja...@redhat.com PR middle-end/60556 * expr.c (convert_move): Use emit_store_flag_force instead of emit_store_flag

Re: [PING] [PATCH] Fix PR rtl-optimization/pr60663

2014-04-11 Thread Jakub Jelinek
On Fri, Apr 11, 2014 at 05:19:59PM +0800, Zhenqiang Chen wrote: Or, fix up the insane arm costs for ASM_OPERANDS: case ASM_OPERANDS: /* Just a guess. Cost one insn per input. */ *cost = COSTS_N_INSNS (ASM_OPERANDS_INPUT_LENGTH (x)); return true; I don't think

Re: [patch] Fix texinfo warnings for doc/gcc.texi [was: Re: doc bugs]

2014-04-11 Thread Jakub Jelinek
On Sat, Mar 29, 2014 at 10:51:58AM +0100, Tobias Burnus wrote: 2014-03-29 Tobias Burnus bur...@net-b.de PR other/59055 * doc/bugreport.texi (Bugs): Remove nodes pointing to the nirvana. * doc/gcc.texi (Service): Update description in the @menu *

Re: [PATCH] Remove directional rounding division negate folding

2014-04-11 Thread Jakub Jelinek
On Fri, Apr 11, 2014 at 01:03:51PM +0200, Richard Biener wrote: Both premature (can't find or think of an existing place that would rely on those) and bogus, - (4 /[fl] 5) isn't equal to (4 /[fl] -5). Removing and not trying to fold into 4 /[cl] -5 as we have no good way of creating testcases

Re: [patch] Fix PR59295 -- move redundant friend decl warning under -Wredundant-decls

2014-04-11 Thread Jakub Jelinek
On Fri, Apr 11, 2014 at 09:20:13AM -0700, Paul Pluzhnikov wrote: To fix PR59295, this patch moves (generally useless) warning about repeated / redundant friend declarations under -Wredundant-decls. Tested on Linux/x86_64 with no regressions. Ok for trunk once it opens in stage 1?

Re: [Patch, fortran] PR60717 - Wrong code with recursive procedure with unlimited polymorphic dummy argument

2014-04-12 Thread Jakub Jelinek
On Wed, Apr 02, 2014 at 10:29:23PM +0200, Paul Richard Thomas wrote: 2014-04-12 Paul Thomas pa...@gcc.gnu.org PR fortran/58771 * trans.h : Add 'use_offset' bitfield to gfc_se. * trans-array.c (gfc_conv_expr_descriptor) : Use 'use_offset' as a trigger to unconditionally

Re: [patch, libgfortran] [4.7/4.8/4.9/4.10 Regression] list directed io from array results in end of file

2014-04-12 Thread Jakub Jelinek
On Fri, Apr 11, 2014 at 04:57:42PM -0700, Jerry DeLisle wrote: On 04/11/2014 04:31 PM, Tobias Burnus wrote: Jerry DeLisle wrote: I plan to commit the following patch to 4.10, 4.9, 4.8, and 4.7. It is a partial revert of the patch to PR38199 which is an optimization of internal unit

Re: RFA: Testsuite PATCH to add support for dlopen tests

2014-04-14 Thread Jakub Jelinek
On Sun, Apr 13, 2014 at 09:24:28PM -0400, Hans-Peter Nilsson wrote: On Fri, 11 Apr 2014, Jakub Jelinek wrote: On Thu, Apr 10, 2014 at 02:18:26PM +0100, Ramana Radhakrishnan wrote: I see failures from last night on aarch64-none-elf and arm-none-eabi (both bare-metal) configurations even

Re: [PATCH] Fix variant of PR60819

2014-04-14 Thread Jakub Jelinek
On Mon, Apr 14, 2014 at 11:41:39AM +0200, Richard Biener wrote: Bootstrap/regtest pending on x86_64-unknown-linux-gnu, ok for trunk and branches (after 4.9.0)? Thanks, Richard. 2014-04-14 Richard Biener rguent...@suse.de Marc Glisse marc.gli...@inria.fr PR c/60819

Re: [testsuite] Fix vect_widen_mult_si_to_di_pattern on non-x86/ia64 targets

2014-04-14 Thread Jakub Jelinek
On Mon, Apr 14, 2014 at 12:25:15PM +0200, Rainer Orth wrote: The new gcc.dg/vect/pr60656.c test errors out on non-x86/ia64 targets: ERROR: gcc.dg/vect/pr60656.c: error executing dg-final: can't read et_vect_widen_mult_si_to_di_pattern_saved: no such variable UNRESOLVED:

Re: Patch ping

2014-04-14 Thread Jakub Jelinek
On Mon, Jan 13, 2014 at 08:22:47AM -0700, Jeff Law wrote: On 01/13/14 08:20, Jakub Jelinek wrote: On Mon, Jan 13, 2014 at 08:15:11AM -0700, Jeff Law wrote: On 01/13/14 01:07, Jakub Jelinek wrote: I'd like to ping 2 patches: http://gcc.gnu.org/ml/gcc-patches/2014-01/msg00140.html - Ensure

Re: Patch ping

2014-04-14 Thread Jakub Jelinek
On Thu, Apr 10, 2014 at 12:01:31PM -0400, DJ Delorie wrote: But ubsan is a new feature in 4.9, and it is a bootstrap failure with that feature. I will leave it up to the release manager to decide if they want this non-regression patch applied before the branch, then. This is for the

Re: [PATCH] Prevent out of bound access for multilib_options

2014-04-14 Thread Jakub Jelinek
On Wed, Apr 09, 2014 at 10:00:38PM +0800, Kito Cheng wrote: `q` will out of bound access if `*q` already reach the end of multilib_options, so check it before increment to prevent condition check part out of bound access. btw, this bug is detected by address sanitizer. 2014-04-09 Kito

Re: [PING] [PATCH, DOC] Mention -free enabled by default for -O2 and above on AArch64

2014-04-14 Thread Jakub Jelinek
On Mon, Apr 14, 2014 at 04:00:38PM +0100, Yufeng Zhang wrote: Thanks. Patch has been committed to the trunk. Is it OK for gcc-4_9-branch? Ok. Jakub

Re: Fix indirect call profiling for COMDAT symbols

2014-04-14 Thread Jakub Jelinek
On Mon, Apr 14, 2014 at 07:22:37PM +0200, Jan Hubicka wrote: Hi, while looking into firefox profiles, I noticed that we miss devirtualizations to comdat symbols, because we manage to get different profile_id in each unit. This is easily fixed by the following patch that makes

Re: [PATCH] Add DW_AT_const_value as unsigned or int depending on type and value used.

2014-04-14 Thread Jakub Jelinek
On Mon, Apr 14, 2014 at 02:55:52PM -0700, Cary Coutant wrote: Also note that size_of_die and value_format will still choose DW_FORM_data[1248] for dw_val_class_unsigned_const in most cases. Don't you really want to use DW_FORM_udata? DW_FORM_data[1248] is in many cases smaller than

Re: [PATCH] Add DW_AT_const_value as unsigned or int depending on type and value used.

2014-04-15 Thread Jakub Jelinek
On Mon, Apr 14, 2014 at 03:48:06PM -0700, Cary Coutant wrote: Also note that size_of_die and value_format will still choose DW_FORM_data[1248] for dw_val_class_unsigned_const in most cases. Don't you really want to use DW_FORM_udata? DW_FORM_data[1248] is in many cases smaller than

Re: [PATCH] Fix sanitizer tests to work under QEMU

2014-04-15 Thread Jakub Jelinek
On Tue, Apr 15, 2014 at 10:49:48AM +0400, Maxim Ostapenko wrote: Some ASan and UBSan pattern match tests fail under QEMU, because libsanitizer adds escape sequences which confuse Dejagnu (because it thinks that it is actually running under a tty). This bug was already fixed for some tests (see

[PATCH] Install some more headers for plugins (PR plugins/59335)

2014-04-15 Thread Jakub Jelinek
Hi! This patch installs some headers that were newly added in 4.9 (other than cilk/vtable-verify/omp/ubsan headers), which might be needed by some plugins. Bootstrapped/regtested on x86_64-linux and i686-linux. Ok for trunk/4.9? 2014-04-15 Jakub Jelinek ja...@redhat.com PR plugins

[PATCH] Add support for -fno-sanitize-recover and -fsanitize-undefined-trap-on-error (PR sanitizer/60275)

2014-04-15 Thread Jakub Jelinek
undefined behavior will be reported (through the SIGILL/abort). Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk? 2014-04-15 Jakub Jelinek ja...@redhat.com PR sanitizer/60275 * common.opt (fsanitize-recover, fsanitize-undefined-trap-on-error): New

[PATCH] Fix reassociation with -g (PR tree-optimization/60844)

2014-04-15 Thread Jakub Jelinek
. But, as the following testcase shows, we don't take into account that gsi_remove can add debug stmts, and those don't have uid set. Fixed thusly, bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk/4.9.1? 2014-04-15 Jakub Jelinek ja...@redhat.com PR tree-optimization/60844

Re: RFA: Tighten checking for 'X' constraints

2014-04-16 Thread Jakub Jelinek
On Tue, Apr 15, 2014 at 09:53:16PM +0100, Richard Sandiford wrote: As Robert pointed out here: http://gcc.gnu.org/ml/gcc-patches/2014-04/msg00416.html we're a bit too eager when folding stuff into an 'X' constraint. The value at expand time is sensible, but after that asm_operand_ok

Re: [PATCH] register CALL_INSN_FUNCTION_USAGE in find_all_hard_reg_sets

2014-04-16 Thread Jakub Jelinek
On Wed, Apr 16, 2014 at 11:46:14AM +0200, Tom de Vries wrote: ...why do we need two different mechanisms to deal with these two? IMO the set recorded for the callee should contain what the callee instructions clobber and nothing else. CALL_INSN_FUNCTION_USAGE should contain everything

Re: RFA: Tighten checking for 'X' constraints

2014-04-16 Thread Jakub Jelinek
On Wed, Apr 16, 2014 at 11:43:12AM +0100, Richard Sandiford wrote: X was defined against reload, which always reloaded MEM addresses to follow the appropriate base and index register classes. This was done as a first pass before matching against the constraints: I think it would be fine if X

Re: RFA: Tighten checking for 'X' constraints

2014-04-16 Thread Jakub Jelinek
On Wed, Apr 16, 2014 at 02:24:06PM +0100, Richard Sandiford wrote: side-effect of inline-asm on certain location in memory, but don't really need the address of that memory. Often memory is too big hammer, people often say that certain inline-asm uses or sets or uses/sets or clobbers say

Re: [PATCH, i386, PR57623] Introduce synonyms for BMI intrinsics

2014-04-17 Thread Jakub Jelinek
and 4.9. 2014-04-17 Jakub Jelinek ja...@redhat.com PR target/60847 Forward port from 4.8 branch 2013-07-19 Kirill Yukhin kirill.yuk...@intel.com * config/i386/bmiintrin.h (_blsi_u32): New. (_blsi_u64): Ditto. (_blsr_u32): Ditto. (_blsr_u64

Re: Patch ping

2014-04-17 Thread Jakub Jelinek
On Wed, Apr 16, 2014 at 02:45:37PM -0400, DJ Delorie wrote: I'll approve both patches, if you agree to think about a way to solve this problem without module-specific configury changes for each such command line option. I understand the usefulness of having instrumentation, but the configure

Re: [PATCH v8] PR middle-end/60281

2014-04-18 Thread Jakub Jelinek
On Fri, Apr 18, 2014 at 12:21:50PM +0800, lin zuojian wrote: Here is the patch after the Jakub's review, and Jakub helps with the coding style. --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,3 +1,12 @@ +2014-04-18 Lin Zuojian manjian2...@gmail.com + PR middle-end/60281

Re: [C PATCH] Warn if switch has boolean value (PR c/60439)

2014-04-18 Thread Jakub Jelinek
On Fri, Apr 18, 2014 at 07:49:22AM +0200, Marc Glisse wrote: On Fri, 18 Apr 2014, Marek Polacek wrote: This patch implements a new warning that warns when controlling expression of a switch has boolean value. (Intentionally I don't warn if the controlling expression is (un)signed:1

Re: [PATCH] Do not run IPA transform phases multiple times

2014-04-18 Thread Jakub Jelinek
On Wed, Apr 16, 2014 at 03:28:59PM +, Zamyatin, Igor wrote: Likely after this was checked in appeared following on x86 FAIL: gcc.dg/vect/vect-simd-clone-11.c -flto -ffat-lto-objects (internal compiler error) FAIL: gcc.dg/vect/vect-simd-clone-11.c -flto -ffat-lto-objects (test for

Re: [PATCH] Fix up rotate expansion (take 2)

2014-04-18 Thread Jakub Jelinek
On Wed, Apr 16, 2014 at 10:22:52PM -0400, DJ Delorie wrote: + { + other_amount + = simplify_gen_unary (NEG, GET_MODE (op1), + op1, GET_MODE (op1)); + other_amount + = simplify_gen_binary

Re: [PATCH] Do not run IPA transform phases multiple times

2014-04-18 Thread Jakub Jelinek
On Fri, Apr 18, 2014 at 01:33:54PM +0200, Martin Jambor wrote: I am aware this problem has been reported but my problem is that I cannot reproduce it anywhere. The tests pass on x86_64 host and the only i686 host I use is gcc45 on gcc farm where these tests are skipped. It is very likely

[PATCH] Fix omp declare simd cloning (PR tree-optimization/60823)

2014-04-18 Thread Jakub Jelinek
and i686-linux. Richard, does this look reasonable? 2014-04-18 Jakub Jelinek ja...@redhat.com PR tree-optimization/60823 * omp-low.c (ipa_simd_modify_function_body): Go through all SSA_NAMEs and for those refering to vector arguments which are going to be replaced

[4.9] Add no-dist for libffi and boehm-gc (PR other/43620)

2014-04-22 Thread Jakub Jelinek
Hi! In order to avoid the ftp.gnu.org security check failures in make dist* (that we don't use anyway), I've committed following fix to 4.9 branch. --- boehm-gc/ChangeLog (revision 209553) +++ boehm-gc/ChangeLog (working copy) @@ -1,3 +1,13 @@ +2014-04-22 Jakub Jelinek ja...@redhat.com

Re: PATCH: PR target/60868: [4.9/4.10 Regression] ICE: in int_mode_for_mode, at stor-layout.c:400 with -minline-all-stringops -minline-stringops-dynamically -march=core2

2014-04-22 Thread Jakub Jelinek
On Thu, Apr 17, 2014 at 10:07:29AM -0700, H.J. Lu wrote: Hi, GET_MODE returns VOIDmode on CONST_INT. It happens with -O0. This patch uses counter_mode on count_exp to get mode. Tested on Linux/x86-64 without regressions. OK for trunk and 4.9 branch? Ok, thanks. 2014-04-17 H.J. Lu

[committed] Fix ICE on invalid combined distribute parallel for (PR c/59073)

2014-04-22 Thread Jakub Jelinek
, committed to trunk and 4.9 branch. 2014-04-22 Jakub Jelinek ja...@redhat.com PR c/59073 c/ * c-parser.c (c_parser_omp_parallel): If c_parser_omp_for fails, don't set OM_PARALLEL_COMBINED and return NULL. cp/ * parser.c (cp_parser_omp_parallel): If cp_parser_omp_for

Re: version typeinfo for 128bit types

2014-04-22 Thread Jakub Jelinek
On Tue, Apr 22, 2014 at 04:26:23PM -0400, Michael Meissner wrote: On Tue, Apr 22, 2014 at 10:06:19PM +0200, Marc Glisse wrote: Hello, as written in the PR, my patch seems wrong for platforms like powerpc that already had the __float128 typeinfo for long double with a different version.

Re: [PATCH][RFC][wide-int] Fix some build errors on arm in wide-int branch and report ICE

2014-04-23 Thread Jakub Jelinek
On Wed, Apr 23, 2014 at 04:36:23PM +0200, Richard Biener wrote: I should point out that there is a community that wants to go in the opposite direction here. They are the people with real 32 bit hosts who want to go back to a world where they are allowed to make hwi a 32 bit value.

Re: [PATCH] Fix web/60933

2014-04-24 Thread Jakub Jelinek
On Thu, Apr 24, 2014 at 10:15:31AM +0200, Richard Biener wrote: We probably should try to bump the versions used by that script to something more recent though (should we do that for the 4.9 branch even?). Any idea what to choose here? I'd say mpc 1.0.2 is fine, so is mpfr 3.1.2, but should

Re: [PATCH] Fix web/60933

2014-04-24 Thread Jakub Jelinek
On Thu, Apr 24, 2014 at 10:38:38AM +0200, Richard Biener wrote: Is there a reason why you have lowered the minimum versions (4.3.2 - 4.2.3, 2.4.2 - 2.4.0, 0.8.1 - 0.8.0)? As I say will not work I checked what we reject at configure time (for the oldest versions that work we'll complain

Re: [PING^8][PATCH] Add a couple of dialect and warning options regarding Objective-C instance variable scope

2014-04-24 Thread Jakub Jelinek
On Thu, Apr 24, 2014 at 01:12:02PM +0300, Dimitris Papavasiliou wrote: Ping! Does anybody know the current record of longest ping? I'd like to at least break it before giving up. How has this been tested? I'm seeing: +FAIL: obj-c++.dg/local-decl-1.mm -fgnu-runtime (test for warnings, line

[committed] Fix some linear/lastprivate omp issues

2014-04-24 Thread Jakub Jelinek
thusly, committed to trunk/4.9. 2014-04-24 Jakub Jelinek ja...@redhat.com * tree.h (OMP_CLAUSE_LINEAR_GIMPLE_SEQ): Define. * gimplify.c (omp_is_private): Change last argument's type to int. Only diagnose lastprivate if the simd argument is 1, only diagnose linear

[committed] Fix atomic seq_cst parsing

2014-04-24 Thread Jakub Jelinek
, committed to trunk and 4.9. 2014-04-24 Jakub Jelinek ja...@redhat.com gcc/c/ * c-parser.c (c_parser_omp_atomic): Allow seq_cst before atomic-clause, allow comma in between atomic-clause and seq_cst. gcc/cp/ * parser.c (cp_parser_omp_atomic): Allow seq_cst before

Re: [PATCH] Fix PR60930

2014-04-25 Thread Jakub Jelinek
On Thu, Apr 24, 2014 at 09:20:50PM -0600, Jeff Law wrote: PR tree-optimization/60930 * gcc.dg/torture/pr60930.c: New test. Doesn't the test depend on long long being at least 64 bits? But that is guaranteed by C99, isn't it? 5.2.4.2.1 says: ... Their implementation-defined values

Re: [PATCH] Fix PR60930

2014-04-25 Thread Jakub Jelinek
On Fri, Apr 25, 2014 at 10:59:19AM +0200, Richard Biener wrote: On Fri, 25 Apr 2014, Jakub Jelinek wrote: On Thu, Apr 24, 2014 at 09:20:50PM -0600, Jeff Law wrote: PR tree-optimization/60930 * gcc.dg/torture/pr60930.c: New test. Doesn't the test depend on long long being at least

Re: [PATCH, testsuite]: Require vect_simd_clones effective target for c-c++-common/gomp/pr60823-2.c

2014-04-25 Thread Jakub Jelinek
On Fri, Apr 25, 2014 at 11:51:06AM +0200, Uros Bizjak wrote: Hello! This is a runtime test, so check if we are able to at least compile the source. 2014-04-25 Uros Bizjak ubiz...@gmail.com * c-c++-common/gomp/pr60823-2.c: Require effective target vect_simd_clones. Tested

Re: [SPARC] Fix PR target/60941

2014-04-25 Thread Jakub Jelinek
On Fri, Apr 25, 2014 at 12:47:32PM +0200, Eric Botcazou wrote: /* PR target/60941 */ /* Reported by Martin Husemann mar...@netbsd.org */ extern void abort (void); static void __attribute__((noinline)) set (unsigned long *l) { *l = 31; } int main (void) { unsigned long l;

Re: [SPARC] Fix PR target/60941

2014-04-25 Thread Jakub Jelinek
On Fri, Apr 25, 2014 at 01:24:13PM +0200, Eric Botcazou wrote: I'm afraid the testcase will fail on int16 targets, so perhaps you should guard the body of main other than return 0; with #if __INT_MAX__ = 2147483647ULL or #if __SIZEOF_INT__ = 4 or similar (or require int32plus target,

[PATCH] Fix vector division lowering (PR tree-optimization/60960)

2014-04-25 Thread Jakub Jelinek
with scalar shift count). The following patch fixes this by not calling expand_vector_divmod at all if the type doesn't have a vector mode. Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk/4.9? 2014-04-25 Jakub Jelinek ja...@redhat.com PR tree-optimization/60960

Re: [PATCH] A new reload-rewrite pattern recognizer for GCC vectorizer.

2014-04-26 Thread Jakub Jelinek
On Thu, Apr 24, 2014 at 05:32:54PM -0700, Cong Hou wrote: In this patch a new reload-rewrite pattern detector is composed to handle the following pattern in the loop being vectorized: x = *p; ... y = *p; or *p = x; ... y = *p; In both cases, *p is reloaded

Re: [SPARC] Fix PR target/60941

2014-04-26 Thread Jakub Jelinek
On Sat, Apr 26, 2014 at 03:30:25PM +0200, Eric Botcazou wrote: Not clear to me, (2U i) should be zero if the shift count is masked. 2U 31 is undefined behavior on those targets. Precisely not, or else we are not talking about the same notion of masking. Eh, C99, 6.5.7/3: If the value

Re: [PATCH] Optionally trap on impossible devirtualization

2014-04-28 Thread Jakub Jelinek
On Mon, Apr 28, 2014 at 11:05:06AM +0200, Richard Biener wrote: On Fri, Apr 25, 2014 at 5:35 PM, Martin Jambor mjam...@suse.cz wrote: Hi, the patch below might be useful for testcase preparation and debugging compiler bugs such as PR 60965. When -ftrap-on-impossible-devirtualization is

<    1   2   3   4   5   6   7   8   9   10   >