Patch to support extended characters in C/C++ identifiers

2019-08-12 Thread Lewis Hyatt
Hello- The attached patch for libcpp adds support for extended characters (e.g. UTF-8) in identifiers. A preliminary version of the patch was posted on PR c/67224 as Comment 26 (https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67224#c26) and discussed with Joseph Myers. Here is an updated patch

Re: Patch to support extended characters in C/C++ identifiers

2019-09-12 Thread Lewis Hyatt
On Tue, Sep 10, 2019 at 11:47:22PM +, Joseph Myers wrote: > On Mon, 12 Aug 2019, Lewis Hyatt wrote: > > > Hello- > > > > The attached patch for libcpp adds support for extended characters (e.g. > > UTF-8) > > in identifiers. A preliminary version o

Re: Patch to support extended characters in C/C++ identifiers

2019-09-11 Thread Lewis Hyatt
On Tue, Sep 10, 2019 at 7:47 PM Joseph Myers wrote: > > Thanks, I think this is OK with a few updates to the documentation. Thanks for looking through this, I'm glad it will be acceptable. I will make the documentation adjustments as you suggest. Speaking of documentation, one other thing

Re: Patch to support extended characters in C/C++ identifiers

2019-09-19 Thread Lewis Hyatt
On Thu, Sep 19, 2019 at 3:57 PM Joseph Myers wrote: > > On Thu, 12 Sep 2019, Lewis Hyatt wrote: > > > Attached is a single patch relative to current trunk that incorporates all > > of > > your feedback. I gzipped it like last time just in case the invalid UTF-

[PATCH] Multibyte awareness for diagnostics (PR 49973)

2019-09-26 Thread Lewis Hyatt
?id=91843#c1). I can also submit that couple-line patch here if it looks OK. -Lewis /ChangeLog 2019-09-26 Lewis Hyatt PR preprocessor/49973 * contrib/gen_wcwidth.cpp: New standalone utility to generate libcpp/generated_cpp_wcwidth.h. libcpp/ChangeLog 2019-09-26 Lewis

Re: [PATCH] Multibyte awareness for diagnostics (PR 49973)

2019-09-26 Thread Lewis Hyatt
On Thu, Sep 26, 2019 at 4:47 PM Joseph Myers wrote: > > On Thu, 26 Sep 2019, Lewis Hyatt wrote: > > > A couple notes: > > - In order to avoid any portability problems with wchar_t, the > > equivalent of wcwidth() from libc is implemented in-house. > > I'm une

Re: [PATCH] Multibyte awareness for diagnostics (PR 49973)

2019-09-27 Thread Lewis Hyatt
On Thu, Sep 26, 2019 at 08:46:56PM +, Joseph Myers wrote: > On Thu, 26 Sep 2019, Lewis Hyatt wrote: > > > A couple notes: > > - In order to avoid any portability problems with wchar_t, the > > equivalent of wcwidth() from libc is implemented in-house. >

Ping: [PATCH] Fix multibyte-related issues in pretty-print.c (PR 91843)

2019-11-11 Thread Lewis Hyatt
-Lewis On Thu, Oct 10, 2019 at 4:27 PM Lewis Hyatt wrote: > > Hello- > > This short patch addresses https://gcc.gnu.org/bugzilla/show_bug.cgi?id=91843 > by adding the needed multibyte awareness to pretty-print.c. > Together with my other patch awaiting review > (https

[committed] Add myself to MAINTAINERS

2019-12-10 Thread Lewis Hyatt
Thanks for the sponsorship David. 2019-12-10 Lewis Hyatt * MAINTAINERS (Write After Approval): Add myself. Index: MAINTAINERS === --- MAINTAINERS (revision 279166) +++ MAINTAINERS (revision 279167) @@ -429,6 +429,7

Re: [PATCH] Fix multibyte-related issues in pretty-print.c (PR 91843)

2019-12-10 Thread Lewis Hyatt
On Mon, Dec 9, 2019 at 4:58 PM David Malcolm wrote: > > On Thu, 2019-10-10 at 16:27 -0400, Lewis Hyatt wrote: > > Hello- > > > > This short patch addresses > > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=91843 > > by adding the needed multibyte awareness to

Re: [PATCH] Multibyte awareness for diagnostics (PR 49973)

2019-12-09 Thread Lewis Hyatt
On Mon, Dec 09, 2019 at 03:12:31PM -0500, David Malcolm wrote: > On Fri, 2019-12-06 at 15:31 -0500, Lewis Hyatt wrote: > > On Fri, Dec 06, 2019 at 10:54:30AM -0500, David Malcolm wrote: > > [...] > > > > The patch is OK for trunk with the nits above fixed. Do y

Re: [PATCH] Fix multibyte-related issues in pretty-print.c (PR 91843)

2019-12-09 Thread Lewis Hyatt
On Mon, Dec 9, 2019 at 4:58 PM David Malcolm wrote: > > On Thu, 2019-10-10 at 16:27 -0400, Lewis Hyatt wrote: > > Hello- > > > > This short patch addresses > > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=91843 > > by adding the needed multibyte awareness to

[PATCH] Ensure colorization doesn't corrupt multibyte sequences in diagnostics

2019-12-12 Thread Lewis Hyatt
this may arise, but still perhaps the ranges coming out of libcpp could be improved? Thanks... -Lewis gcc/ChangeLog: 2019-12-12 Lewis Hyatt * diagnostic-show-locus.c (layout::print_source_line): Do not emit color codes in the middle of a UTF-8 sequence

Re: [PATCH] Multibyte awareness for diagnostics (PR 49973)

2019-10-18 Thread Lewis Hyatt
On Fri, Sep 27, 2019 at 4:41 PM Lewis Hyatt wrote: > > On Thu, Sep 26, 2019 at 08:46:56PM +, Joseph Myers wrote: > > On Thu, 26 Sep 2019, Lewis Hyatt wrote: > > > > > A couple notes: > > > - In order to avoid any portability problems with wchar_t, th

[PATCH] Fix multibyte-related issues in pretty-print.c (PR 91843)

2019-10-10 Thread Lewis Hyatt
/ChangeLog: 2019-10-10 Lewis Hyatt PR 91853 * pretty-print.c (pp_quoted_string): Avoid hex-escaping valid multibyte input. Fix off-by-one-bug printing the last byte before a hex-escaped output. (pp_character): Don't apply line wrapping in the middle

Ping: [PATCH] wwwdocs: Document support for extended identifiers added to GCC 10

2020-02-25 Thread Lewis Hyatt
Hello- Just checking whether the below is OK for gcc 10 changes.html please. Thanks! https://gcc.gnu.org/ml/gcc-patches/2020-01/msg01667.html -Lewis On Fri, Jan 24, 2020 at 10:25 AM Lewis Hyatt wrote: > > Hello- > > There was a comment on PR67224: > https://gcc.gnu.org/bugzilla/

[PATCH] driver: Fix typos in options descriptions

2020-01-30 Thread Lewis Hyatt
for the old output; modified that test too. -Lewis gcc/ChangeLog: 2020-01-30 Lewis Hyatt * common.opt: Avoid redundancy in the help text. * config/arc/arc.opt: Likewise. * config/cr16/cr16.opt: Likewise. gcc/c-family/ChangeLog: 2020-01-30 Lewis Hyatt * c.opt: Avoid

[PATCH] diagnostics: Add options to control the column units [PR49973] [PR86904]

2020-01-31 Thread Lewis Hyatt
for taking a look at it. -Lewis gcc/ChangeLog: 2020-01-31 Lewis Hyatt * common.opt: Added -fdiagnostics-column-unit= and -fdiagnostics-column-origin= options. Fix typo in the description text for -fdiagnostics-output-format. * diagnostic-format-json.cc

Re: [PATCH] diagnostics: Add options to control the column units [PR49973] [PR86904]

2020-01-31 Thread Lewis Hyatt
On Fri, Jan 31, 2020 at 3:32 PM David Malcolm wrote: > > On Fri, 2020-01-31 at 14:31 -0500, Lewis Hyatt wrote: > > Hello- > > > > Here is the second patch that I mentioned when I submitted the other > > related > > patch (which is awaiting review): > >

Re: [PATCH] diagnostics: Add options to control the column units [PR49973] [PR86904]

2020-01-31 Thread Lewis Hyatt
Thanks for taking a look, sorry about that, it's my first new option :). I will add in the next iteration. -Lewis On Fri, Jan 31, 2020 at 5:45 PM Joseph Myers wrote: > > This seems to be missing invoke.texi documentation for the new options. > > -- > Joseph S. Myers > jos...@codesourcery.com

[PATCH] wwwdocs: Document support for extended identifiers added to GCC 10

2020-01-24 Thread Lewis Hyatt
Hello- There was a comment on PR67224: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=67224#c33 suggesting to document this feature in changes.html. Here would be my suggestion, in case that's desirable. Thanks! -Lewis commit 6aad009fb93ced5fc79867a79a9021adec0d23d1 Author: Lewis Hyatt Date

[PATCH] diagnostics: Support conversion of tabs to spaces [PR86904]

2020-01-23 Thread Lewis Hyatt
: 2020-01-23 Lewis Hyatt PR other/86904 * common.opt: Handle -ftabstop here instead of in c-family options. * opts.c (common_handle_option): Likewise. * diagnostic-show-locus.c (struct line_bounds): Clarified that the units are now always display

Ping: [PATCH] Ensure colorization doesn't corrupt multibyte sequences in diagnostics

2020-01-14 Thread Lewis Hyatt
Hello- I thought I might ping this short patch please, just in case it may make sense to include in GCC 10 along with the other UTF-8-related fixes to diagnostics. Thanks! https://gcc.gnu.org/ml/gcc-patches/2019-12/msg00915.html -Lewis On Thu, Dec 12, 2019 at 6:21 PM Lewis Hyatt wrote

[PATCH] preprocessor: Reinitialize frontend parser after loading a PCH [PR112319]

2023-11-01 Thread Lewis Hyatt
Hello- https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112319 This is a one-line patch to fix the GCC 14 regression noted in the PR. Bootstrap + regtest all languages on x86-64 looks good. Is it OK please? Thanks! -Lewis -- >8 -- Since r14-2893, the frontend parser object needs to exist when

Re: [PATCH 1/2] libdiagnostics: header and examples

2023-11-07 Thread Lewis Hyatt
On Mon, Nov 6, 2023 at 8:29 PM David Malcolm wrote: > > Here's a work-in-progress patch for GCC that adds a libdiagnostics.h > header describing the public interface, along with various testcases > that show usage examples for the API. Various aspects of this need > work; posting now for early

[PATCH] diagnostics: pch: Remember diagnostic pragmas in a PCH [PR64117]

2023-11-07 Thread Lewis Hyatt
Hello- https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64117 This fixes an old PR / enhancement request. Bootstrap + regtest all languages on x86-64 Linux. Please let me know if it looks OK? Thanks! -Lewis -- >8 -- As the PR points out, we do not currently record in a PCH whether any diagnostics

Re: [PATCH] libcpp: Improve the diagnostic for poisoned identifiers [PR36887]

2023-10-26 Thread Lewis Hyatt
On Thu, Oct 26, 2023 at 4:49 AM Christophe Lyon wrote: > We have noticed that the new tests fail on aarch64 with: > .../aarch64-unknown-linux-gnu/libc/usr/lib/crt1.o: in function `_start': > .../sysdeps/aarch64/start.S:110:(.text+0x38): undefined reference to `main' > > Looking at the test, I'd

Re: [PATCH] libcpp: Improve the diagnostic for poisoned identifiers [PR36887]

2023-10-26 Thread Lewis Hyatt
On Thu, Oct 26, 2023 at 12:48 PM Christophe Lyon wrote: > > On Thu, 26 Oct 2023 at 18:18, Lewis Hyatt wrote: > > > > On Thu, Oct 26, 2023 at 4:49 AM Christophe Lyon > > wrote: > > > We have noticed that the new tests fail on aarch64 with: > > > .../aar

Re: [PATCH] libcpp: Fix ICE on #include after a line marker directive [PR61474]

2023-09-19 Thread Lewis Hyatt
On Tue, Sep 19, 2023 at 1:13 PM Marek Polacek wrote: > > On Tue, Sep 19, 2023 at 06:08:50PM +0100, Richard Sandiford wrote: > > Lewis Hyatt via Gcc-patches writes: > > > Hello- > > > > > > This fixes an old PR, bootstrap + regtest on x86-64 Linux. Pleas

[PATCH] libcpp: Improve the diagnostic for poisoned identifiers [PR36887]

2023-09-19 Thread Lewis Hyatt
Hello- This patch implements the PR's request to add more information to the diagnostic issued for using a poisoned identifier. Bootstrapped + regtested all languages on x86-64 Linux. Does it look OK please? Thanks! -Lewis -- >8 -- The PR requests an enhancement to the diagnostic issued for

[PATCH] libcpp: testsuite: Add test for fixed _Pragma bug [PR82335]

2023-10-02 Thread Lewis Hyatt
Hello- https://gcc.gnu.org/bugzilla/show_bug.cgi?id=82335 is another _Pragma-related bug that got fixed in GCC 12 but is still open. Before closing it out, I thought it would be good to add the testcase from that PR, which we don't have exactly in the testsuite already. Is it OK please? Thanks!

Re: [PATCH] c++: Make -Wunknown-pragmas controllable by #pragma GCC diagnostic [PR89038]

2023-10-19 Thread Lewis Hyatt
On Thu, Oct 19, 2023 at 8:43 AM Marek Polacek wrote: > > On Wed, Oct 18, 2023 at 05:15:42PM -0400, Lewis Hyatt wrote: > > Hello- > > > > The PR points out that my fix for PR53431 was incomplete and did not handle > > -Wunknown-pragmas. This is a one-line

Re: [PATCH] libcpp: testsuite: Add test for fixed _Pragma bug [PR82335]

2023-10-18 Thread Lewis Hyatt
May I please ping this one, and/or, is it something straightforward enough I can just commit it as obvious? Thanks! https://gcc.gnu.org/pipermail/gcc-patches/2023-October/631814.html -Lewis On Mon, Oct 2, 2023 at 6:23 PM Lewis Hyatt wrote: > > Hello- > > https://gcc.gnu.

[PATCH] c++: Make -Wunknown-pragmas controllable by #pragma GCC diagnostic [PR89038]

2023-10-18 Thread Lewis Hyatt
Hello- The PR points out that my fix for PR53431 was incomplete and did not handle -Wunknown-pragmas. This is a one-line fix to correct that, is it OK for trunk and for GCC 13 backport please? bootstrap + regtest all languages on x86-64 Linux. Thanks! -Lewis -- >8 -- As noted on the PR, commit

ping: [PATCH] libcpp: Improve the diagnostic for poisoned identifiers [PR36887]

2023-10-20 Thread Lewis Hyatt
Hello- May I please ping this one? Thanks... https://gcc.gnu.org/pipermail/gcc-patches/2023-September/630967.html -Lewis On Wed, Sep 20, 2023 at 12:12 AM Lewis Hyatt wrote: > > Hello- > > This patch implements the PR's request to add more information to the > diagnostic i

ping: [PATCH] preprocessor: c++: Support `#pragma GCC target' macros [PR87299]

2023-10-13 Thread Lewis Hyatt
On Tue, Sep 12, 2023 at 04:09:21PM -0400, Lewis Hyatt wrote: > On Tue, Aug 8, 2023 at 5:53 PM Jason Merrill wrote: > > > > On 7/31/23 22:22, Lewis Hyatt via Gcc-patches wrote: > > > `#pragma GCC target' is not currently handled in preprocess-only mode > > >

[PATCH] c-family: Let libcpp know when the compilation is for a PCH [PR9471]

2023-11-10 Thread Lewis Hyatt
Hello- The PR may be 20 years old, but by now it only needs a one-line fix :). Is it OK please? Bootstrapped + regtested all langauges on x86-64 Linux. Thanks! -Lewis https://gcc.gnu.org/bugzilla/show_bug.cgi?id=9471 https://gcc.gnu.org/bugzilla/show_bug.cgi?id=47857 -- >8 -- libcpp will

[PATCH] diagnostics: Fix behavior of permerror options after diagnostic pop [PR111918]

2023-11-09 Thread Lewis Hyatt
Hello- https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111918 This patch fixes the behavior of `#pragma GCC diagnostic pop' for permissive error diagnostics such as -Wnarrowing (in C++11). Those currently do not return to the correct state after the last pop; they become effectively simple warnings

ping: [PATCH] libcpp: Support extended characters for #pragma {push,pop}_macro [PR109704]

2024-02-10 Thread Lewis Hyatt
Hello- https://gcc.gnu.org/pipermail/gcc-patches/2024-January/642926.html May I please ping this one? Thanks! On Sat, Jan 13, 2024 at 5:12 PM Lewis Hyatt wrote: > > Hello- > > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109704 > > The below patch fixes the issue noted in th

Re: [PATCH] libcpp: Improve location for macro names [PR66290]

2024-02-20 Thread Lewis Hyatt
On Mon, Feb 19, 2024 at 11:36 PM Alexandre Oliva wrote: > > This backport for gcc-13 is the first of two required for the > g++.dg/pch/line-map-3.C test to stop hitting a variant of the known > problem mentioned in that testcase: on riscv64-elf and riscv32-elf, > after restoring the PCH, the

ping: [PATCH] diagnostics: Fix behavior of permerror options after diagnostic pop [PR111918]

2024-02-16 Thread Lewis Hyatt
CCing some global reviewers as well, in case anyone has a minute to take a look please? Thanks! https://gcc.gnu.org/pipermail/gcc-patches/2023-November/638692.html On Thu, Jan 25, 2024 at 4:57 PM Lewis Hyatt wrote: > > May I please ask again about this one? It's just a couple lines,

ping^2: [PATCH] diagnostics: Fix behavior of permerror options after diagnostic pop [PR111918]

2023-12-19 Thread Lewis Hyatt
Hello- May I please ping this one? Thanks... https://gcc.gnu.org/pipermail/gcc-patches/2023-November/638692.html -Lewis On Wed, Nov 29, 2023 at 7:05 PM Lewis Hyatt wrote: > > On Thu, Nov 09, 2023 at 04:16:10PM -0500, Lewis Hyatt wrote: > > https://gcc.gnu.org/bugzilla/show_bug.c

[PATCH] libcpp: Fix macro expansion for argument of __has_include [PR110558]

2023-12-12 Thread Lewis Hyatt
Hello- https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110558 This is a small fix for the libcpp issue noted in the PR. Bootstrap + regtest all languages on x86-64 Linux. Is it ok for trunk please? Also, it's not a regression, having never worked since __has_include was introduced in GCC 5, but

Re: [PATCH] c-family: Fix ICE with large column number after restoring a PCH [PR105608]

2023-12-20 Thread Lewis Hyatt
Hello- May I please ping this PCH patch? Thanks! https://gcc.gnu.org/pipermail/gcc-patches/2023-December/639467.html -Lewis On Tue, Dec 5, 2023 at 8:52 PM Lewis Hyatt wrote: > > Hello- > > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105608 > > There are two related

ping: [PATCH] libcpp: Fix macro expansion for argument of __has_include [PR110558]

2024-01-03 Thread Lewis Hyatt
Hello- May I please ping this one? Thanks... https://gcc.gnu.org/pipermail/gcc-patches/2023-December/640386.html -Lewis On Tue, Dec 12, 2023 at 6:18 PM Lewis Hyatt wrote: > > Hello- > > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110558 > > This is a small fix for the

Re: [PATCH v2] libstdc++: Add Unicode-aware width estimation for std::format

2024-01-06 Thread Lewis Hyatt
On Sat, Jan 6, 2024 at 11:40 AM Jonathan Wakely wrote: > > Here's a V2 patch which addresses the two things I mentioned: the new > Python script now generates a complete file that can just be included by > , and the full Unicode 15.1.0 grapheme cluster break > rules are supported (I think ...

ping^3: [PATCH] diagnostics: Fix behavior of permerror options after diagnostic pop [PR111918]

2024-01-08 Thread Lewis Hyatt
Can I please ping this one again? It's 3 lines or so to fix the PR. Thanks! https://gcc.gnu.org/pipermail/gcc-patches/2023-November/638692.html On Tue, Dec 19, 2023 at 6:20 PM Lewis Hyatt wrote: > > Hello- > > May I please ping this one? Thanks... > https://gcc.gnu.org/pipermail/g

[PATCH] libcpp: Support extended characters for #pragma {push, pop}_macro [PR109704]

2024-01-13 Thread Lewis Hyatt
Hello- https://gcc.gnu.org/bugzilla/show_bug.cgi?id=109704 The below patch fixes the issue noted in the PR that extended characters cannot appear in the identifier passed to a #pragma push_macro or #pragma pop_macro. Bootstrap + regtest all languages on x86-64 Linux. Is it OK for GCC 13 please?

ping: [PATCH] libcpp: Fix __has_include_next ICE in the last directory of the path [PR80755]

2024-01-11 Thread Lewis Hyatt
Can I please ping this one? Thanks... https://gcc.gnu.org/pipermail/gcc-patches/2023-December/641247.html -Lewis On Thu, Dec 21, 2023 at 7:37 AM Lewis Hyatt wrote: > > Hello- > > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=80755 > > Here is a short fix for the ICE in libc

[PATCH] libcpp: Fix __has_include_next ICE in the last directory of the path [PR80755]

2023-12-21 Thread Lewis Hyatt
Hello- https://gcc.gnu.org/bugzilla/show_bug.cgi?id=80755 Here is a short fix for the ICE in libcpp noted in the PR. Bootstrap + regtest all languages on x86-64 Linux. Is it OK please? Thanks! -Lewis -- >8 -- In libcpp/files.cc, the function _cpp_has_header(), which implements __has_include

[PATCH] c-family: Fix ICE with large column number after restoring a PCH [PR105608]

2023-12-05 Thread Lewis Hyatt
Hello- https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105608 There are two related issues here really, a regression since GCC 11 where we can ICE after restoring a PCH, and a deeper issue with bogus locations assigned to macros that were defined prior to restoring a PCH. This patch fixes the ICE

ping: [PATCH] diagnostics: Fix behavior of permerror options after diagnostic pop [PR111918]

2023-11-29 Thread Lewis Hyatt
On Thu, Nov 09, 2023 at 04:16:10PM -0500, Lewis Hyatt wrote: > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111918 > > This patch fixes the behavior of `#pragma GCC diagnostic pop' for permissive > error diagnostics such as -Wnarrowing (in C++11). Those currently do not > return

[PATCH] libcpp: Fix unsigned promotion for unevaluated divide by zero [PR112701]

2023-11-27 Thread Lewis Hyatt
Hello- https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112701 Here is a one-line fix to an edge case in libcpp's expression evaluator noted in the PR. Bootstrap + regtest all languages on x86-64 Linux. Is it OK please? Thanks! -Lewis -- >8 -- When libcpp encounters a divide by zero while

Re: [PATCH] preprocessor: Reinitialize frontend parser after loading a PCH [PR112319]

2023-11-30 Thread Lewis Hyatt
On Thu, Nov 30, 2023 at 4:19 PM Marek Polacek wrote: > > On Wed, Nov 01, 2023 at 05:54:57PM -0400, Lewis Hyatt wrote: > > Hello- > > > > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112319 > > > > This is a one-line patch to fix the GCC 14 regression noted in

Re: [PATCH] c-family: Fix ICE with large column number after restoring a PCH [PR105608]

2024-01-31 Thread Lewis Hyatt
On Wed, Jan 31, 2024 at 03:18:01PM -0500, Jason Merrill wrote: > On 1/30/24 21:49, Lewis Hyatt wrote: > > On Fri, Jan 26, 2024 at 04:16:54PM -0500, Jason Merrill wrote: > > > On 12/5/23 20:52, Lewis Hyatt wrote: > > > > Hello- > > > > > > > &g

Re: [PATCH] c-family: Fix ICE with large column number after restoring a PCH [PR105608]

2024-02-01 Thread Lewis Hyatt
On Thu, Feb 1, 2024 at 7:24 AM Rainer Orth wrote: > > Hi Lewis, > > > On Fri, Jan 26, 2024 at 04:16:54PM -0500, Jason Merrill wrote: > >> On 12/5/23 20:52, Lewis Hyatt wrote: > >> > Hello- > >> > > >> > https://gcc.gnu.org/bugzill

Re: [PATCH] c-family: Fix ICE with large column number after restoring a PCH [PR105608]

2024-01-30 Thread Lewis Hyatt
On Fri, Jan 26, 2024 at 04:16:54PM -0500, Jason Merrill wrote: > On 12/5/23 20:52, Lewis Hyatt wrote: > > Hello- > > > > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=105608 > > > > There are two related issues here really, a regression since GCC 11 where we

ping: [PATCH] diagnostics: Fix behavior of permerror options after diagnostic pop [PR111918]

2024-01-25 Thread Lewis Hyatt
/638692.html -Lewis On Mon, Jan 8, 2024 at 6:53 PM Lewis Hyatt wrote: > > Can I please ping this one again? It's 3 lines or so to fix the PR. Thanks! > https://gcc.gnu.org/pipermail/gcc-patches/2023-November/638692.html > > On Tue, Dec 19, 2023 at 6:20 PM Lewis Hyatt wrote

ping: [PATCH] c-family: Fix ICE with large column number after restoring a PCH [PR105608]

2024-01-25 Thread Lewis Hyatt
Hello- May I please ping this small patch? Thanks https://gcc.gnu.org/pipermail/gcc-patches/2023-December/639467.html -Lewis On Wed, Dec 20, 2023 at 8:02 PM Lewis Hyatt wrote: > > Hello- > > May I please ping this PCH patch? Thanks! > https://gcc.gnu.org/pipermail/gcc-patche

ping: [PATCH] preprocessor: Reinitialize frontend parser after loading a PCH [PR112319]

2023-11-17 Thread Lewis Hyatt
May I please ping this one? Thanks... https://gcc.gnu.org/pipermail/gcc-patches/2023-November/634931.html On Wed, Nov 1, 2023 at 5:55 PM Lewis Hyatt wrote: > > Hello- > > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=112319 > > This is a one-line patch to fix the GCC 1

[PATCH] Makefile.tpl: Avoid race condition in generating site.exp from the top level

2023-11-17 Thread Lewis Hyatt
Hello- I often find it convenient to run a new c-c++-common test from the main build dir like: $ make -j 2 RUNTESTFLAGS=dg.exp=new-test.c check-gcc-{c,c++} I noticed that sometimes this produces a corrupted site.exp and then no tests work until it is remade manually. To avoid the issue, it is

ping: [PATCH] diagnostics: Fix behavior of permerror options after diagnostic pop [PR111918]

2024-03-19 Thread Lewis Hyatt
https://gcc.gnu.org/pipermail/gcc-patches/2023-November/638692.html Thanks! On Fri, Feb 16, 2024 at 7:02 PM Lewis Hyatt wrote: > https://gcc.gnu.org/pipermail/gcc-patches/2023-November/638692.html > > On Thu, Jan 25, 2024 at 4:57 PM Lewis Hyatt wrote: > > > > May I p

[PATCH] libcpp: Fix _Pragma("GCC system_header") [PR114436]

2024-03-23 Thread Lewis Hyatt
Hello- https://gcc.gnu.org/bugzilla/show_bug.cgi?id=114436 This is a small fix for the issue mentioned in the PR that _Pragma("GCC system_header") does not work completely. I believe it was always the case since _Pragma() support was first added. bootstrap + regtested all languages on x86-64

Re: [PATCH] libcpp: Improve location for macro names [PR66290]

2024-02-22 Thread Lewis Hyatt
On Thu, Feb 22, 2024 at 3:56 AM Richard Biener wrote: > > On Tue, Feb 20, 2024 at 3:33 PM Lewis Hyatt wrote: > > > > On Mon, Feb 19, 2024 at 11:36 PM Alexandre Oliva wrote: > > > > > > This backport for gcc-13 is the first of two required for the > &

Re: ping: [PATCH] libcpp: Fix __has_include_next ICE in the last directory of the path [PR80755]

2024-02-27 Thread Lewis Hyatt
, 2024 at 7:34 AM Lewis Hyatt wrote: > > Can I please ping this one? Thanks... > https://gcc.gnu.org/pipermail/gcc-patches/2023-December/641247.html > > -Lewis > > On Thu, Dec 21, 2023 at 7:37 AM Lewis Hyatt wrote: > > > > Hello- > > > > https

Re: ping: [PATCH] libcpp: Support extended characters for #pragma {push,pop}_macro [PR109704]

2024-05-28 Thread Lewis Hyatt
Hello- May I please ping this one (now for GCC 15)? Thanks! https://gcc.gnu.org/pipermail/gcc-patches/2024-January/642926.html -Lewis On Sat, Feb 10, 2024 at 9:02 AM Lewis Hyatt wrote: > > Hello- > > https://gcc.gnu.org/pipermail/gcc-patches/2024-January/642926.html > >

Re: Ping: [PATCH] wwwdocs: Document support for extended identifiers added to GCC 10

2020-03-11 Thread Lewis Hyatt via Gcc-patches
: > > On Tue, 25 Feb 2020, Lewis Hyatt wrote: > > Just checking whether the below is OK for gcc 10 changes.html please. > > Thanks! > > https://gcc.gnu.org/ml/gcc-patches/2020-01/msg01667.html > > Yes, this looks fine to me from a web perspective. > > Thank you, > Gerald

Thoughts on applying a short diagnostics patch for GCC 10

2020-04-15 Thread Lewis Hyatt via Gcc-patches
-64 linux looks good with all reg tests the same before + after: FAIL 94 94 PASS 473413 473413 UNSUPPORTED 11503 11503 UNTESTED 195 195 XFAIL 1818 1818 XPASS 36 36 Thanks! -Lewis gcc/ChangeLog: 2020-04-15 Lewis Hyatt * diagnostic-show-locus.c (layout::print_source_line): Do not emit

[PATCH] driver: Improve the generated help text for alias options with arguments

2020-03-15 Thread Lewis Hyatt via Gcc-patches
form, -Wimplicit-fallthrough=0). -Lewis 2020-03-15 Lewis Hyatt * opts.c (print_filtered_help): Improve the help text for alias options with arguments. diff --git a/gcc/opts.c b/gcc/opts.c index ac160ed8404..a120858d77b 100644 --- a/gcc/opts.c +++ b/gcc/opts.c @@ -1315,14

Re: [PATCH] driver: Fix typos in options descriptions

2020-03-15 Thread Lewis Hyatt via Gcc-patches
On Fri, Mar 13, 2020 at 01:24:07AM +, Joseph Myers wrote: > On Thu, 30 Jan 2020, Lewis Hyatt wrote: > > > Is this something that would be desirable to change for GCC 10? Attached > > patch would do so, and the output would become instead: > > This patch is OK. (It m

Re: Ping: [PATCH] wwwdocs: Document support for extended identifiers added to GCC 10

2020-04-22 Thread Lewis Hyatt via Gcc-patches
On Wed, Mar 11, 2020 at 9:12 AM Lewis Hyatt wrote: > On Sat, Mar 7, 2020 at 6:23 PM Gerald Pfeifer wrote: > > > > On Tue, 25 Feb 2020, Lewis Hyatt wrote: > > > Just checking whether the below is OK for gcc 10 changes.html please. > > > Thanks! > > >

Re: [PATCH] driver: Improve the generated help text for alias options with arguments

2020-03-20 Thread Lewis Hyatt via Gcc-patches
On Tue, Mar 17, 2020 at 11:52:13AM +, Richard Sandiford wrote: > Lewis Hyatt writes: > > On Mon, Mar 16, 2020 at 06:11:08PM +, Richard Sandiford wrote: > >> Lewis Hyatt via Gcc-patches writes: > > ... > >> > FWIW there are three other optio

Re: [PATCH] driver: Improve the generated help text for alias options with arguments

2020-03-20 Thread Lewis Hyatt via Gcc-patches
On Fri, Mar 20, 2020 at 01:16:42PM -0600, Martin Sebor wrote: > On 3/20/20 11:46 AM, Richard Sandiford wrote: > > Martin Sebor writes: > > > On 3/17/20 5:52 AM, Richard Sandiford wrote: > > > > Lewis Hyatt writes: > > > > > On Mon, Mar 16, 2020

Re: [PATCH] driver: Improve the generated help text for alias options with arguments

2020-03-16 Thread Lewis Hyatt via Gcc-patches
On Mon, Mar 16, 2020 at 06:11:08PM +, Richard Sandiford wrote: > Lewis Hyatt via Gcc-patches writes: ... > > FWIW there are three other options currently affected by this change > > (-Wimplicit-fallthrough, -fcf-protection, and -flive-patching). The change > > for >

Re: [PATCH] driver: Improve the generated help text for alias options with arguments

2020-03-16 Thread Lewis Hyatt via Gcc-patches
On Mon, Mar 16, 2020 at 6:11 PM Lewis Hyatt wrote: > Regarding -Wmissing-format-attribute, that is an interesting case, it's the > only > instance in any *.opt that has an = sign in the Alias target. If I understand > correctly, this one can't use the 3-argument form of Alias() be

Re: [PATCH] diagnostics: Add options to control the column units [PR49973] [PR86904]

2020-05-08 Thread Lewis Hyatt via Gcc-patches
On Fri, Jan 31, 2020 at 03:31:59PM -0500, David Malcolm wrote: > On Fri, 2020-01-31 at 14:31 -0500, Lewis Hyatt wrote: > > Hello- > > > > Here is the second patch that I mentioned when I submitted the other > > related > > patch (which is awaiting review): >

Re: [committed, wwwdocs] gcc-11/changes: Add notes about column number changes

2020-10-06 Thread Lewis Hyatt via Gcc-patches
On Tue, Oct 6, 2020 at 11:09 AM David Malcolm wrote: > > I've taken the liberty of pushing this website patch, having checked > that it validates. > > It covers the changes by Lewis in 004bb936d6d5f177af26ad4905595e843d5665a5 > (PR 49973 and PR 86904). > Cool, thank you for mentioning it here!

Re: [PATCH] libstdc++: testsuite: Address random failure in pthread_create() [PR54185]

2020-08-18 Thread Lewis Hyatt via Gcc-patches
On Tue, Aug 18, 2020 at 09:43:31AM +0100, Jonathan Wakely wrote: > On 13/08/20 18:15 -0400, Lewis Hyatt via Libstdc++ wrote: > > Hello- > > > > The attached patch was discussed briefly on PR 54185 here: > > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=54185#c14 &g

[PATCH] libcpp: Update cpp_wcwidth() to Unicode 13.0.0

2020-10-23 Thread Lewis Hyatt via Gcc-patches
Hello- The attached patch updates cpp_wcwidth() (for computation of display widths needed to calculate column numbers in diagnostics) from Unicode 12 to Unicode 13. The patch was purely mechanical, following the directions in contrib/unicode/README without any unexpected hiccups. A couple

[PATCH] libstdc++: testsuite: Address random failure in pthread_create() [PR54185]

2020-08-13 Thread Lewis Hyatt via Gcc-patches
Hello- The attached patch was discussed briefly on PR 54185 here: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=54185#c14 The test case for this PR sometimes fails due to random failures in pthread_create() that are not related to the original PR. This patch fixes it up by ignoring those failures.

[PATCH] diagnostics: Add new option -fdiagnostics-plain-output

2020-08-11 Thread Lewis Hyatt via Gcc-patches
Hello- Attached is the patch I mentioned in another discussion here: https://gcc.gnu.org/pipermail/gcc-patches/2020-August/551442.html This adds a new option -fdiagnostics-plain-output that currently means the same thing as: -fno-diagnostics-show-caret -fno-diagnostics-show-line-numbers

Re: [PATCH][RFC] diagnostics: Add support for Unicode drawing characters

2020-08-05 Thread Lewis Hyatt via Gcc-patches
On Fri, Jul 24, 2020 at 02:49:36PM +0100, Richard Sandiford wrote: > Lewis Hyatt via Gcc-patches writes: > > On Thu, Jul 23, 2020 at 05:47:28PM -0400, David Malcolm wrote: > >> On Thu, 2020-07-23 at 12:28 -0400, Lewis Hyatt via Gcc-patches wrote: > >> > Hello- >

Ping: [PATCH] diagnostics: Add options to control the column units [PR49973] [PR86904]

2020-07-10 Thread Lewis Hyatt via Gcc-patches
Hello- May I please ping you about this patch? Thanks! https://gcc.gnu.org/pipermail/gcc-patches/2020-June/547900.html -Lewis On Thu, Jun 11, 2020 at 11:26:28AM -0400, Lewis Hyatt wrote: > On Wed, Jun 10, 2020 at 12:11:00PM -0400, David Malcolm wrote: > > Thanks for the patch; so

Re: [PATCH] diagnostics: Add options to control the column units [PR49973] [PR86904]

2020-07-13 Thread Lewis Hyatt via Gcc-patches
On Mon, Jul 13, 2020 at 03:04:20PM -0400, David Malcolm wrote: > > +@item -fdiagnostics-column-unit=@var{UNIT} > > +@opindex fdiagnostics-column-unit > > +Select the units for the column number. This affects traditional > > diagnostics > > +(in the absence of @option{-fno-show-column}), as well

Ping: [PATCH] diagnostics: Add options to control the column units [PR49973] [PR86904]

2020-06-09 Thread Lewis Hyatt via Gcc-patches
May I please ping this patch? https://gcc.gnu.org/pipermail/gcc-patches/2020-May/545426.html Thanks! -Lewis On Fri, May 08, 2020 at 03:35:25PM -0400, Lewis Hyatt wrote: > On Fri, Jan 31, 2020 at 03:31:59PM -0500, David Malcolm wrote: > > On Fri, 2020-01-31 at 14:31 -0500, Lewis Hy

Re: [PATCH] diagnostics: Add options to control the column units [PR49973] [PR86904]

2020-06-11 Thread Lewis Hyatt via Gcc-patches
from 0. The column origin is recorded in the JSON output in > > +the @code{column-origin} tag. In the remaining examples below, the extra > > +column number outputs have been omitted for brevity. > > [...snip...] > I improved the docs along these lines. > Thanks again for

[PATCH][RFC] diagnostics: Add support for Unicode drawing characters

2020-07-23 Thread Lewis Hyatt via Gcc-patches
ecifics, the patch is easily modified for that now or in the future. Thanks for any feedback! -Lewis From: Lewis Hyatt Date: Thu, 23 Jul 2020 10:11:04 -0400 Subject: [PATCH] diagnostics: Add support for Unicode drawing characters Adds the new option -fdiagnostics-unicode-drawing, on by default

Re: [PATCH][RFC] diagnostics: Add support for Unicode drawing characters

2020-07-23 Thread Lewis Hyatt via Gcc-patches
On Thu, Jul 23, 2020 at 05:47:28PM -0400, David Malcolm wrote: > On Thu, 2020-07-23 at 12:28 -0400, Lewis Hyatt via Gcc-patches wrote: > > Hello- > > > > The attached patch is complete including docs, but I tagged as RFC > > because I am not sure if anyone will

Re: [PATCH] diagnostics: Add new option -fdiagnostics-plain-output

2020-08-14 Thread Lewis Hyatt via Gcc-patches
On Wed, Aug 12, 2020 at 12:54 PM Richard Sandiford wrote: > > Lewis Hyatt writes: > > Hello- > > > > Attached is the patch I mentioned in another discussion here: > > https://gcc.gnu.org/pipermail/gcc-patches/2020-August/551442.html > > > > This ad

[PATCH] diagnostics: Support for -finput-charset [PR93067]

2020-12-18 Thread Lewis Hyatt via Gcc-patches
Hello- The attached patch addresses PR93067: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=93067#c0 This is similar to the patch I posted last year on the PR, with some tweaks to make it a little simpler. Recapping some of the commentary on the PR: When source lines are needed for diagnostics

Re: [PATCH] libstdc++: Avoid zero-probability events in discrete_distribution [PR61369]

2020-12-15 Thread Lewis Hyatt via Gcc-patches
On Thu, Nov 19, 2020 at 07:16:52PM +, Jonathan Wakely wrote: > On 19/11/20 12:57 -0500, Lewis Hyatt via Libstdc++ wrote: > > Hello- > > > > PR61369 (https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61369) points out > > that std::discrete_distribution can retur

Re: [PATCH][RFC] diagnostics: Add support for Unicode drawing characters

2020-11-11 Thread Lewis Hyatt via Gcc-patches
On Thu, Jul 23, 2020 at 05:47:28PM -0400, David Malcolm wrote: > On Thu, 2020-07-23 at 12:28 -0400, Lewis Hyatt via Gcc-patches wrote: > > Hello- > > > > The attached patch is complete including docs, but I tagged as RFC > > because I am not sure if anyone will

Re: Ping: [PATCH] Ensure colorization doesn't corrupt multibyte sequences in diagnostics

2020-11-14 Thread Lewis Hyatt via Gcc-patches
On Fri, Nov 13, 2020 at 5:27 PM Jeff Law wrote: > > > On 1/14/20 5:05 PM, Lewis Hyatt wrote: > > Hello- > > > > I thought I might ping this short patch please, just in case it may > > make sense to include in GCC 10 along with the other UTF-8-related

libstdc++: Avoid zero-probability events in discrete_distribution [PR61369]

2020-11-19 Thread Lewis Hyatt via Gcc-patches
figured it would be fine to just include it in random.tcc unconditionally. bootstrap + testing were done on x86-64 GNU/Linux, all tests the same before + after plus 2 new passes from the new test. Thanks for taking a look! -Lewis From: Lewis Hyatt Date: Wed, 18 Nov 2020 17:12:51 -0500 Subject: [PATCH

Re: [PATCH] libcpp: Update cpp_wcwidth() to Unicode 13.0.0

2020-11-07 Thread Lewis Hyatt via Gcc-patches
On Fri, Nov 6, 2020 at 12:46 PM Jeff Law wrote: > > > On 10/23/20 9:01 AM, Lewis Hyatt via Gcc-patches wrote: > > Hello- > > > > The attached patch updates cpp_wcwidth() (for computation of display > > widths needed to calculate column numbers in diagnostics)

Re: [PATCH/RFC] Add GCC_EXTRA_DIAGNOSTIC_OUTPUT environment variable for fix-it hints

2021-01-14 Thread Lewis Hyatt via Gcc-patches
On Thu, Jan 14, 2021 at 4:34 PM David Malcolm via Gcc-patches wrote: ... > > One remaining issue raised in that Emacs bug is the encoding of these > > lines, and, indeed, the encoding of GCC's stderr in general: > > currently we emit a mixture of bytes and UTF-8; I believe we emit > > filenames

Re: [PATCH] diagnostics: Support for -finput-charset [PR93067]

2021-05-24 Thread Lewis Hyatt via Gcc-patches
On Tue, May 18, 2021 at 5:31 AM Iain Buclaw wrote: > > Excerpts from Lewis Hyatt via Gcc-patches's message of January 29, 2021 4:46 > pm: > > Q1: What is the input charset? > > A1: > > > > libcpp: Whatever was passed to -finput-charset (note, for

Re: [committed] input.c: move file caching globals to a new file_cache class

2021-07-11 Thread Lewis Hyatt via Gcc-patches
Hi David- I thought this might be a good opportunity to ask about the patch that supports -finput-charset in diagnostic.c please? https://gcc.gnu.org/pipermail/gcc-patches/2021-January/564527.html The patch will require some work to adapt to the new changes below. I am happy to do that, but

Ping: [PATCH] diagnostics: Support for -finput-charset [PR93067]

2021-04-30 Thread Lewis Hyatt via Gcc-patches
concerns about the approach to letting front ends configure how the input is to be converted, I am happy to try other ways. Thanks! -Lewis On Fri, Jan 29, 2021 at 10:46:30AM -0500, Lewis Hyatt wrote: > On Tue, Jan 26, 2021 at 04:02:52PM -0500, David Malcolm wrote: > > On Fri, 2020-12-18

Re: [PATCH] diagnostics: Support for -finput-charset [PR93067]

2021-01-29 Thread Lewis Hyatt via Gcc-patches
On Tue, Jan 26, 2021 at 04:02:52PM -0500, David Malcolm wrote: > On Fri, 2020-12-18 at 18:03 -0500, Lewis Hyatt wrote: > > Hello- > > > > The attached patch addresses PR93067: > > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=93067#c0 > > > > This is

  1   2   3   >