Re: [PATCH] Add clang-format config to contrib folder

2015-11-19 Thread Martin Liška
. Thanks, Martin On Wed, Nov 18, 2015 at 8:10 AM, Martin Liška <mli...@suse.cz> wrote: Hello. Following patch adds a clang-format config file that should respect the GNU coding standards. As the file is not part of build process, I hope the patch can be applied even though we've just s

[hsa] Class refactoring of hsa_insn_basic

2015-09-04 Thread Martin Liška
Hello. Following patch is a refactoring of ISA hierarchy related to hsa_insn_basic class. Thanks, Martin >From 9679925a23976db153b431d55f0f9cf7131f3886 Mon Sep 17 00:00:00 2001 From: mliska Date: Thu, 3 Sep 2015 22:58:45 +0200 Subject: [PATCH 3/4] HSA: follow-up and refactoring

[hsa] Create HSA clones

2015-09-04 Thread Martin Liška
Hello. Following patch adds a new IPA pass that creates clones intended to be expanded to HSAIL. The pass is capable of LTO stuff. Thanks, Martin >From 8cbddf693f93328f117dc48588deee924d2df6cd Mon Sep 17 00:00:00 2001 From: mliska Date: Tue, 1 Sep 2015 14:10:24 +0200 Subject:

[hsa] HSA: reuse get_integer_type_by_bytes

2015-09-08 Thread Martin Liška
Hello. Following patch is a small clean-up which reuses already existing function. Martin >From e592465b575c477f9311eba2e66e9bf1ec4c54fc Mon Sep 17 00:00:00 2001 From: mliska Date: Fri, 4 Sep 2015 14:38:13 +0200 Subject: [PATCH 3/7] HSA: reuse get_integer_type_by_bytes.

[hsa] Use newly added hsa_op_immed ctor.

2015-09-08 Thread Martin Liška
Hello. Following patch uses new hsa_op_immed ctor, which is mainly used in HSAIL emission of instructions that generate kernel from kernel dispatching. Martin >From 7cf50d2831ec8b161858ecdbfb19b6287230384d Mon Sep 17 00:00:00 2001 From: mliska Date: Fri, 4 Sep 2015 14:19:25

[hsa] Introduce a new ctor for hsa_op_immed.

2015-09-08 Thread Martin Liška
Hello. Following patch adds a new ctor for hsa_op_immed class. Martin >From dc72ba0001f5b98c97da9ea5c03fccf2340e893d Mon Sep 17 00:00:00 2001 From: mliska Date: Fri, 4 Sep 2015 13:33:08 +0200 Subject: [PATCH 1/7] HSA: introduce a new ctor for hsa_op_immed. gcc/ChangeLog:

[hsa] Add support for __builtin_mem{set,cpy}.

2015-09-08 Thread Martin Liška
Hello. Following patch adds support for HSAIL emission on the pair of builtins. Martin >From 4bb6a85f805dd7cab4f4a2ce7f148803214e5a9e Mon Sep 17 00:00:00 2001 From: mliska Date: Fri, 4 Sep 2015 16:29:21 +0200 Subject: [PATCH 4/7] HSA: add support for __builtin_mem{set,cpy}.

[hsa] Fix TARGET_MEM_REF code emission.

2015-09-10 Thread Martin Liška
Hello. Following patch changes type of an immediate constant in an address calculation to respect an address type. Martin >From fcbcf975217d44b0bd4674bda972b0a28b1a6afa Mon Sep 17 00:00:00 2001 From: mliska Date: Thu, 10 Sep 2015 10:16:12 +0200 Subject: [PATCH] HSA: fix

Re: [HSA] introduce hsa_num_threads

2015-09-30 Thread Martin Liška
On 09/25/2015 04:22 PM, Martin Liška wrote: > Hello. > > In the following patch HSA is capable of handling various OMP builtins > that are utilized to set or get the number of threads. > > Martin > Hello. This patch is a small follow-up which preserves hsa_num_threads am

[HSA] Add new gate predicate

2015-09-23 Thread Martin Liška
Hello. Following patch does a small refactoring of HSA tree generation pass. Martin >From a887efce8fc6aa136a2a069ea5ddda10b4e28de6 Mon Sep 17 00:00:00 2001 From: marxin Date: Tue, 22 Sep 2015 18:58:12 +0200 Subject: [PATCH] HSA: add new gate predicate gcc/ChangeLog: 2015-09-22

[HSA] Enhancement of back-end

2015-09-25 Thread Martin Liška
Hello. Following patch set enhances back-end, it adds support for SBR instructions and it fixed many issues spotted in GCC's test suite. Patches have been just applied to HSA branch: a73d92c HSA: add support for SBR instruction. 6485fbf HSA: fix issues in GIMPLE switch expansion. b73698c HSA:

[HSA] introduce hsa_num_threads

2015-09-25 Thread Martin Liška
Hello. In the following patch HSA is capable of handling various OMP builtins that are utilized to set or get the number of threads. Martin >From adfd806108dc5f9343811171de62b3af1d4ef903 Mon Sep 17 00:00:00 2001 From: marxin Date: Thu, 24 Sep 2015 23:07:14 +0200 Subject: [PATCH]

[PATCH] Fix Changelog entry and add pr66896.C

2015-12-07 Thread Martin Liška
Hi. As Jakub pointed out in https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66896#c15, I forgot to add a test-case to both GCC-5-branch and trunk. May I please installed the suggested patch to both these branches? Thanks, Martin >From 7df3eaa59c4b6ee9f011f35ee480e022fe77e0b3 Mon Sep 17 00:00:00

[PATCH 9/N] Fix memory leak tree-if-conv.c

2015-12-08 Thread Martin Liška
Hello. Simple memory leak fix. Patch can bootstrap and survives regression tests on x86_64-unknown-linux-gnu. Ready for trunk? Martin >From f2f533ec19b36a9ead2f72b148d1aeed074ef136 Mon Sep 17 00:00:00 2001 From: marxin Date: Sat, 28 Nov 2015 08:42:14 +0100 Subject:

[PATCH 8/N] Fix memory leak in tree-vectorizer.h

2015-12-08 Thread Martin Liška
Hello. The patch removes memory leaks that are caused by overwriting an existing item in stmt_vec_info_vec (in set_vinfo_for_stmt). My first attempt was to call free_stmt_vec_info for old entries that are overwritten, but it caused double frees as there are some references between

Re: [PATCH,RFC] Introduce RUN_UNDER_VALGRIND in test-suite

2015-12-08 Thread Martin Liška
On 12/03/2015 03:15 PM, Bernd Schmidt wrote: > On 11/23/2015 10:34 AM, Martin Liška wrote: >> On 11/21/2015 05:26 AM, Hans-Peter Nilsson wrote: >>> IIRC you can replace the actual dg-runtest proc with your own >>> (implementing a wrapper). Grep aroung, I think we d

[DOC, PATCH] Mention --enable-valgrind-annotations in install.texi

2015-12-08 Thread Martin Liška
Hello. I would like to add a missing configure option. Thanks, Martin >From f828b34177908aebb1efab194f749bbdac0b1dbb Mon Sep 17 00:00:00 2001 From: marxin Date: Tue, 8 Dec 2015 16:54:43 +0100 Subject: [PATCH] Mention --enable-valgrind-annotations in install.texi gcc/ChangeLog:

[PATCH] Fix PR ipa/68790

2015-12-08 Thread Martin Liška
Hi. I'm sending patch for the PR, unfortunately I've back-ported Honza's patch that introduced the regression to GCC 5.3. Fix is obvious, I've been running regression tests for both trunk and gcc-5-branch. Identical patch can be applied (modulo a line with 'cleanup-ipa-dump'). Ready after it

[DOC,PATCH] Mention clog10, clog10f an clog10l in Builtins section.

2015-12-04 Thread Martin Liška
Hello. I noticed that Builtins section of documentation does not mention clog10{,f,l} functions. I've tried to write a patch, however I'm not sure how should be these functions described. Thanks, Martin >From 2cb8dfd30ac14e1de00f3788a0b6e55c6a7fa8b9 Mon Sep 17 00:00:00 2001 From: marxin

[HSA] Handle __builtin_{bzero,mempcpy}

2015-12-04 Thread Martin Liška
Hello. The patch handles builtins mentioned in the email subject and was installed to the HSA branch. Thanks, Martin >From b56ba10d46c03cadfda16c6658dd3134f5da09f8 Mon Sep 17 00:00:00 2001 From: marxin Date: Thu, 3 Dec 2015 13:31:28 +0100 Subject: [PATCH 2/3] HSA: implement

[HSA] Fix emission of internal functions

2015-12-04 Thread Martin Liška
Hello. Following patch handles just floating pointer internal functions and for the rest if displays warning message. Patch has been installed to the HSA branch. Thanks, Martin >From 5c6581d913c754e4e0a197e073bfa3c17c20b31f Mon Sep 17 00:00:00 2001 From: marxin Date: Fri, 4 Dec

Re: [DOC, PATCH] Mention --enable-valgrind-annotations in install.texi

2015-12-09 Thread Martin Liška
On 12/09/2015 12:47 AM, Gerald Pfeifer wrote: > On Tue, 8 Dec 2015, Martin Liška wrote: >> I would like to add a missing configure option. > > I saw that Jeff approved while I was mulling over the patch, > but still have two questons: > > 1. Why did you sort this

[PATCH] Fix memory leaks in tree-vect-data-refs.c

2015-12-09 Thread Martin Liška
Hi. This is simple follow-up of the previous patch that fixes last remaining leak in vectorizer. Patch can regbootstrap on x64_64-linux-gnu. Ready for trunk? Martin >From 0d61420eb49dec0f5d14108373a546a8f1b52571 Mon Sep 17 00:00:00 2001 From: marxin Date: Wed, 9 Dec 2015

[PATCH] GCC-5 backport of PR lto/65948

2015-12-09 Thread Martin Liška
Hi. I would like to backport forgotten patch to GCC-5 branch. Bootstrap and regression tests have been running, ready after it finishes? Thanks, Martin >From 626df2a92db87f7c0668c7f2902f314ed6a9bc4c Mon Sep 17 00:00:00 2001 From: marxin Date: Wed, 9 Dec 2015 12:49:22 +0100

[hsa] Support internal functions and implement various __builtin_*

2015-12-02 Thread Martin Liška
Hello. Following patch add support for internal functions that are either expanded to an HSAIL instruction, or a function call is generated. Apart from that, utilizing bit string instructions, we support all builtins that are based on the type of instructions. Patch set: 00c2bb6 HSA: reorder

[PATCH, i386]: Fix PR 67484 (version 2)

2015-12-11 Thread Martin Liška
Hello. I've just applied suggested change that Richi proposed. The patch can bootstrap on x86_64-linux-gnu and survives regression tests. Moreover, the memory leak/invalid read has gone. Ready for trunk? Thanks, Martin >From f0eca2d3efd711498fbc8b7e8980fdf32f0abfd0 Mon Sep 17 00:00:00 2001

Re: [hsa 3/10] HSA libgomp plugin [part 2/2]

2015-12-10 Thread Martin Liška
On 12/09/2015 01:15 PM, Jakub Jelinek wrote: > On Mon, Dec 07, 2015 at 12:20:49PM +0100, Martin Jambor wrote: >> +#include >> +#include >> +#include >> +#include >> +#include "libgomp-plugin.h" >> +#include "gomp-constants.h" >> +#include "hsa.h" >> +#include "hsa_ext_finalize.h" > > If these

Re: [hsa 3/10] HSA libgomp plugin [part 1/2]

2015-12-10 Thread Martin Liška
On 12/09/2015 01:15 PM, Jakub Jelinek wrote: > On Mon, Dec 07, 2015 at 12:20:49PM +0100, Martin Jambor wrote: >> +#include >> +#include >> +#include >> +#include >> +#include "libgomp-plugin.h" >> +#include "gomp-constants.h" >> +#include "hsa.h" >> +#include "hsa_ext_finalize.h" > > If these

[PATCH] Fix usage of an uninitialized variable

2016-01-06 Thread Martin Liška
Simple fix of a warning reported during bootstrap: ../../lto-plugin/lto-plugin.c: In function ‘all_symbols_read_handler’: ../../lto-plugin/lto-plugin.c:673:20: warning: ‘linker_output_str’ may be used uninitialized in this function [-Wmaybe-uninitialized] *lto_arg_ptr++ = xstrdup

Re: [PATCH 2/6] Fix memory leak in tree-ssa

2015-11-26 Thread Martin Liška
On 11/23/2015 02:48 PM, marxin wrote: gcc/ChangeLog: 2015-11-20 Martin Liska * tree-ssa.c (redirect_edge_var_map_destroy): Release vectors that are used as a second argument of a hash_map. --- gcc/tree-ssa.c | 5 + 1 file changed, 5 insertions(+) diff

Re: [PATCH] Fix memory leaks in tree-ssa-uninit.c

2015-11-26 Thread Martin Liška
On 11/20/2015 12:15 PM, Martin Liška wrote: On 11/20/2015 03:14 AM, Bernd Schmidt wrote: BTW, I'm with whoever said absolutely no way to the idea of making automatic changes like this as part of a commit hook. I think the whitespace change can go in if it hasn't already, but I think

Re: [PATCH 3/6] Fix memory leaks in IPA devirt

2015-11-26 Thread Martin Liška
On 11/23/2015 11:29 PM, Trevor Saunders wrote: On Mon, Nov 23, 2015 at 02:48:37PM +0100, marxin wrote: gcc/ChangeLog: 2015-11-20 Martin Liska * ipa-devirt.c (ipa_devirt): Use auto_vec instead of a local-scope vec. Release final_warning_records. ---

Re: [PATCH 1/6] Fix memory leak in cilk

2015-11-26 Thread Martin Liška
On 11/23/2015 02:48 PM, marxin wrote: gcc/c/ChangeLog: 2015-11-20 Martin Liska PR c++/68312 * c-array-notation.c (fix_builtin_array_notation_fn): Use release_vec_vec instead of vec::release. (build_array_notation_expr): Likewise.

[PATCH 7/N] Fix newly introduced memory leak in tree-ssa-loop-ivopts.c

2015-11-26 Thread Martin Liška
Hi. There's one more patch that fixes really of lot memory leaks related to loop ivopts. The regression was introduced by r230647. Patch was tested in the series with the rest and the compiler bootstraps successfully. Ready for trunk? Thanks, Martin >From

[HSA] Implementation of various omp_* function

2015-11-27 Thread Martin Liška
Hello. Following pair of patches implements missing omp function. Installed to the HSA branch. Thanks, Martin >From 90cb91ca75ce29e560184fbd1ca03a7e58fc6685 Mon Sep 17 00:00:00 2001 From: marxin Date: Thu, 26 Nov 2015 10:18:44 +0100 Subject: [PATCH 1/5] HSA: implement

[HSA] fix emission of function names with user-defined assembly names

2015-11-27 Thread Martin Liška
Hello. The patch has just been applied to the HSA branch. Martin >From 9f791cd1715b65599a4b022a56a7eac7e0816e72 Mon Sep 17 00:00:00 2001 From: marxin Date: Fri, 27 Nov 2015 09:06:58 +0100 Subject: [PATCH 3/5] HSA: fix emission of function names with user-defined names

Re: [hsa] Back-end enhancement

2015-11-25 Thread Martin Liška
On 11/24/2015 06:22 PM, Martin Liška wrote: > Hi. > > Following small series enhances HSA back-end in following manner: > > 1) HSA: support alloca builtin > 2) HSA: dump alignment of mem and alloca instructions > 3) HSA: write back OMP arguments after a kernel dispatch >

[hsa] Back-end enhancement

2015-11-24 Thread Martin Liška
Hi. Following small series enhances HSA back-end in following manner: 1) HSA: support alloca builtin 2) HSA: dump alignment of mem and alloca instructions 3) HSA: write back OMP arguments after a kernel dispatch All patches have been committed to the branch. Martin >From

Re: [PATCH 1/6] Fix memory leak in cilk

2015-11-27 Thread Martin Liška
On 11/27/2015 10:21 AM, Bernd Schmidt wrote: > Already improved, wasn't it? (Please don't quote the entire previous patch > next time). > > > Bernd Thanks, I just applied nits pointed by you. Patch installed as r231001. Thank you, Martin

Re: [PATCH 7/N] Fix newly introduced memory leak in tree-ssa-loop-ivopts.c

2015-11-27 Thread Martin Liška
On 11/27/2015 04:54 AM, Bin.Cheng wrote: > On Fri, Nov 27, 2015 at 5:08 AM, Martin Liška <mli...@suse.cz> wrote: >> Hi. >> >> There's one more patch that fixes really of lot memory leaks related to loop >> ivopts. >> The regression was introduced by r23064

[PATCH] Add clang-format config to contrib folder

2015-11-18 Thread Martin Liška
Hello. Following patch adds a clang-format config file that should respect the GNU coding standards. As the file is not part of build process, I hope the patch can be applied even though we've just skipped to stage3? The patch adds a hunk to Makefile which can create symlink to the root

Re: [PATCH] Fix memory leaks in tree-ssa-uninit.c

2015-11-18 Thread Martin Liška
On 11/13/2015 08:19 PM, Jeff Law wrote: > On 11/13/2015 09:58 AM, Martin Liška wrote: >> On 11/13/2015 05:32 PM, Jeff Law wrote: >>> On 11/13/2015 05:50 AM, Martin Liška wrote: >>>> Hello. >>>> >>>> Patch survives regbootstrap on x8

Re: [PATCH] Fix memory leaks in tree-ssa-uninit.c

2015-11-19 Thread Martin Liška
On 11/19/2015 01:50 AM, Joseph Myers wrote: I don't think all the reformattings here are things we want to do globally for most source files. E.g. @@ -75,18 +74,17 @@ get_mask_first_set_bit (unsigned mask) static bool has_undefined_value_p (tree t) { - return (ssa_undefined_value_p (t)

Re: [PATCH] Fix memory leaks in tree-ssa-uninit.c

2015-11-20 Thread Martin Liška
On 11/20/2015 03:14 AM, Bernd Schmidt wrote: > BTW, I'm with whoever said absolutely no way to the idea of making automatic > changes like this as part of a commit hook. > > I think the whitespace change can go in if it hasn't already, but I think the > other one still has enough problems that

Re: [PATCH] Add clang-format config to contrib folder

2015-11-20 Thread Martin Liška
On 11/19/2015 06:43 PM, Pedro Alves wrote: > On 11/19/2015 12:54 PM, Martin Liška wrote: >> ContinuationIndentWidth: 2 >> -ForEachMacros: >> ['_FOR_EACH','_FOR_EACH_1','FOR_EACH_AGGR_INIT_EXPR_ARG','FOR_EACH_ALIAS','FOR_EACH_ALLOCNO','FOR_EACH_ALLOCNO_OBJECT','FO

Re: [PATCH] Add clang-format config to contrib folder

2015-11-19 Thread Martin Liška
On 11/19/2015 11:40 AM, Martin Liška wrote: > On 11/19/2015 12:09 AM, Sebastian Pop wrote: >> Martin, thanks for getting this patch out. I like the patch. >> Jeff, clang-format has scripts that allow formatting only the lines >> touched by a patch. >> It also has a s

Re: [PATCH,RFC] Introduce RUN_UNDER_VALGRIND in test-suite

2015-11-23 Thread Martin Liška
On 11/21/2015 05:26 AM, Hans-Peter Nilsson wrote: > On Thu, 19 Nov 2015, Martin Li?ka wrote: >> Hello. >> >> In last two weeks I've removed couple of memory leaks, mainly tight to >> middle-end. >> Currently, a user of the GCC compiler can pass '--enable-checking=valgrind' >> configure option >>

[PATCH, gcc5 backport] Fix PR ipa/65908

2015-11-23 Thread Martin Liška
Hi. At the end of last week, Richi asked me to back port aforementioned PR. The patch contains two parts: first one is the patch that was applied to trunk and the second one is a hunk that implements param_used_p (coming from r222374). Patch can bootstrap and survives regression tests on

Re: [PATCH 0/6] Another fixes of various memory leaks

2015-11-23 Thread Martin Liška
On 11/23/2015 03:36 PM, Bernd Schmidt wrote: > On 11/23/2015 02:49 PM, marxin wrote: >> Following series has been just bootregtested on x86_64-linux-gnu >> (all patches together). > > All ok except 5/6 which I'm not finding obvious. Better to have a cilk/c++ > person have a look. Hi. Sure,

[hsa] Redesign busy loop waiting so that a kernel dispatch signal can be reused

2015-11-24 Thread Martin Liška
Hello. Following patch is a workaround for Carrizo devices that tend to have problems with propagation of signal values due to an issue with L2. Commited to the branch. Martin >From ca4475aedb47e49b4bdc0a8980f200ec93b31d61 Mon Sep 17 00:00:00 2001 From: marxin Date: Tue, 24 Nov

Re: [PATCH] Fix memory leaks in tree-ssa-uninit.c

2015-11-19 Thread Martin Liška
On 11/19/2015 02:58 PM, Bernd Schmidt wrote: > On 11/19/2015 11:16 AM, Martin Liška wrote: >> You are right, however as the original coding style was really broken, >> it was much easier >> to use the tool and clean-up fall-out. >> >> Waiting for thoughts related t

[PATCH,RFC] Introduce RUN_UNDER_VALGRIND in test-suite

2015-11-19 Thread Martin Liška
Hello. In last two weeks I've removed couple of memory leaks, mainly tight to middle-end. Currently, a user of the GCC compiler can pass '--enable-checking=valgrind' configure option that will run all commands within valgrind environment, but as the valgrind runs just with '-q' option, the

Re: Moving backwards/FSM threader into its own pass

2016-06-09 Thread Martin Liška
Hello. The patch caused: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=71466 Thanks, Martin

Re: [PATCH 2/2] Add edge predictions pruning

2016-06-09 Thread Martin Liška
On 06/08/2016 02:41 PM, Jan Hubicka wrote: > Adding hash for this prupose is bit of an overkill (there are > definitly cheaper ways of solving so), but it will hardly affect compile > time, so the pathc is OK. > > Thanks, > Honza Hi Sending the final version where I added comments and I also

[PATCH] Do not enable -fcheck-pointer-bounds w/ -fsanitize=bounds

2016-06-09 Thread Martin Liška
Hello. I've prepared patch for the PR that is very similar to what was done in PR65044. I've been currently testing the patch on x86_64-linux. Ready to be installed after it finishes? Thanks, Martin >From a04b8e09388499686aabd401ef33e2821f3f0809 Mon Sep 17 00:00:00 2001 From: marxin

Re: Update probabilities in predict.def to match reality

2016-06-09 Thread Martin Liška
On 06/07/2016 09:27 PM, Jan Hubicka wrote: > There are bugs in few predictors - goto predictor is dead because the FE code > was dropped, > return predictor is bit random because CFG is optimized (it should probably > be done in FE), > loop iv compare seems bogus and fortran fail alloc does not

Re: [PATCH 2/2] Add edge predictions pruning

2016-06-08 Thread Martin Liška
Hi. I'm sending second version of the patch, where I fixed dump_prediction function to dump a proper edge. Thanks, Martin >From 0d82e8def140636fe186888a525fe84e329d676b Mon Sep 17 00:00:00 2001 From: marxin Date: Tue, 31 May 2016 17:29:53 +0200 Subject: [PATCH 2/4] Add edge

[PATCH 3/N] Add sorting support to analyze_brprob script

2016-06-08 Thread Martin Liška
Hello. This is a small followup, where I would like to add new argument to analyze_brprob.py script file. With the patch, one can sort predictors by e.g. hitrate: Example CPU2006 HEURISTICS BRANCHES (REL) HITRATE COVERAGE COVERAGE (REL) loop iv

Re: Update probabilities in predict.def to match reality

2016-06-08 Thread Martin Liška
On 06/07/2016 09:27 PM, Jan Hubicka wrote: > There are bugs in few predictors - goto predictor is dead because the FE code > was dropped, > return predictor is bit random because CFG is optimized (it should probably > be done in FE), > loop iv compare seems bogus and fortran fail alloc does not

Re: Update probabilities in predict.def to match reality

2016-06-08 Thread Martin Liška
On 06/08/2016 12:21 PM, Andreas Schwab wrote: > Jan Hubicka writes: > >> Bootstrapped/regtested x86_64-linux, will commit it later today. > > FAIL: gcc.dg/tree-ssa/slsr-8.c scan-tree-dump-times optimized " w?* " 7 > > Andreas. > Hi. It's caused by a different

[PATCH 4/N] Add new analyze_brprob_spec.py script

2016-06-08 Thread Martin Liška
Hi. The second follow up patch adds new script which is a simple wrapper around analyze_brprob.py and can be used to dump statistics for results that are in different folder (like SPEC benchmarks). Sample: ./contrib/analyze_brprob_spec.py --sorting=hitrate

[PATCH] Do not instrument string cst w/ unknown decl size (PR, sanitizer/71378)

2016-06-03 Thread Martin Liška
Hi! As seen in the issue, we try to instrument a global variable that contains a string constant. Following patch does not instrument in the size is variable (VLA). Patch survives regression tests and bootstraps on x86_64-linux. It's questionable whether the same situation can also happen in

Re: [PATCH] Do not instrument string cst w/ unknown decl size (PR, sanitizer/71378)

2016-06-03 Thread Martin Liška
On 06/03/2016 01:00 PM, Jakub Jelinek wrote: > I think the STRING_CST with non-constant size is already a bug, so this > patch looks to me just like a workaround for a bug that is somewhere else. Ah, thanks for clarification, it looked weird to me. I've just reclassified the PR, btw. clang++

Re: [BUILDROBOT] MPS430 build problem due to new enum

2016-06-13 Thread Martin Liška
On 06/12/2016 01:55 PM, Jan-Benedict Glaw wrote: > The new `NONE' from your enum clashes with a NONE used in a MSP430 > private enum. > > MfG, JBG Hi. Thanks for having heads up, I've been testing following patch. The patch survives with --target=msp430-elf. Ready after it finishes? Thanks,

Re: [BUILDROBOT] MPS430 build problem due to new enum

2016-06-13 Thread Martin Liška
On 06/13/2016 10:46 AM, Jan Hubicka wrote: > Hmm, namespace conflict. I guess renaming enum items to REASON_* should > solve it easily. > Or we can add a namespace. > > Martin, both variants of fix are pre-approved. > Honza OK, I've just installed (r237370) a patch that prefixes all enum

Re: [PATCH] Improve tree-ssa-tail-merge for switches (PR tree-optimization/71520)

2016-06-14 Thread Martin Liška
On 06/14/2016 10:00 AM, Richard Biener wrote: > I'd like to postpone this until tail-merging got rid of its SCCVN > dependency (the proposed merge with the ICF machinery). Hi. I'm going to continue on that at the very beginning of next month. Martin

[PATCH] Fix code emission for FAIL_ALLOC predictor

2016-06-13 Thread Martin Liška
Hello. Following patch fixes Fortran FAIL_ALLOC predictor in a way that it introduces a new one (PRED_FORTRAN_REALLOC) and it properly marks returned values as described in the following 2 examples: A) allocate_allocatable original annotation: if ((logical(kind=4)) __builtin_expect

Re: [PATCH] Fix code emission for FAIL_ALLOC predictor

2016-06-15 Thread Martin Liška
Adding missing patch. Martin >From 35ba97e0139d955c04e67ca157f8899bbb468bf1 Mon Sep 17 00:00:00 2001 From: marxin Date: Thu, 9 Jun 2016 17:51:38 +0200 Subject: [PATCH] Fix code emission for FAIL_ALLOC predictor gcc/ChangeLog: 2016-06-13 Martin Liska *

[PATCH] [OBVIOUS] Fix obvious typo in predict.c

2016-06-15 Thread Martin Liška
Hello. This corrects a typo in predict.c, which is pre-approved by Honza. Survives regression tests & bootstraps on x86_64-linux-gnu. Installed as r237481. Martin >From 5d755d1a83094b24319d4a31d1c951c8aa622a87 Mon Sep 17 00:00:00 2001 From: marxin Date: Wed, 15 Jun 2016

Re: [PATCH 2/3] Add profiling support for IVOPTS

2016-05-30 Thread Martin Liška
On 05/24/2016 12:11 PM, Bin.Cheng wrote: > Hi, > Could you please factor out this as a function and remove the goto > statements? Okay with this change if no fallout in benchmarks you > run. > > Thanks, > bin Hi. Thanks for the review, I've just verified that it does not introduce any

Re: [PATCH 1/3] Encapsulate comp_cost within a class with methods.

2016-05-26 Thread Martin Liška
On 05/19/2016 01:24 PM, Bin.Cheng wrote: > On Thu, May 19, 2016 at 11:23 AM, Martin Liška <mli...@suse.cz> wrote: >> On 05/16/2016 03:55 PM, Martin Liška wrote: >>> On 05/16/2016 12:13 PM, Bin.Cheng wrote: >>>> Hi Martin, >>>> Could you please

[PATCH] Fix first match heuristics

2016-06-02 Thread Martin Liška
Hi. Following patch fixes a typo in first match heuristics that blocks selection of best first match heuristics. It's questionable whether to add a spacial test-case for that? I'm bit concerned that it can be a bit fragile. Bootstrapped and regtested on x86_64-linux. Ready for trunk? Thanks,

[PATCH, COMMITTED] Fix display name of PRED_FORTRAN_FAIL_IO

2016-06-02 Thread Martin Liška
Hi. Following patch fixes an obvious typo in definition of a predictor. Installed as r237040. Martin >From f78bf4238b4a3c7d6e03d7c00718204123a2cbfd Mon Sep 17 00:00:00 2001 From: marxin Date: Thu, 2 Jun 2016 18:13:25 +0200 Subject: [PATCH] Fix display name of

[PATCH] Change minimum of -predicted-iterations to 1 (PR71619)

2016-06-22 Thread Martin Liška
Hello. Following patch just changes minimum value to 1. I think having minimum to zero does not make any good sense. Running reg on x86_64-linux-gnu, ready after it finishes? Thanks, Martin >From c677c2bdc0f011dbda013dd396431b3afcbc2ae9 Mon Sep 17 00:00:00 2001 From: marxin

Re: [PATCH] Change minimum of -predicted-iterations to 1 (PR71619)

2016-06-22 Thread Martin Liška
On 06/22/2016 04:59 PM, Martin Liška wrote: > Hello. > > Following patch just changes minimum value to 1. I think having minimum to > zero > does not make any good sense. > > Running reg on x86_64-linux-gnu, ready after it finishes? > > Thanks, > Martin > As

[PATCH] Fix memory leak in tree-ssa-reassoc.c

2016-06-17 Thread Martin Liška
Hi. Following simple patch fixes a newly introduced memory leak. Patch survives regression tests and bootstraps on x86_64-linux. Ready from trunk? Thanks, Martin >From a2e6be16d7079b744db4d383b8317226ab53ff58 Mon Sep 17 00:00:00 2001 From: marxin Date: Fri, 17 Jun 2016 12:26:58

[PATCH] [OBVIOUS] s/imposisble/impossible in predict.c

2016-06-21 Thread Martin Liška
Hello. I've just installed patch that does $SUBJECT. Thanks, Martin >From 8302396974053dd00cd5eaff594dddf2f1ccf80b Mon Sep 17 00:00:00 2001 From: marxin Date: Tue, 21 Jun 2016 18:05:50 +0200 Subject: [PATCH] s/imposisble/impossible in predict.c gcc/ChangeLog: 2016-06-21

[PATCH] Do not emit SAVE_EXPR for already assigned SSA_NAMEs (PR71606).

2016-06-23 Thread Martin Liška
Hi. This is candidate patch for the PR, which do not create SAVE_EXPR trees for already assigned SSA_NAMEs. Patch survives reg on x86_64-linux-gnu. Thoughts? Thanks, Martin >From 91d01830302171b5cd53fa2f32cc881b2b50762f Mon Sep 17 00:00:00 2001 From: marxin Date: Wed, 22 Jun

[PATCH] Fix PR middle-end/71619

2016-06-23 Thread Martin Liška
Hi. Following patch reverts the hunk that was removed in r237103. Patch can bootstrap & passes regression tests on x86_64-linux-gnu. Patch is approved by Honza. Thanks, Martin >From e31bef9738193edd46fae118074bd7f241f366c2 Mon Sep 17 00:00:00 2001 From: marxin Date: Thu, 23 Jun

[PATCH] Fix PR rtl-optimization/71634

2016-06-23 Thread Martin Liška
Hello. Following patch changes minimum of ira-max-loops-num to 1. Having the minimum equal to zero does not make much sense. Ready after it finishes reg on x86_64-linux? Thanks, Martin >From e72dafdf3a2a7cfaca4a617fd10e80dd7aae1e91 Mon Sep 17 00:00:00 2001 From: marxin Date:

Re: [PATCH] Prevent LTO wrappers to process a recursive execution

2016-06-23 Thread Martin Liška
On 06/23/2016 06:57 AM, Jeff Law wrote: > Is this still something you want to pursue? It looks pretty reasonable and > one could make an argument that it's a good idea in and of itself. > > jeff Yeah, I would like to install the patch :) Can I take your reply as signal that it's accepted?

[PATCH] Add 'Fortran' to display text of all PRED_FORTRAN_*

2016-06-16 Thread Martin Liška
Hello. Following patch just enhances display names of all Fortran predictors. Pre-approved by Honza. Patch survives reg on x86_64-linux-gnu. Installed as r237532. Martin >From 4bfd7a78395c5145712fd5a104e9a9dd43b9c541 Mon Sep 17 00:00:00 2001 From: marxin Date: Thu, 16 Jun 2016

[PATCH] Introduce fortran loop preheader

2016-06-16 Thread Martin Liška
Hello. Following patch introduces FORTRAN_LOOP_PREHEADER predictor for all Fortran loops that are transformed to: [Evaluate loop bounds and step] dovar = from; if ((step > 0) ? (dovar <= to) : (dovar => to)) { for (;;) { body; cycle_label: cond =

[PATCH] Fix finding of a first match predictor

2016-06-16 Thread Martin Liška
Hello. Currently, whenever we find a first match predictor, we firstly find a predictor which is defined first in the list of predictors and eventually we check that the predictor is PRED_FLAG_FIRST_MATCH. Proper implementation is to consider just predictors with the flag set. Patch reg on

Re: [PATCH] Implement -fdiagnostics-parseable-fixits

2016-06-24 Thread Martin Liška
On 06/22/2016 05:25 AM, David Malcolm wrote: > Clang has an option -fdiagnostics-parseable-fixits, which emits a > machine-readable version of the fixits, for use by IDEs. (The only > IDE I know of that supports this format is Xcode [1]; does anyone > know of other IDEs supporting this? I'd be

[PATCH] Dump profile-based number of iterations

2016-06-24 Thread Martin Liška
Hello Following patch dumps # of iterations for loops that iterates with unknown number of iterations and profile is available. The same support is added to contrib/analyze_brprob.py script. Sample output of the script: Loop count: 918 avg. # of iter: 6.29 median # of iter: 8.00 avg.

[PATCH] Change PRED_LOOP_EXIT from 92 to 85.

2016-06-17 Thread Martin Liška
Hello. After we've recently applied various changes (fixes) to predict.c, SPEC2006 shows that PRED_LOOP_EXIT value should be amended. Survives regression tests & bootstrap on x86_64-linux. Pre-approved by Honza, installed as r237556. Thanks, Martin >From 849c2e064bcadc269f82656d15722f28d1b1fe73

Re: [hsa merge 07/10] IPA-HSA pass

2016-01-15 Thread Martin Liška
On 01/15/2016 10:52 AM, Jan Hubicka wrote: > Do we really need to look that up in the hsa summary? Why these can not be > partitioned the > usual way? Hi. Yes, it's needed as hsa-brig.c uses host function declaration of a kernel as a key for libgomp. That's why we want to put the pair to a LTO

Re: [hsa merge 07/10] IPA-HSA pass

2016-01-15 Thread Martin Liška
On 01/14/2016 01:58 PM, Jakub Jelinek wrote: > Does it really need to be enabled whenever in_lto_p? > I mean, if HSA is not configured in, I think the gate should be false too. Sure, it can be removed, change will incorporated in final installed version of the file. Thanks, Martin

Re: [PATCH] Mark -fstack-protect as optimization flag (PR middle-end/71585)

2016-06-29 Thread Martin Liška
On 06/28/2016 03:54 PM, Richard Biener wrote: > I wonder about the inliner change. If one marks a single function > with -fstack-protector > that implicitely marks callers with -fno-stack-protector. So I'd > rather disable inlining > between different settings here? It works in the opposite

Re: [PATCH, RFC] New memory usage statistics infrastructure

2016-02-01 Thread Martin Liška
On 01/29/2016 05:24 PM, Patrick Palka wrote: > On Thu, May 28, 2015 at 1:07 PM, Jeff Law <l...@redhat.com> wrote: >> On 05/28/2015 06:29 AM, Martin Liška wrote: >> >>>> >>> >>> Hello. >>> >>> Thank you for pointing about miss

Re: [PATCH 10/9] ENABLE_CHECKING refactoring: remove remaining occurrences

2016-02-24 Thread Martin Liška
On 02/23/2016 04:21 PM, Richard Biener wrote: > On Wed, Nov 4, 2015 at 4:03 PM, Mikhail Maltsev wrote: >> On 11/03/2015 02:35 AM, Jeff Law wrote: >>> This is good fore the trunk too. Please install. >>> >>> Thanks! >>> >>> jeff >> >> Committed as r229758. > >> grep

Re: [PATCH 10/9] ENABLE_CHECKING refactoring: remove remaining occurrences

2016-02-24 Thread Martin Liška
On 02/24/2016 03:27 PM, Michael Matz wrote: > But nothing can set ENABLE_CHECKING anymore (the macro is meanwhile called > CHECKING_P), so all that code is dead anyway. So either the new macro > should be used or that code should be removed. > > > Ciao, > Michael. Good point, well the change

[PATCH, HSA] Fix emission of clrsb{l,ll} builtins

2016-02-22 Thread Martin Liška
Hello. Following patch correctly handles builtins mentioned in the email subject in order to return correct value for 0 as the argument. The patch can boostrap on x86_64-linux-gnu and survives regression tests and is pre-approved by Martin Jambor. Moreover, I'm preparing a test-case that will

Re: [wwwdocs] Describe behavior of -flifetime-dse in class constructors

2016-02-25 Thread Martin Liška
On 02/17/2016 04:01 PM, Martin Liška wrote: > On 02/17/2016 03:23 PM, Jakub Jelinek wrote: >> "has been" looks weird. I'd say that the C++ compiler is now more >> aggressive... >> >> Jakub > > Sending v3. > > M. > Hi. I've been th

[PATCH] Do not gather mem stats in run_exit_handles (PR middle-end/69919)

2016-02-25 Thread Martin Liška
Hello. As discussed in https://gcc.gnu.org/bugzilla/show_bug.cgi?id=69919#c3, following patch guards usage of memory statistics infrastructure after a mem_alloc_description is already destructed. Patch can lto-bootstrap on x86_64-linux-gnu with --enable-gather-detailed-mem-stats and survives

Re: [wwwdocs] Describe behavior of -flifetime-dse in class constructors

2016-02-25 Thread Martin Liška
On 02/19/2016 05:52 AM, Jan Hubicka wrote: > Hi, > thank you for working this out and writting summary. I think in a shorter > form this would make > excellent entry for changes.html, too. We tell about the new feature and > warn users about fallout > that is always good. Good idea. That's a

Re: [PATCH 10/9] ENABLE_CHECKING refactoring: remove remaining occurrences

2016-02-25 Thread Martin Liška
On 02/25/2016 11:14 AM, Pierre-Marie de Rodat wrote: > Understood. Martin, as the ENABLE_CHECKING refactoring is not comitted yet, > could you do the substitution ENABLE_CHECKING → CHECKING_P for these > dwarf2out.* occurences as part of it? Sure. Just working on that. Martin

[HSA,PATCH] reduce dump output w/o -details flag

2016-02-29 Thread Martin Liška
Hello. Following patch limits the number of dump information which is printed to *.hsagen dump file. Patch has been pre-approved by Martin Jambor and survives regbootstrap on x86_64-linux-gnu. Installed as r233814. Thanks, Martin >From 30e91f90196fcf4c2180bd907ad0f775611f7135 Mon Sep 17

Re: [DOC, PATCH] Mention --enable-valgrind-annotations in install.texi

2016-02-26 Thread Martin Liška
On 12/09/2015 11:01 AM, Markus Trippelsdorf wrote: > Sorry, but this is simply awful ;-). How about: > > Mark selected memory related operations in the compiler when run under > valgrind to suppress false positives. Hi. I forgot to install the patch, following Markus' correction, installed as

<    1   2   3   4   5   6   7   8   9   10   >