Re: [PATCH 0/X] Introduce HWASAN sanitizer to GCC

2019-11-05 Thread Martin Liška
On 11/5/19 12:32 PM, Matthew Malcomson wrote: Hello, This patch series adds the LLVM hardware address sanitizer (HWASAN) to GCC. The document describing HWASAN can be found here http://clang.llvm.org/docs/HardwareAssistedAddressSanitizerDesign.html. Hello. Thank you for the patch. I've just

[PATCH] Clear version_info_node in delete_function_version.

2019-11-05 Thread Martin Liška
Hi. When calling delete_function_version, we should also clear version_info_node once it can be seen GGC collect. Patch can bootstrap on x86_64-linux-gnu and survives regression tests. Ready to be installed? Thanks, Martin gcc/ChangeLog: 2019-11-05 Martin Liska PR c++/92354

Re: [PATCH][RFC] Param to options conversion (demo).

2019-11-05 Thread Martin Liška
On 11/5/19 3:13 PM, Richard Biener wrote: On Thu, Oct 31, 2019 at 2:17 PM Martin Liška wrote: On 10/31/19 2:16 PM, Martin Liška wrote: On 10/31/19 2:01 PM, Martin Liška wrote: Hi. Based on the discussion with Honza and Richard I'm sending a proposal for conversion of param machinery

Re: [PATCH 0/X] Introduce HWASAN sanitizer to GCC

2019-11-05 Thread Martin Liška
On 11/5/19 5:11 PM, Matthew Malcomson wrote: On 05/11/2019 15:10, Martin Liška wrote: On 11/5/19 12:32 PM, Matthew Malcomson wrote: Hello, This patch series adds the LLVM hardware address sanitizer (HWASAN) to GCC.  The document describing HWASAN can be found here http://clang.llvm.org/docs

Re: [PATCH 0/X] Introduce HWASAN sanitizer to GCC

2019-11-05 Thread Martin Liška
On 11/5/19 6:35 PM, Matthew Malcomson wrote: On 05/11/2019 17:22, Martin Liška wrote: On 11/5/19 5:11 PM, Matthew Malcomson wrote: On 05/11/2019 15:10, Martin Liška wrote: On 11/5/19 12:32 PM, Matthew Malcomson wrote: Hello, This patch series adds the LLVM hardware address sanitizer (HWASAN

Re: [PATCH 3/5] Reapply all revisions mentioned in LOCAL_PATCHES.

2019-11-05 Thread Martin Liška
On 11/5/19 7:41 PM, Rainer Orth wrote: Hi Martin, libsanitizer/ChangeLog: 2019-11-05 Martin Liska * asan/asan_globals.cpp (CheckODRViolationViaIndicator): Reapply from LOCAL_PATCHES. (CheckODRViolationViaPoisoning): Likewise. (RegisterGlobal): Likewise.

[PATCH 1/3] Libsanitizer: merge from trunk

2019-11-05 Thread Martin Liška
Hello. As I was correctly notified, LLVM has moved to git mono repository before 2 weeks ago. So that my last merge from trunk did point to the tip of their repository. So that, I rewrote the merge.sh script and made one more merge. Patch can bootstrap on x86_64-linux-gnu and survives regression

[PATCH 2/3] Reapply all revisions mentioned in LOCAL_PATCHES.

2019-11-05 Thread Martin Liška
>From f967ce2f155d50c8d28b9a7f5c7d10443131d940 Mon Sep 17 00:00:00 2001 From: Martin Liska Date: Tue, 5 Nov 2019 19:10:21 +0100 Subject: [PATCH 2/3] Reapply all revisions mentioned in LOCAL_PATCHES. libsanitizer/ChangeLog: 2019-11-05 Martin Liska * all source files: Reapply all revisions m

Re: [PATCH][RFC] Param to options conversion (demo).

2019-11-06 Thread Martin Liška
On 11/5/19 5:01 PM, Richard Biener wrote: On Tue, Nov 5, 2019 at 4:22 PM Martin Liška wrote: On 11/5/19 3:13 PM, Richard Biener wrote: On Thu, Oct 31, 2019 at 2:17 PM Martin Liška wrote: On 10/31/19 2:16 PM, Martin Liška wrote: On 10/31/19 2:01 PM, Martin Liška wrote: Hi. Based on the

Re: Free memory used by optimization/target options

2019-11-06 Thread Martin Liška
On 11/5/19 11:40 AM, Jan Hubicka wrote: + print " if (ptr->" name")"; + print "free (const_cast (ptr->" name"));"; If I'm correct, you can call free even for a NULL pointer. Martin

Re: Add object allocators to symbol and call summaries

2019-11-06 Thread Martin Liška
On 11/5/19 6:53 PM, Jan Hubicka wrote: Found it. It turns out that ggc_prune_ovehread_list is bogus. It walks all active allocations objects and looks if they was collected accoutnig their collection and then throws away all allocations (including those not colelcted) and those gets no longer a

[PATCH] Make mklog more robust.

2019-11-07 Thread Martin Liška
Hi. The patch makes mklog more robust for a line in patch: '---param=foo=bar xyz'. I'm going to install it if there are no objections. Martin contrib/ChangeLog: 2019-11-07 Martin Liska * mklog: The script fails for patches that contain: '---param=foo=bar xyz'. --- contrib/

Re: [PATCH 0/2] Introduce a new GCC option, --record-gcc-command-line

2019-11-07 Thread Martin Liška
On 11/6/19 6:21 PM, Egeyar Bagcioglu wrote: Hello, Hello. I would like to propose the following patches which introduce a compile option --record-gcc-command-line. When passed to gcc, it saves the command line option into the produced object file. The option makes it trivial to trace back

Re: [PATCH 0/2] Introduce a new GCC option, --record-gcc-command-line

2019-11-07 Thread Martin Liška
+ adding the author of Annobin to the email thread On 11/7/19 10:24 AM, Martin Liška wrote: a) it does not print per function options, which can be modified with  __attribute__ (or pragma): Compiler is aware of the information (and uses it in inlining (or ICF) for instance

Re: [PATCH 1/3] Libsanitizer: merge from trunk

2019-11-07 Thread Martin Liška
Hi. There's updated version of the merge.sh which is simplified and only redirected to the new git repository. I'm going to install the series. Thanks, Martin >From 6aa47fc1eebc512ef8f821bd407978faec3bb0e0 Mon Sep 17 00:00:00 2001 From: Martin Liska Date: Tue, 5 Nov 2019 19:06:34 +0100 Subject:

Re: [patch][avr] PR92055: Add switches to enable 64-bit [long] double.

2019-11-07 Thread Martin Liška
Hello. I've noticed quite some GNU coding style violations with your patch. Please next time, use something like: $ git diff HEAD~ > /tmp/patch && ./contrib/check_GNU_style.py /tmp/patch Thanks, Martin

Re: [patch][avr] PR92055: Add switches to enable 64-bit [long] double.

2019-11-07 Thread Martin Liška
On 11/7/19 1:39 PM, Georg-Johann Lay wrote: Am 07.11.19 um 10:41 schrieb Martin Liška: Hello. I've noticed quite some GNU coding style violations with your patch. Please next time, use something like: $ git diff HEAD~ > /tmp/patch && ./contrib/check_GNU_style.py /tmp/patch

[PATCH] Rename identifiers in a test-case.

2019-11-08 Thread Martin Liška
Hi. I renamed identifiers and reformatted the test-case. I'm going to install the patch. Martin gcc/testsuite/ChangeLog: 2019-11-08 Martin Liska * g++.dg/pr92339.C: Rename identifiers to something more readable. --- gcc/testsuite/g++.dg/pr92339.C | 19 ++-

[PATCH] Enhance syntax of -fdbg-cnt.

2019-11-11 Thread Martin Liška
Hi. The patch makes debug counter more usable. In particular, one can now list multiple closed intervals and -fdbg-cnt-list can reflect that. Based on the discussion with Richard, I decided to leave semi-closed intervals and make it closed, it's more intuitive. Example: $ g++ -O2 tramp3d-v4.ii

[PATCH] Sort debug counter names.

2019-11-11 Thread Martin Liška
Hi. The small patch is about sorting of debug counter values. Ready to be installed? Thanks, Martin >From f9e1387c8e03d73d00d701fa9754af850424215f Mon Sep 17 00:00:00 2001 From: Martin Liska Date: Mon, 11 Nov 2019 09:03:24 +0100 Subject: [PATCH] Sort debug counter names. gcc/ChangeLog: 2019-1

[PATCH] Use more SET_OPTION_IF_UNSET.

2019-11-11 Thread Martin Liška
There's one more refactoring patch that is about more usage of SET_OPTION_IF_UNSET for parameters. Patch can bootstrap on x86_64-linux-gnu and survives regression tests. Ready to be installed? Thanks, Martin >From 638a27f03c7ce06bcc02d7c5d27ba6eb794abede Mon Sep 17 00:00:00 2001 From: Martin Lis

[PATCH] Relax lto-dump.o dependency.

2019-11-11 Thread Martin Liška
Hi. Current lto-dump.o relies on some FE generated files as pre-requirement. That hover delays LTO linking of the lto-dump and so that I adjusted the dependency to LTO_OBJS which will work as well. Patch can bootstrap on x86_64-linux-gnu and survives regression tests. Ready to be installed? Tha

Re: [PATCH 3/X] [libsanitizer] Add option to bootstrap using HWASAN

2019-11-11 Thread Martin Liška
On 11/7/19 7:37 PM, Matthew Malcomson wrote: +@item @samp{bootstrap-hwasan} +Compiles GCC itself using HWAddress Sanitization in order to catch invalid +memory accesses within the GCC code. This option is only available on AArch64 +targets with a very recent linux kernel (5.4 or later). + Appa

Re: [PATCH] Enhance syntax of -fdbg-cnt.

2019-11-11 Thread Martin Liška
On 11/11/19 3:19 PM, Richard Biener wrote: On Mon, Nov 11, 2019 at 9:17 AM Martin Liška wrote: Hi. The patch makes debug counter more usable. In particular, one can now list multiple closed intervals and -fdbg-cnt-list can reflect that. Based on the discussion with Richard, I decided to

Re: [PATCH] Enhance syntax of -fdbg-cnt.

2019-11-11 Thread Martin Liška
On 11/11/19 3:19 PM, Richard Biener wrote: -static unsigned int limit_low[debug_counter_number_of_counters]; +static auto_vec *limits[debug_counter_number_of_counters] = {NULL}; Hm, apparently it's not working. I see a stack corruption when calling dbgcnt. I also explicitly called .create (2) f

Re: [PATCH] Enhance syntax of -fdbg-cnt.

2019-11-11 Thread Martin Liška
On 11/11/19 3:50 PM, Richard Biener wrote: On Mon, Nov 11, 2019 at 3:33 PM Martin Liška wrote: On 11/11/19 3:19 PM, Richard Biener wrote: On Mon, Nov 11, 2019 at 9:17 AM Martin Liška wrote: Hi. The patch makes debug counter more usable. In particular, one can now list multiple closed

Re: [PATCH] Enhance syntax of -fdbg-cnt.

2019-11-11 Thread Martin Liška
On 11/11/19 4:25 PM, Martin Liška wrote: I'm going to test the patch. Martin There's one more version where I use more references to mitigate indirection of 'counter' vectors. Martin >From e3b8b3edfed1b5ba320d0fe85686908c5c37c22a Mon Sep 17 00:00:00 2001 From: Martin

Re: [PATCH] Sort debug counter names.

2019-11-11 Thread Martin Liška
On 11/11/19 3:20 PM, Richard Biener wrote: On Mon, Nov 11, 2019 at 9:23 AM Martin Liška wrote: Hi. The small patch is about sorting of debug counter values. Ready to be installed? OK Thanks, Martin Hi. There's a small follow up where I enforce the sorting via a selftest. Read

Re: [PATCH] Enhance syntax of -fdbg-cnt.

2019-11-12 Thread Martin Liška
On 11/12/19 9:35 AM, Richard Biener wrote: On Mon, Nov 11, 2019 at 3:56 PM Martin Liška wrote: On 11/11/19 3:19 PM, Richard Biener wrote: -static unsigned int limit_low[debug_counter_number_of_counters]; +static auto_vec *limits[debug_counter_number_of_counters] = {NULL}; Hm, apparently

Re: [PATCH] Sort debug counter names.

2019-11-12 Thread Martin Liška
On 11/12/19 9:39 AM, Richard Biener wrote: On Tue, Nov 12, 2019 at 8:50 AM Martin Liška wrote: On 11/11/19 3:20 PM, Richard Biener wrote: On Mon, Nov 11, 2019 at 9:23 AM Martin Liška wrote: Hi. The small patch is about sorting of debug counter values. Ready to be installed? OK

[PATCH 8/9] Remove option_default_params and option_validate_param hooks.

2019-11-12 Thread Martin Liška
On 11/11/19 3:36 PM, Richard Biener wrote: as a followup I notice that the targets *_default_params () functions should be merged into the default-options structs they have (did you check the defaults are still applied and user-overridable?) Apparently, the *_default_params target hook is not c

Re: [PATCH 0/7] Param conversion to option machinery

2019-11-12 Thread Martin Liška
On 11/11/19 3:42 PM, Richard Biener wrote: I didn't go over them but maybe we can postpone this to a followup and for now make_none_ of them Optimization which preserves Ok, there's updated patch w/o the Optimization keyword. previous behavior (I guess the optimize attribute/pragma doesn't a

Re: [PATCH 3/X] [libsanitizer] Add option to bootstrap using HWASAN

2019-11-12 Thread Martin Liška
On 11/11/19 5:03 PM, Matthew Malcomson wrote: Ah! My apologies -- I sent up a series with a few documentation mistakes. (the others were wording problems so less noticeable) That's fine, I fixed that very easily. Right now, I can confirm using a aarch64 KVM with the following linux kernel: 5.4

Re: [PATCH 5/7] Remove last leftover usage of params* files.

2019-11-12 Thread Martin Liška
On 11/12/19 4:39 PM, Harwath, Frederik wrote: Hi Martin, On 06.11.19 13:40, Martin Liska wrote: (finalize_options_struct): Remove. This patch has been committed by now, but it seems that a single use of finalize_options_struct has been overlooked in gcc/tree-streamer-in.c. Thank y

[PATCH] Remove params for a specific optimization option.

2019-11-13 Thread Martin Liška
Hello. The patch is about removal of special *-O2 parameters that Honza added some time ago. Right now, we have a better mechanism how to have a different default value for a parameter. I'm planning to send a patch that will decorate some params with Optimization attribute and so that one can sen

Re: Free ipa-prop edge summaries for inline calls

2019-11-13 Thread Martin Liška
On 11/12/19 11:07 PM, Martin Jambor wrote: Since ipa_node_params_sum->get might be a bit too long, perhaps we could use ipcp_node_sum->get or something similar. And similarly for edges. What do you think? I'm for the suggested change! Martin

Re: [PATCH] Remove params for a specific optimization option.

2019-11-13 Thread Martin Liška
On 11/13/19 9:20 AM, Jan Hubicka wrote: Hello. The patch is about removal of special *-O2 parameters that Honza added some time ago. Right now, we have a better mechanism how to have a different default value for a parameter. I'm planning to send a patch that will decorate some params with Optim

Re: [PATCH 4/7] Remove gcc/params.* files.

2019-11-13 Thread Martin Liška
On 11/12/19 10:13 PM, Rainer Orth wrote: Hi Martin, gcc/ChangeLog: 2019-11-06 Martin Liska * Makefile.in: Remove PARAMS_H and params.list and params.options. this has obviously not been tested properly: it completely broke gcc.dg/params/params.exp: Hello. Sorry for the

Re: [PATCH] Enhance syntax of -fdbg-cnt.

2019-11-13 Thread Martin Liška
On 11/12/19 10:00 AM, Martin Liška wrote: There's one another version that I'm testing right now. It survives regression tests and bootstrap. Richi, may I install it the patch? Thanks, Martin

Re: [PATCH 0/2] Introduce a new GCC option, --record-gcc-command-line

2019-11-13 Thread Martin Liška
On 11/7/19 3:50 PM, Egeyar Bagcioglu wrote: On 11/7/19 10:24 AM, Martin Liška wrote: On 11/6/19 6:21 PM, Egeyar Bagcioglu wrote: Hello, Hello. Thanks for your detailed reply Martin. You'll find my reply inline. Since you added Nick Clifton to your following reply, I am adding him to

Re: [PATCH 0/2] Introduce a new GCC option, --record-gcc-command-line

2019-11-13 Thread Martin Liška
On 11/7/19 4:13 PM, Nick Clifton wrote: Hi Egeyar, Thanks for including me in this discussion. This option is similar to -frecord-gcc-switches. For the record I will also note that there is -fverbose-asm which does almost the same thing, but only records the options as comments in the assemb

Re: [PATCH] Add if-chain to switch conversion pass.

2019-11-13 Thread Martin Liška
On 11/4/19 3:48 PM, Jakub Jelinek wrote: On Mon, Nov 04, 2019 at 03:23:20PM +0100, Martin Liška wrote: The patch adds a new pass that identifies a series of if-elseif statements and transform then into a GIMPLE switch (if possible). The pass runs right after tree-ssa pass and I decided to

[PATCH][DOC] Document -fallocation-dce.

2019-11-13 Thread Martin Liška
Hi. The patch is about a documentation entry for a newly added option in GCC 10. Ready for trunk? Martin gcc/ChangeLog: 2019-11-13 Martin Liska PR other/92329 * doc/invoke.texi: Document -fallocation-dce. --- gcc/doc/invoke.texi | 8 +++- 1 file changed, 7 insertions(+

[PATCH] Enable VPOPCNTDQ for icelake-{client,server} and tigerlake.

2019-11-13 Thread Martin Liška
Hi. The patch adds a missing feature for PTA_ICELAKE_CLIENT and inherited CPUs. One can see that: https://en.wikipedia.org/wiki/AVX-512#CPUs_with_AVX-512 Patch can bootstrap on x86_64-linux-gnu and survives regression tests. Ready to be installed? Thanks, Martin gcc/ChangeLog: 2019-11-13 Mar

Re: [Patch + RFC][contrib] gcc-changelog/git_commit.py: Check for missing description

2020-11-03 Thread Martin Liška
On 10/30/20 2:16 PM, Tobias Burnus wrote: In terms of issues, it seems as if Ubuntu 20.04.1 LTS has a too old unidiff – I copied the check from test_email.py and applied it to git_email.py – otherwise, nearly all tests fail. Hello. Please apply this hunk separately, it's fine. Still, I do s

Re: [Patch + RFC][contrib] gcc-changelog/git_commit.py: Check for missing description

2020-11-03 Thread Martin Liška
On 10/30/20 2:16 PM, Tobias Burnus wrote: In terms of issues, it seems as if Ubuntu 20.04.1 LTS has a too old unidiff – I copied the check from test_email.py and applied it to git_email.py – otherwise, nearly all tests fail. Still, I do see some fails – I have attached the fails I got. (fails.lo

[PATCH][pushed] Add setup.cfg for pytest.

2020-11-03 Thread Martin Liška
It adds FLAKE8 automatically when pytest is run. Installed. contrib/ChangeLog: * gcc-changelog/setup.cfg: New file. --- contrib/gcc-changelog/setup.cfg | 2 ++ 1 file changed, 2 insertions(+) create mode 100644 contrib/gcc-changelog/setup.cfg diff --git a/contrib/gcc-changelog/setup.

Re: [Patch + RFC][contrib] gcc-changelog/git_commit.py: Check for missing description

2020-11-04 Thread Martin Liška
On 11/3/20 7:46 PM, Tobias Burnus wrote: On 03.11.20 17:28, Martin Liška wrote: I really think the check should support situations where a description is provided on the next line (first after '\t', so not '\t*') as you see in the failing test: That was supposed to h

[PATCH][pushed] gcc-changelog: Change parse_git_revisions strict argument to True.

2020-11-04 Thread Martin Liška
Change the default that is used by GIT server hook and also by git_update_version.py. Both should use True now. Right now the server hook uses: home/gccadmin/hooks-bin/commit_checker commits = parse_git_revisions(os.environ['GIT_DIR'], commit_rev) errs = [] for commit in

Re: [PATCH] ASAN: disable -Wno-stringop-overflow for 2 tests

2020-11-05 Thread Martin Liška
On 10/31/20 4:59 PM, H.J. Lu wrote: On Tue, Oct 13, 2020 at 1:17 AM Jakub Jelinek via Gcc-patches wrote: On Tue, Oct 13, 2020 at 10:11:26AM +0200, Martin Liška wrote: --- a/gcc/testsuite/g++.dg/asan/asan_test.C +++ b/gcc/testsuite/g++.dg/asan/asan_test.C @@ -9,6 +9,7 @@ // { dg-additional

[PATCH] gcc-changelog: prevent double cherry-pick line

2020-11-05 Thread Martin Liška
I'm going to prevent from creation of double 'cherry picked from' lines. There are quite some revision that violate that. I'm going to install it tomorrow in order to make DATESTAMP succeed the upcoming night. Then we can update server hook. Martin contrib/ChangeLog: * gcc-changelog/g

Re: Fix uninitialized memory use in ipa-modref

2020-11-05 Thread Martin Liška
On 11/5/20 3:27 PM, Jan Hubicka wrote: poly_int64 offset; struct modref_parm_map parm_map; + parm_map.parm_offset_known = false; + parm_map.parm_offset = 0; + I'm curious, can't we use a proper C++ class construction. The IPA pass is new and so we can make it more C++-ish? Similar

[PATCH][pushed] testsuite: fix malloc alignment in test

2020-11-06 Thread Martin Liška
Hi. The patch fixes the testcase on ppc64. I'm going to push the commit. Martin gcc/testsuite/ChangeLog: PR gcov-profile/97461 * gcc.dg/tree-prof/pr97461.c: Return aligned memory. --- gcc/testsuite/gcc.dg/tree-prof/pr97461.c | 8 +++- 1 file changed, 7 insertions(+), 1 del

Re: Fix uninitialized memory use in ipa-modref

2020-11-06 Thread Martin Liška
On 11/5/20 6:54 PM, Jan Hubicka wrote: On 11/5/20 3:27 PM, Jan Hubicka wrote: poly_int64 offset; struct modref_parm_map parm_map; + parm_map.parm_offset_known = false; + parm_map.parm_offset = 0; + I'm curious, can't we use a proper C++ class construction. The IPA pass is new and s

Re: Fix uninitialized memory use in ipa-modref

2020-11-06 Thread Martin Liška
On 11/5/20 6:37 PM, Jan Hubicka wrote: We can't because our vec does not accept non-pods and this needs to be GGC safe since it points to trees. Ah, that's new to me! Thanks, Martin

Re: [PATCH] Optimize macro: make it more predictable

2020-11-09 Thread Martin Liška
On 11/3/20 2:27 PM, Richard Biener wrote: On Fri, Oct 23, 2020 at 1:47 PM Martin Liška wrote: Hey. This is a follow-up of the discussion that happened in thread about no_stack_protector attribute: https://gcc.gnu.org/pipermail/gcc-patches/2020-May/545916.html The current optimize attribute

Re: [PATCH] Optimize macro: make it more predictable

2020-11-09 Thread Martin Liška
On 11/3/20 2:34 PM, Jakub Jelinek wrote: On Tue, Nov 03, 2020 at 02:27:52PM +0100, Richard Biener wrote: On Fri, Oct 23, 2020 at 1:47 PM Martin Liška wrote: This is a follow-up of the discussion that happened in thread about no_stack_protector attribute: https://gcc.gnu.org/pipermail/gcc

Re: [PATCH] Optimize macro: make it more predictable

2020-11-09 Thread Martin Liška
On 11/6/20 6:34 PM, Jeff Law wrote: So you XNEWVEC and store the result into "merge_decoded_options".  But you free "decoded_options".  Was that intentional? Hello. Good point here. This seems to bring a bit more predictability, but I suspect there's more to do here. Yes, both should be

Re: [PATCH v2] Add if-chain to switch conversion pass.

2020-11-09 Thread Martin Liška
On 11/6/20 1:31 PM, Richard Biener wrote: On Fri, Oct 16, 2020 at 4:04 PM Martin Liška wrote: Hello. There's another version of the patch that should be based on what I discussed with Richi and Jakub: - the first patch introduces a new option -fbit-tests that analogue to -fjump-t

[PATCH] Prefer bit-test over the jump table.

2020-11-09 Thread Martin Liška
Hello. As mentioned in the PR, we used to prefer BT over JT in switch expansion. I restore the behavior to that. Patch can bootstrap on x86_64-linux-gnu and survives regression tests. Ready to be installed? Thanks, Martin gcc/ChangeLog: PR tree-optimization/97736 * tree-switch

Re: [PATCH] analyzer: remove dead code

2020-11-09 Thread Martin Liška
PING^1 On 10/23/20 5:26 PM, Martin Liška wrote: Hey. I've noticed that when building GCC with Clang. David what do you think about it? Thanks, Martin gcc/analyzer/ChangeLog: * constraint-manager.cc (constraint_manager::merge): Remove unused code. * constraint-mana

[PATCH][pushed] clang: fix -Wmisleading-indentation warning.

2020-11-13 Thread Martin Liška
gcc/c-family/c-attribs.c:4698:5: warning: misleading indentation; statement is not part of the previous 'if' [-Wmisleading-indentation] gcc/c-family/ChangeLog: * c-attribs.c (build_attr_access_from_parms): Format properly. --- gcc/c-family/c-attribs.c | 2 +- 1 file changed, 1 insertio

[PATCH][pushed] testsuite: move expected error location

2020-11-13 Thread Martin Liška
Hello. One obvious fix of expected error location. Martin gcc/testsuite/ChangeLog: PR testsuite/97788 * g++.dg/ubsan/pr61272.C: Move expected error location. --- gcc/testsuite/g++.dg/ubsan/pr61272.C | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/gcc/te

Re: [Patch 0/X] HWASAN v4

2020-11-13 Thread Martin Liška
-----

Re: [pushed] Objective-C/C++ (parsers) : Update @property attribute parsing.

2020-11-16 Thread Martin Liška
On 11/6/20 8:54 PM, Iain Sandoe wrote: +/* Provide a dummy type for the RID enum used as an argument to + objc_prop_attr_kind_for_rid () */ +enum rid { DUMMY }; + Hello. I've noticed the hunk caused the following -Wodr warning: /home/mliska/Programming/gcc/objdir/./prev-gcc/xg++ -B/home/ml

Re: [pushed] Objective-C/C++ (parsers) : Update @property attribute parsing.

2020-11-16 Thread Martin Liška
On 11/16/20 10:00 AM, Iain Sandoe wrote: Hi Martin, Martin Liška wrote: On 11/6/20 8:54 PM, Iain Sandoe wrote: +/* Provide a dummy type for the RID enum used as an argument to +   objc_prop_attr_kind_for_rid () */ +enum rid { DUMMY }; + I've noticed the hunk caused the following

Re: [PATCH] Prefer bit-test over the jump table.

2020-11-16 Thread Martin Liška
On 11/9/20 4:56 PM, Jeff Law wrote: On 11/9/20 7:24 AM, Martin Liška wrote: Hello. As mentioned in the PR, we used to prefer BT over JT in switch expansion. I restore the behavior to that. Patch can bootstrap on x86_64-linux-gnu and survives regression tests. Ready to be installed? Thanks,

Re: [r11-4852 Regression] FAIL: g++.dg/ubsan/pr61272.C (test for excess errors) on Linux/x86_64

2020-11-16 Thread Martin Liška
On 11/10/20 1:14 AM, sunil.k.pandey via Gcc-patches wrote: On Linux/x86_64, 05b03452db6a520091aed254d3c399caed714b15 is the first bad commit commit 05b03452db6a520091aed254d3c399caed714b15 Author: Jason Merrill Date: Fri Nov 6 20:41:54 2020 -0500 c++: Improve error location for class us

Re: [PATCH] gcov: Add -fprofile-info-section support

2020-11-16 Thread Martin Liška
On 11/13/20 5:47 PM, Sebastian Huber wrote: Hello. Sorry for slow response. Register the profile information in the specified section instead of using a constructor/destructor. A pointer to the profile information generated by -fprofile-arcs or -ftest-coverage is placed in the specified secti

Re: [stage1][PATCH] Change semantics of -frecord-gcc-switches and add -frecord-gcc-switches-format.

2020-11-16 Thread Martin Liška
On 11/10/20 9:53 PM, Qing Zhao wrote: The deadline for gcc11 stage 1 is approaching.  The pinged patch is one that has been sent for review 8 months ago in order to Make into gcc11. Hello. You didn't miss the deadline as all patches sent before stage1 can be reviewed even during stage3. Note

[PATCH][pushed] Add .cache to git ignore.

2020-11-16 Thread Martin Liška
ChangeLog: * .gitignore: Add cache as clangd uses it now. --- .gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/.gitignore b/.gitignore index d9eeaf2ed7a..1a29029895a 100644 --- a/.gitignore +++ b/.gitignore @@ -38,6 +38,7 @@ TAGS.sub .clang-format .clang-tidy .clangd +.c

Re: [PATCH] gcov: Add -fprofile-info-section support

2020-11-16 Thread Martin Liška
On 11/16/20 12:02 PM, Sebastian Huber wrote: Hello Martin, On 16/11/2020 11:26, Martin Liška wrote: Sorry for slow response. Register the profile information in the specified section instead of using a constructor/destructor.  A pointer to the profile information generated by -fprofile-arcs

[PATCH] modref: add missing Param Optimization keywords

2020-11-16 Thread Martin Liška
Hello. This fixes: FAIL: compiler driver --help=common option(s): "^ +-.*[^:.]$" absent from output: " --param=modref-max-depth= Maximum depth of DFS walk used by modref escape analysis" Ready to be installed after tests? Thanks, Martin gcc/ChangeLog: * params.opt: All modref para

[PATCH][pushed] mklog: support unidiff 0.5.4

2020-11-16 Thread Martin Liška
Hi. The patch adds support of unidiff 0.5.4 for mklog.py. Tested that in a virtual environment. Martin contrib/ChangeLog: * mklog.py: Do not call read on an input stream. Fix some flake8 issues. --- contrib/mklog.py | 9 - 1 file changed, 4 insertions(+), 5 deletions(-

Re: Detect EAF flags in ipa-modref

2020-11-16 Thread Martin Liška
On 11/16/20 1:44 PM, Jan Hubicka wrote: Martin, we collected very many warnings when building with configure --with-build-config=bootstrap-lto.mk This patch fixes some of them, but there are many others, can you take a look? Hello. I guess you mean Martin Jambor, or me? Please CC :) Martin

Re: [PATCH] modref: add missing Param Optimization keywords

2020-11-16 Thread Martin Liška
On 11/16/20 1:25 PM, Jan Hubicka wrote: Hello. This fixes: FAIL: compiler driver --help=common option(s): "^ +-.*[^:.]$" absent from output: " --param=modref-max-depth= Maximum depth of DFS walk used by modref escape analysis" Ready to be installed after tests? Thanks, Martin gcc/ChangeLo

Re: [PATCH] Relax invalidation of TOP N counters in PGO.

2020-01-10 Thread Martin Liška
On 1/9/20 10:51 AM, Jan Hubicka wrote: On 1/8/20 3:05 PM, Jan Hubicka wrote: I would still preffer invalidation before streaming (which is fully deterministic) and possibly have option Do you mean __gcov_merge_topn? I suggest we do the following: - have non-deterministic and determini

[PATCH][OBVIOUS] Fix wrong parenthesis in inliner.

2020-01-10 Thread Martin Liška
Hi. This restores parenthesis to before r280040. Patch can bootstrap on x86_64-linux-gnu and survives regression tests. And fixes the issue for ppc64le-linux-gnu. Thanks, Martin gcc/ChangeLog: 2020-01-10 Martin Liska PR ipa/93217 * ipa-inline-analysis.c (offline_size): Mak

Re: [PATCH] Make warn_inline Optimization option.

2020-01-13 Thread Martin Liška
Hi. I've got a patch that restores --help=optimize to what we had for GCC 9. That means it will not print parameters (and the warn_inline warning). Patch can bootstrap on x86_64-linux-gnu and survives regression tests. Ready to be installed? Thanks, Martin >From 44870c6ac7e97a36cbd0ca102bbe73ab

Re: [PATCH] Add Optimization for various IPA parameters.

2020-01-13 Thread Martin Liška
On 1/11/20 1:20 PM, Tamar Christina wrote: It seems the parameters no longer do anything. i.e. -flto --param ipa-cp-eval-threshold=1 --param ipa-cp-unit-growth=80 doesn't have any effect anymore. Hi. You are right, the param '--param ipa-cp-unit-growth' is really unused. It's cause by Martin

Re: [PATCH] Do not set -fomit-frame-pointer if TARGET_OMIT_LEAF_FRAME_POINTER_P.

2020-01-14 Thread Martin Liška
PING^1 On 1/3/20 12:23 PM, Martin Liška wrote: Hi. I'm not fully sure about the change, but -momit-leaf-frame-pointer probably should not globally omit frame pointers? Patch can bootstrap on x86_64-linux-gnu and survives regression tests. Ready to be installed? Thanks, Martin gcc/Chan

Re: [PATCH] Do not set -fomit-frame-pointer if TARGET_OMIT_LEAF_FRAME_POINTER_P.

2020-01-14 Thread Martin Liška
On 1/14/20 12:18 PM, Jan Hubicka wrote: PING^1 On 1/3/20 12:23 PM, Martin Liška wrote: Hi. I'm not fully sure about the change, but -momit-leaf-frame-pointer probably should not globally omit frame pointers? Patch can bootstrap on x86_64-linux-gnu and survives regression tests. Ready

Re: [PATCH v7] Missed function specialization + partial devirtualization

2020-01-14 Thread Martin Liška
On 1/13/20 4:23 AM, luoxhu wrote: Thanks a lot! Rebased & updated, will commit below patch shortly when git push is ready. Hello. I'm pretty sure the patch contains failure of the following tests: FAIL: gcc.dg/tree-prof/crossmodule-indir-call-topn-1.c scan-pgo-wpa-ipa-dump profile_estimate

Re: GCC 8 backports

2020-01-15 Thread Martin Liška
Hi. There's one more backport commit I've just tested and installed. Martin >From 67c0ee2c48a5e154bf00fa8326536881a92e287c Mon Sep 17 00:00:00 2001 From: Jan Hubicka Date: Sun, 14 Apr 2019 22:56:45 +0200 Subject: [PATCH] Backport d2a0371d2641e85c5e6ca396029be32204d976df gcc/ChangeLog: 2019-04

[PATCH] Record outer non-cleanup region in TREE EH.

2020-01-15 Thread Martin Liška
Hi. The patch is about caching of outer non-CLEANUP region for a leh_state. It's a spin off the https://gcc.gnu.org/bugzilla/show_bug.cgi?id=93199#c19, now it's not using a hash_map, but a cached value in leh_state. Patch can bootstrap on x86_64-linux-gnu and survives regression tests. Ready to

Re: [PATCH v7] Missed function specialization + partial devirtualization

2020-01-15 Thread Martin Liška
Hi. I know the root cause of the failure and will send a patch soon to the mailing list. Martin

Re: [PATCH] Record outer non-cleanup region in TREE EH.

2020-01-15 Thread Martin Liška
On 1/15/20 12:08 PM, Richard Biener wrote: On Wed, Jan 15, 2020 at 10:57 AM Martin Liška wrote: Hi. The patch is about caching of outer non-CLEANUP region for a leh_state. It's a spin off the https://gcc.gnu.org/bugzilla/show_bug.cgi?id=93199#c19, now it's not using a hash_map, bu

Re: [PATCH v7] Missed function specialization + partial devirtualization

2020-01-15 Thread Martin Liška
On 1/15/20 11:49 AM, Martin Liška wrote: Hi. I know the root cause of the failure and will send a patch soon to the mailing list. Martin There's an obvious patch that I'm going to install. Note that order of function call evaluation in a function call is undefined. It's a s

Re: [PATCH] Record outer non-cleanup region in TREE EH.

2020-01-15 Thread Martin Liška
On 1/15/20 12:48 PM, Martin Liška wrote: On 1/15/20 12:08 PM, Richard Biener wrote: On Wed, Jan 15, 2020 at 10:57 AM Martin Liška wrote: Hi. The patch is about caching of outer non-CLEANUP region for a leh_state. It's a spin off the https://gcc.gnu.org/bugzilla/show_bug.cgi?id=9319

Re: [PATCH] Relax invalidation of TOP N counters in PGO.

2020-01-15 Thread Martin Liška
Hi. So I'm sending first version of the relaxation patch and a demonstration source file that can demonstrate how me merge profile for indirect functions provided on input. There are some demonstrations: 1) rm indir-call.gcda -f ; ./a.out ABCD && gcov-dump -l indir-call.gcda | grep -A2 'indirec

[PATCH] Fix spacing in a dump in value-prof.c.

2020-01-16 Thread Martin Liška
Hi. One obvious dump fix that I've just tested. I'm going to install it. Patch can bootstrap on x86_64-linux-gnu and survives regression tests. Thanks, Martin gcc/ChangeLog: 2020-01-15 Martin Liska * value-prof.c (dump_histogram_value): Fix obvious spacing issue. --- gcc/

[PATCH] Fix noreorder symbol partitioning reversion.

2020-01-16 Thread Martin Liška
Hi. The patch is fixes a regression in libgcrypt package where we incorrectly forget to stream out a definition of a no-reorder symbol. It's caused by LTO balanced map reversion, where we do not revert also best_noreorder_pos. It's pre-approved patch by Honza and I'm going to install it. Patch c

[PATCH] Make target_clones resolver fn static.

2020-01-17 Thread Martin Liška
Hi. The patch removes need to have a gnu_indirect_function global symbol. That aligns the code with what ppc64 target does. Patch can bootstrap on x86_64-linux-gnu and survives regression tests. Ready to be installed? Thanks, Martin gcc/ChangeLog: 2020-01-17 Martin Liska PR target

Re: [PATCH] Relax invalidation of TOP N counters in PGO.

2020-01-17 Thread Martin Liška
Ok, after personal discussion with Honza that I had, we should be more conservative and prune only a run-time TOP N counters before we merge them. The patch does that. Can you please Honza test me the patch of Firefox? Thanks, Martin >From 7fe1e6a59139ae00cefd1f5edf082d428952203e Mon Sep 17 00:00

Re: [PATCH] Fix noreorder symbol partitioning reversion.

2020-01-20 Thread Martin Liška
Hi. I've just tested the backport on both GCC 8 and 9 branches. I'm going to install it. Martin >From 4a856551c0f969be6525371892277c206b4181da Mon Sep 17 00:00:00 2001 From: Martin Liska Date: Mon, 20 Jan 2020 11:16:21 +0100 Subject: [PATCH] Backport f48c6014133c8989702458f9082e34ba6dd326d4 gc

Re: [PATCH] Make target_clones resolver fn static.

2020-01-21 Thread Martin Liška
On 1/20/20 3:52 PM, Richard Biener wrote: On Mon, Jan 20, 2020 at 3:46 PM H.J. Lu wrote: On Mon, Jan 20, 2020 at 6:41 AM Alexander Monakov wrote: On Mon, 20 Jan 2020, H.J. Lu wrote: Bare IFUNC's don't seem to have this restriction. Why do we want to constrain target clones this way?

[PATCH] Remove dead variable.

2020-01-21 Thread Martin Liška
Hi. The patch is obvious and approved by Segher. Martin gcc/ChangeLog: 2020-01-21 Martin Liska * config/rs6000/rs6000.c (common_mode_defined): Remove unused variable. --- gcc/config/rs6000/rs6000.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/gcc/config/rs6000/rs

[PATCH] Prune invalid filename due to makefile syntax.

2020-01-21 Thread Martin Liška
Hi. The patch strips '#' in filenames used for Makefile. Ready to be installed? Thanks, Martin gcc/ChangeLog: 2020-01-21 Martin Liska PR driver/93057 * lto-wrapper.c (prune_filename_for_make): Prune characters like '#'. --- gcc/lto-wrapper.c | 11 +++ 1 fil

Re: [PATCH] Prune invalid filename due to makefile syntax.

2020-01-21 Thread Martin Liška
On 1/21/20 4:15 PM, Andreas Schwab wrote: On Jan 21 2020, Martin Liška wrote: diff --git a/gcc/lto-wrapper.c b/gcc/lto-wrapper.c index fe8f292f877..f2504cc5b4f 100644 --- a/gcc/lto-wrapper.c +++ b/gcc/lto-wrapper.c @@ -1241,6 +1241,16 @@ jobserver_active_p (void) && is_valid

Re: [PATCH] Prune invalid filename due to makefile syntax.

2020-01-21 Thread Martin Liška
On 1/21/20 4:08 PM, Jan Hubicka wrote: I think this is not enough - you need to take into consideration all special characters used by make and bash, such as $ and others... Hm, you are right. Do you have a reasonable list which we should support? Or should we leave this known limitation? Mart

<    4   5   6   7   8   9   10   11   12   13   >