I think what you're looking for is:
if (DECL_CLONED_FUNCTION_P (clone) DECL_CLONED_FUNCTION (clone) == decl)
That's a much cleaner implementation.
Ollie
On Tue, Sep 27, 2011 at 6:18 PM, Delesley Hutchins deles...@google.com wrote:
This patch fixes a bug in the parser which cause an internal
On Thu, Sep 29, 2011 at 10:13 AM, Delesley Hutchins deles...@google.com wrote:
Unfortunately, DECL_CLONED_FUNCTION_P is not actually a predicate that allows
you to call DECL_CLONED_FUNCTION safely. Look at the definition of the
macros; despite what the comments say, DECL_CLONED_FUNCTION_P
On Mon, Oct 10, 2011 at 3:37 PM, Delesley Hutchins deles...@google.com wrote:
--- gcc/tree-threadsafe-analyze.c (revision 179771)
+++ gcc/tree-threadsafe-analyze.c (working copy)
@@ -1830,14 +1830,27 @@ remove_lock_from_lockset (tree lockable, struct po
This feels like a bug in
On Wed, Oct 12, 2011 at 9:58 AM, Delesley Hutchins deles...@google.com wrote:
I don't think that will fix this bug. The bug occurs if:
(1) The exclusive lock set has error_mark_node.
(2) The shared lock set has the actual lock.
Oh, I see. This change looks fine for google/gcc-4_6, then.
of these
drivers.
Google ref 6302116.
2012-04-17 Ollie Wild a...@google.com
* gcc/common.opt (Xclang-only): New option.
* gcc/doc/invoke.texi (Xclang-only): Document new option.
* gcc/gcc.c (display_help): Print new option.
(driver_handle_option): Support new option
code block:
int main() {
int64_t i64 = 123;
printf(My int64: %PRId64\n, i64);
}
Google ref b/6377711.
2012-04-22 Ollie Wild a...@google.com
* gcc/c-family/c-common.c:
* gcc/c-family/c-opts.c (c_common_handle_option):
* gcc/c-family/c.opt:
* gcc/doc
. If the patch doesn't look close to acceptance in a couple
days, I think it'll make sense to put the then-current version into
the google branches while people are agreeing about what to do in the
long run.
On Sun, Apr 22, 2012 at 8:14 PM, Ollie Wild a...@google.com wrote:
I'd like to get
code block:
int main() {
int64_t i64 = 123;
printf(My int64: %PRId64\n, i64);
}
Tested via bootstrap + test.
Okay for trunk?
Thanks,
Ollie
2012-04-22 Ollie Wild a...@google.com
* gcc/c-family/c-common.c:
* gcc/c-family/c-opts.c (c_common_handle_option
On Mon, Apr 23, 2012 at 7:10 AM, Gabriel Dos Reis
g...@integrable-solutions.net wrote:
On Sun, Apr 22, 2012 at 10:59 PM, Ollie Wild a...@google.com wrote:
Add new option, -Wreserved-user-defined-literal.
Just shorten it to -Wliteral-suffix.
I chose -Wreserved-user-defined-literal because
On Mon, Apr 23, 2012 at 7:53 AM, Gabriel Dos Reis
g...@integrable-solutions.net wrote:
On Mon, Apr 23, 2012 at 7:30 AM, Ollie Wild a...@google.com wrote:
Do you still want me to shorten in?
yes.
Done. Updated patch attached.
Ollie
commit 3f53671fb7fc7811277f047e7914f78e127031a6
Author
On Mon, Apr 23, 2012 at 2:39 PM, Diego Novillo dnovi...@google.com wrote:
This would be for google/main, right? It does not seem fit for
google/integration.
It needs to be in google/integration because it blocks nearly all of
our code from compiling with -std=gnu++11, and there's no way to
On Mon, Apr 23, 2012 at 3:51 PM, Diego Novillo dnovi...@google.com wrote:
Great, thanks. Patch is OK with the ChangeLog entries filled-in. Not sure
if you'd rather wait for the trunk commit to go in, though. It may be better
to put this version in google/integration and deal with the
On Mon, Apr 23, 2012 at 8:28 AM, Gabriel Dos Reis
g...@integrable-solutions.net wrote:
Thanks. Tom, I am satisfied with the diagnostic part.
I think the CPP part makes sense but it is your call.
Hi, Tom, just a quick checkin to see if you've had a chance to review this, yet.
Thanks,
Ollie
On Thu, Apr 26, 2012 at 8:35 AM, Tom Tromey tro...@redhat.com wrote:
This is ok with this change.
Thanks. Updated and submitted to trunk.
Ollie
On Wed, May 9, 2012 at 8:19 AM, Simon Baldwin sim...@google.com wrote:
Hide all uses of __float128 from Clang.
Brackets _GLIBCXX_USE_FLOAT128 with #ifndef __clang__. Clang does not
currently support the __float128 builtin, and so will fail to process
libstdc++ headers that use it.
Tested
of r180638 from google/gcc-4_6 (despite the fact that
that revision says to NOT forward-port this). Minor additional fixups have
been applied.
2012-05-15 Ollie Wild a...@google.com
* gcc/cp/decl.c (check_static_variable_definition): Only generate a
constexpr warning when
standardese.
Tested via bootstrap + test.
Okay for trunk?
Thanks,
Ollie
2012-08-02 Ollie Wild a...@google.com
Richard Smith richardsm...@google.com
* include/bits/stl_map.h (operator[](key_type)): Replace
std::make_pair with value_type.
* testsuite/23_containers
On Fri, Aug 3, 2012 at 2:39 AM, Paolo Carlini paolo.carl...@oracle.com wrote:
Ok, but, can you also double check and in case fix unordered_map too?
Looks like we have the same issue, right?
Indeed, we do. I'll send a separate patch for the unordered_map problem.
Thanks!
Paolo.
PS:
OK. Don't forget to add xfail files for google/trunk and google/gcc-4_7, too.
Ollie
On Fri, Aug 3, 2012 at 9:14 AM, Simon Baldwin sim...@google.com wrote:
Add powerpc-grtev3-linux-gnu.xfail to contrib/testsuite-management.
Tested with build followed by validate_failures.py.
2012-08-03
. ;-)
If this looks good, I'll take a stab at std::map.
Thanks,
Ollie
2012-08-03 Ollie Wild a...@google.com
* include/bits/hashtable.h (_M_emplace_bucket): New function.
* include/bits/hashtable_policy.h (operator[](key_type)): Replace
_M_insert_bucket call
?
Ollie
2012-08-08 Ollie Wild a...@google.com
* testsuite-management/powerpc-grtev3-linux-gnu.xfail: xfail
23_containers/map/element_access/2.cc from libstdc++.
* testsuite-management/x86_64-grtev3-linux-gnu.xfail: Ditto.
commit 0e6b70f28b33c1c017afb7374fc724cd61b62745
Author
As discussed, this patch XFAILs the libitm failures uncovered by
http://gcc.gnu.org/viewcvs?view=revisionrevision=190233.
OK for google/gcc-4_7?
Ollie
2012-08-09 Ollie Wild a...@google.com
* testsuite-management/x86_64-grtev3-linux-gnu.xfail: XFAIL libitm
failuires.
commit
d023097c555a6f7cb84685fd7befedb550889d2c
Author: Ollie Wild a...@google.com
Date: Mon Aug 13 15:36:24 2012 -0500
2012-08-13 Ollie Wild a...@google.com
PR c++/54197
* gcc/cp/call.c (extend_ref_init_temps_1): Handle COMPOUND_EXPR trees.
* gcc/testsuite/g++.dg/init/lifetime3.C: New test.
diff
(Adding other C++ maintainers in case someone else wants to have a stab.)
Ping?
Ollie
On Mon, Aug 13, 2012 at 4:01 PM, Ollie Wild a...@google.com wrote:
On Mon, Aug 13, 2012 at 3:50 PM, Jakub Jelinek ja...@redhat.com wrote:
The formatting doesn't match GCC coding conventions in several
On Thu, Aug 16, 2012 at 12:12 PM, Diego Novillo dnovi...@google.com wrote:
I wonder if it wouldn't make more sense to iterate until we find the
rightmost element in a compound_expr chain, but I don't think they are
neither common nor long enough to matter.
Yeah, that was my thinking. I can
On Thu, Aug 16, 2012 at 2:13 PM, Gabriel Dos Reis
g...@integrable-solutions.net wrote:
On Wed, Aug 15, 2012 at 9:52 AM, Ollie Wild a...@google.com wrote:
(Adding other C++ maintainers in case someone else wants to have a
stab.)
Ping?
I consider Jason to be the expert on this; so let
On Mon, Aug 20, 2012 at 9:58 AM, Ollie Wild a...@google.com wrote:
Jason, any idea when you can look at this?
The patch is about as short as they come, so it shouldn't take long to
review.
Ping?
On Fri, Aug 31, 2012 at 7:20 AM, Simon Baldwin sim...@google.com wrote:
Add a configure option to disable system header canonicalizations.
Libcpp may canonicalize system header paths with lrealpath() for diagnostics,
dependency output, and similar. If gcc is held in a symlink farm the
On Fri, Aug 31, 2012 at 10:01 AM, Simon Baldwin sim...@google.com wrote:
On 31 August 2012 16:31, Ollie Wild a...@google.com wrote:
The patch exactly meets the definition of google/integration only,
which is that it fixes up something that affects only Google's use of
gcc.
The criterion
On Fri, Aug 31, 2012 at 10:37 AM, Jason Merrill ja...@redhat.com wrote:
OK, sorry for the delay.
No worries. Thanks.
Submitted to trunk and gcc-4_7-branch as r190834 and r190839.
Ollie
On Fri, Aug 31, 2012 at 10:30 AM, Simon Baldwin sim...@google.com wrote:
Yes. I meant --disable-canonical-prefixes. That is a gcc configure
flag that we use to control the default setting for
-[no-]canonical-prefixes where neither flag is supplied on the gcc
command line.
version, and (c) rework the libstdc++ source files to key off a more
appropriate macro (e.g. SHARED_LIB). That's going to take some time,
though, especially since upgrading libtool is a major (and rare)
event.
Okay for google/integration and google/gcc-4_7?
Thanks,
Ollie
2012-09-05 Ollie Wild
Ok for inclusion in google/gcc-4_6.
Ollie
On Fri, Jul 22, 2011 at 5:46 PM, Jeffrey Yasskin jyass...@google.com wrote:
For the google/gcc-4_6 branch _only_. I'll fix the inconsistency in
debug locations later for trunk and google/main.
In some translation units the debug location of
Okay for google/gcc-4_6.
Ollie
On Tue, Jul 26, 2011 at 7:27 PM, Delesley Hutchins deles...@google.com wrote:
Le-Chun added the additional routine to remove pointers from a set;
that code is unique to annotalysis. I can't easily include a test
case, because the bug is difficult to trigger.
On Thu, Nov 3, 2011 at 1:20 PM, Delesley Hutchins deles...@google.com wrote:
This patch adds support for array indexing (i.e. operator []) in lock
expressions. The current version of gcc seems to emit these as
expressions involving pointer arithmetic, so we update
get_canonical_lock_expr()
On Tue, Nov 8, 2011 at 12:11 PM, Delesley Hutchins deles...@google.com wrote:
This patch fixes a bug wherein the trylock attribute would not work if
it was attached to a virtual method.
Diego, can you please review this?
Thanks,
Ollie
commit 44417f1103b0823f950f539a38a5539b8ff74330
Author: Ollie Wild a...@google.com
Date: Mon Apr 25 21:55:44 2011 -0400
When using GRTE (libc) and linking statically, instead of just -lc add:
-lc -lnss_borg -lnss_cache -lnss_dns -lnss_files -lresolv
to the link
commit 99835abc5d2a7fd3ae0950c8a16fd6d223d408c9
Author: Ollie Wild a...@google.com
Date: Fri Apr 29 13:03:57 2011 -0400
Remove unqualified lookups into dependent template base classes from
STL headers. These break clang.
See http://clang.llvm.org/compatibility.html
Submitted to google/main.
Adding libstd...@gcc.gnu.org for trunk approval.
Ollie
On Mon, May 2, 2011 at 9:34 AM, Ollie Wild a...@google.com wrote:
commit 99835abc5d2a7fd3ae0950c8a16fd6d223d408c9
Author: Ollie Wild a...@google.com
Date: Fri Apr 29 13:03:57 2011 -0400
Remove
On Mon, May 2, 2011 at 2:53 PM, Diego Novillo dnovi...@google.com wrote:
Since google/gcc-4_6 follows the 4.6 branch, changes in minor
revisions cause unnecessary churn in directory names.
Fixed with this. OK for google/gcc-4_6?
Yes, okay for google/gcc-4_6.
Thanks,
Ollie
Approved for google/integration (since Diego is on vacation).
Paul, please also merge this change only to google/main and google/gcc-4_6.
Thanks,
Ollie
On Thu, May 19, 2011 at 1:24 PM, Paul Pluzhnikov ppluzhni...@google.com wrote:
This patch is for google/integration branch.
Sorry about not
Ok, for google/integration. Please integrate to google/main and
google/gcc-4_6 as well.
Ollie
On Fri, May 20, 2011 at 10:05 AM, Simon Baldwin sim...@google.com wrote:
Make libstdc++'s abi_check more robust against readelf output format.
libstdc++-abi/abi_check in the libstdc++-v3 testsuite
commit cbd38ef0c58ac4a365913d2bb2a2e0c062516dbb
Author: Ollie Wild a...@google.com
Date: Sat Feb 11 22:05:52 2012 -0600
Update known failures to reflect current reality.
diff --git a/contrib/testsuite-management/x86_64-unknown-linux-gnu.xfail
b/contrib/testsuite-management/x86_64-unknown
Hey, Jing, you broke the google/gcc-4_6 branch by checking the new
header file into the wrong directory.
Fixed via r184386.
Ollie
On Fri, Feb 17, 2012 at 10:25 PM, Jing Yu jin...@google.com wrote:
OK. Thanks for porting the patch.
I will commit the patch into google/gcc-4_6_2-mobile for you.
The latest Crosstool builds reveal one new test failure (and fix several
others). This patch adds the missing failure to x86_64-unknown-linux-gnu.xfail.
2012-02-21 Ollie Wild a...@google.com
* testsuite-management/x86_64-unknown-linux-gnu.xfail: Add
gcc.c-torture/execute/vshuf
commit d00e10980dde6c19ec3d8035a80769d54288
Author: Ollie Wild a...@google.com
Date: Sun Feb 26 00:30:42 2012 -0600
Update BASE-VER to 4.7.x (for consistency across minor releases). This is
what we do with the existing google/gcc-4_6 branch.
gcc/ChangeLog.google-4_7
this to the google/integration branch and integrating to
google/main and google/gcc-4_7.
Ollie
2012-03-01 Ollie Wild a...@google.com
* contrib/testsuite-management/x86_64-grtev3-linux-gnu.xfail:
* gcc/config.gcc:
* gcc/config/i386/linux.h:
* gcc/config/i386/linux64.h
--git a/contrib/ChangeLog.google-main b/contrib/ChangeLog.google-main
index f313f6f..937da9c 100644
--- a/contrib/ChangeLog.google-main
+++ b/contrib/ChangeLog.google-main
@@ -1,3 +1,8 @@
+2012-03-05 Ollie Wild a...@google.com
+
+ * testsuite-management/x86_64-grtev3-linux-gnu.xfail: Updated
without -fPIC anyway.
See http://gcc.gnu.org/ml/gcc/2012-03/msg00104.html for details.
Google ref 5836136.
2012-03-08 Ollie Wild a...@google.com
* libgcc/Makefile.in (vis_hide): Move default initialization before
inclusion of $(tmake_file).
* libgcc/config.host (*-grtev3
On Mon, Mar 12, 2012 at 8:03 PM, Easwaran Raman era...@google.com wrote:
OK for google/main and google/4_6 branches?
You will need to check this into google/gcc-4_7 as well.
Ollie
On Thu, Jun 30, 2011 at 12:09 PM, Diego Novillo dnovi...@google.com wrote:
On 11-06-30 13:01 , Delesley Hutchins wrote:
Okay for branches/annotalysis and google/main?
OK with some minor formatting nits below.
Please also cherry-pick this into the google/gcc_4-6 branch. I've
sent you
OK.
Ollie
On Mon, Nov 5, 2012 at 12:40 PM, Paul Pluzhnikov ppluzhni...@google.com wrote:
Greetings,
This patch is for google/gcc-4_7 branch.
Thanks,
2012-11-05 Paul Pluzhnikov ppluzhni...@google.com
* contrib/testsuite-management/powerpc-grtev3-linux-gnu.xfail:
headers.
Do not attempt to use it directly. Instead, include map or=
set=.
Submitting as trivial, and will backport to google/gcc-4_7.
Google ref b/7621728.
Ollie
2012-11-27 Ollie Wild a...@google.com
* include/bits/stl_tree.h (@headername): Fix incorrect Doxygen macro
: Ollie Wild a...@google.com
Date: Wed Sep 19 14:52:53 2012 -0500
Merge r191125 and r191191 from gcc-4_7-branch.
Google ref b/7173106.
* libsupc++/guard.cc (__cxa_guard_acquire): Exit the loop earlier if
we detect that another thread has had success. Don't
Tom, this is mainly a libcpp change. Would you mind taking a look?
Thanks,
Ollie
On Mon, Oct 1, 2012 at 9:56 AM, Simon Baldwin sim...@google.com wrote:
Ping, again.
On 21 September 2012 12:45, Simon Baldwin sim...@google.com wrote:
Ping.
On Wed, May 1, 2013 at 9:04 AM, Simon Baldwin sim...@google.com wrote:
Fix libatomic testsuite for when GCC_UNDER_TEST is not plain xgcc.
Libatomic tests fail if GCC_UNDER_TEST is set to something other than a plain
xgcc invocation (for example, when $CC requires a special -sysroot). Fix
56 matches
Mail list logo
