[PATCH 8/8] DWARF: describe properly Ada packed arrays

2015-07-16 Thread Pierre-Marie de Rodat
of the original packed type, if any. Fix TYPE_DECL peeling around the name of the input type. -- Pierre-Marie de Rodat From 2be4df85e18e86c999d7f493366804bb57052abf Mon Sep 17 00:00:00 2001 From: derodat derodat@f8352e7e-cb20-0410-8ce7-b5d9e71c585c Date: Thu, 18 Dec 2014 12:45:52 +

[PATCH 7/8] DWARF: add a language hook for scalar biased types

2015-07-16 Thread Pierre-Marie de Rodat
the bias to subrange_type_die. -- Pierre-Marie de Rodat From 702af856454dd74dc23979e488d311ea008981ee Mon Sep 17 00:00:00 2001 From: Pierre-Marie de Rodat dero...@adacore.com Date: Thu, 8 Jan 2015 11:07:06 +0100 Subject: [PATCH 7/8] DWARF: add a language hook for scalar biased types Front

[PATCHES] Enhance standard DWARF for Ada

2015-07-16 Thread Pierre-Marie de Rodat
in advance for the review! [1] https://github.com/eliben/pyelftools/ -- Pierre-Marie de Rodat

[PATCH 1/8] Add a flag to control the balance between GNAT encodings, and std. DWARF

2015-07-16 Thread Pierre-Marie de Rodat
variable. (gnat_post_options): Initialize this global from options. -- Pierre-Marie de Rodat From 77212283fa0ddbbf6aef4a6f16aa0e8286b811f3 Mon Sep 17 00:00:00 2001 From: Pierre-Marie de Rodat dero...@adacore.com Date: Wed, 17 Sep 2014 14:54:50 +0200 Subject: [PATCH 1/8] Add a flag to control

Re: [PATCH 1/8] Add a flag to control the balance between GNAT encodings, and std. DWARF

2015-07-16 Thread Pierre-Marie de Rodat
On 07/16/2015 12:12 PM, Richard Biener wrote: On Thu, Jul 16, 2015 at 10:52 AM, Andreas Schwab sch...@suse.de wrote: Pierre-Marie de Rodat dero...@adacore.com writes: +fgnat-encodings= IMHO the option name should include dwarf. And start with -g Thank you for your answers! Changing

[PATCH 5/8] DWARF: describe Ada dynamic arrays as proper arrays

2015-07-16 Thread Pierre-Marie de Rodat
pointers and generate the corresponding array type descriptions. -- Pierre-Marie de Rodat From 27e94b46e4873b175682848e87ccc60bec9f98b2 Mon Sep 17 00:00:00 2001 From: derodat derodat@f8352e7e-cb20-0410-8ce7-b5d9e71c585c Date: Fri, 3 Oct 2014 09:57:06 + Subject: [PATCH 5/8] DWARF: describe

[PATCH 2/8] DWARF: handle variable-length records and variant parts

2015-07-16 Thread Pierre-Marie de Rodat
. (prune_unused_types_walk): Don't mark DWARF procedures by default. Mark variant parts since nothing is supposed to reference them. gcc/testsuite/ChangeLog: * gnat.dg/specs/debug1.ads: Update the expected number of DW_AT_artificial attribute in compiler output. -- Pierre-Marie de Rodat

[PATCH 6/8] create a macro for max dimensions for array descr. lang. hook

2015-07-16 Thread Pierre-Marie de Rodat
. * dwarf2out.c (gen_type_die_with_usage): Check that the array descr. language hook does not return an array with more dimensions that it should. -- Pierre-Marie de Rodat From 5221a4fadfa84f31cc97e0eba26f8640c9abe70d Mon Sep 17 00:00:00 2001 From: Pierre-Marie de Rodat dero...@adacore.com

[PATCH 3/8] DWARF: add a language hook to override types in debugging information

2015-07-16 Thread Pierre-Marie de Rodat
): Invoke the get_debug_type language hook, process its result instead, if any. (gen_descr_array_type_die): Add array-wide stride processing. -- Pierre-Marie de Rodat From d50a4b3d02753ccd89e05d08d9f7a9516afdf8de Mon Sep 17 00:00:00 2001 From: Pierre-Marie de Rodat dero...@adacore.com Date

Re: [PATCH 2/8] DWARF: handle variable-length records and variant parts

2015-07-16 Thread Pierre-Marie de Rodat
in compiler output. -- Pierre-Marie de Rodat From a7ba9b22e494c0d7db0d141008f87c33fd7864a3 Mon Sep 17 00:00:00 2001 From: Pierre-Marie de Rodat dero...@adacore.com Date: Thu, 3 Jul 2014 14:16:09 +0200 Subject: [PATCH 2/8] DWARF: handle variable-length records and variant parts Enhance the DWARF back-end

[PATCH] PR rtl-optimization/66790: uninitialized registers handling in REE

2015-07-18 Thread Pierre-Marie de Rodat
to add_removable_extension. (find_and_remove_re): Call df_mir_add_problem. -- Pierre-Marie de Rodat From 2b0fe78644c3c3b16555b69d0b787dbad4a434a4 Mon Sep 17 00:00:00 2001 From: Pierre-Marie de Rodat dero...@adacore.com Date: Sat, 18 Jul 2015 13:10:45 +0200 Subject: [PATCH] REE: fix

[PATCH] PR debug/53927: fix value for DW_AT_static_link

2015-07-20 Thread Pierre-Marie de Rodat
(finalize_nesting_tree_1): Append a field to hold the frame base address. * dwarf2out.c (gen_subprogram_die): Generate for DW_AT_static_link a location description that computes the value of this field. -- Pierre-Marie de Rodat

[PATCH] Track indirect calls for call site information in debug info.

2015-07-20 Thread Pierre-Marie de Rodat
-Marie de Rodat From 1fee786f51baca25f1363cd82f207cd67f48e69f Mon Sep 17 00:00:00 2001 From: Pierre-Marie de Rodat dero...@adacore.com Date: Thu, 13 Jun 2013 11:13:08 +0200 Subject: [PATCH] Track indirect calls for call site information in debug info. gcc/ChangeLog: * passes.def: Add a new pass

Re: [PATCH v2] PR rtl-optimization/66790: uninitialized registers handling in REE

2015-10-19 Thread Pierre-Marie de Rodat
problems.c (df_live_bb_local_compute): Clear GEN bits for DF_REF_MUST_CLOBBER references. This one is probably ok too; I still want to experiment with it a little. Sure, I only committed the attached updated first patch. -- Pierre-Marie de Rodat >From 0275c4a20a4b9daaefbbddd5306e9214e7d5d673 Mon Sep 17

Re: [PATCH v2] PR rtl-optimization/66790: uninitialized registers handling in REE

2015-10-20 Thread Pierre-Marie de Rodat
it with questions in comment #27 but there was no followup on this point afterwards and Bernd approved the change so I thought it was fine: what should I do? Thanks in advance, -- Pierre-Marie de Rodat

Re: GCC 6 Status Report (2015-10-16)

2015-10-20 Thread Pierre-Marie de Rodat
side (affecting both dwarf2out and var-tracking), Richard told me in August that he’s not the correct person to ping for dwarf2out patches, so I did ping you for the var-tracking part and Jason for the dwarf2out part afterwards. -- Pierre-Marie de Rodat

Re: GCC 6 Status Report (2015-10-16)

2015-10-20 Thread Pierre-Marie de Rodat
://gcc.gnu.org/ml/gcc-patches/2015-08/msg01854.html). The corresponding support in GDB is in the development branch. If there is anything I should do to ease the review process, please let me know. :-) Thank you in advance! -- Pierre-Marie de Rodat

[PATCH v2] PR rtl-optimization/66790: uninitialized registers handling in REE

2015-10-13 Thread Pierre-Marie de Rodat
ompute): Clear GEN bits for DF_REF_MUST_CLOBBER references. -- Pierre-Marie de Rodat >From d7bf6e8c194f66e6b7e1823ad3d118115e4406bc Mon Sep 17 00:00:00 2001 From: Pierre-Marie de Rodat <dero...@adacore.com> Date: Sat, 18 Jul 2015 13:10:45 +0200 Subject: [PATCH 1/2] REE: fix uninitia

[PATCH, PING*3] PR rtl-optimization/66790: uninitialized registers handling in REE

2015-08-31 Thread Pierre-Marie de Rodat
On 07/19/2015 12:14 AM, Pierre-Marie de Rodat wrote: This patch is an attempt to fix PR rtl-optimization/66790: please see <https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66790> for the context. This adds a new dataflow problem (MIR for Must-Initialized Registers) and use it in the RE

[PATCH, PING*3] DWARF: materialize subprogram renamings in Ada as imported declarations

2015-08-31 Thread Pierre-Marie de Rodat
On 07/25/2015 09:44 PM, Pierre-Marie de Rodat wrote: This change makes GCC materialize subprogram renamings in Ada as imported declarations (DW_TAG_imported_declarations). For instance, procedure Foo renames Bar; will output: DW_TAG_imported_declaration: DW_AT_name: foo

[PATCH, PING*4] Track indirect calls for call site information in debug info.

2015-08-31 Thread Pierre-Marie de Rodat
On 07/20/2015 02:45 PM, Pierre-Marie de Rodat wrote: On PowerPC targets with -mlongcall, most subprogram calls are turned into indirect calls: the call target is read from a register even though it is compile-time known. This makes it difficult for machine code static analysis engines to recover

[PATCH, PING*4] PR debug/53927: fix value for DW_AT_static_link

2015-08-31 Thread Pierre-Marie de Rodat
On 07/20/2015 09:39 AM, Pierre-Marie de Rodat wrote: This patch fixes the static link description in DWARF to comply with the specification. In order to do so, it appends a field to all FRAME objects to hold the frame base address (DW_AT_frame_base) so that the nested subrograms can directly

[PATCHES, PING*4] Enhance standard DWARF for Ada

2015-08-31 Thread Pierre-Marie de Rodat
On 07/16/2015 10:34 AM, Pierre-Marie de Rodat wrote: This patch series aims at enhancing GCC to emit standard DWARF in place of the current GNAT encodings (non-standard DWARF) for a set of "basic" types: dynamic arrays, variable-length records, variant parts, etc. Ping for the pa

Re: [PATCH, PING*4] Track indirect calls for call site information in debug info.

2015-12-02 Thread Pierre-Marie de Rodat
On 12/02/2015 02:57 PM, Jakub Jelinek wrote: Ok, thanks. Great, thank you! I’ve pushed the change. -- Pierre-Marie de Rodat

[PATCHES, PING] Enhance standard DWARF for Ada

2015-12-03 Thread Pierre-Marie de Rodat
On 11/26/2015 01:34 PM, Pierre-Marie de Rodat wrote: Done! (I repalced the dwarf_proc_decl_table hash table with a dwarf_proc_stack_usage_map hash_map) Here's an update for the only affected patch. Regtested again on x86_64-linux. Ping for the patches submitted in <https://gcc.gnu.org/ml/

Re: [PATCH, PING*4] Track indirect calls for call site information in debug info.

2015-12-02 Thread Pierre-Marie de Rodat
be! Here’s the patch implemeting this, bootstrapped and regtested without regression on x86_64-linux. -- Pierre-Marie de Rodat >From 41ed1a37921b4f9c5f762334265e72fd8e4b4a25 Mon Sep 17 00:00:00 2001 From: Pierre-Marie de Rodat <dero...@adacore.com> Date: Thu, 13 Jun 2013 11:13:08 +020

Re: [PATCHES, PING*2] Enhance standard DWARF for Ada

2015-12-09 Thread Pierre-Marie de Rodat
Ping for the patches submitted in <https://gcc.gnu.org/ml/gcc-patches/2015-11/msg02723.html> and for the 2/8 update submitted in <https://gcc.gnu.org/ml/gcc-patches/2015-11/msg03224.html>. Thank you in advance! -- Pierre-Marie de Rodat

Re: [PATCHES, PING*5] Enhance standard DWARF for Ada

2015-12-17 Thread Pierre-Marie de Rodat
On 12/16/2015 10:30 PM, Jason Merrill wrote: OK with those changes. All changes done, and all patches pushed. Thank you very much!! -- Pierre-Marie de Rodat

Re: [PATCHES, PING*5] Enhance standard DWARF for Ada

2015-12-16 Thread Pierre-Marie de Rodat
On 12/11/2015 09:25 PM, Jason Merrill wrote: Hmm, can we generate the DWARF procedures during finalize_size_functions to avoid the need for preserve_body? Good idea, thank you! Here’s the updated patch (bootstrapped and regtested on x86_64-linux, as usual). -- Pierre-Marie de Rodat >F

Re: [PATCHES, PING*5] Enhance standard DWARF for Ada

2016-01-05 Thread Pierre-Marie de Rodat
On 01/03/2016 12:45 AM, Eric Botcazou wrote: On powerpc64: FAIL: gnat.dg/specs/debug1.ads scan-assembler-times DW_AT_artificial 18 $ grep -c DW_AT_artificial debug1.s 17 Test removed. Thank you both! -- Pierre-Marie de Rodat

Re: [PATCH 2/2] Ada: add XVE/XVU parallel types to lexical scopes

2016-01-06 Thread Pierre-Marie de Rodat
Committed. Thank you! -- Pierre-Marie de Rodat

[PATCH 1/2] DWARF: process all TYPE_DECL nodes when iterating on scopes

2016-01-05 Thread Pierre-Marie de Rodat
Hello, In Ada, it is possible to have nested subprograms in the following configuration: procedure Parent is type T; [...] procedure Child (Value : T) is begin [...] end Child; begin [...] end Parent; If we generate debugging

[PATCH 2/2] Ada: add XVE/XVU parallel types to lexical scopes

2016-01-05 Thread Pierre-Marie de Rodat
Hello, This change adds TYPE_DECL nodes for XVE/XVU parallel types to lexical scopes so that these types are properly scoped in the debug information. Ok to commit? Thank you in advance! gcc/ada/ChangeLog: * gcc-interface/utils.c (rest_of_record_type_compilation): Add XVE/XVU

Re: [PATCHES, PING*5] Enhance standard DWARF for Ada

2015-12-18 Thread Pierre-Marie de Rodat
, thank you for the heads up. -- Pierre-Marie de Rodat

Re: [PATCHES, PING*5] Enhance standard DWARF for Ada

2015-12-21 Thread Pierre-Marie de Rodat
On 12/18/2015 09:23 PM, Pierre-Marie de Rodat wrote: On 12/18/2015 06:56 PM, Jason Merrill wrote: These broke a lot of tests in the GDB C++ testsuite. Specifically, the commit DWARF: handle variable-length records and variant parts Arg, sad to hear that! I did testing at some point

Re: [PATCHES, PING*5] Enhance standard DWARF for Ada

2015-12-21 Thread Pierre-Marie de Rodat
On 12/21/2015 04:39 PM, Jason Merrill wrote: OK, thanks. Committed. Thank you again! -- Pierre-Marie de Rodat

Re: [PATCH, PING*4] PR debug/53927: fix value for DW_AT_static_link

2015-11-24 Thread Pierre-Marie de Rodat
On 08/31/2015 09:28 AM, Pierre-Marie de Rodat wrote: Ping for the patch submitted in <https://gcc.gnu.org/ml/gcc-patches/2015-07/msg01629.html>. As Jason noticed in another thread, I forgot to attach the patch here (although it’s filed in the bug tracker). Here it is! Rebased against

Re: [PATCH, PING*4] Track indirect calls for call site information in debug info.

2015-11-24 Thread Pierre-Marie de Rodat
+regtested the patch: the updated version is attached. Thanks in advance for your review! -- Pierre-Marie de Rodat >From 2a02ebc79b51693a341355a2301dc0f733591930 Mon Sep 17 00:00:00 2001 From: Pierre-Marie de Rodat <dero...@adacore.com> Date: Thu, 13 Jun 2013 11:13:08 +0200 Subject: [PAT

Re: [PATCH, PING*3] DWARF: materialize subprogram renamings in Ada as imported declarations

2015-11-24 Thread Pierre-Marie de Rodat
! -- Pierre-Marie de Rodat

Re: [PATCH, PING*4] Track indirect calls for call site information in debug info.

2015-11-30 Thread Pierre-Marie de Rodat
that I’m working on this matter: I hope I’ll be able to yield a patch implementing your proposal before the end of this week. -- Pierre-Marie de Rodat

Re: [PATCHES, PING*5] Enhance standard DWARF for Ada

2015-11-26 Thread Pierre-Marie de Rodat
-linux. -- Pierre-Marie de Rodat >From 46826e401566c26ad77e2bb6b782cc6034b96fd3 Mon Sep 17 00:00:00 2001 From: Pierre-Marie de Rodat <dero...@adacore.com> Date: Thu, 3 Jul 2014 14:16:09 +0200 Subject: [PATCH 2/8] DWARF: handle variable-length records and variant parts Enhance the DWARF

Re: [PATCH, PING*4] PR debug/53927: fix value for DW_AT_static_link

2015-11-26 Thread Pierre-Marie de Rodat
L_NAME (fb_decl) = get_identifier ("FRAME_BASE.PARENT"); TYPE_FIELDS (root->frame_type) = chainon (TYPE_FIELDS (root->frame_type), fb_decl); Much better, thanks. :-) Here’s the updated patch. Regtested again on x86_64-linux. -- Pierre-Marie de Rodat >From 3f067709d86fea1

Re: [PATCH, PING*4] PR debug/53927: fix value for DW_AT_static_link

2015-11-26 Thread Pierre-Marie de Rodat
again for reviewing! -- Pierre-Marie de Rodat

Re: [PATCHES, PING*5] Enhance standard DWARF for Ada

2015-11-24 Thread Pierre-Marie de Rodat
On 11/23/2015 10:08 PM, Jason Merrill wrote: On 11/23/2015 08:53 AM, Pierre-Marie de Rodat wrote: Do you think the other patches could make it before the branch? (if they could, I will rebase+retest them as quick as possible). Probably, yes. I can't find the DW_AT_static_link patch, though

[PATCH, PING] DWARF: process all TYPE_DECL nodes when iterating on scopes

2016-01-12 Thread Pierre-Marie de Rodat
Hello, Ping for the patch submitted in <https://gcc.gnu.org/ml/gcc-patches/2016-01/msg00160.html>. Thanks! -- Pierre-Marie de Rodat

[PATCH] DWARF: add abstract origin links on lexical blocks DIEs

2016-01-12 Thread Pierre-Marie de Rodat
Hello, Although the following patch does not fix a regression, I believe it fixes a bug visible from a debugger, so I think it’s a valid candidate at this stage. This change tracks from which abstract lexical block concrete ones come from in DWARF so that debuggers can inherit the former

Re: [PATCH] DWARF: add abstract origin links on lexical blocks DIEs

2016-01-15 Thread Pierre-Marie de Rodat
Anyway, the patch looks ok to me but please give others a chance to chime in. Sure. Thank you for reviewing! -- Pierre-Marie de Rodat /* { dg-do run } */ /* { dg-options "-O2 -g -std=gnu99" } */ extern void *create (const char *); extern void destroy (void *); extern void do_nothing (c

Re: [PATCH] DWARF: add abstract origin links on lexical blocks DIEs

2016-01-18 Thread Pierre-Marie de Rodat
will not be too fragile… -- Pierre-Marie de Rodat

Re: [PATCH 1/2] DWARF: process all TYPE_DECL nodes when iterating on scopes

2016-01-19 Thread Pierre-Marie de Rodat
_type just returns the existing DW_TAG_record_type (still in the global scope). So assuming your proposal of the change is correct, should we then use TYPE_CONTEXT in order to (potentially) relocate TREE_TYPE (decl) in add_type_attribute? -- Pierre-Marie de Rodat -- The aim of this test is to ch

Re: [PATCH 10/9] ENABLE_CHECKING refactoring: remove remaining occurrences

2016-02-24 Thread Pierre-Marie de Rodat
t. I’m a little bit desynchronized with the development pace these days: would this be for stage 4 or GCC 7? -- Pierre-Marie de Rodat

Re: [PATCH] Fix DW_OP_GNU_implicit_pointer referring to DW_TAG_dwarf_procedure (PR debug/69947)

2016-02-26 Thread Pierre-Marie de Rodat
! -- Pierre-Marie de Rodat

Re: [PATCH 10/9] ENABLE_CHECKING refactoring: remove remaining occurrences

2016-02-25 Thread Pierre-Marie de Rodat
On 02/25/2016 11:15 AM, Martin Liška wrote: Sure. Just working on that. Great, thank you! -- Pierre-Marie de Rodat

Re: [PATCH 10/9] ENABLE_CHECKING refactoring: remove remaining occurrences

2016-02-25 Thread Pierre-Marie de Rodat
do the substitution ENABLE_CHECKING → CHECKING_P for these dwarf2out.* occurences as part of it? -- Pierre-Marie de Rodat

Re: [PATCHES, PING*5] Enhance standard DWARF for Ada

2016-02-25 Thread Pierre-Marie de Rodat
thread (https://gcc.gnu.org/ml/gcc-patches/2016-01/msg01078.html), I always feel uncomfortable writing brittle dg-scan testcases, hence the current lack of testcases for those DWARF changes. -- Pierre-Marie de Rodat

Re: [PATCHES, PING*5] Enhance standard DWARF for Ada

2016-02-25 Thread Pierre-Marie de Rodat
that prune_unused_types_walk_loc_descr does not know about this kind of operation. I think the attached patch is a more general fix for that. What do you think? (bootstrapped and regtested on x86_64-linux) -- Pierre-Marie de Rodat >From 671199e8a7da326e54e081b5c368f93428455e98 Mon Sep 17 00:00:00 2001 F

Re: [PATCHES, PING*5] Enhance standard DWARF for Ada

2016-02-25 Thread Pierre-Marie de Rodat
-S -g -fgnat-encodings=minimal -dA foo.adb && grep DW_OP_call4 foo.s foo.s:313: .byte 0x99# DW_OP_call4 -- Pierre-Marie de Rodat procedure Foo is type Record_Type (N : Natural) is record S1 : String (1 .. N); S2 : String (1 .. N); end record; procedure Pr

Re: [PATCH] DWARF: add abstract origin links on lexical blocks DIEs

2016-01-20 Thread Pierre-Marie de Rodat
On 01/18/2016 10:47 AM, Pierre-Marie de Rodat wrote: Thank you for your inputs! I’m going to try that, then. I hope this test will not be too fragile… Here it is! Re-bootstrapped and regtested successfuly on x86_64-linux. I’ve checked that the testcase fails on the mainline. -- Pierre-Marie

[PATCH] DWARF: turn dw_loc_descr_node field into hash map for frame offset check

2016-04-27 Thread Pierre-Marie de Rodat
Hello, As discussed on , this change removes a field in the dw_loc_descr_node structure so we can get rid of the CHECKING_P macro usage. This field was used to perform consistency checks for frame offset in DWARF procedures. As a

Re: [PATCH] DWARF: turn dw_loc_descr_node field into hash map for frame offset check

2016-04-27 Thread Pierre-Marie de Rodat
On 04/27/2016 01:31 PM, Richard Biener wrote: Ok. Thanks, Richard. Thank you for the very quick feedback! I just commited the change. -- Pierre-Marie de Rodat

[PING][PATCH] DWARF: add abstract origin links on lexical blocks DIEs

2016-04-26 Thread Pierre-Marie de Rodat
Ping for the patch submitted at <https://gcc.gnu.org/ml/gcc-patches/2016-01/msg01495.html>. It applies just fine on the current trunk and still bootstrapps and regtests successfuly on x86_64-linux. Thank you in advance, -- Pierre-Marie de Rodat

[PATCH] Fix a typo in dwarf2out.c:resolve_args_picking_1

2016-05-03 Thread Pierre-Marie de Rodat
Hello, Under specific circumstances for Ada programs, such as in the testcase this change adds, the DWARF back-end currently crashes because of inconsistent internal state. This is due to a typo: a local variable is called frame_offset_ but resolve_args_picking_1 wrongly modifies emit-rtl.h's

Re: [PATCH] Fix a typo in dwarf2out.c:resolve_args_picking_1

2016-05-03 Thread Pierre-Marie de Rodat
On 05/03/2016 05:41 PM, Richard Biener wrote: This change fixes this typo. Bootstrapped and regtested on x86_64-linux successfuly. Ok to commit? Thank you in advance! OK also for branches. Comitted to trunk and gcc-6-branch. Thank you! -- Pierre-Marie de Rodat

[PING*2][PATCH] DWARF: add abstract origin links on lexical blocks DIEs

2016-05-04 Thread Pierre-Marie de Rodat
Ping for the patch submitted at <https://gcc.gnu.org/ml/gcc-patches/2016-01/msg01495.html>. It applies just fine on the current trunk and still bootstrapps and regtests successfuly on x86_64-linux. Thank you in advance, -- Pierre-Marie de Rodat

[PATCH] DWARF: fix stack usage assessment for DW_OP_neg

2016-05-10 Thread Pierre-Marie de Rodat
Hello, When the DWARF back-end generates DW_OP_neg operations in DWARF procedures, we get an ICE because of inconsistent stack usage computation for the embedding expression. This is because resolve_args_picking_1 thinks DW_OP_neg is a binary operation (pops 2 stack slots, pushes 1) whereas it

Re: [PATCH] DWARF: fix stack usage assessment for DW_OP_neg

2016-05-10 Thread Pierre-Marie de Rodat
On 05/10/2016 05:20 PM, Jakub Jelinek wrote: gcc/ * dwarf2out.c (resolve_args_picking_1): Consider DW_OP_neg as an unary operation, not a binary one. Ok. This is committed. Thank you Jakub for the quick feedback! -- Pierre-Marie de Rodat

Re: [PING*2][PATCH] DWARF: add abstract origin links on lexical blocks DIEs

2016-05-10 Thread Pierre-Marie de Rodat
On 05/09/2016 01:01 PM, Richard Biener wrote: Ok and sorry for the delay. No problem. :-) Thanks, this is committed! -- Pierre-Marie de Rodat

Re: [PATCH] DWARF: space-optimize loc. descr. for integer literals on 32-bit targets

2016-08-18 Thread Pierre-Marie de Rodat
On 08/18/2016 01:29 PM, Trevor Saunders wrote: HOST_BITS_PER_WIDE_INT is now always 64, so you don't need that check. Good point, thank you! I’ll adapt the patch. -- Pierre-Marie de Rodat

Re: [PATCH] DWARF: do not emit DW_TAG_variable to materialize DWARF procedures

2016-08-18 Thread Pierre-Marie de Rodat
On 08/18/2016 02:39 PM, Richard Biener wrote: Ok. Thank you for the quick review! This is commited, now (revision 239575). -- Pierre-Marie de Rodat

Re: [PATCH] Generalize overriding mechanism for debug info output options defaults

2016-08-18 Thread Pierre-Marie de Rodat
!). -- Pierre-Marie de Rodat

[PATCH, PING] DWARF: process all TYPE_DECL nodes when iterating on scopes

2016-09-06 Thread Pierre-Marie de Rodat
Hello, On 08/29/2016 11:03 AM, Pierre-Marie de Rodat wrote: Here is another attempt to solve the original issue. This time, with a proper testcase. ;-) Rebased against trunk, boostrapped and regtested on x86_64-linux. Ping for the patch submitted at <https://gcc.gnu.org/ml/gcc-patches/2

[PATCH, PING] DWARF: space-optimize loc. descr. for integer literals on 32-bit targets

2016-08-31 Thread Pierre-Marie de Rodat
Hello, Ping for the patch submitted at <https://gcc.gnu.org/ml/gcc-patches/2016-08/msg01314.html>. Also, here’s the update that Trevor suggested. Thanks! -- Pierre-Marie de Rodat >From da6753ad98127778e8923db63ce51b52a853ed17 Mon Sep 17 00:00:00 2001 From: Pierre-Marie de Ro

Re: [PATCH, PING] DWARF: process all TYPE_DECL nodes when iterating on scopes

2016-09-08 Thread Pierre-Marie de Rodat
investigate this way next week. Thanks again! :-) -- Pierre-Marie de Rodat

Re: [PATCH] DWARF: remove pessimistic DWARF version checks for imported entities

2016-10-05 Thread Pierre-Marie de Rodat
On 10/04/2016 09:50 PM, Jason Merrill wrote: OK. On 10/05/2016 06:53 AM, Dominique d'Humières wrote: The new patch works on darwin without new regression. Thank you both for your help! This is now comitted. -- Pierre-Marie de Rodat

Re: [PATCH] DWARF: remove pessimistic DWARF version checks for imported entities

2016-10-04 Thread Pierre-Marie de Rodat
ted on x86_64-linux. I also tested on x86_64-apple-darwin14.5.0 that the above errors are gone. -- Pierre-Marie de Rodat >From fbcac99dc769c2a2280bc816e67506b67124660c Mon Sep 17 00:00:00 2001 From: Pierre-Marie de Rodat Date: Thu, 18 Aug 2016 11:33:23 +0200 Subject: [PATCH] DWARF: move p

[PATCH] DWARF: space-optimize loc. descr. for integer literals on 32-bit targets

2016-08-18 Thread Pierre-Marie de Rodat
Hello, This enhances location description generation so that the generated opcodes for integer literals are as space-efficient when HOST_WIDE_INT is 64-bits large than when it's 32-bits large. In particular, this reduces the size of the opcodes generated to produce big unsigned literals using

[PATCH] DWARF: remove pessimistic DWARF version checks for imported entities

2016-08-18 Thread Pierre-Marie de Rodat
Hello, A check in dwarf2out_imported_module_or_decl prevents valid strict DWARF2 constructs such as DW_TAG_imported_declaration from being emitted in dwarf2out_imported_module_or_decl_1. The latter already protects the emission of newer DWARF tags with appropriate checks, so the one in the

[PATCH] DWARF: do not emit DW_TAG_variable to materialize DWARF procedures

2016-08-18 Thread Pierre-Marie de Rodat
Hello, For -gdwarf-3 and newer, the DWARF back-end sometimes generates DWARF procedures to factorize complex location descriptions. DWARF procedures can be materialized as DW_TAG_dwarf_procedure DIEs, but actually any DIE that can hold a DW_AT_location attribute is also accepted. Unlike what I

[PATCH] Generalize overriding mechanism for debug info output options defaults

2016-08-18 Thread Pierre-Marie de Rodat
Hello, Currently, the VxWorks target overrides the defaults for debug info output options (DWARF version, strictness) in a target-specific options hook. This patch creates macros so that these defaults can be overriden in config headers. In particular, this will make it easier to have different

Re: [PATCH] Generalize overriding mechanism for debug info output options defaults

2016-08-26 Thread Pierre-Marie de Rodat
). One good way to start thinking about this stuff is what would need to change to support a world where the target (or front-end) were a DSO and replaceable. Interesting, thank you! So, I hereby abandon this patch. ;-) -- Pierre-Marie de Rodat

Re: [PATCH 1/2] DWARF: process all TYPE_DECL nodes when iterating on scopes

2016-08-29 Thread Pierre-Marie de Rodat
): For TYPE_DECLs that have the same scope as their type, relocate the type DIE if it was generated without a scope. gcc/testsuite/ * gnat.dg/debug9.adb: New testcase. -- Pierre-Marie de Rodat >From 7b629a631b532d561ed66c0dc973dfbf1f5d Mon Sep 17 00:00:00 2001 From: Pierre-Marie de Rodat &l

Re: [PATCH, PING] DWARF: process all TYPE_DECL nodes when iterating on scopes

2016-09-27 Thread Pierre-Marie de Rodat
::finalize_compilation_unit). The new patch attached tries to fix the call order. Bootstrapping and regtesting on x86_64-linux were clean except one testcase where the debug output changed legitimally (matcher updated). Ok to commit? Thank you in advance! -- Pierre-Marie de Rodat >F

[PATCH, PING*2] DWARF: space-optimize loc. descr. for integer literals on 32-bit targets

2016-09-27 Thread Pierre-Marie de Rodat
Hello, Ping for the patch submitted at <https://gcc.gnu.org/ml/gcc-patches/2016-08/msg02117.html>. Thanks! -- Pierre-Marie de Rodat

[PATCH, PING] DWARF: remove pessimistic DWARF version checks for imported entities

2016-09-27 Thread Pierre-Marie de Rodat
gcc-patches/2016-08/msg01315.html>. Thank you in advance! -- Pierre-Marie de Rodat

[PATCH] debug/PR78112: remove recent duplicates for DW_TAG_subprogram attributes

2016-11-08 Thread Pierre-Marie de Rodat
Hello, This patch comes from the discussion for PR debug/78112 (https://gcc.gnu.org/bugzilla/show_bug.cgi?id=78112). It seems to fix the regression Rainer detected on x86_64-apple-darwin, although I still wonder why remaining duplicate attributes (which were already present before my original

[PING, PATCH] DWARF: make signedness explicit for enumerator const values

2016-11-08 Thread Pierre-Marie de Rodat
Hello, Ping for the patch submitted there: <https://gcc.gnu.org/ml/gcc-patches/2016-10/msg01060.html>. Thank you in advance! -- Pierre-Marie de Rodat

Re: [PATCH] debug/PR78112: remove recent duplicates for DW_TAG_subprogram attributes

2016-11-10 Thread Pierre-Marie de Rodat
? Ok. This is committed as r242035. Thanks! -- Pierre-Marie de Rodat

Re: [PATCH] DWARF: make signedness explicit for enumerator const values

2016-11-14 Thread Pierre-Marie de Rodat
it would make sense, but would it be acceptable to enable this even in strict mode? If not, I’d prefer to stick to a solution that would apply everywhere. :-) -- Pierre-Marie de Rodat

Re: [PATCH] debug/PR78112: remove recent duplicates for DW_TAG_subprogram attributes

2016-11-18 Thread Pierre-Marie de Rodat
/show_bug.cgi?id=78112#c17), I reproduce inconsistent results on this even on a very reduced testcase. So I wonder if I should just remove this testcase. -- Pierre-Marie de Rodat

Re: [PATCH] DWARF: make signedness explicit for enumerator const values

2016-11-18 Thread Pierre-Marie de Rodat
looses without an actual (base) type telling them how to interpret the constant. I see, thank you for the explanation! :-) I agree with you, so I’ll revise to instead add a DW_AT_type attribute to enumeration DIEs to point to a base type. -- Pierre-Marie de Rodat

Re: [PATCH] DW_TAG_ptr_to_member_type for PMF and DW_AT_{,rvalue_}reference for those

2016-11-03 Thread Pierre-Marie de Rodat
need/want to run this testsuite, here it is in its current state: <https://github.com/pmderodat/dwarf-ada-testsuite>. Anyway, that being said: your patch does not introduce regressions in my testsuite, so it’s fine as far as I’m concerned. :-) Thank you for asking! -- Pierre-Marie de Rodat

Re: [PATCH, PING] DWARF: process all TYPE_DECL nodes when iterating on scopes

2016-10-11 Thread Pierre-Marie de Rodat
x your particular issue in a more reliable way. I think it makes sense, and it seems to work, so many thanks for the suggestion! Bootstrapped and regtested successfuly on x86_64-linux. And this time, I did not forgot to attach the new testcase! -- Pierre-Marie de Rodat

[PATCH, PING*3] DWARF: space-optimize loc. descr. for integer literals on 32-bit targets

2016-10-11 Thread Pierre-Marie de Rodat
Hello, Ping for the patch submitted at <https://gcc.gnu.org/ml/gcc-patches/2016-08/msg02117.html>. Thanks! -- Pierre-Marie de Rodat

Re: [PATCH, PING] DWARF: process all TYPE_DECL nodes when iterating on scopes

2016-10-12 Thread Pierre-Marie de Rodat
On 10/12/2016 10:15 AM, Richard Biener wrote: Ok. Thanks, Committed. Thank you! -- Pierre-Marie de Rodat

Re: [PATCH, PING] DWARF: space-optimize loc. descr. for integer literals on 32-bit targets

2016-10-12 Thread Pierre-Marie de Rodat
On 10/12/2016 10:13 AM, Richard Biener wrote: Ok. Thanks, Committed. Thank you! -- Pierre-Marie de Rodat

[PATCH] DWARF: make signedness explicit for enumerator const values

2016-10-13 Thread Pierre-Marie de Rodat
Hello, Currently, the DWARF description does not specify the signedness of the representation of enumeration types. This is a problem in some contexts where DWARF consumers need to determine if value X is greater than value Y. For instance in Ada: type Enum_Type is ( A, B, C, D); for

Re: [PATCH] [PR78112] Remove the g++.dg/pr78112.C testcase

2016-12-08 Thread Pierre-Marie de Rodat
darwin-16.3.0 and I’ve checked manually we have the correct number of attributes with a partial arm-none-abi compiler (i.e. just cc1plus). -- Pierre-Marie de Rodat >From fa8d7ca05a8711e261b5c4cfeec885c3ecede508 Mon Sep 17 00:00:00 2001 From: Pierre-Marie de Rodat <dero...@adacore.com> Da

Re: [PATCH] DWARF: make signedness explicit for enumerator const values

2016-12-09 Thread Pierre-Marie de Rodat
On 11/18/2016 06:22 PM, Pierre-Marie de Rodat wrote: I agree with you, so I’ll revise to instead add a DW_AT_type attribute to enumeration DIEs to point to a base type. Here is the patch to implement this. Bootstrapped and regtested (GCC’s testsuite) successfuly on x86_64-linux. However

Re: [PATCH] DWARF: make signedness explicit for enumerator const values

2016-12-09 Thread Pierre-Marie de Rodat
, it’s just that I’m not confident enough that it will be fine for DWARF consumers. -- Pierre-Marie de Rodat

Re: [PATCH] Fix DW_AT_data_member_location/DW_AT_bit_offset handling (PR debug/78839)

2017-01-12 Thread Pierre-Marie de Rodat
ral lines below. Is it to avoid the conversions to tree/wide int/HOST_WIDE_INT (i.e. an optimization)? -- Pierre-Marie de Rodat

[PATCH] [PR78112] Remove the g++.dg/pr78112.C testcase

2016-11-30 Thread Pierre-Marie de Rodat
Hello, I recently added a testcase for PR78112's resolution. Unfortunately, what it tests changes from one platform to another and I even get different results for a single platform (see ). As multiple developpers reported these errors and

<    1   2   3   4   5   6   7   8   9   10   >