PR85787: Extend malloc_candidate_p to handle multiple phis.

2018-08-28 Thread Prathamesh Kulkarni
against 0 and the phi. Bootstrapped+tested on x86_64-unknown-linux-gnu. OK to commit ? Thanks, Prathamesh 2018-08-28 Prathamesh Kulkarni PR tree-optimization/85787 * ipa-pure-const.c (malloc_candidate_p_1): Move most of malloc_candidate_p into this function and add support for

Re: PR85787: Extend malloc_candidate_p to handle multiple phis.

2018-09-05 Thread Prathamesh Kulkarni
On 28 August 2018 at 16:56, Prathamesh Kulkarni wrote: > H > The attached patch extends malloc_candidate_p to handle multiple phis. > There's a lot of noise in the patch because I moved most of > malloc_candidate_p into > new function malloc_candidate_p_1. The only real change is

Re: PR83750: CSE erf/erfc pair

2018-11-05 Thread Prathamesh Kulkarni
On Mon, 5 Nov 2018 at 15:10, Richard Biener wrote: > > On Fri, Nov 2, 2018 at 10:37 AM Prathamesh Kulkarni > wrote: > > > > Hi, > > This patch adds two transforms to match.pd to CSE erf/erfc pair. > > erfc(x) is canonicalized to 1 - erf(x) and is the

Re: PR83750: CSE erf/erfc pair

2018-11-05 Thread Prathamesh Kulkarni
On Mon, 5 Nov 2018 at 18:14, Richard Biener wrote: > > On Mon, Nov 5, 2018 at 1:11 PM Prathamesh Kulkarni > wrote: > > > > On Mon, 5 Nov 2018 at 15:10, Richard Biener > > wrote: > > > > > > On Fri, Nov 2, 2018 at 10:37 AM Prathamesh Kulkarni > &g

Re: [ARM] Implement division using vrecpe, vrecps

2018-11-02 Thread Prathamesh Kulkarni
On Fri, 26 Oct 2018 at 10:34, Prathamesh Kulkarni wrote: > > Hi, > This is a rebased version of patch that adds a pattern to neon.md for > implementing division with multiplication by reciprocal using > vrecpe/vrecps with -funsafe-math-optimizations excluding -Os. > The newl

PR83750: CSE erf/erfc pair

2018-11-02 Thread Prathamesh Kulkarni
> 0 which resolves the regression. Bootstrapped+tested on x86_64-unknown-linux-gnu. Cross-testing on arm and aarch64 variants in progress. OK for trunk if passes ? Thanks, Prathamesh 2018-11-02 Prathamesh Kulkarni * match.pd (erfc(x) -> 1 - erf(x)): New pattern. (1 - e

[ARM] Implement division using vrecpe, vrecps

2018-10-25 Thread Prathamesh Kulkarni
stalled the patch). Bootstrap+tested on arm-linux-gnueabihf. Cross-tested on arm*-*-* variants. OK for trunk ? Thanks, Prathamesh 2018-10-26 Prathamesh Kulkarni * config/arm/neon.md (div3): New pattern. testsuite/ * gcc.target/arm/neon-vect-div-1.c: New test

Re: [ARM] Implement division using vrecpe, vrecps

2018-11-08 Thread Prathamesh Kulkarni
On Mon, 5 Nov 2018 at 19:22, Ramana Radhakrishnan wrote: > > On 26/10/2018 06:04, Prathamesh Kulkarni wrote: > > Hi, > > This is a rebased version of patch that adds a pattern to neon.md for > > implementing division with multiplication by reciprocal using > > vr

Re: PR83750: CSE erf/erfc pair

2018-11-08 Thread Prathamesh Kulkarni
On Tue, 6 Nov 2018 at 16:04, Richard Biener wrote: > > On Mon, Nov 5, 2018 at 3:11 PM Prathamesh Kulkarni > wrote: > > > > On Mon, 5 Nov 2018 at 18:14, Richard Biener > > wrote: > > > > > > On Mon, Nov 5, 2018 at 1:11 PM Prathamesh Kulkarni >

Re: [ARM] Implement division using vrecpe, vrecps

2018-11-04 Thread Prathamesh Kulkarni
On Fri, 2 Nov 2018 at 19:08, Wilco Dijkstra wrote: > > Prathamesh Kulkarni wrote: > > > This is a rebased version of patch that adds a pattern to neon.md for > > implementing division with multiplication by reciprocal using > > vrecpe/vrecps with -funsafe-math-

Re: PR85787: Extend malloc_candidate_p to handle multiple phis.

2018-10-04 Thread Prathamesh Kulkarni
On Fri, 14 Sep 2018 at 22:49, Jeff Law wrote: > > On 8/28/18 5:26 AM, Prathamesh Kulkarni wrote: > > H > > The attached patch extends malloc_candidate_p to handle multiple phis. > > There's a lot of noise in the patch because I moved most of > > malloc_can

[SVE ACLE] Implement svlsl_wide

2019-01-18 Thread Prathamesh Kulkarni
Hi, I committed the attached patch to aarch64/sve-acle-branch that implements svlsl_wide. Thanks, Prathamesh diff --git a/gcc/config/aarch64/aarch64-sve-builtins.c b/gcc/config/aarch64/aarch64-sve-builtins.c index f080a67ef00..0e3db669422 100644 --- a/gcc/config/aarch64/aarch64-sve-builtins.c +++

PR88788 - Infinite loop in malloc_candidate_p_1

2019-01-14 Thread Prathamesh Kulkarni
, Prathamesh 2019-01-15 Richard Biener Prathamesh Kulkarni PR ipa/88378 * ipa-pure-const.c (malloc_candidate_p_1): Add parameter visited and return true if SSA_NAME is already marked in visited bitmap. * (malloc_candidate_p): Pass visited

Re: PR88788 - Infinite loop in malloc_candidate_p_1

2019-01-15 Thread Prathamesh Kulkarni
On Tue, 15 Jan 2019 at 14:33, Richard Biener wrote: > > On Tue, 15 Jan 2019, Jakub Jelinek wrote: > > > On Tue, Jan 15, 2019 at 12:29:21PM +0530, Prathamesh Kulkarni wrote: > > > 2019-01-15 Richard Biener > > > Prathamesh Kulkarni > > > >

[SVE ACLE] Fix for PR88839

2019-04-06 Thread Prathamesh Kulkarni
Hi, I committed attached patch, which fixes PR88839 to sve-acle-branch after approval from Richard Sandiford offline. Thanks, Prathamesh diff --git a/gcc/config/aarch64/aarch64.c b/gcc/config/aarch64/aarch64.c index ec60e972f5f..f8d5270b982 100644 --- a/gcc/config/aarch64/aarch64.c +++

[SVE ACLE] Implement svlsl

2019-02-12 Thread Prathamesh Kulkarni
Committed attached patch to aarch64/sve-acle-branch. Thanks, Prathamesh diff --git a/gcc/config/aarch64/aarch64-sve-builtins.c b/gcc/config/aarch64/aarch64-sve-builtins.c index ed06db9b7c6..598411fb834 100644 --- a/gcc/config/aarch64/aarch64-sve-builtins.c +++

Re: [AArch64] [SVE] PR88837 - Poor vector construction code in VL-specific mode

2019-06-03 Thread Prathamesh Kulkarni
On Mon, 3 Jun 2019 at 16:25, Richard Sandiford wrote: > > Prathamesh Kulkarni writes: > >> > diff --git a/gcc/testsuite/lib/target-supports.exp > >> > b/gcc/testsuite/lib/target-supports.exp > >> > index 3bd6e815715..0ff0d8fb757 100644 > >

Re: [AArch64] [SVE] PR88837 - Poor vector construction code in VL-specific mode

2019-06-03 Thread Prathamesh Kulkarni
On Mon, 3 Jun 2019 at 14:53, Richard Sandiford wrote: > > Prathamesh Kulkarni writes: > > On Thu, 30 May 2019 at 21:19, Richard Sandiford > > wrote: > >> > >> Prathamesh Kulkarni writes: > >> > On Thu, 30 May 2019 at 15:10, Richard Sandiford &g

Re: [AArch64] [SVE] PR88837 - Poor vector construction code in VL-specific mode

2019-06-03 Thread Prathamesh Kulkarni
On Thu, 30 May 2019 at 21:19, Richard Sandiford wrote: > > Prathamesh Kulkarni writes: > > On Thu, 30 May 2019 at 15:10, Richard Sandiford > > wrote: > >> > >> Prathamesh Kulkarni writes: > >> > diff --git a/gcc/testsuite/gcc.target/aarch64

Re: [AArch64] [SVE] PR88837 - Poor vector construction code in VL-specific mode

2019-06-07 Thread Prathamesh Kulkarni
On Thu, 6 Jun 2019 at 16:54, Richard Sandiford wrote: > > Szabolcs Nagy writes: > > On 03/06/2019 08:26, Prathamesh Kulkarni wrote: > >> +++ b/gcc/testsuite/gcc.target/aarch64/sve/init_8.c > >> @@ -0,0 +1,32 @@ > >> +/* { dg-do assemble { target aarch64_

Re: [AArch64] [SVE] PR88837 - Poor vector construction code in VL-specific mode

2019-06-07 Thread Prathamesh Kulkarni
On Fri, 7 Jun 2019 at 18:26, Richard Sandiford wrote: > > Prathamesh Kulkarni writes: > > On Thu, 6 Jun 2019 at 16:54, Richard Sandiford > > wrote: > >> > >> Szabolcs Nagy writes: > >> > On 03/06/2019 08:26, Prathamesh Kulkarni wrote: > >&g

Re: [AArch64] [SVE] PR88837 - Poor vector construction code in VL-specific mode

2019-06-08 Thread Prathamesh Kulkarni
On Fri, 7 Jun 2019 at 22:47, Richard Sandiford wrote: > > Prathamesh Kulkarni writes: > > 2019-06-07 Prathamesh Kulkarni > > > > * gcc.target/aarch64/sve/init_1.c: Remove options > > -O2 -fno-schedule-insns and instead pass -O. > &g

Re: [AArch64] [SVE] PR88837 - Poor vector construction code in VL-specific mode

2019-05-30 Thread Prathamesh Kulkarni
On Wed, 29 May 2019 at 18:10, Richard Sandiford wrote: > > Prathamesh Kulkarni writes: > > Hi, > > The attached patch tries to improve initialization for fixed-length > > SVE vector and it's algorithm is described in comments for > > aarch64_sve_expand_vector_init(

Re: [AArch64] [SVE] PR88837 - Poor vector construction code in VL-specific mode

2019-05-30 Thread Prathamesh Kulkarni
On Thu, 30 May 2019 at 15:10, Richard Sandiford wrote: > > Prathamesh Kulkarni writes: > > diff --git a/gcc/testsuite/gcc.target/aarch64/sve/init_1.c > > b/gcc/testsuite/gcc.target/aarch64/sve/init_1.c > > new file mode 100644 > > index 000..cbfeff4a59c &

[AArch64] [SVE] PR88837 - Poor vector construction code in VL-specific mode

2019-05-27 Thread Prathamesh Kulkarni
on patch in qemu. Does the patch look OK ? Thanks, Prathamesh 2019-05-27 Prathamesh Kulkarni Richard Sandiford * vector-builder.h (vector_builder::count_dups): New method. * config/aarch64/aarch64-protos.h (aarch64_expand_sve_vector_init): Declare

Re: [PR 90939] Remove outdated assert in ipcp_bits_lattice::meet_with

2019-06-25 Thread Prathamesh Kulkarni
On Mon, 24 Jun 2019 at 22:02, Martin Jambor wrote: > > Hi, > > in August 2016 Prathamesh implemented inter-procedural propagation of > known non-zero bits on integers. In August that same year he then also > added the ability to track it for pointer, replacing separate alignment > tracking. > >

Re: [SVE] [fwprop] PR88833 - Redundant moves for WHILELO-based loops

2019-06-25 Thread Prathamesh Kulkarni
On Mon, 24 Jun 2019 at 21:41, Prathamesh Kulkarni wrote: > > On Mon, 24 Jun 2019 at 19:51, Richard Sandiford > wrote: > > > > Prathamesh Kulkarni writes: > > > @@ -1415,6 +1460,19 @@ forward_propagate_into (df_ref use) > > >

[SVE] [fwprop] PR88833 - Redundant moves for WHILELO-based loops

2019-06-21 Thread Prathamesh Kulkarni
Hi, The attached patch tries to fix PR88833. For the following test-case: subroutine foo(x) real :: x(100) x = x + 10 end subroutine foo Assembly with -O3 -march=armv8.2-a+sve: foo_: .LFB0: .cfi_startproc mov w2, 100 mov w3, w2 mov x1, 0

Re: [SVE] [fwprop] PR88833 - Redundant moves for WHILELO-based loops

2019-06-24 Thread Prathamesh Kulkarni
On Mon, 24 Jun 2019 at 14:59, Richard Sandiford wrote: > > Prathamesh Kulkarni writes: > > diff --git a/gcc/fwprop.c b/gcc/fwprop.c > > index 45703fe5f01..93a1a10c9a6 100644 > > --- a/gcc/fwprop.c > > +++ b/gcc/fwprop.c > > @@ -547,6 +547,54 @@ propagate_rtx_

Re: [SVE] [fwprop] PR88833 - Redundant moves for WHILELO-based loops

2019-06-24 Thread Prathamesh Kulkarni
On Mon, 24 Jun 2019 at 19:51, Richard Sandiford wrote: > > Prathamesh Kulkarni writes: > > @@ -1415,6 +1460,19 @@ forward_propagate_into (df_ref use) > >if (!def_set) > > return false; > > > > + if (reg_prop_only > > + && !REG_P

cse.c typo fix

2019-05-22 Thread Prathamesh Kulkarni
Hi, The attached patch fixes a typo in cse_dump_path, which I came across while debugging another issue. OK to commit ? Thanks, Prathamesh 2019-05-22 Prathamesh Kulkarni * cse.c (cse_dump_path): s/dump_file/f. diff --git a/gcc/cse.c b/gcc/cse.c index 6c9cda16a98..35840a6d5ca 100644

Re: [PATCH] Add simplification rule tanh (x) * cosh (x) -> sinh (x)

2019-04-29 Thread Prathamesh Kulkarni
On Tue, 30 Apr 2019 at 02:56, Jeff Law wrote: > > On 1/30/19 7:10 AM, Bárbara de Castro Fernandes wrote: > > This patch simplifies the function tanh (x) * cosh (x) -> sinh (x). > > This rule is derived from the relationship between hyperbolic > > functions. > > > > I ran the tests and

Re: [SVE] [fwprop] PR88833 - Redundant moves for WHILELO-based loops

2019-07-03 Thread Prathamesh Kulkarni
On Tue, 2 Jul 2019 at 18:22, Richard Sandiford wrote: > > Prathamesh Kulkarni writes: > > On Tue, 2 Jul 2019 at 16:59, Richard Sandiford > > wrote: > >> > >> Thanks for fixing this. > >> > >> Prathamesh Kulkarni writes: > >> >

Re: [SVE] [fwprop] PR88833 - Redundant moves for WHILELO-based loops

2019-06-26 Thread Prathamesh Kulkarni
On Wed, 26 Jun 2019 at 16:05, Richard Sandiford wrote: > > Prathamesh Kulkarni writes: > > On Tue, 25 Jun 2019 at 20:05, Richard Sandiford > > wrote: > >> > >> Prathamesh Kulkarni writes: > >> > On Mon, 24 Jun 2019 at 21:41, Prathamesh Kulkar

Re: [SVE] [fwprop] PR88833 - Redundant moves for WHILELO-based loops

2019-06-26 Thread Prathamesh Kulkarni
On Tue, 25 Jun 2019 at 20:05, Richard Sandiford wrote: > > Prathamesh Kulkarni writes: > > On Mon, 24 Jun 2019 at 21:41, Prathamesh Kulkarni > > wrote: > >> > >> On Mon, 24 Jun 2019 at 19:51, Richard Sandiford > >> wrote: > >> > > &g

Re: PR90723

2019-07-11 Thread Prathamesh Kulkarni
On Thu, 11 Jul 2019 at 01:48, Richard Sandiford wrote: > > Prathamesh Kulkarni writes: > > Hi, > > For following test-case: > > > > typedef double v4df __attribute__ ((vector_size (32))); > > void foo(v4df); > > > > int > > main () > &

Re: PR90723

2019-07-13 Thread Prathamesh Kulkarni
On Thu, 11 Jul 2019 at 13:39, Richard Sandiford wrote: > > Prathamesh Kulkarni writes: > > @@ -186,6 +186,23 @@ skip_alternative (const char *p) > > /* Nonzero means volatile operands are recognized. */ > > extern int volatile_ok; > > > > +/* RAII class

PR90723

2019-07-09 Thread Prathamesh Kulkarni
ss. OK to commit ? Thanks, Prathamesh 2019-07-09 Prathamesh Kulkarni PR target/90723 * recog.h (volatile_ok_temp): New class. * config/aarch64/aarch64.c (aarch64_emit_sve_pred_move): Set volatile_ok temporarily to true using volatile_ok_temp. *

Re: [SVE] [fwprop] PR88833 - Redundant moves for WHILELO-based loops

2019-07-04 Thread Prathamesh Kulkarni
On Wed, 3 Jul 2019 at 17:06, Richard Sandiford wrote: > > Prathamesh Kulkarni writes: > > On Tue, 2 Jul 2019 at 18:22, Richard Sandiford > > wrote: > >> > >> Prathamesh Kulkarni writes: > >> > On Tue, 2 Jul 2019 at 16:59, Richard Sandiford

Re: [SVE] [fwprop] PR88833 - Redundant moves for WHILELO-based loops

2019-07-02 Thread Prathamesh Kulkarni
On Wed, 26 Jun 2019 at 23:45, Richard Sandiford wrote: > > Prathamesh Kulkarni writes: > > On Wed, 26 Jun 2019 at 16:05, Richard Sandiford > > wrote: > >> > >> Prathamesh Kulkarni writes: > >> > On Tue, 25 Jun 2019 at 20:05, Richard Sandiford &g

Re: [SVE] [fwprop] PR88833 - Redundant moves for WHILELO-based loops

2019-07-02 Thread Prathamesh Kulkarni
On Tue, 2 Jul 2019 at 16:59, Richard Sandiford wrote: > > Thanks for fixing this. > > Prathamesh Kulkarni writes: > > diff --git a/gcc/simplify-rtx.c b/gcc/simplify-rtx.c > > index 89a46a933fa..79bd0cfbd28 100644 > > --- a/gcc/simplify-rtx.c > > +++ b/gcc/si

Re: PR90724 - ICE with __sync_bool_compare_and_swap with -march=armv8.2-a

2019-08-15 Thread Prathamesh Kulkarni
On Thu, 8 Aug 2019 at 11:22, Prathamesh Kulkarni wrote: > > On Thu, 1 Aug 2019 at 15:34, Prathamesh Kulkarni > wrote: > > > > On Thu, 25 Jul 2019 at 11:56, Prathamesh Kulkarni > > wrote: > > > > > > On Wed, 17 Jul 2019 at 18:15, Prathamesh Kulkarni

[SVE] PR86753

2019-08-14 Thread Prathamesh Kulkarni
Hi, The attached patch tries to fix PR86753. For following test: void f1 (int *restrict x, int *restrict y, int *restrict z) { for (int i = 0; i < 100; ++i) x[i] = y[i] ? z[i] : 10; } vect dump shows: vect_cst__42 = { 0, ... }; vect_cst__48 = { 0, ... }; vect__4.7_41 = .MASK_LOAD

Re: PR90724 - ICE with __sync_bool_compare_and_swap with -march=armv8.2-a

2019-08-21 Thread Prathamesh Kulkarni
On Mon, 19 Aug 2019 at 22:14, James Greenhalgh wrote: > > On Thu, Aug 15, 2019 at 02:11:25PM +0100, Prathamesh Kulkarni wrote: > > On Thu, 8 Aug 2019 at 11:22, Prathamesh Kulkarni > > wrote: > > > > > > On Thu, 1 Aug 2019 at 15:34, Prathamesh Kulkarni > >

Re: [SVE] PR86753

2019-08-21 Thread Prathamesh Kulkarni
On Thu, 15 Aug 2019 at 01:50, Richard Sandiford wrote: > > Richard Biener writes: > > On Wed, Aug 14, 2019 at 6:49 PM Richard Biener > > wrote: > >> > >> On Wed, Aug 14, 2019 at 5:06 PM Prathamesh Kulkarni > >> wrote: > >> >

[SVE] [aarch64] Add "@" in vcond_mask pattern

2019-08-21 Thread Prathamesh Kulkarni
ailure. OK to commit ? Thanks, Prathamesh 2019-08-22 Prathamesh Kulkarni * aarch64-sve.md (vcond_mask): Add "@". diff --git a/gcc/config/aarch64/aarch64-sve.md b/gcc/config/aarch64/aarch64-sve.md index ac65e691d73..f58353e9c6d 100644 --- a/gcc/config/aarch64/aarch64-sve.md +++ b/gcc

[SVE] PR88839

2019-08-20 Thread Prathamesh Kulkarni
Hi, The attached patch is a fix for PR88839 ported from sve-acle-branch. OK to commit to trunk ? Thanks, Prathamesh 2019-08-21 Prathamesh Kulkarni Richard Sandiford PR target/88839 * config/aarch64/aarch64.c (aarch64_evpc_sel): New function

Re: [SVE] PR86753

2019-08-31 Thread Prathamesh Kulkarni
On Fri, 30 Aug 2019 at 16:15, Richard Biener wrote: > > On Wed, Aug 28, 2019 at 11:02 AM Richard Sandiford > wrote: > > > > Prathamesh Kulkarni writes: > > > On Tue, 27 Aug 2019 at 21:14, Richard Sandiford > > > wrote: > > >> > >

Re: [SVE] PR86753

2019-08-25 Thread Prathamesh Kulkarni
On Fri, 23 Aug 2019 at 19:43, Richard Sandiford wrote: > > Prathamesh Kulkarni writes: > > On Fri, 23 Aug 2019 at 18:15, Richard Sandiford > > wrote: > >> > >> Prathamesh Kulkarni writes: > >> > On Thu, 22 Aug 2019 at 16:44, Richard Biener >

Re: [SVE] PR86753

2019-08-26 Thread Prathamesh Kulkarni
On Mon, 26 Aug 2019 at 14:48, Richard Biener wrote: > > On Sun, Aug 25, 2019 at 11:13 PM Prathamesh Kulkarni > wrote: > > > > On Fri, 23 Aug 2019 at 19:43, Richard Sandiford > > wrote: > > > > > > Prathamesh Kulkarni writes: > >

Re: [SVE] PR88839

2019-08-21 Thread Prathamesh Kulkarni
On Wed, 21 Aug 2019 at 15:18, Richard Sandiford wrote: > > Prathamesh Kulkarni writes: > > Hi, > > The attached patch is a fix for PR88839 ported from sve-acle-branch. > > OK to commit to trunk ? > > > > Thanks, > > Prathamesh > > > > 2

Re: [SVE] PR86753

2019-08-23 Thread Prathamesh Kulkarni
On Thu, 22 Aug 2019 at 16:44, Richard Biener wrote: > > On Wed, Aug 21, 2019 at 8:24 PM Prathamesh Kulkarni > wrote: > > > > On Thu, 15 Aug 2019 at 01:50, Richard Sandiford > > wrote: > > > > > > Richard Biener writes: > > > > On W

Re: [SVE] PR86753

2019-08-23 Thread Prathamesh Kulkarni
On Fri, 23 Aug 2019 at 18:15, Richard Sandiford wrote: > > Prathamesh Kulkarni writes: > > On Thu, 22 Aug 2019 at 16:44, Richard Biener > > wrote: > >> > >> On Wed, Aug 21, 2019 at 8:24 PM Prathamesh Kulkarni > >> wrote: > >> &g

Re: [SVE] PR86753

2019-08-27 Thread Prathamesh Kulkarni
On Tue, 27 Aug 2019 at 21:14, Richard Sandiford wrote: > > Richard should have the final say, but some comments... > > Prathamesh Kulkarni writes: > > diff --git a/gcc/tree-vect-stmts.c b/gcc/tree-vect-stmts.c > > index 1e2dfe5d22d..862206b3256 100644 > > --- a/g

Re: [SVE] PR86753

2019-08-27 Thread Prathamesh Kulkarni
On Tue, 27 Aug 2019 at 17:29, Richard Sandiford wrote: > > Richard Biener writes: > > On Tue, Aug 27, 2019 at 11:58 AM Richard Sandiford > > wrote: > >> ifcvt produces: > >> > >>[local count: 1063004407]: > >> # i_34 = PHI > >> # ivtmp_5 = PHI > >> _1 = (long unsigned int) i_34; >

PR78736

2019-08-28 Thread Prathamesh Kulkarni
+test on x86_64-unknown-linux-gnu. (Also IIRC, Wall triggered several instances of the warning with allmodconfig kernel build last time). Is the patch OK to commit ? Thanks, Prathamesh 2019-08-29 Prathamesh Kulkarni * doc/invoke.texi: Document -Wenum-conversion. * c-family/c.opt

Re: [SVE] PR86753

2019-09-05 Thread Prathamesh Kulkarni
On Thu, 5 Sep 2019 at 14:29, Richard Sandiford wrote: > > Sorry for the slow reply. > > Prathamesh Kulkarni writes: > > On Fri, 30 Aug 2019 at 16:15, Richard Biener > > wrote: > >> > >> On Wed, Aug 28, 2019 at 11:02 AM Richard Sandiford > >>

Re: [2/2] PR 78736: libgomp fallout

2019-09-04 Thread Prathamesh Kulkarni
On Tue, 9 May 2017 at 18:59, Jakub Jelinek wrote: > > On Tue, May 09, 2017 at 06:55:12PM +0530, Prathamesh Kulkarni wrote: > > ping https://gcc.gnu.org/ml/gcc-patches/2017-05/msg00135.html > > The libgomp patch is ok provided the warning is added. > Though, should it be in -

Re: PR78736

2019-09-04 Thread Prathamesh Kulkarni
On Wed, 4 Sep 2019 at 01:22, Jeff Law wrote: > > On 8/28/19 8:55 PM, Prathamesh Kulkarni wrote: > > Hi, > > This is a rebased patch on trunk for PR78736. The last time, it got > > stuck, because of warning issues with libgfortran, for which I filed > > PR91593. T

Re: [SVE] PR86753

2019-09-10 Thread Prathamesh Kulkarni
On Tue, 10 Sep 2019 at 19:05, Matthew Malcomson wrote: > > Resending because I forgot to avoid the disclaimer and hence my email > didn't go to the gcc-patches list. > > > > On 09/09/19 21:55, Prathamesh Kulkarni wrote: > > On Mon, 9 Sep 2019 at 22:06, Pra

Re: [SVE] PR86753

2019-09-16 Thread Prathamesh Kulkarni
On Mon, 9 Sep 2019 at 09:36, Prathamesh Kulkarni wrote: > > On Mon, 9 Sep 2019 at 16:45, Richard Sandiford > wrote: > > > > Prathamesh Kulkarni writes: > > > With patch, the only following FAIL remains for aarch64-sve.exp: > > > FAIL: gcc.target/aarch64/

Re: [PATCH][ARM] Enable code hoisting with -Os (PR80155)

2019-09-14 Thread Prathamesh Kulkarni
On Wed, 11 Sep 2019 at 11:50, Wilco Dijkstra wrote: > > While code hoisting generally improves codesize, it can affect performance > negatively. Benchmarking shows it doesn't help SPEC and negatively affects > embedded benchmarks, so only enable code hoisting with -Os on Arm. > > Bootstrap OK,

Re: [SVE] PR86753

2019-09-09 Thread Prathamesh Kulkarni
On Mon, 9 Sep 2019 at 16:45, Richard Sandiford wrote: > > Prathamesh Kulkarni writes: > > With patch, the only following FAIL remains for aarch64-sve.exp: > > FAIL: gcc.target/aarch64/sve/cond_unary_2.c -march=armv8.2-a+sve > > scan-assembler-times \\tmovprfx\\t 6 &

Re: PR90724 - ICE with __sync_bool_compare_and_swap with -march=armv8.2-a

2019-09-09 Thread Prathamesh Kulkarni
On Thu, 22 Aug 2019 at 00:05, Prathamesh Kulkarni wrote: > > On Mon, 19 Aug 2019 at 22:14, James Greenhalgh > wrote: > > > > On Thu, Aug 15, 2019 at 02:11:25PM +0100, Prathamesh Kulkarni wrote: > > > On Thu, 8 Aug 2019 at 11:22, Prathamesh Kulkarni > > >

Re: [SVE] PR86753

2019-09-09 Thread Prathamesh Kulkarni
On Mon, 9 Sep 2019 at 22:06, Prathamesh Kulkarni wrote: > > On Mon, 9 Sep 2019 at 16:45, Richard Sandiford > wrote: > > > > Prathamesh Kulkarni writes: > > > With patch, the only following FAIL remains for aarch64-sve.exp: > > > FAIL: gcc.target/aarch64/

Re: [PATCH][ARM] Enable code hoisting with -Os (PR80155)

2019-09-18 Thread Prathamesh Kulkarni
On Wed, 18 Sep 2019 at 01:46, Richard Biener wrote: > > On Tue, Sep 17, 2019 at 7:18 PM Wilco Dijkstra wrote: > > > > Hi Richard, > > > > > The issue with the bugzilla is that it lacked appropriate testcase(s) and > > > thus > > > it is now a mess. There are clear testcases (maybe not in the

Re: PR90724 - ICE with __sync_bool_compare_and_swap with -march=armv8.2-a

2019-08-07 Thread Prathamesh Kulkarni
On Thu, 1 Aug 2019 at 15:34, Prathamesh Kulkarni wrote: > > On Thu, 25 Jul 2019 at 11:56, Prathamesh Kulkarni > wrote: > > > > On Wed, 17 Jul 2019 at 18:15, Prathamesh Kulkarni > > wrote: > > > > > > On Wed, 17 Jul 2019 at 13:45, Kyrill Tkacho

Re: PR90724 - ICE with __sync_bool_compare_and_swap with -march=armv8.2-a

2019-08-01 Thread Prathamesh Kulkarni
On Thu, 25 Jul 2019 at 11:56, Prathamesh Kulkarni wrote: > > On Wed, 17 Jul 2019 at 18:15, Prathamesh Kulkarni > wrote: > > > > On Wed, 17 Jul 2019 at 13:45, Kyrill Tkachov > > wrote: > > > > > > Hi Prathamesh > > > > >

Re: PR91166 - Unfolded ZIPs of constants

2019-07-23 Thread Prathamesh Kulkarni
On Fri, 19 Jul 2019 at 18:12, Richard Sandiford wrote: > > Not really my area, but FWIW... > > Prathamesh Kulkarni writes: > > Hi, > > The attached patch tries to fix PR91166. > > Does it look OK ? > > Bootstrap+test in progress on aarch64-linux-g

Re: PR91166 - Unfolded ZIPs of constants

2019-07-23 Thread Prathamesh Kulkarni
On Tue, 23 Jul 2019 at 16:36, Richard Biener wrote: > > On Tue, 23 Jul 2019, Prathamesh Kulkarni wrote: > > > On Fri, 19 Jul 2019 at 18:12, Richard Sandiford > > wrote: > > > > > > Not really my area, but FWIW... > > > > > > Prathamesh

Re: PR91166 - Unfolded ZIPs of constants

2019-07-23 Thread Prathamesh Kulkarni
On Tue, 23 Jul 2019 at 17:48, Richard Biener wrote: > > On Tue, 23 Jul 2019, Prathamesh Kulkarni wrote: > > > On Tue, 23 Jul 2019 at 16:36, Richard Biener wrote: > > > > > > On Tue, 23 Jul 2019, Prathamesh Kulkarni wrote: > > > > > >

Re: PR90724 - ICE with __sync_bool_compare_and_swap with -march=armv8.2-a

2019-07-17 Thread Prathamesh Kulkarni
On Wed, 10 Jul 2019 at 16:54, Prathamesh Kulkarni wrote: > > Hi, > For following test-case, > static long long AL[24]; > > int > check_ok (void) > { > return (__sync_bool_compare_and_swap (AL+1, 0x20003ll, 0x1234567890ll)); > } > > Compiling with -O2 -mar

Re: PR90724 - ICE with __sync_bool_compare_and_swap with -march=armv8.2-a

2019-07-17 Thread Prathamesh Kulkarni
On Wed, 17 Jul 2019 at 13:45, Kyrill Tkachov wrote: > > Hi Prathamesh > > On 7/10/19 12:24 PM, Prathamesh Kulkarni wrote: > > Hi, > > For following test-case, > > static long long AL[24]; > > > > int > > check_ok (void) > > { > >

PR91166 - Unfolded ZIPs of constants

2019-07-17 Thread Prathamesh Kulkarni
Hi, The attached patch tries to fix PR91166. Does it look OK ? Bootstrap+test in progress on aarch64-linux-gnu and x86_64-unknown-linux-gnu. Thanks, Prathamesh 2019-07-17 Prathamesh Kulkarni PR middle-end/91166 * match.pd (vec_perm_expr(v, v, mask) -> v): New patt

Re: PR90724 - ICE with __sync_bool_compare_and_swap with -march=armv8.2-a

2019-07-25 Thread Prathamesh Kulkarni
On Wed, 17 Jul 2019 at 18:15, Prathamesh Kulkarni wrote: > > On Wed, 17 Jul 2019 at 13:45, Kyrill Tkachov > wrote: > > > > Hi Prathamesh > > > > On 7/10/19 12:24 PM, Prathamesh Kulkarni wrote: > > > Hi, > > > For following test-case, > >

[SVE] PR91532

2019-09-19 Thread Prathamesh Kulkarni
Hi, For PR91532, the dead store is trivially deleted if we place dse pass between ifcvt and vect. Would it be OK to add another instance of dse there ? Or should we add an ad-hoc "basic-block dse" sub-pass to ifcvt that will clean up the dead store ? Thanks, Prathamesh

Re: [PATCH][ARM] Enable code hoisting with -Os (PR80155)

2019-09-18 Thread Prathamesh Kulkarni
On Wed, 18 Sep 2019 at 22:17, Prathamesh Kulkarni wrote: > > On Wed, 18 Sep 2019 at 01:46, Richard Biener > wrote: > > > > On Tue, Sep 17, 2019 at 7:18 PM Wilco Dijkstra > > wrote: > > > > > > Hi Richard, > > > > > > > Th

Re: [SVE] PR91532

2019-09-30 Thread Prathamesh Kulkarni
On Wed, 25 Sep 2019 at 23:44, Richard Biener wrote: > > On Wed, 25 Sep 2019, Prathamesh Kulkarni wrote: > > > On Fri, 20 Sep 2019 at 15:20, Jeff Law wrote: > > > > > > On 9/19/19 10:19 AM, Prathamesh Kulkarni wrote: > > > > Hi, > > > > For

Re: [SVE] PR91532

2019-10-01 Thread Prathamesh Kulkarni
On Wed, 2 Oct 2019 at 01:08, Jeff Law wrote: > > On 10/1/19 12:40 AM, Richard Biener wrote: > > On Mon, 30 Sep 2019, Prathamesh Kulkarni wrote: > > > >> On Wed, 25 Sep 2019 at 23:44, Richard Biener wrote: > >>> > >>> On Wed, 25 Sep 2019, Pra

Re: [SVE] PR86753

2019-10-02 Thread Prathamesh Kulkarni
On Wed, 25 Sep 2019 at 09:17, Prathamesh Kulkarni wrote: > > On Mon, 16 Sep 2019 at 08:54, Prathamesh Kulkarni > wrote: > > > > On Mon, 9 Sep 2019 at 09:36, Prathamesh Kulkarni > > wrote: > > > > > > On Mon, 9 Sep 2019 at 16:45, Richard Sandi

[tree-if-conv.c] Move call to ifcvt_local_dce after rpo vn

2019-10-01 Thread Prathamesh Kulkarni
@@ +2019-10-01 Prathamesh Kulkarni + + * tree-if-conv.c (tree_if_conversion): Move call to ifcvt_local_dce + after local CSE. + 2019-10-01 Jan Hubicka * doc/invoke.texi (early-inlining-insns-O2): Document. Index: tree-if-conv.c

PR90724 - ICE with __sync_bool_compare_and_swap with -march=armv8.2-a

2019-07-10 Thread Prathamesh Kulkarni
satisfies aarch64_plus_operand predicate and if not, forces it to be in register, which resolves ICE. Does it look OK ? Bootstrap+testing in progress on aarch64-linux-gnu. PS: The issue has nothing to do with SVE, which I incorrectly mentioned in bug report. Thanks, Prathamesh 2019-07-10 Prathames

Re: PR92163

2019-11-04 Thread Prathamesh Kulkarni
On Mon, 4 Nov 2019 at 18:37, Christophe Lyon wrote: > > On Mon, 28 Oct 2019 at 16:03, Prathamesh Kulkarni > wrote: > > > > On Mon, 28 Oct 2019 at 07:18, Richard Biener > > wrote: > > > > > > On Fri, Oct 25, 2019 at 9:58 PM Prathamesh Kulkarni >

[SVE] PR89007 - Implement generic vector average expansion

2019-11-14 Thread Prathamesh Kulkarni
hamesh 2019-11-15 Prathamesh Kulkarni PR tree-optimization/89007 * tree-vect-patterns.c (vect_recog_average_pattern): If there is no target support available, generate code to distribute rshift over plus and add one depending upon floor or ceil rounding. tes

Re: PR92163

2019-11-06 Thread Prathamesh Kulkarni
On Tue, 5 Nov 2019 at 18:36, Christophe Lyon wrote: > > On Tue, 5 Nov 2019 at 05:46, Prathamesh Kulkarni > wrote: > > > > On Mon, 4 Nov 2019 at 18:37, Christophe Lyon > > wrote: > > > > > > On Mon, 28 Oct 2019 at 16:03, Prathamesh Kulkarni >

PR92608 - ICE: Segmentation fault (in find_loop_guard)

2019-11-20 Thread Prathamesh Kulkarni
Hi, The issue seems to happen with -O1, because header only contains phi: [local count: 118111600]: # iter.12_9 = PHI <0(2), iter.12_10(10)> and thus we hit segfault in following hunk in find_loop_guard: else { cond = dyn_cast (last_stmt (header)); if (!

Re: PR92608 - ICE: Segmentation fault (in find_loop_guard)

2019-11-21 Thread Prathamesh Kulkarni
On Thu, 21 Nov 2019 at 13:42, Richard Biener wrote: > > On Thu, 21 Nov 2019, Prathamesh Kulkarni wrote: > > > Hi, > > The issue seems to happen with -O1, because header only contains phi: > > > >[local count: 118111600]: > > # iter.12_9 = PHI <0(2

Re: [SVE] PR89007 - Implement generic vector average expansion

2019-12-09 Thread Prathamesh Kulkarni
On Thu, 5 Dec 2019 at 18:17, Richard Biener wrote: > > On Thu, 5 Dec 2019, Prathamesh Kulkarni wrote: > > > On Fri, 29 Nov 2019 at 15:41, Richard Biener > > wrote: > > > > > > On Fri, Nov 22, 2019 at 12:40 PM Prathamesh Kulkarni > > > wro

Re: [SVE] PR89007 - Implement generic vector average expansion

2019-12-05 Thread Prathamesh Kulkarni
On Fri, 29 Nov 2019 at 15:41, Richard Biener wrote: > > On Fri, Nov 22, 2019 at 12:40 PM Prathamesh Kulkarni > wrote: > > > > On Wed, 20 Nov 2019 at 16:54, Richard Biener wrote: > > > > > > On Wed, 20 Nov 2019, Richard Sandiford wrote: > > &

Re: [testsuite] Add test for PR91532

2019-10-20 Thread Prathamesh Kulkarni
On Sat, 19 Oct 2019 at 23:45, Richard Sandiford wrote: > > Prathamesh Kulkarni writes: > > Hi Richard, > > Sorry for not adding the test in PR91532 fix. > > Is the attached patch OK to commit ? > > > > Thanks, > > Prathamesh > > > > 2

Re: [SVE] PR91272

2019-10-28 Thread Prathamesh Kulkarni
On Sun, 27 Oct 2019 at 06:08, Richard Sandiford wrote: > > Prathamesh Kulkarni writes: > > @@ -10288,6 +10261,23 @@ vectorizable_condition (stmt_vec_info stmt_info, > > gimple_stmt_iterator *gsi, > > vect_finish_stmt_generation (

Re: PR92163

2019-10-28 Thread Prathamesh Kulkarni
On Mon, 28 Oct 2019 at 07:18, Richard Biener wrote: > > On Fri, Oct 25, 2019 at 9:58 PM Prathamesh Kulkarni > wrote: > > > > On Fri, 25 Oct 2019 at 13:19, Richard Biener > > wrote: > > > > > > On Wed, Oct 23, 2019 at 11:45 PM Pratham

Re: [SVE] PR86753

2019-10-17 Thread Prathamesh Kulkarni
On Wed, 16 Oct 2019 at 04:19, Richard Sandiford wrote: > > Richard Biener writes: > > On Tue, Oct 15, 2019 at 8:07 AM Prathamesh Kulkarni > > wrote: > >> > >> On Wed, 9 Oct 2019 at 08:14, Prathamesh Kulkarni > >> wrote: > >> > > >&

Re: [SVE] PR91272

2019-10-21 Thread Prathamesh Kulkarni
On Fri, 18 Oct 2019 at 14:36, Richard Sandiford wrote: > > Prathamesh Kulkarni writes: > > Hi, > > The attached patch tries to fix PR91272. > > Does it look OK ? > > > > With patch, I see following failures for aarch64-sve.exp: > > FAIL: gcc.target/a

PR92085

2019-10-14 Thread Prathamesh Kulkarni
Hi, The issue with PR91532 patch was in following hunk in ifcvt_local_dce: if (dse_classify_store (, stmt, false, NULL, NULL, latch_vdef) == DSE_STORE_DEAD) delete_dead_or_redundant_assignment (, "dead"); gsi_next (); continue; which

Re: [SVE] PR86753

2019-10-15 Thread Prathamesh Kulkarni
On Wed, 9 Oct 2019 at 08:14, Prathamesh Kulkarni wrote: > > On Tue, 8 Oct 2019 at 13:21, Richard Sandiford > wrote: > > > > Leaving the main review to Richard, just some comments... > > > > Prathamesh Kulkarni writes: > > > @@ -9774,6 +9777,10 @@ vect_

Re: PR92085

2019-10-15 Thread Prathamesh Kulkarni
On Mon, 14 Oct 2019 at 23:23, Jakub Jelinek wrote: > > On Mon, Oct 14, 2019 at 03:24:02PM -0700, Prathamesh Kulkarni wrote: > > The patch fixes this by simply putting gsi_next in else, which avoids > > the above issue. > > Bootstrap+test in progress on x86_64-unknown-lin

PR92163

2019-10-23 Thread Prathamesh Kulkarni
Hi, The attached patch tries to fix PR92163 by calling gimple_purge_dead_eh_edges from ifcvt_local_dce if we need eh cleanup. Does it look OK ? Thanks, Prathamesh 2019-10-24 Prathamesh Kulkarni PR tree-optimization/92163 * tree-if-conv.c (ifcvt_local_dce): Call

Re: [SVE] PR91272

2019-10-23 Thread Prathamesh Kulkarni
On Tue, 22 Oct 2019 at 13:12, Richard Sandiford wrote: > > Prathamesh Kulkarni writes: > > diff --git a/gcc/tree-vect-stmts.c b/gcc/tree-vect-stmts.c > > index acdd90784dc..dfd33b142ed 100644 > > --- a/gcc/tree-vect-stmts.c > > +++ b/gcc/tree-vect-stmt

[testsuite] Add test for PR91532

2019-10-18 Thread Prathamesh Kulkarni
Hi Richard, Sorry for not adding the test in PR91532 fix. Is the attached patch OK to commit ? Thanks, Prathamesh 2019-10-18 Prathamesh Kulkarni PR tree-optimization/91532 testsuite/ * gcc.target/aarch64/sve/fmla_2.c: Add dg-scan check for deleted store. diff --git a/gcc

<    1   2   3   4   5   6   7   8   9   10   >