Re: [PATCH] genemit: Split insn-emit.cc into ten files.

2023-10-17 Thread Sam James
Robin Dapp writes: > Hi, > > the attached v2 includes Tamar's suggestion of keeping the current > stdout behavior. When no output files are passed (via -O) the output > is written to stdout as before. > > Tamar also mentioned off-list that, similar to match.pd, it might make > sense to

Re: [PATCH] doc: explicitly say 'lifetime' for DCE

2023-11-02 Thread Sam James
Richard Biener writes: > On Thu, Nov 2, 2023 at 10:03 AM Sam James wrote: >> >> Say 'memory lifetime' rather than 'memory life' as lifetime is the more >> standard term nowadays (indeed we have e.g. -fno-lifetime-dse). >> >> It's also easier

[PATCH 2/4] maintainer-scripts/gcc_release: create index between snapshots <-> commits

2023-11-02 Thread Sam James
reports. maintainer-scripts/ * gcc_release: Create known_snapshots.txt as an index between snapshots and commits. Signed-off-by: Sam James --- Note that there's a few different approaches we can take here. I've gone for the simpler one of having it still fetch from the remote site

[PATCH 1/4] contrib: add generate_snapshot_index.py

2023-11-02 Thread Sam James
up the information from bug reports. contrib/: * generate_snapshot_index.py: New file. Signed-off-by: Sam James --- contrib/generate_snapshot_index.py | 79 ++ 1 file changed, 79 insertions(+) create mode 100755 contrib/generate_snapshot_index.py diff --git

[PATCH 3/4] maintainer-scripts/gcc_release: use HTTPS for links

2023-11-02 Thread Sam James
maintainer-scripts/ * gcc_release: Use HTTPS for links. Signed-off-by: Sam James --- maintainer-scripts/gcc_release | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/maintainer-scripts/gcc_release b/maintainer-scripts/gcc_release index 4cd1fa799660..cf6a5731c609

[PATCH 4/4] maintainer-scripts/gcc_release: cleanup whitespace

2023-11-02 Thread Sam James
maintainer-scripts/ * gcc_release: Cleanup whitespace. Signed-off-by: Sam James --- maintainer-scripts/gcc_release | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/maintainer-scripts/gcc_release b/maintainer-scripts/gcc_release index cf6a5731c609

[PATCH] doc: explicitly say 'lifetime' for DCE

2023-11-02 Thread Sam James
): Explicitly say 'lifetime' as this has become the standard term for what we're doing here. Signed-off-by: Sam James --- gcc/doc/passes.texi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gcc/doc/passes.texi b/gcc/doc/passes.texi index eb2bb6062834..470ac498a132 100644

Re: [PATCH] doc: explicitly say 'lifetime' for DCE

2023-11-02 Thread Sam James
Richard Biener writes: > On Thu, Nov 2, 2023 at 11:25 AM Sam James wrote: >> >> >> Richard Biener writes: >> >> > On Thu, Nov 2, 2023 at 10:03 AM Sam James wrote: >> >> >> >> Say 'memory lifetime' rather than 'memory life' as lifet

Re: [PATCH] libstdc++: avoid uninitialized read in basic_string constructor

2023-11-03 Thread Sam James
Jonathan Wakely writes: > On Thu, 2 Nov 2023 at 19:58, Ben Sherman > wrote: >> >> Tested on x86_64-pc-linux-gnu, please let me know if there's anything >> else needed. I haven't contributed before and don't have write access, so >> apologies if I've missed anything. > > This was

Re: [PING][PATCH] Include safe-ctype.h after C++ standard headers, to avoid over-poisoning

2023-10-29 Thread Sam James
Dimitry Andric writes: > Ping. It would be nice to get this QoL fix in. > Yes please - we've been using this in Gentoo since around when it was first posted. No complaints. I cannot approve but it looks good to me. > -Dimitry > >> On 28 Sep 2023, at 18:37, Dimitry Andric wrote: >> >> Ref:

[PATCH htdocs] bugs: Mention -D_GLIBCXX_ASSERTIONS and -D_GLIBCXX_DEBUG

2023-10-26 Thread Sam James
with it (as it breaks ABI). Signed-off-by: Sam James --- htdocs/bugs/index.html | 7 +++ 1 file changed, 7 insertions(+) diff --git a/htdocs/bugs/index.html b/htdocs/bugs/index.html index da3d4c0d..a5a38f42 100644 --- a/htdocs/bugs/index.html +++ b/htdocs/bugs/index.html @@ -56,6 +56,13

[PATCH htdocs v2] bugs: Mention -D_GLIBCXX_ASSERTIONS and -D_GLIBCXX_DEBUG

2023-10-26 Thread Sam James
with it (as it breaks ABI). Signed-off-by: Sam James --- v2: Improve phrasing for the types of checks and be less scornful about ABI changes. htdocs/bugs/index.html | 7 +++ 1 file changed, 7 insertions(+) diff --git a/htdocs/bugs/index.html b/htdocs/bugs/index.html index da3d4c0d

Re: [PATCH htdocs] bugs: Mention -D_GLIBCXX_ASSERTIONS and -D_GLIBCXX_DEBUG

2023-10-26 Thread Sam James
Jonathan Wakely writes: > On Thursday, 26 October 2023, Sam James wrote: >> These options both enabled more checking within the C++ standard library >> and can expose errors in submitted code. >> >> -D_GLIBCXX_DEBUG is mentioned separately because while we want pe

Re: [PATCH][_Hashtable] Add missing destructor call

2023-11-06 Thread Sam James
François Dumont writes: > Noticed looking for other occasion to replace __try/__catch with RAII > helper. > >     libstdc++: [_Hashtable] Add missing node destructor call > >     libstdc++-v3/ChangeLog: > >     * include/bits/hashtable_policy.h >    

[PATCH htdocs v3] bugs: Mention -D_GLIBCXX_ASSERTIONS and -D_GLIBCXX_DEBUG

2023-10-26 Thread Sam James
with it (as it breaks ABI). Signed-off-by: Sam James --- v3: Link to debug mode docs. v2: Improve phrasing for the types of checks and be less scornful about ABI changes. htdocs/bugs/index.html | 8 1 file changed, 8 insertions(+) diff --git a/htdocs/bugs/index.html b/htdocs/bugs

Re: [PATCH] Support g++ 4.8 as a host compiler.

2023-10-07 Thread Sam James
Jeff Law writes: > On 10/4/23 16:19, Roger Sayle wrote: >> The recent patch to remove poly_int_pod triggers a bug in g++ >> 4.8.5's >> C++ 11 support which mistakenly believes poly_uint16 has a non-trivial >> constructor. This in turn prohibits it from being used as a member in >> a union

Re: [PATCH v2] gcc: Introduce -fhardened

2023-10-19 Thread Sam James
Richard Biener writes: > On Wed, Oct 11, 2023 at 10:48 PM Marek Polacek wrote: >> >> On Tue, Sep 19, 2023 at 10:58:19AM -0400, Marek Polacek wrote: >> > On Mon, Sep 18, 2023 at 08:57:39AM +0200, Richard Biener wrote: >> > > On Fri, Sep 15, 2023 at 5:09 PM Marek Polacek via Gcc-patches >> > >

Re: [PATCH] Do not prepend target triple to -fuse-ld=lld,mold.

2023-10-15 Thread Sam James
Tatsuyuki Ishi writes: > lld and mold are platform-agnostic and not prefixed with target triple. > Prepending the target triple makes it less likely to find the intended > linker executable. > > A potential breaking change is that we no longer try to search for > triple-prefixed lld/mold

Re: [PATCH] genemit: Split insn-emit.cc into ten files.

2023-10-16 Thread Sam James
Robin Dapp writes: > Hi, > > the attached v2 includes Tamar's suggestion of keeping the current > stdout behavior. When no output files are passed (via -O) the output > is written to stdout as before. > > Tamar also mentioned off-list that, similar to match.pd, it might make > sense to

Re: [PATCH 4/4] maintainer-scripts/gcc_release: cleanup whitespace

2023-11-10 Thread Sam James
Joseph Myers writes: > On Thu, 2 Nov 2023, Sam James wrote: > >> maintainer-scripts/ >> * gcc_release: Cleanup whitespace. > > OK. Thanks. Would you mind pushing the two you approved?

[PATCH] MAINTAINERS: Fix formatting

2023-11-10 Thread Sam James
ChangeLog: * MAINTAINERS (Write After Approval): Fix indentation and missing email bracket. Signed-off-by: Sam James --- MAINTAINERS | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index c43167d9a752..9ad68687f769 100644

Re: [PATCH v1 2/4] C++: Support clang compatible [[musttail]]

2024-01-24 Thread Sam James
Andi Kleen writes: > This patch implements a clang compatible [[musttail]] attribute for > returns. This is PR83324. See also PR52067 and PR110899. > > musttail is useful as an alternative to computed goto for interpreters. > With computed goto the interpreter function usually ends up very

Re: [PATCH V1] Common infrastructure for load-store fusion for aarch64 and rs6000 target

2024-02-14 Thread Sam James
Ajit Agarwal writes: > Hello Richard: > > > On 14/02/24 4:03 pm, Richard Sandiford wrote: >> Hi, >> >> Thanks for working on this. >> >> You posted a version of this patch on Sunday too. If you need to repost >> to fix bugs or make other improvements, could you describe the changes >> that

Re: [PATCH] Notes on the warnings-as-errors change in GCC 14

2024-02-15 Thread Sam James
Florian Weimer writes: > * Sam James: > >> It's fine if you leave this out, but consider mentioning the common >> pitfall of autoconf projects not including config.h consistently before >> all inclues. We could also mention AC_USE_SYSTEM_EXTENSIONS. > > I added: &

Re: [PATCH] Turn on LRA on all targets

2024-02-15 Thread Sam James
Sam James writes: > [[PGP Signed Part:Undecided]] > > "Maciej W. Rozycki" writes: > >> On Sun, 23 Apr 2023, Segher Boessenkool wrote: >> >>> > There are extra ICEs in regression testing and code quality is poor; cf. >>> > <https

[PATCH] testsuite: Fix vfprintf-chk-1.c with -fhardened

2024-02-15 Thread Sam James
chk + jmp vfprintf@PLT ``` 2024-02-15 Sam James gcc/testsuite/ChangeLog: * gcc.c-torture/execute/vfprintf-chk-1.c (__vfprintf_chk): Undefine _FORTIFY_SOURCE to call the real vfprintf. --- The test, AIUI, is trying to test GCC's own basic _chk bits rather than any of

Re: [PATCH wwwdocs] gcc-14: Some very common historic Autoconf probes that no longer work

2024-02-17 Thread Sam James
Florian Weimer writes: > --- > htdocs/gcc-14/porting_to.html | 43 > +++ > 1 file changed, 43 insertions(+) > > diff --git a/htdocs/gcc-14/porting_to.html b/htdocs/gcc-14/porting_to.html > index 123b5e9f..ab65c5e7 100644 > ---

Re: [PATCH wwwdocs] gcc-14: Add code examples for -Wreturn-mismatch

2024-02-17 Thread Sam James
Florian Weimer writes: > --- > htdocs/gcc-14/porting_to.html | 46 > --- > 1 file changed, 43 insertions(+), 3 deletions(-) > > diff --git a/htdocs/gcc-14/porting_to.html b/htdocs/gcc-14/porting_to.html > index bbbaa25a..123b5e9f 100644 > ---

Re: [PATCH] Notes on the warnings-as-errors change in GCC 14

2024-02-07 Thread Sam James
Florian Weimer writes: > --- > htdocs/gcc-14/porting_to.html | 465 > ++ > 1 file changed, 465 insertions(+) > Can't approve but LGTM. Thank you for being so thorough - it'll be helpful when showing upstreams. > diff --git

Re: Introduce -finline-stringops (was: Re: [RFC] Introduce -finline-memset-loops)

2023-12-11 Thread Sam James
Alexandre Oliva via Gcc-patches writes: > On Jun 2, 2023, Alexandre Oliva wrote: > >> Introduce -finline-stringops > > Ping? https://gcc.gnu.org/pipermail/gcc-patches/2023-June/620472.html Should the docs for the x86-specific -minline-all-stringops refer to the new -finline-stringops?

Re: [11 PATCH] libiberty, Darwin: Fix a build warning. [PR112823]

2023-12-01 Thread Sam James
Iain Sandoe writes: > HI Sam, Hi Iain, > > I think this qualifies as obvious (it’s on my list, but I did not get to it > yet, > so go ahead). Thanks. I can't push it myself - could you do that for me? thanks again, sam > > Iain > >> On 2 Dec 2023, at 05:30,

[11 PATCH] libiberty, Darwin: Fix a build warning. [PR112823]

2023-12-01 Thread Sam James
From: Iain Sandoe r12-3005-g220c410162ebece4f missed a cast for the set_32 call. Fixed thus. Signed-off-by: Iain Sandoe Signed-off-by: Sam James libiberty/ChangeLog: PR other/112823 * simple-object-mach-o.c (simple_object_mach_o_write_segment): Cast the first argument

Re: [PATCH 2/6] c: Turn int-conversion warnings into permerrors

2023-12-01 Thread Sam James
Jeff Law writes: > On 12/1/23 18:13, Sam James wrote: >> 钟居哲 writes: >> >>> Hi, This patch cause error on building newlib/glibc/musl on RISC-V port: >>> >>> /work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-newl

Re: [PATCH 2/6] c: Turn int-conversion warnings into permerrors

2023-12-01 Thread Sam James
钟居哲 writes: > Hi, This patch cause error on building newlib/glibc/musl on RISC-V port: > > /work/home/jzzhong/work/toolchain/riscv/build/dev-rv64gcv_zvfh_zfh-lp64d-medany-newlib-spike-debug/../../newlib/libgloss/riscv/sys_access.c:8:40: > error: passing argument 3 of 'syscall_errno' makes

Re: [PATCH v3 00/11] : More warnings as errors by default

2023-11-27 Thread Sam James
Florian Weimer writes: > * Jeff Law: > >> On 11/20/23 02:55, Florian Weimer wrote: >>> This revision addresses Marek's comment about handing >>> -Wdeclaration-missing-parameter-type properly in conjunction with >>> -fpermissive. A new test (permerror-fpermissive-nowarning.c) >>> demonstrates

Re: [PATCH] testsuite: Adjust for the new permerror -Wincompatible-pointer-types

2023-12-06 Thread Sam James
Yang Yujie writes: > On Wed, Dec 06, 2023 at 10:45:22AM -0700, Jeff Law wrote: >> >> >> On 12/6/23 05:12, Florian Weimer wrote: >> > * Yang Yujie: >> > >> > > From: Yang Yujie >> > > Subject: [PATCH] testsuite: Adjust for the new permerror >> > > -Wincompatible-pointer-types >> > > To:

Re: About 31109 - gprofng not built and installed in a combined binutils+gcc build

2024-01-31 Thread Sam James
Richard Biener writes: > On Wed, Jan 31, 2024 at 4:46 AM Vladimir Mezentsev > wrote: >> >> Hi, >> >> I asked in https://sourceware.org/bugzilla/show_bug.cgi?id=31109 >> > I prepared a patch for the releases/gcc-13 branch. >> > Richard Biener rejected my patch for >> this branch. >> >

Re: [PING][PATCH] Include safe-ctype.h after C++ standard headers, to avoid over-poisoning

2024-01-20 Thread Sam James
Sam James writes: > Dimitry Andric writes: > >> Ping. It would be nice to get this QoL fix in. >> > > Yes please - we've been using this in Gentoo since around when it was > first posted. No complaints. > > I cannot approve but it looks good to me. Ping. &g

Re: [PING][PATCH] Include safe-ctype.h after C++ standard headers, to avoid over-poisoning

2024-01-30 Thread Sam James
Sam James writes: > Sam James writes: > >> Dimitry Andric writes: >> >>> Ping. It would be nice to get this QoL fix in. >>> >> >> Yes please - we've been using this in Gentoo since around when it was >> first posted. No complaints. &g

Re: [PING][PATCH] Include safe-ctype.h after C++ standard headers, to avoid over-poisoning

2024-01-30 Thread Sam James
Sam James writes: > [[PGP Signed Part:Undecided]] > > Sam James writes: > >> Sam James writes: >> >>> Dimitry Andric writes: >>> >>>> Ping. It would be nice to get this QoL fix in. >>>> >>> >>> Ye

Re: [PATCH]middle-end: check memory accesses in the destination block [PR113588].

2024-02-03 Thread Sam James
Toon Moene writes: > On 2/1/24 22:33, Tamar Christina wrote: > >> Bootstrapped Regtested on aarch64-none-linux-gnu and x86_64-pc-linux-gnu no >> issues. >> Also checked both with --enable-lto --with-build-config='bootstrap-O3 >> bootstrap-lto' --enable-multilib >> and --enable-lto

Re: [PATCH 1/4] libsanitizer: merge from upstream (c425db2eb558c263)

2023-11-15 Thread Sam James
Jakub Jelinek writes: > Hi! > > The following patch is result of libsanitizer/merge.sh > from c425db2eb558c263 (yesterday evening). > > Bootstrapped/regtested on x86_64-linux and i686-linux (together with > the follow-up 3 patches I'm about to post). > > Iain, could you please check Darwin? >

Re: [PATCH V3 4/7] ira: Support subreg copy

2023-11-18 Thread Sam James
Lehua Ding writes: > Hi Vladimir, > > On 2023/11/17 22:05, Vladimir Makarov wrote: >> On 11/16/23 21:06, Lehua Ding wrote: >>> Hi Vladimir, >>> >>> Thank you so much for your review. Based on your comments, I feel >>> like there are a lot of issues, especially the long compile time >>> issue.

Re: [PATCH V3 4/7] ira: Support subreg copy

2023-11-18 Thread Sam James
Lehua Ding writes: > Hi Sam, > > On 2023/11/18 16:06, Sam James wrote: >> Lehua Ding writes: >> >>> Hi Vladimir, >>> >>> On 2023/11/17 22:05, Vladimir Makarov wrote: >>>> On 11/16/23 21:06, Lehua Ding wrote: >>>>>

Re: Propagate value ranges of return values

2023-11-19 Thread Sam James
Jan Hubicka writes: > Hi, > this patch implements very basic propaation of return value ranges from VRP > pass. This helps std::vector's push_back since we work out value range of > allocated block. This propagates only within single translation unit. I > hoped > we will also do the

Re: [committed] hppa: Revise REG+D address support to allow long displacements before reload

2023-11-16 Thread Sam James
John David Anglin writes: > On 2023-11-16 4:52 p.m., Jeff Law wrote: >> >> >> On 11/16/23 10:54, John David Anglin wrote: >>> Tested on hppa-unknown-linux-gnu and hppa64-hp-hpux11.11.  Committed >>> to trunk. >>> >>> This patch works around problem compiling python3.11 by improving >>> REG+D

Re: [committed] hppa: Revise REG+D address support to allow long displacements before reload

2023-11-16 Thread Sam James
Sam James writes: > John David Anglin writes: > >> On 2023-11-16 4:52 p.m., Jeff Law wrote: >>> >>> >>> On 11/16/23 10:54, John David Anglin wrote: >>>> Tested on hppa-unknown-linux-gnu and hppa64-hp-hpux11.11.  Committed >>>>

Re: [PATCH 3/6] c: Turn -Wimplicit-function-declaration into a pedpermerror [PR91092]

2023-11-13 Thread Sam James
Florian Weimer writes: > In the future, it may make sense to avoid cascading errors from > the implicit declaration, especially its assumed int return type. > This change here only changes the kind of the diagnostic, not > its wording or consequences. > > gcc/c/ > > * doc/invoke.texi

Re: [PATCH 2/6] c: Turn int-conversion warnings into permerrors [PR106416]

2023-11-13 Thread Sam James
Florian Weimer writes: > gcc/ > > * doc/invoke.texi (Warning Options): Document changes. > > gcc/c/ > > * c-typeck.cc (build_conditional_expr): Use pedpermerror for > pointer/integer type mismatches, based on -Wint-conversion. > (pedwarn_pedpermerror_init,

Re: [PATCH 0/6] Turn some C warnings into errors by default

2023-11-13 Thread Sam James
Florian Weimer writes: > This patch series converts the following warnings into errors by > default: > > -Wint-conversion > -Wimplicit-function-declaration > -Wimplicit-int > -Wreturn-mismatch > -Wincompatible-pointer-types > > As explained in the first commit, I decided not to use

Re: [PATCH 4/6] c: Turn -Wimplicit-int into a pedpermerror [PR91093]

2023-11-13 Thread Sam James
Florian Weimer writes: > There is a missed opportunity here to issue spelling diagnostics > in prototype declarations (e.g., for “extern int foo (int32t);”). > > gcc/ > > * doc/invoke.texi (Warning Options): Document changes. > > gcc/c/ > > * c-decl.cc (warn_defaults_to): Call

Re: [PATCH v2 5/8] c: Do not ignore some forms of -Wimplicit-int in system headers

2023-11-14 Thread Sam James
Florian Weimer writes: > Most -Wimplicit-int warnings were unconditionally disabled for system > headers. Only missing types for parameters in old-style function > definitions resulted in warnings. This is inconsistent with the > treatment of other permerrors, which are active in system

Re: [PATCH v2 5/8] c: Do not ignore some forms of -Wimplicit-int in system headers

2023-11-14 Thread Sam James
Florian Weimer writes: > * Sam James: > >> Florian Weimer writes: >> >>> Most -Wimplicit-int warnings were unconditionally disabled for system >>> headers. Only missing types for parameters in old-style function >>> definition

Re: [PATCH v2 0/8] Turn some C warnings into errors by default

2023-11-14 Thread Sam James
Florian Weimer writes: > This new series covers: > > -Wint-conversion > -Wimplicit-function-declaration > -Wimplicit-int > -Wreturn-mismatch > -Wincompatible-pointer-types > -Wdeclaration-missing-parameter-type (new) > > There are now gcc.dg/permerror-*.c tests which track the

Re: [PATCH] C99 testsuite readiness: -fpermissive tests

2023-11-11 Thread Sam James
Florian Weimer writes: > * Eric Gallager: > >>> diff --git a/gcc/testsuite/gcc.c-torture/compile/20080910-1.c >>> b/gcc/testsuite/gcc.c-torture/compile/20080910-1.c >>> index bf32775d401..911fb562790 100644 >>> --- a/gcc/testsuite/gcc.c-torture/compile/20080910-1.c >>> +++

Re: [RFC PATCH] Detecting lifetime-dse issues via Valgrind [PR66487]

2023-11-11 Thread Sam James
exactl...@ispras.ru writes: > From: Daniil Frolov > > PR 66487 is asking to provide sanitizer-like detection for C++ object lifetime > violations that are worked around with -fno-lifetime-dse in Firefox, LLVM, > OpenJade. > > The discussion in the PR was centered around extending MSan, but

Re: [RFC PATCH] Detecting lifetime-dse issues via Valgrind [PR66487]

2023-11-12 Thread Sam James
Alexander Monakov writes: > On Sat, 11 Nov 2023, Sam James wrote: > >> > Valgrind client requests are offered as macros that emit inline asm. For >> > use >> > in code generation, we need to wrap it in a built-in. We know that >> > implementing >

Re: [RFC PATCH] Detecting lifetime-dse issues via Valgrind [PR66487]

2023-11-12 Thread Sam James
Sam James writes: > Alexander Monakov writes: > [...] >> >> I'm very curious what you mean by "this has come up with LLVM [] too": >> ttbomk, >> LLVM doesn't do such lifetime-based optimization yet, which is why compiling >> LLVM with LLVM doesn'

Re: [PATCH] libstdc++: hashtable: No need to update before begin node in _M_remove_bucket_begin

2024-01-16 Thread Sam James
Huanghui Nie writes: > Hi. Please CC the libstdc++ LM for libstdc++ patches, per https://gcc.gnu.org/onlinedocs/libstdc++/manual/appendix_contributing.html#list.patches. > [...]

Re: [PATCH 0/2] mmap: Avoid the sanitizer configure check failure

2024-04-09 Thread Sam James
"H.J. Lu" writes: > When -fsanitize=address,undefined is used to build, the mmap configure > check failed with I think Paul fixed this in autoconf commit 09b6e78d1592ce10fdc975025d699ee41444aa3f, so we should add a comment about that so we can clean this up in future. > >

Re: [wwwdocs] gcc-14: Mention that some warnings are now errors

2024-04-13 Thread Sam James
Eric Gallager writes: > On Sat, Apr 13, 2024 at 5:51 AM Sebastian Huber > wrote: >> >> --- >> htdocs/gcc-14/changes.html | 11 +++ >> 1 file changed, 11 insertions(+) >> >> diff --git a/htdocs/gcc-14/changes.html b/htdocs/gcc-14/changes.html >> index 8ac08e9a..a183fad8 100644 >> ---

Re: [PATCH] Include safe-ctype.h after C++ standard headers, to avoid over-poisoning

2024-03-06 Thread Sam James
FX Coudert writes: > I would like to patch this patch from September 2023: > https://gcc.gnu.org/pipermail/gcc-patches/2023-September/631611.html > > This bug is now hitting macOS in the latest version of Xcode (it was > originally seen on freebsd). > I confirm that the patch is restoring

Re: [PATCH] testsuite: Fix vfprintf-chk-1.c with -fhardened

2024-03-12 Thread Sam James
Sam James writes: > With _FORTIFY_SOURCE >= 2 (enabled by -fhardened), vfprintf-chk-1.c's > __vfprintf_chk ends up calling __vprintf_chk rather than vprintf. > > ``` > --- a/fortify.s > +++ b/no-fortify.s > @@ -8,27 +8,28 @@ > [...] > __vfprintf_chk

Re: [PATCH] Predefine __STRICT_ALIGN__ if STRICT_ALIGNMENT

2024-03-17 Thread Sam James
YunQiang Su writes: > Arm32 predefines __ARM_FEATURE_UNALIGNED if -mno-unaligned-access, > and RISC-V predefines __riscv_misaligned_avoid, while other ports > that support -mstrict-align/-mno-unaligned-access don't have such > macro, and these backend macros are only avaiable for c-family. >

[PATCH v2] contrib: Improve dg-extract-results.sh's Python detection

2024-03-07 Thread Sam James
'python' on some systems (e.g. SLES 15) might be Python 2. Prefer python3, then python, then python2 (as the script still tries to work there). contrib/ChangeLog: * dg-extract-results.sh: Check for python3 before python. Check for python2 last. --- v2: Add python2 and drop EPYTHON.

[PATCH] contrib: Improve dg-extract-results.sh's Python detection

2024-03-07 Thread Sam James
'python' on some systems (e.g. SLES 15) might be Python 2. Prefer ${EPYTHON} if defined (used by Gentoo's python-exec wrapping), then python3, then python. contrib/ChangeLog: * dg-extract-results.sh: Check for python3 before python. --- contrib/dg-extract-results.sh | 17 ++---

Re: [PATCH] contrib: Improve dg-extract-results.sh's Python detection

2024-03-07 Thread Sam James
Jakub Jelinek writes: > On Thu, Mar 07, 2024 at 02:16:37PM +0000, Sam James wrote: >> 'python' on some systems (e.g. SLES 15) might be Python 2. Prefer ${EPYTHON} >> if defined (used by Gentoo's python-exec wrapping), then python3, then >> python. > > I'd say EPY

Re: [PATCH v3 06/11] c: Turn -Wimplicit-function-declaration into a permerror

2024-04-09 Thread Sam James
Sebastian Huber writes: > On 20.11.23 10:56, Florian Weimer wrote: >> In the future, it may make sense to avoid cascading errors from >> the implicit declaration, especially its assumed int return type. >> This change here only changes the kind of the diagnostic, not >> its wording or

Re: [PATCH v3 06/11] c: Turn -Wimplicit-function-declaration into a permerror

2024-04-09 Thread Sam James
Sebastian Huber writes: > On 09.04.24 14:10, Sam James wrote: >> Sebastian Huber writes: >> >>> On 20.11.23 10:56, Florian Weimer wrote: >>>> In the future, it may make sense to avoid cascading errors from >>>> the implicit declaration, especial

Re: [PATCH 0/2] Condition coverage fixes

2024-04-08 Thread Sam James
Jørgen Kvalsvik writes: > Hi, > > I propose these fixes for the current issues with the condition > coverage. > > Rainer, I propose to simply delete the test with __sigsetjmp. I don't > think it actually detects anything reasonable any more, I kept it around > to prevent a regression. Since then

Re: [PATCH] Add ia64*-*-* to the list of obsolete targets

2024-02-23 Thread Sam James
Richard Biener writes: > The following deprecates ia64*-*-* for GCC 14. Since we plan to > force LRA for GCC 15 and the target only has slim chances of getting > updated this notifies people in advance. Given both Linux and > glibc have axed the target further development is also made

Re: [PATCH v2] Do not emulate vectors containing floats.

2024-02-23 Thread Sam James
Juergen Christ writes: > The emulation via word mode tries to perform integer arithmetic on floating > point values instead of floating point arithmetic. This leads to > mis-compilations. Is the bug ref + test missing? > > Failure occured on s390x on these existing test cases: >

Re: [PATCH] Fix -Wstringop-overflow warning in 23_containers/vector/types/1.cc

2024-05-27 Thread Sam James
François Dumont writes: > In C++98 this test fails with: For this, and your other -Wfree-nonheap-object patches, could you see if it helps with any of the bugs reported for both -Wstringop-overflow and -Wfree-nonheap-object in libstdc++? There's a bunch of (possible) dupes that it'd be worth

[PATCH] modula2: Fully respect DESTDIR in texi rule

2024-05-20 Thread Sam James
This was originally reported in Gentoo at https://bugs.gentoo.org/930014. 2024-05-20 Sam James gcc/m2/ * Make-lang.in (m2.install-info): Pass --destdir for dir index. --- gcc/m2/Make-lang.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gcc/m2/Make-lang.in b/gcc

Re: [PATCH] LoongArch: Fix unintentional bash-ism in r14-3665.

2023-09-06 Thread Sam James via Gcc-patches
Yang Yujie writes: > gcc/ChangeLog: > > * config.gcc: remove non-POSIX syntax "<<<". > --- Thanks, I was just about to report this. > gcc/config.gcc | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/gcc/config.gcc b/gcc/config.gcc > index

Re: [PATCH] [11/12/13/14 Regression] ABI break in _Hash_node_value_base since GCC 11 [PR 111050]

2023-09-10 Thread Sam James via Gcc-patches
François Dumont via Gcc-patches writes: > Following confirmation of the fix by TC here is the patch where I'm > simply adding a 'constexpr' on _M_next(). > > Please let me know this ChangeLog entry is correct. I would prefer > this patch to be assigned to 'TC' with me as co-author but I don't

Re: RFC: Introduce -fhardened to enable security-related flags

2023-09-16 Thread Sam James via Gcc-patches
Hans-Peter Nilsson via Gcc-patches writes: >> Date: Tue, 29 Aug 2023 15:42:27 -0400 >> From: Marek Polacek via Gcc-patches > >> Surely, there must be no ABI impact, the option cannot cause >> severe performance issues, > >> Currently, -fhardened enables: > ... >>

Re: RFC: Introduce -fhardened to enable security-related flags

2023-08-29 Thread Sam James via Gcc-patches
Marek Polacek via Gcc-patches writes: > Improving the security of software has been a major trend in the recent > years. Fortunately, GCC offers a wide variety of flags that enable extra > hardening. These flags aren't enabled by default, though. And since > there are a lot of hardening

Re: RFC: Introduce -fhardened to enable security-related flags

2023-09-18 Thread Sam James via Gcc-patches
Hans-Peter Nilsson writes: >> From: Sam James >> Date: Sun, 17 Sep 2023 05:00:37 +0100 > >> Hans-Peter Nilsson via Gcc-patches writes: >> >> >> Date: Tue, 29 Aug 2023 15:42:27 -0400 >> >> From: Marek Polacek via Gcc-patches >> >

Re: [PATCH] Add clang's invalid-noreturn warning flag

2023-08-15 Thread Sam James via Gcc-patches
Julian Waters via Gcc-patches writes: > Anyone? Please see https://gcc.gnu.org/contribute.html#patches, specifically the "Pinging patches, Getting patches applied" section.

Re: [PATCH] maintainer-scripts/gcc_release: compress xz in parallel

2022-11-11 Thread Sam James via Gcc-patches
> On 8 Nov 2022, at 07:14, Sam James wrote: > > 1. This should speed up decompression for folks, as parallel xz > creates a different archive which can be decompressed in parallel. > > Note that this different method is enabled by default in a new > xz release

Re: [PATCH] maintainer-scripts/gcc_release: compress xz in parallel

2022-11-17 Thread Sam James via Gcc-patches
> On 8 Nov 2022, at 07:14, Sam James wrote: > > 1. This should speed up decompression for folks, as parallel xz > creates a different archive which can be decompressed in parallel. > > Note that this different method is enabled by default in a new > xz release

Re: Announcement: Porting the Docs to Sphinx - tomorrow

2022-11-08 Thread Sam James via Gcc-patches
> On 8 Nov 2022, at 13:55, Martin Liška wrote: > > Hi. > > Tomorrow in the morning (UTC time), I'm going to migrate the documentation > to Sphinx. The final version of the branch can be seen here: > > $ git fetch origin refs/users/marxin/heads/sphinx-final > $ git co FETCH_HEAD > > URL:

Re: Announcement: Porting the Docs to Sphinx - tomorrow

2022-11-08 Thread Sam James via Gcc-patches
> On 9 Nov 2022, at 00:00, Joseph Myers wrote: > > On Tue, 8 Nov 2022, Sam James via Gcc wrote: > >> Yes, please (https://gcc.gnu.org/bugzilla/show_bug.cgi?id=106899) >> even for snapshots? Pretty please? :) > > I think we want snapshots to come o

Re: [PATCH] maintainer-scripts/gcc_release: compress xz in parallel

2022-11-07 Thread Sam James via Gcc-patches
> On 8 Nov 2022, at 07:34, Eric Botcazou wrote: > >> I build GCC regularly from the weekly snapshots >> and so the decompression time adds up. > > But is very largely dwarfed by the build time of the compiler, isn't it? > It is. It's no big deal if the patch isn't accepted, it's just

Re: [PATCH] maintainer-scripts/gcc_release: compress xz in parallel

2022-11-07 Thread Sam James via Gcc-patches
> On 8 Nov 2022, at 07:36, Sam James wrote: > > > >> On 8 Nov 2022, at 07:34, Eric Botcazou wrote: >> >>> I build GCC regularly from the weekly snapshots >>> and so the decompression time adds up. >> >> But is very la

[PATCH] maintainer-scripts/gcc_release: compress xz in parallel

2022-11-07 Thread Sam James via Gcc-patches
ble. So, if a different number of threads is preferred, it's fine to set e.g. -T2, etc. Signed-off-by: Sam James --- maintainer-scripts/gcc_release | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/maintainer-scripts/gcc_release b/maintainer-scripts/gcc_release in

Re: [PATCH] maintainer-scripts/gcc_release: compress xz in parallel

2022-11-07 Thread Sam James via Gcc-patches
> On 8 Nov 2022, at 07:33, Xi Ruoyao wrote: > > On Tue, 2022-11-08 at 07:14 +0000, Sam James via Gcc-patches wrote: >> 1. This should speed up decompression for folks, as parallel xz >>creates a different archive which can be decompressed in parallel. >> >

Re: [PATCH] maintainer-scripts/gcc_release: compress xz in parallel

2022-11-08 Thread Sam James via Gcc-patches
> On 8 Nov 2022, at 08:52, Jakub Jelinek wrote: > > On Tue, Nov 08, 2022 at 07:40:02AM +0000, Sam James wrote: >>> On 8 Nov 2022, at 07:33, Xi Ruoyao wrote: >>> I'm wondering if running xz -T0 on different machines (with different >>> core numbers) m

[PATCH v2] RISC-V: Avoid calloc() poisoning on musl

2023-03-11 Thread Sam James via Gcc-patches
config/riscv/genrvv-type-indexer.cc: Avoid calloc() poisoning on musl by adding include. v2: fix changelog. Signed-off-by: Sam James --- gcc/ChangeLog | 5 + gcc/config/riscv/genrvv-type-indexer.cc | 1 + 2 files changed, 6 insertions(+) diff --git a

[PATCH] RISC-V: Avoid calloc() poisoning on musl

2023-03-11 Thread Sam James via Gcc-patches
config/riscv/genrvv-type-indexer.cc: Add missing include. Signed-off-by: Sam James --- gcc/ChangeLog | 5 + gcc/config/riscv/genrvv-type-indexer.cc | 1 + 2 files changed, 6 insertions(+) diff --git a/gcc/ChangeLog b/gcc/ChangeLog index c9e557ce833..7783b2f4

[PATCH v3] gcc: Drop obsolete INCLUDE_PTHREAD_H

2023-03-12 Thread Sam James via Gcc-patches
This is no longer used since 0a62889c7a155f8ed971860d68870dc9c46bb004, so let's clean it up. gcc/ChangeLog: * system.h: Drop unused INCLUDE_PTHREAD_H. Signed-off-by: Sam James --- gcc/system.h | 4 1 file changed, 4 deletions(-) diff --git a/gcc/system.h b/gcc/system.h index

[PATCH v4 1/2] RISC-V: Avoid calloc() poisoning on musl

2023-03-13 Thread Sam James via Gcc-patches
config/riscv/genrvv-type-indexer.cc: Avoid calloc() poisoning on musl by including earlier. * system.h: Add INCLUDE_SSTREAM. Signed-off-by: Sam James --- gcc/config/riscv/genrvv-type-indexer.cc | 2 +- gcc/system.h| 4 2 files changed, 5 inser

[PATCH v4 2/2] gcc: Drop obsolete INCLUDE_PTHREAD_H

2023-03-13 Thread Sam James via Gcc-patches
This is no longer used since 0a62889c7a155f8ed971860d68870dc9c46bb004, so let's clean it up. gcc/ChangeLog: * system.h: Drop unused INCLUDE_PTHREAD_H. Signed-off-by: Sam James --- gcc/system.h | 4 1 file changed, 4 deletions(-) diff --git a/gcc/system.h b/gcc/system.h index

Re: [PATCH v4 1/2] RISC-V: Avoid calloc() poisoning on musl

2023-03-14 Thread Sam James via Gcc-patches
Kito Cheng writes: > RISC-V part is ok, and I assume you didn't have write access so I'm > gonna push that since the system.h change also got approved :) > > On Tue, Mar 14, 2023 at 5:07 PM Richard Biener via Gcc-patches > wrote: >> >> On Tue, Mar 14, 2023 at 1:24 A

Re: [PATCH v4 1/2] RISC-V: Avoid calloc() poisoning on musl

2023-03-14 Thread Sam James via Gcc-patches
>> >> On Tue, Mar 14, 2023 at 5:07 PM Richard Biener via Gcc-patches >> wrote: >> > >> > On Tue, Mar 14, 2023 at 1:24 AM Sam James via Gcc-patches >> > wrote: >> > > >> > > This fixes errors like: >> > > ``` >&

Re: [PATCH v5] gcc: Drop obsolete INCLUDE_PTHREAD_H

2023-04-18 Thread Sam James via Gcc-patches
Jeff Law writes: > On 4/2/23 15:33, Sam James wrote: >> gcc/ChangeLog: >> * system.h: Drop unused INCLUDE_PTHREAD_H. > THanks. I've pushed this to the trunk. Cheers Jeff! > jeff best, sam signature.asc Description: PGP signature

[PATCH] testsuite: Add testcase for sparc ICE [PR105573]

2023-04-21 Thread Sam James via Gcc-patches
r11-10018-g33914983cf3734c2f8079963ba49fcc117499ef3 fixed PR105312 and added a test case for target/arm but the duplicate PR105573 has a test case for target/sparc that was uncommitted until now. 2023-04-21 Sam James PR tree-optimization/105312 PR target/105573 * gcc

[PATCH v2] testsuite: Add testcase for sparc ICE [PR105573]

2023-04-24 Thread Sam James via Gcc-patches
r11-10018-g33914983cf3734c2f8079963ba49fcc117499ef3 fixed PR105312 and added a test case for target/arm but the duplicate PR105573 has a test case for target/sparc that was uncommitted until now. 2023-04-21 Sam James PR tree-optimization/105312 PR target/105573 * gcc

Re: [PATCH] testsuite: Add testcase for sparc ICE [PR105573]

2023-04-24 Thread Sam James via Gcc-patches
Richard Biener writes: > On Fri, 21 Apr 2023, Sam James wrote: > >> r11-10018-g33914983cf3734c2f8079963ba49fcc117499ef3 fixed PR105312 and added >> a test case for target/arm but the duplicate PR105573 has a test case for >> target/sparc that was uncommitted until now

  1   2   >