Re: [wwwdocs] AVR entry in readings.htmls

2018-03-11 Thread Denis Chertykov
This is a new one. http://www.microchip.com/design-centers/8-bit/microchip-avr-mcus 2018-03-10 20:15 GMT+04:00 Gerald Pfeifer : > It appears this link at atmel.com has been taken down without > what appears a replacement, so I applied the patch below. > > Denis, if you have a

[PATCH,avr] Fix PR84209 code issue due to post-reload split of SP into 2 QI regs

2018-02-07 Thread Denis Chertykov
Committed. 2018-01-09 Georg-Johann Lay PR target/84209 * config/avr/avr.h (GENERAL_REGNO_P, GENERAL_REG_P): New macros. * config/avr/avr.md: Only post-reload split REG-REG moves if either register is REGERAL_REG_P. --- config/avr/avr.h (revision

Re: [patch,avr] Implement PR83737

2018-01-08 Thread Denis Chertykov
2018-01-08 20:19 GMT+04:00 Georg-Johann Lay : > This PR skips saving of any registers in main. > > Attribute OS_main can do this as well, however we can just drop > any saves / restores in all optimized compilation -- not even > the test suite needs these saves. > > The feature can

Re: [patch,avr] Fir PR91910: ICE for bad attribute "address".

2017-08-21 Thread Denis Chertykov
2017-08-21 16:35 GMT+04:00 Georg-Johann Lay : > "address" attribute only must be specified with VARs, > yet the compiler dived into attribute analysis for > non-VARs, resulting in ICE. > > This patch also adds OPT_Wattributes as warning filter. > > Ok to apply? Approved. Please

Re: [patch 2/2,avr] PR49847: Add hook to place read-only lookup-tables in named address-space

2017-07-27 Thread Denis Chertykov
2017-07-27 16:50 GMT+04:00 Georg-Johann Lay : > On 27.07.2017 14:29, Georg-Johann Lay wrote: >> >> For some targets, the best place to put read-only lookup tables as >> generated by -ftree-switch-conversion is not the generic address space >> but some target specific address space.

Re: [patch,avr,doc] Re-layout "AVR Built-in Functions"

2017-07-20 Thread Denis Chertykov
Approved. 2017-07-20 18:28 GMT+04:00 Georg-Johann Lay : > Hi, this is a re-layout of mentioned section in extend.texi. > > Purpose is to have a unified layout where the explanation has > a farther indentation than the item (function) to be explained. > > Ok for trunk? > > Johann >

Re: [patch,avr] Fix PR80929, work around middle-end PR81444

2017-07-15 Thread Denis Chertykov
2017-07-14 18:16 GMT+04:00 Georg-Johann Lay : > Hi, this patch restores some of the divmod handling. > > It addresses two issues: > > 1) rtx_costs might be called with code = LSHIFTRT for a mul_highpart. This > is the case when outer_code = TRUNCATE. This patch uses a new function

Re: [patch,avr] PR81407: Error if progmem variable needs constructing.

2017-07-12 Thread Denis Chertykov
2017-07-12 12:45 GMT+04:00 Georg-Johann Lay : > Hi, if the C++ front-end decides that something will need constructing, > it will silently put the stuff into .rodata so that according > pgm_read_xxx will read garbage from .progmem. > > As proposed by Jason, this patch diagnoses such

Re: [patch,avr][Ping #3] PR81075: Move jump-tables out of .text

2017-07-07 Thread Denis Chertykov
I'm sorry for so long delay. Please apply the patch. 2017-07-05 14:19 GMT+04:00 Georg-Johann Lay : > Ping #3 > > http://gcc.gnu.org/ml/gcc-patches/2017-06/msg01029.html > > As avr maintainers are off-line, would a global maintainer have > a look at this? > > Thanks, > > Johann > >

Re: [patch,avr] Fix PR20296 / PR81268: Better ISR prologues / epilogues

2017-07-07 Thread Denis Chertykov
2017-07-07 18:31 GMT+04:00 Georg-Johann Lay : > Hi, > > this patch addresses a very old issue, the non-optimal > generation of ISR prologues and epilogues. > > As GAS now provides the __gcc_isr pseudo instruction to > overcome some problems, see > >

Re: [patch,avr] Add support for devices with flash accessible by LD.

2017-06-12 Thread Denis Chertykov
2017-06-12 11:40 GMT+04:00 Georg-Johann Lay : > On 12.06.2017 08:30, Pitchumani Sivanupandi wrote: >> >> On Friday 09 June 2017 03:59 PM, Georg-Johann Lay wrote: >>> >>> Hi, >>> >>> This patch adds support for devices that can access flash memory >>> by LD* instructions, hence there

Re: [patch,avr] Simplify genmultilib.awk

2017-05-22 Thread Denis Chertykov
2017-05-22 15:37 GMT+04:00 Georg-Johann Lay : > This patch simplifies genmultilib.awk so that it generates > MULTILIB_REQUIRED instead of the complement, MULTILIB_EXCEPTIONS. > > The current awk script dates back to the days when we mapped > all the > 200 devices to the mmcu core

Re: [patch,avr] Fix PR80462

2017-04-19 Thread Denis Chertykov
2017-04-19 14:43 GMT+04:00 Georg-Johann Lay : > This PR is about an incorrect warning for variables in progmem > without initializer. If the variable is just an alias like in > and with -fmerge-all-constants > > const __flash char string1[] = "same string"; > const __flash char

Re: install.texi and avr (was: Target maintainers: doc/install.texi love and care)

2017-03-13 Thread Denis Chertykov
2017-03-12 15:32 GMT+04:00 Gerald Pfeifer : > On Sun, 12 Mar 2017, Gerald Pfeifer wrote: >> Also, I'm offering help around one particular aspect I noticed: >> >> References to dependencies on really, really old versions of >> binutils (talking 10+ years here) which I think we

Re: [patch,avr] Tweak addhi3_zero_extend.

2017-02-06 Thread Denis Chertykov
2017-02-06 14:03 GMT+04:00 Georg-Johann Lay : > This patch adds an alternative to addhi3_zero_extend for the case > where output operand and the 8-bit addend happen to reside > the the same register. Without the patch this might lead > to additional reloads to satisfy the

Re: Ping#1: [patch,avr]: For PR78883 #3

2017-02-06 Thread Denis Chertykov
2017-02-06 14:06 GMT+04:00 Georg-Johann Lay : > https://gcc.gnu.org/ml/gcc-patches/2017-01/msg00926.html > > On 13.01.2017 12:53, Georg-Johann Lay wrote: >> >> This is 3rd way to fix PR78883 by rejecting malicious expressions >> from the start. >> >> Ok for trunk? >> >> Johann >> >>

Re: [patch,avr]: Increase branch costs after reload.

2017-01-16 Thread Denis Chertykov
2017-01-13 17:28 GMT+04:00 Georg-Johann Lay : > This adds a penalty of 4 to the post-reload branch costs. > > Purpose is reduce the number of out-of-line blocks like in > > unsigned long variant5 (unsigned in) > { > unsigned long out = 0; > if (in & (1 << 0)) out |= 0xful <<

Re: [patch,avr] PR78883: Implement CANNOT_CHANGE_MODE_CLASS.

2017-01-06 Thread Denis Chertykov
2017-01-02 19:22 GMT+04:00 Georg-Johann Lay : > On 02.01.2017 15:54, Dominik Vogt wrote: >> >> On Mon, Jan 02, 2017 at 03:47:43PM +0100, Georg-Johann Lay wrote: >>> >>> This fixes PR78883 which is a problem in reload revealed by a >>> change to combine.c. The fix is as proposed by

Re: Ping #1: [patch,testsuite,avr]: Filter-out -mmcu= from options for tests that set -mmcu=

2016-12-13 Thread Denis Chertykov
2016-12-13 13:36 GMT+04:00 Georg-Johann Lay : > Ping #1 > > As I explained below, the solution taken be arm (pruning output) > does not work here. Approved. Please apply your patch. > > Johann > > On 02.12.2016 11:21, Georg-Johann Lay wrote: >> >> On 01.12.2016 17:40, Mike Stump

Re: [patch,avr] Clean up n_flash field from MCU information.

2016-12-01 Thread Denis Chertykov
2016-12-01 12:26 GMT+03:00 Georg-Johann Lay : > The introduction of the flash_size field in avr_mcu_t rendered the n_flash > field redundant. This patch computes the value of n_flash as needed from > flash_size and cleans up n_flash. > > Ok for trunk? > > Johann > > gcc/ >

Re: [patch,avr] Document how to avoid progmem on AVR_TINY.

2016-12-01 Thread Denis Chertykov
2016-12-01 17:28 GMT+03:00 Georg-Johann Lay : > This adds to the documentation a hint how to set up a linker description > file that avoids progmem altogether any without the usual overhead of > locating read-only data in RAM. The proposed linker description file is > completely

Re: Ping: Re: [patch, avr] Add flash size to device info and make wrap around default

2016-11-30 Thread Denis Chertykov
2016-11-30 18:09 GMT+03:00 Georg-Johann Lay <a...@gjlay.de>: > On 30.11.2016 07:27, Pitchumani Sivanupandi wrote: >> >> On Tuesday 29 November 2016 10:06 PM, Denis Chertykov wrote: >>> >>> 2016-11-28 10:17 GMT+03:00 Pitchumani Sivanupandi &g

Re: Ping: Re: [patch, avr] Add flash size to device info and make wrap around default

2016-11-29 Thread Denis Chertykov
2016-11-28 10:17 GMT+03:00 Pitchumani Sivanupandi <pitchumani.sivanupa...@microchip.com>: > On Saturday 26 November 2016 12:11 AM, Denis Chertykov wrote: >> >> I'm sorry for delay. >> >> I have a problem with the patch: >> (Stripping trailing CRs from patch

Re: [patch,avr]: Improve code as of PR41076

2016-11-25 Thread Denis Chertykov
2016-11-25 18:34 GMT+03:00 Georg-Johann Lay : > Mentioned PR is about composing 16-bit values out of 8-bit values which due > to integer promotions likes to work on 16-bit values. > > The patch adds 3 combiner patterns to catch such situations and then split > after reload. Some

Re: Ping: Re: [patch, avr] Add flash size to device info and make wrap around default

2016-11-25 Thread Denis Chertykov
to disable.) patching file specs.h Hunk #1 succeeded at 58 (offset 1 line). Hunk #2 succeeded at 66 (offset 1 line). 2016-11-22 23:27 GMT+03:00 Georg-Johann Lay <a...@gjlay.de>: > Denis Chertykov schrieb: >> >> Do you have any objections, George ? > > > No, the last de

Re: Ping: Re: [patch, avr] Add flash size to device info and make wrap around default

2016-11-22 Thread Denis Chertykov
Do you have any objections, George ? 2016-11-22 8:05 GMT+03:00 Pitchumani Sivanupandi : > Ping! > > On Monday 14 November 2016 07:03 PM, Pitchumani Sivanupandi wrote: >> >> Ping! >> >> On Thursday 10 November 2016 01:53 PM, Pitchumani Sivanupandi wrote: >>>

Re: [patch,avr] Fix PR60300: Minor prologue improvement.

2016-11-22 Thread Denis Chertykov
2016-11-22 15:41 GMT+03:00 Georg-Johann Lay : > This patch is a minor improvement of prologue length. It now allows frame > sizes of up to 11 to be allocated by RCALL + PUSH 0 sequences but limits the > number of RCALLs to 3. > > The PR has some discussion on size vs. speed

Re: [patch,avr] Disallow LDS / STS for .rodata on AVR_TINY.

2016-11-20 Thread Denis Chertykov
2016-11-18 16:31 GMT+03:00 Georg-Johann Lay : > Currently, Binutils still comes with an AVR_TINY linker description file > which puts .rodata into RAM so that LDS is applicable for reading such > objects. > > However, as these devices come with a linearised address model, linker >

Re: [patch,avr] Add new option -mabsdata.

2016-11-11 Thread Denis Chertykov
2016-11-09 19:55 GMT+03:00 Sandra Loosemore : > On 11/07/2016 05:54 AM, Georg-Johann Lay wrote: >> >> @@ -15261,6 +15262,13 @@ GCC supports the following AVR devices a >> >> @include avr-mmcu.texi >> >> +@item -mabsdata >> +@opindex mabsdata >> + >> +Assume that all data

Re: [patch,avr] Fix PR71676 / PR71678: casesi not working for SImode / Dimode

2016-10-25 Thread Denis Chertykov
2016-10-24 13:33 GMT+03:00 Georg-Johann Lay : > This fixes issues with casesi that originate from taking hard coded > subreg:HI of the SImode switch value: > > * The subreg is cutting away the upper bytes which is wrong code if the > switch actually operates on a value > 16 bits. >

Re: [patch,avr] Introduce absdata attribute to allow LDS /STS on Tiny

2016-10-14 Thread Denis Chertykov
2016-10-12 14:32 GMT+03:00 Georg-Johann Lay : > This patch introduces a new variable attribute "absdata". > > Reduced Tiny cores have only a limited range of addresses 0x40..0xbf which > can be handled by LDS / STS directly. The attribute allows the user to > assert that it is

Re: [patch,avr] Use avr-passes.def to register passes.

2016-10-11 Thread Denis Chertykov
2016-10-10 16:36 GMT+03:00 Georg-Johann Lay : > This is a code clean-up using the new -passes.def feature in order > to register avr target passes and to get -fdump-xxx etc. to work for such > passes. > > Ok for trunk? > > Johann > > * config/avr/avr-passes.def: New file. >

Re: [patch,wwwdocs] Add v7 AVR release notes.

2016-10-07 Thread Denis Chertykov
2016-10-07 17:06 GMT+03:00 Georg-Johann Lay : > Mentioning some AVR target specific improvements. > > Ok? > Ok.

Re: [Patch, avr] Backport fix for PR 65210 to gcc-5-branch

2016-09-26 Thread Denis Chertykov
Approved. Please commit. 2016-09-26 15:30 GMT+03:00 Senthil Kumar Selvaraj : > Ping! > > Regards > Senthil > Senthil Kumar Selvaraj writes: > >> Hi, >> >> Is it ok to backport PR 65210 to gcc-5-branch? The patch is already in >> 6.x and trunk. >> >> Regards

Re: [Patch, avr] Provide correct LD offset bound in avr_address_cost

2016-09-22 Thread Denis Chertykov
2016-09-22 7:52 GMT+03:00 Senthil Kumar Selvaraj : > Hi, > > This patch fixes cost computation in avr_address_cost - instead of the > hardcoded 61, it uses the already existing MAX_LD_OFFSET(mode) macro. > > This showed up when investigating a code size

Re: [patch,avr] Fix PR77326: CC_NONE might clobber condition code

2016-09-20 Thread Denis Chertykov
2016-09-20 13:07 GMT+03:00 Georg-Johann Lay : > This fixes the case of CC_NONE (insn attribute for cc is "none"): > > Even in cases where the instructions of an insn do not change the condition > code of the machine, they still might change some registers by clobber, set, > etc. If

Re: [BUILDROBOT] avr broken

2016-08-17 Thread Denis Chertykov
2016-08-16 21:26 GMT+03:00 Nathan Sidwell : > On 08/16/16 13:04, Jan-Benedict Glaw wrote: > >> That'll probably work. But after all, I'm not an AVR maintainer (not >> even an user), but just running the Build Robot. > > > Does your robot approve? :) > I'm an AVR maintainer. The

Re: [patch, avr] Fix mmcu to specs issues

2016-08-08 Thread Denis Chertykov
Sorry for delay. Committed. 2016-08-08 9:17 GMT+03:00 Pitchumani Sivanupandi : > Ping! > > > On Friday 29 July 2016 05:14 PM, Pitchumani Sivanupandi wrote: >> >> On Friday 29 July 2016 02:06 PM, Georg-Johann Lay wrote: >>> >>> On 28.07.2016 13:50, Pitchumani

Re: [patch,avr] PR 55181 work around do_store_flag producing shifts for bit extractions

2016-08-03 Thread Denis Chertykov
2016-08-03 18:41 GMT+03:00 Georg-Johann Lay : > do_store_flag has hard-coded right shift for testing a bit, I found no way > to let the backend direct expr.c into generating an extzv. As rectifying > the middle-end is beyond by time frame, here is yet another kludge to catch > the

Re: [patch,avr] PR70677: Use -fno-caller-saves for avr

2016-08-01 Thread Denis Chertykov
2016-08-01 15:17 GMT+03:00 Georg-Johann Lay : > Problem with -fcaller-saves is that there are situations where it triggers > an expensive frame just to store a variable around a function call even > though there are plenty of call-saved registers. > > Example: > > typedef

Re: [patch,avr] Adjust insn length of forward branches.

2016-08-01 Thread Denis Chertykov
2016-08-01 10:56 GMT+03:00 Georg-Johann Lay : > The length computation of "branch" flavour insn length attribute computed a > length one instruction too short, e.g. in the following test case: > > #define N0(N) if (X++ < N) __builtin_avr_nop() > > #define N1(N)

Re: [patch,avr] Add built-in function to emit NOPs

2016-08-01 Thread Denis Chertykov
2016-08-01 11:23 GMT+03:00 Georg-Johann Lay : > This adds a new built-in function that inserts a requested number of NOPs > into the instruction stream. I found it useful when testing avr-gcc. > > Ok to apply? > > > Johann > > > * doc/extend.texi (AVR Built-in Functions):

Re: [patch,avr] remove secondary_reload hook implementation

2016-07-22 Thread Denis Chertykov
2016-07-21 18:33 GMT+03:00 Georg-Johann Lay : > This removes avr's TARGET_SECONDARY_RELOAD implementation which never worked > as expected... > > Its intention was to provide an 8-bit scratch register for loads from > non-generic address-spaces as they might need to set RAMPZ to the

Re: [patch,avr] More insns to handle (inverted) bit-bit moves

2016-07-21 Thread Denis Chertykov
2016-07-20 15:59 GMT+03:00 Georg-Johann Lay : > This adds some insns that set a destination bit expressed as zero_extract to > a source bit expressed as extract, right shift, and simple combinations > thereof. > > Purpose is smaller code and to avoid costly extracts or shifts. This

Re: [patch,avr] Slightly better memory accesses on avr_tiny

2016-07-19 Thread Denis Chertykov
2016-07-19 13:31 GMT+03:00 Georg-Johann Lay : > This patch tries to improve the bloated code we are currently generating for > AVR_TINY. It's mostly about printing the memory loads and stores and more > usage of reg_unused_after to print shorter instruction sequences in some >

Re: [patch,avr] make progmem work on AVR_TINY, use TARGET_ADDR_SPACE_DIAGNOSE_USAGE

2016-07-18 Thread Denis Chertykov
2016-07-15 18:26 GMT+03:00 Georg-Johann Lay : > This patch needs new hook TARGET_ADDR_SPACE_DIAGNOSE_USAGE: > https://gcc.gnu.org/ml/gcc-patches/2016-07/msg00839.html > > This patch turns attribute progmem into a working feature for AVR_TINY > cores. > > It boils down to adding

Re: [patch,avr] minor tweaks for 8-bit operations

2016-07-14 Thread Denis Chertykov
2016-07-13 14:12 GMT+03:00 Georg-Johann Lay : > > This patch contains some unrelated tweaks > > - Supplying no-ldregs variant for andqi3, iorqi3 where a const_int mask > affects only 1 bit > > - Some patterns that match situations with zero_extend that can be performed > with less

Re: [patch, avr,wwwdocs] PR 58655

2016-06-28 Thread Denis Chertykov
Committed. 2016-06-27 14:41 GMT+03:00 Pitchumani Sivanupandi : > Ping! > > > On Wednesday 22 June 2016 12:05 PM, Pitchumani Sivanupandi wrote: >> >> On Tuesday 21 June 2016 09:39 PM, Georg-Johann Lay wrote: >>> >>> Pitchumani Sivanupandi schrieb:

Re: [patch, avr] Fix PR30417: Wrap -Tdata into %{!Tdata:...}.

2016-06-20 Thread Denis Chertykov
2016-06-20 16:36 GMT+03:00 Georg-Johann Lay : > This patch allows to specify -Tdata and -Ttext on the command line for MCUs > where the specs file sets these options. For -mmcu=atmega88 for example, > the respective specs reads: > > *link_data_start: > -Tdata 0x800100 > >

Re: [Patch, avr] Fix PR 71151

2016-06-16 Thread Denis Chertykov
2016-06-16 10:27 GMT+03:00 Senthil Kumar Selvaraj : > > Senthil Kumar Selvaraj writes: > >> Georg-Johann Lay writes: >> >>> Senthil Kumar Selvaraj schrieb: Hi, This patch fixes PR 71151 by eliminating the TARGET_ASM_FUNCTION_RODATA_SECTION

Re: [patch, avr] Fix PR67353

2016-06-15 Thread Denis Chertykov
2016-06-15 13:19 GMT+03:00 Pitchumani Sivanupandi : > On Mon, 2016-06-13 at 17:48 +0200, Georg-Johann Lay wrote: >> Pitchumani Sivanupandi schrieb: >> > >> > $ avr-gcc test.c -Wno-misspelled-isr >> > $ >> What about -Werror=misspelled-isr? > > Updated patch. > >>

Re: [patch,avr] ad PR71103: also handle QImode SUBREGs of CONST

2016-06-15 Thread Denis Chertykov
2016-06-15 12:11 GMT+03:00 Georg-Johann Lay : > This patch handles the cases when subreg:QI of a CONST or LABEL_REF is to be > moved to a QImode register. The original patch only handled SYMBOL_REFs. > > OK for trunk and backport? > > > Johann > > -- > > gcc/ > PR

Re: [Patch, avr] Include INCOMING_FRAME_SP_OFFSET when printing stack usage

2016-05-21 Thread Denis Chertykov
2016-05-19 16:10 GMT+03:00 Senthil Kumar Selvaraj : > Ping! > > Regards > Senthil > > Senthil Kumar Selvaraj writes: > >> Hi, >> >> This trivial patch adds INCOMING_FRAME_SP_OFFSET to >> current_function_static_stack_size, thus fixing the 2 (or 3, for >> 3

Re: Ping: [patch, avr] Fix unrecognizable insn ICE for avr (PR71103)

2016-05-21 Thread Denis Chertykov
2016-05-20 16:13 GMT+03:00 Pitchumani Sivanupandi : > Ping! > > Note: Removed the garbled characters and added ChangeLog > -- > avr-gcc crashes for following test as it couldn't recognize the > instruction

Re: [Patch, avr]Fix multiple ICE fallout of PR 69764

2016-03-15 Thread Denis Chertykov
2016-03-10 16:46 GMT+03:00 Senthil Kumar Selvaraj : > Hi, > >This patch fixes ~230 internal compiler errors that showed up after >the fix for PR 69764. After the patch, target backends need to >explicitly specify mode for operand 2 of shift and rotate

Re: [Patch, avr] Restore default value of PARAM_ALLOW_STORE_DATA_RACES to 1

2016-02-02 Thread Denis Chertykov
2016-02-01 16:56 GMT+03:00 Senthil Kumar Selvaraj : > > Hi, > > This patch sets PARAM_ALLOW_STORE_DATA_RACES to 1 (the default until > a year back), to avoid code size regressions in trunk (and probably > 5.x )for the AVR target. > > Consider the following

Re: [Patch, avr] Provide correct memory move costs

2015-12-17 Thread Denis Chertykov
2015-12-16 10:08 GMT+03:00 Senthil Kumar Selvaraj : > Hi, > > When analyzing code size regressions for AVR for top-of-trunk, I > found a few cases where aggresive inlining (by the middle-end) > of functions containing calls to memcpy was bloating up the

Re: [patch, avr] Add new Atmel AVR devices

2015-11-18 Thread Denis Chertykov
2015-11-18 9:36 GMT+03:00 Sivanupandi, Pitchumani : > Attached patch adds new Atmel devices to avr-gcc. > If Ok, could someone commit please? I do not have commit access. > > Regards, > Pitchumani > > gcc/ChangeLog > > 2015-11-18 Pitchumani Sivanupandi

Re: [Patch, avr] Fix PR 67839 - bit addressable instructions generated for out of range addresses

2015-10-28 Thread Denis Chertykov
2015-10-28 9:28 GMT+03:00 Senthil Kumar Selvaraj : > > Ping! > > Regards > Senthil > On Fri, Oct 16, 2015 at 03:17:17PM +0530, Senthil Kumar Selvaraj wrote: > > Ping! > > > > Regards > > Senthil > > > > On Mon, Oct 05, 2015 at 02:30:58PM +0530, Senthil Kumar

Re: [Patch, avr] Fix PR65210

2015-09-04 Thread Denis Chertykov
Committed. 2015-09-02 10:51 GMT+03:00 Senthil Kumar Selvaraj : > Hi, > > This (rather trivial) patch fixes PR65210. The ICE happens because code > wasn't handling io_low attribute where it is supposed to. > > If this is ok, could someone commit please? I

Re: [patch,avr] Fix PR66956: Uses 32-64 widening mul instead of 32-bit mul libcall without MUL.

2015-07-21 Thread Denis Chertykov
2015-07-21 15:54 GMT+03:00 Georg-Johann Lay a...@gjlay.de: This works around an assumption in optabs, namely that if a widening-mul insn is available but no mulmode3 insn, then the widening multiplication insn is preferred over expanding the mode multiply as a libcall. The problem occurs only

Re: [patch, avr] Restore base register if not marked dead/unused

2015-05-25 Thread Denis Chertykov
2015-05-19 16:04 GMT+03:00 Sivanupandi, Pitchumani pitchumani.sivanupa...@atmel.com: Test gcc.c-torture/execute/memcpy-bi.c (-O2) failed for attiny40 device. Cause seems to be in load from memory as it is not restoring base register after load instructions generated. Function

Re: [patch, avr] extend part-clobbered check to AVR_TINY architecture

2015-05-11 Thread Denis Chertykov
2015-05-11 9:07 GMT+03:00 Sivanupandi, Pitchumani pitchumani.sivanupa...@atmel.com: -Original Message- From: Denis Chertykov [mailto:cherty...@gmail.com] Sent: Sunday, May 10, 2015 12:55 PM To: Sivanupandi, Pitchumani Cc: Georg-Johann Lay; GCC Patches Subject: Re: [patch, avr] extend

Re: [patch, avr] extend part-clobbered check to AVR_TINY architecture

2015-05-10 Thread Denis Chertykov
, Pitchumani Sent: Tuesday, April 21, 2015 8:21 PM To: Georg-Johann Lay; Denis Chertykov Cc: GCC Patches Subject: [patch, avr] extend part-clobbered check to AVR_TINY architecture Hi, When tried backporting AVR_TINY architecture support to 4.9, build failed in libgcc for AVR_TINY. Failure

Re: [patch,avr,installed] ad PR65296: Adjust specs to new avr-libc layout as of #44574

2015-04-17 Thread Denis Chertykov
2015-04-17 17:02 GMT+03:00 Georg-Johann Lay a...@gjlay.de: ...I went ahead and installed as http://gcc.gnu.org/r222179 It will be backported to 5.2 as soon as 5.1 is open for patches again (assuming RM won't approve this one for 5.1). IMHO AVR port is not locked for patches. It's not a

Re: [patch,avr] Fix PR 65657 - read from __memx address space tramples arguments to function call

2015-04-17 Thread Denis Chertykov
2015-04-17 10:46 GMT+03:00 Senthil Kumar Selvaraj senthil_kumar.selva...@atmel.com: On Thu, Apr 16, 2015 at 06:47:26PM +0200, Georg-Johann Lay wrote: Am 04/16/2015 um 11:28 AM schrieb Senthil Kumar Selvaraj: On Thu, Apr 16, 2015 at 11:02:05AM +0200, Georg-Johann Lay wrote: Am 04/16/2015 um

Re: [patch,avr,installed] ad PR65296: Adjust specs to new avr-libc layout as of #44574

2015-04-17 Thread Denis Chertykov
2015-04-17 18:32 GMT+03:00 Georg-Johann Lay a...@gjlay.de: Am 04/17/2015 um 04:43 PM schrieb Denis Chertykov: 2015-04-17 17:02 GMT+03:00 Georg-Johann Lay a...@gjlay.de: ...I went ahead and installed as http://gcc.gnu.org/r222179 It will be backported to 5.2 as soon as 5.1 is open

Re: [patch,avr] Fix PR 65657 - read from __memx address space tramples arguments to function call

2015-04-16 Thread Denis Chertykov
2015-04-16 19:47 GMT+03:00 Georg-Johann Lay a...@gjlay.de: Am 04/16/2015 um 11:28 AM schrieb Senthil Kumar Selvaraj: On Thu, Apr 16, 2015 at 11:02:05AM +0200, Georg-Johann Lay wrote: Am 04/16/2015 um 08:43 AM schrieb Senthil Kumar Selvaraj: This patch fixes PR 65657. The following

Re: [patch,avr]: Part2: Fix various problems with specs and specs file generation.

2015-04-08 Thread Denis Chertykov
2015-04-07 15:34 GMT+03:00 Georg-Johann Lay a...@gjlay.de: Am 04/06/2015 um 11:54 AM schrieb Sivanupandi, Pitchumani: Hi Johann, Did you try running g++ tests? It seems xgcc is invoked to get multilibs (from gcc/testsuite/lib/g++.exp) which failed to find specs file. This is because

Re: [patch,avr]: Part5: Fix various problems with specs and specs file generation.

2015-03-17 Thread Denis Chertykov
2015-03-16 21:17 GMT+03:00 Georg-Johann Lay a...@gjlay.de: This patch introduces a new avr specific command option '-nodevicelib' so that linking of libdev.a can be bypassed. The argument of -specs= is suffixed by %s instead of supplying the absolute path. That way -specs= works with

Re: [patch,avr]: Part3 and 4: Fix various problems with specs and specs file generation.

2015-03-11 Thread Denis Chertykov
2015-03-10 18:02 GMT+03:00 Georg-Johann Lay a...@gjlay.de: This is just a small addendum to the option and specs handling: - Document new avr-gcc command options - Change -march= to -mmcu= in some test cases - Add comfigure test to detect whether gas supports -mrmw and --mlink-relax. -

Re: [patch,avr]: Part2: Fix various problems with specs and specs file generation.

2015-03-09 Thread Denis Chertykov
2015-03-09 19:02 GMT+03:00 Georg-Johann Lay a...@gjlay.de: Am 03/03/2015 um 02:21 PM schrieb Senthil Kumar Selvaraj: On Mon, Mar 02, 2015 at 08:40:17PM +0100, Georg-Johann Lay wrote: The new specs file generation introduces several problems. This patch - Fix build warnings - Clean up

Re: [patch,avr]: Fix various problems with specs and specs file generation.

2015-03-02 Thread Denis Chertykov
2015-03-02 22:40 GMT+03:00 Georg-Johann Lay a...@gjlay.de: The new specs file generation introduces several problems. This patch - Fix build warnings - Clean up unused code and the old, now dead specs definitions. - Removes unused files and adjust build scripts / rules. - Issues with

Re: [patch, avr] Take 2: Fix PR64331: insn output and insn length computation rely on REG_DEAD notes.

2015-03-02 Thread Denis Chertykov
2015-03-02 15:32 GMT+03:00 Georg-Johann Lay a...@gjlay.de: Am 02/28/2015 um 09:02 AM schrieb Denis Chertykov: 2015-02-27 1:45 GMT+03:00 Steven Bosscher stevenb@gmail.com: On Thu, Feb 26, 2015 at 8:35 PM, Georg-Johann Lay wrote: Take #2 introduces a new, avr-specific rtl pass whose sole

Re: [patch, avr] Take 2: Fix PR64331: insn output and insn length computation rely on REG_DEAD notes.

2015-02-28 Thread Denis Chertykov
2015-02-27 1:45 GMT+03:00 Steven Bosscher stevenb@gmail.com: On Thu, Feb 26, 2015 at 8:35 PM, Georg-Johann Lay wrote: Take #2 introduces a new, avr-specific rtl pass whose sole purpose is to rectify notes. The pass is scheduled right before cfg does down (right before .*free_cfg) so that

Re: [patch, avr-tiny]: Fix handling of constant addresses.

2015-02-26 Thread Denis Chertykov
2015-02-25 18:56 GMT+03:00 Georg-Johann Lay a...@gjlay.de: The current avr-gcc ICEs in avr.c::tiny_valid_direct_memory_access_range because XEXP (op, 0) is used on op which are not MEM_P (e.g. REG or SUBREG). If op is MEM_P then INTVAL might be used for on RTXes which are not CONST_INT, e.g.

Re: [patch, avr] Tidy up avr-log.c

2015-02-25 Thread Denis Chertykov
2015-02-24 16:09 GMT+03:00 Georg-Johann Lay a...@gjlay.de: avr-log.c and respective macros in avr-protos.h still assume that the implementation language is C90, i.e. no variadic macros are available. This patch cleans up the code from the cumbersome old approach and uses variadic macros for

Re: [patch, avr] Fix PR64331: insn output and insn length computation rely on REG_DEAD notes.

2015-02-23 Thread Denis Chertykov
2015-02-23 13:53 GMT+03:00 Georg-Johann Lay a...@gjlay.de: This patch fixes PR64331 which produced wrong code because of outdated (too many) REG_DEAD notes. These notes are not (re)computed per default, hence do the computation by hand each time avr.c:reg_unused_after is called in a different

Re: [patch, avr] Include stdfix-avrlibc.h in stdfix.h

2015-02-23 Thread Denis Chertykov
2015-02-23 17:12 GMT+03:00 Georg-Johann Lay a...@gjlay.de: This include stdfix-avrlibc.h in the avr-gcc specific stdfix.h. Ok for trunk? Johann gcc/ * config/avr/stdfix.h [__WITH_AVRLIBC__]: Include stdfix-avrlibc.h. Approved. Denis.

Re: [patch, avr] Fix ICE PR64452 pushing eliminated rtxes

2015-02-18 Thread Denis Chertykov
2015-02-18 14:59 GMT+03:00 Georg-Johann Lay a...@gjlay.de: Am 02/17/2015 um 03:34 PM schrieb Denis Chertykov: 2015-02-17 14:12 GMT+03:00 Georg-Johann Lay a...@gjlay.de: Byte-wise pushing virtual regs like arg pointer migth result in patterns like (set (mem:QI (post_dec:HI (reg:HI 32 SP

Re: [patch, avr] Fix ICE PR64452 pushing eliminated rtxes

2015-02-17 Thread Denis Chertykov
2015-02-17 14:12 GMT+03:00 Georg-Johann Lay a...@gjlay.de: Byte-wise pushing virtual regs like arg pointer migth result in patterns like (set (mem:QI (post_dec:HI (reg:HI 32 SP))) (subreg:QI (plus:HI (reg:HI 28) (const_int 17)) 0)) after elimination.

Re: RFA: fix avr C++ preprocessing to pick up device defines

2014-11-09 Thread Denis Chertykov
2014-11-09 19:23 GMT+03:00 Joern Rennecke joern.renne...@embecosm.com: The defaults.h definition of #define CPLUSPLUS_CPP_SPEC CPP_SPEC does not do the right thing with the cpp spec picked up from a spec file, which is now needed for -mmcu processing. Also, a spec file can't override

Re: [patch,avr] correct incorrect spec string for device specs

2014-11-03 Thread Denis Chertykov
Committed.

Re: [PATCH][BUILDROBOT] Unused static function (was: RFA: AVR: add infrastructure for device packages)

2014-10-30 Thread Denis Chertykov
2014-10-29 13:42 GMT+03:00 Jan-Benedict Glaw jbg...@lug-owl.de: On Wed, 2014-10-29 02:23:31 +0100, Jan-Benedict Glaw jbg...@lug-owl.de wrote: On Wed, 2014-10-08 18:50:32 +0100, Joern Rennecke joern.renne...@embecosm.com wrote: Attached is the GCC patch for the basic device package

Re: [patch,avr,4.9] Fix PR63633 ICEs for expanders colliding hard-regs

2014-10-30 Thread Denis Chertykov
2014-10-28 15:47 GMT+03:00 Georg-Johann Lay a...@gjlay.de: Am 10/28/2014 01:34 PM, schrieb Georg-Johann Lay: Middle-end might come up with hard registers as operands for expanders which clobber respective hard regs. This patch uses freshly created pseudos for respective expander operands

Re: [patch,avr] tweak sign extensions, take #2

2014-10-24 Thread Denis Chertykov
2014-10-24 14:37 GMT+04:00 Georg-Johann Lay a...@gjlay.de: Am 10/23/2014 08:16 PM schrieb Denis Chertykov: This optimization makes most sign-extensions one instruction shorter in the case when the source register may be clobbered and the register numbers are different. Source

Re: [patch,avr] tweak sign extensions

2014-10-23 Thread Denis Chertykov
2014-10-23 17:48 GMT+04:00 Georg-Johann Lay a...@gjlay.de: This optimization makes most sign-extensions one instruction shorter in the case when the source register may be clobbered and the register numbers are different. Source and destination may overlap. Ok for trunk? Johann gcc/

Re: [patch,avr,committed]: Fix coding rules.

2014-10-23 Thread Denis Chertykov
2014-10-23 16:33 GMT+04:00 Georg-Johann Lay a...@gjlay.de: This no-op change fixed typos and restored coding rules as obvious like: spaces around operators, space before opening parentheses, wrapping long lines, indentation rules, trailing blanks, etc... http://gcc.gnu.org/r216592 Johann

Re: RFA: AVR: add infrastructure for device packages

2014-10-09 Thread Denis Chertykov
2014-10-08 21:50 GMT+04:00 Joern Rennecke joern.renne...@embecosm.com: As the steering commitee still hasn't spoken on the maintainership issue, apparently this still has to go the write-after-approval route. The purpose of this patch is to make it possible to add support for new devices

Re: [patch,avr] Make jump tables work with bootloader

2014-09-10 Thread Denis Chertykov
2014-09-08 21:12 GMT+04:00 Georg Lay georg@hightec-rt.com: avr-gcc puts jump tables in section .progmem.gcc_sw_table and assumes that .text starts at 0, i.e. LPM is on order to read table entries. This is no more the case if .text starts ata higher address like typically used with boot

Re: [patch, avr] Remove avr devices that are not released

2014-08-22 Thread Denis Chertykov
2014-08-20 18:36 GMT+04:00 Sivanupandi, Pitchumani pitchumani.sivanupa...@atmel.com: Attached patch removes avr devices that are not released (may not be released in near future also). If OK, could someone commit please? Regards, Pitchumani gcc/ChangeLog 2014-08-20 Pitchumani

Re: [Patch, avr] Add device name to cpp_builtins

2014-07-31 Thread Denis Chertykov
2014-07-30 11:19 GMT+04:00 Senthil Kumar Selvaraj senthil_kumar.selva...@atmel.com: On Mon, Jul 28, 2014 at 08:09:28PM +0200, Georg-Johann Lay wrote: Senthil Kumar Selvaraj schrieb: The below patch adds a new preprocessor define for the device name (__AVR_DEVICE_NAME__) that was passed to the

Re: [Patch, avr] Add device name to cpp_builtins

2014-07-24 Thread Denis Chertykov
2014-07-23 12:04 GMT+04:00 Senthil Kumar Selvaraj senthil_kumar.selva...@atmel.com: The below patch adds a new preprocessor define for the device name (__AVR_DEVICE_NAME__) that was passed to the compiler. While the device name macro (say __AVR_ATmega128__) can be used to check for a specific

Re: [Patch, avr] Add atmel ata5782 and ata5831 devices

2014-07-16 Thread Denis Chertykov
2014-07-14 15:44 GMT+04:00 S, Pitchumani pitchuman...@atmel.com: -Original Message- From: gcc-patches-ow...@gcc.gnu.org [mailto:gcc-patches-ow...@gcc.gnu.org] On Behalf Of Denis Chertykov Sent: Friday, July 11, 2014 9:53 PM To: S, Pitchumani Cc: gcc-patches@gcc.gnu.org; Georg-Johann

Re: [patch, avr] atmel avr new devices set-3

2014-07-16 Thread Denis Chertykov
2014-07-15 13:18 GMT+04:00 S, Pitchumani pitchuman...@atmel.com: Hi, Attached patch adds support for following Atmel devices. ata5702m322 atmega325pa atmega64hve2 atmega644rfr2 atmega128rfr2 atmega1284rfr2 atmega256rfr2 atmega2564rfr2 If OK, could someone commit please? Regards,

Re: [patch, avr] atmel avr new devices set-4

2014-07-16 Thread Denis Chertykov
2014-07-15 13:51 GMT+04:00 S, Pitchumani pitchuman...@atmel.com: Hi, Attached patch adds support for new Atmel xmega devices (atxmega8e5, atxmega16e5, atxmega32c3, atxmega32d3). This patch is continuation of patch in https://gcc.gnu.org/ml/gcc-patches/2014-07/msg01038.html If OK, could

Re: [Patch, avr] Add atmel ata5782 and ata5831 devices

2014-07-11 Thread Denis Chertykov
2014-07-11 12:50 GMT+04:00 S, Pitchumani pitchuman...@atmel.com: This patch adds supports for Atmel's ata5782 and ata5831 devices. These devices ISA matches with AVR5 architecture except that text section start for these two devices is 0x8000. By default 0x0 is used as the text start address.

Re: [patch,avr] Fix ICE PR61443

2014-06-11 Thread Denis Chertykov
2014-06-11 13:05 GMT+04:00 Georg-Johann Lay a...@gjlay.de: This is a fix for unrecognizable insn ICE where the push expander generated (subreg(mem)) for non-generic address-space locations. Instead of loading byte-wise and legitimizing such expressions, it's easier and results in better code

Re: [patch,avr] atmel avr new devices set-2

2014-06-03 Thread Denis Chertykov
2014-06-03 18:26 GMT+04:00 S, Pitchumani pitchuman...@atmel.com: Hi, Attached patch adds support for Atmel devices tiny441, tiny828 and tiny841. Please commit if the patch is OK. Note: This is continuation of patch attached in https://gcc.gnu.org/ml/gcc-patches/2014-06/msg00049.html

Re: [patch,avr] atmel avr new devices set-1

2014-06-03 Thread Denis Chertykov
2014-06-02 13:47 GMT+04:00 S, Pitchumani pitchuman...@atmel.com: Hi, Attached patch adds support for Atmel ATA devices (ata6616c, ata6617c, ata664251, ata6612c, ata6613c and ata6614q). Please commit if the patch is OK. I do not have commit access. Regards, Pitchumani gcc/ChangeLog

  1   2   3   4   >