Hi David.
Thanks for the feedback! Well, I think at this point, better to get
"global approval" on the idea and on what you suggested (which I agree
with) before I make any additional changes considering how big the
patch is.
Let's wait for others to also express their opinion here.
Thanks a lot!
Le mar. 29 août 2023 à 17:35, David Malcolm a écrit :
>
> On Tue, 2023-08-29 at 17:15 +0200, Guillaume Gomez wrote:
> > We finished the investigation and found out the issue: when passing
> > arguments by value to functions, rustc still provides "NoAlias" as
> > attribute to the
We finished the investigation and found out the issue: when passing
arguments by value to functions, rustc still provides "NoAlias" as
attribute to the argument whereas it should never be passed in this
case. Luckily for us, in case the argument is a function pointer
coming from a struct field, it
After more investigations, it seems like the fault was on our side as
we were calling `gcc_jit_type_get_restrict` on types that weren't
pointers.
I added a check for that in `gcc_jit_type_get_restrict` directly as well.
We will continue our investigation to be sure we didn't miss anything.
Le
Quick question: do you plan to make the merge or should I ask Antoni?
Le jeu. 17 août 2023 à 17:59, Guillaume Gomez
a écrit :
> Thanks for the review!
>
> Le jeu. 17 août 2023 à 17:50, David Malcolm a écrit
> :
> >
> > On Thu, 2023-08-17 at 17:41 +0200, Guillaume Gomez wrote:
> > > And now I
Thanks for the review!
Le jeu. 17 août 2023 à 17:50, David Malcolm a écrit :
>
> On Thu, 2023-08-17 at 17:41 +0200, Guillaume Gomez wrote:
> > And now I just discovered that a lot of commits from Antoni's fork
> > haven't been sent upstream which is why the ABI count is so high in
> > his
And now I just discovered that a lot of commits from Antoni's fork
haven't been sent upstream which is why the ABI count is so high in
his repository. Fixed that as well.
Le jeu. 17 août 2023 à 17:26, Guillaume Gomez
a écrit :
>
> Antoni spot a typo I made:
>
> I added
Antoni spot a typo I made:
I added `LIBGCCJIT_HAVE_gcc_jit_type_get_size` instead of
`LIBGCCJIT_HAVE_gcc_jit_type_get_restrict`. Fixed in this patch, sorry
for the noise.
Le jeu. 17 août 2023 à 11:30, Guillaume Gomez
a écrit :
>
> Hi Dave,
>
> > What kind of testing has the patch had? (e.g. did
Hi Dave,
> What kind of testing has the patch had? (e.g. did you run "make check-
> jit" ? Has this been in use on real Rust code?)
I tested it as Rust backend directly on this code:
```
pub fn foo(a: i32, b: i32, c: ) {
*a += *c;
*b += *c;
}
```
I ran it with `rustc` (and the GCC
My apologies, forgot to run the commit checkers. Here's the commit
with the errors fixed.
Le mer. 16 août 2023 à 18:32, Guillaume Gomez
a écrit :
>
> Hi,
>
> This patch adds the possibility to specify the __restrict__ attribute
> for function parameters. It is used by the Rust GCC backend.
>
>
Hi,
This patch adds the possibility to specify the __restrict__ attribute
for function parameters. It is used by the Rust GCC backend.
Thanks in advance for the review.
From 8cafadb8409094c7fc66a1073397942a60cb27b3 Mon Sep 17 00:00:00 2001
From: Guillaume Gomez
Date: Fri, 11 Aug 2023 22:48:11
Thanks!
Le jeu. 2 mars 2023 à 23:54, David Malcolm a écrit :
> On Thu, 2023-03-02 at 23:35 +0100, Guillaume Gomez wrote:
> > I don't have push rights so if you could push it, it'd be super
> > appreciated!
>
> Done, as r13-6425-g6b432c0f777ab9; I took the liberty of slightly
> tweaking the
I don't have push rights so if you could push it, it'd be super appreciated!
Le jeu. 2 mars 2023 à 23:33, David Malcolm a écrit :
> On Thu, 2023-03-02 at 23:29 +0100, Guillaume Gomez wrote:
> > Just realized I used whitespace and not a tab. Sorry about that.
> > Here's the
> > fixed version...
Just realized I used whitespace and not a tab. Sorry about that. Here's the
fixed version...
Le jeu. 2 mars 2023 à 23:19, Guillaume Gomez a
écrit :
> No problem, thanks for the explanations.
>
> I joined the patch with the fixed commit message.
>
> Le jeu. 2 mars 2023 à 22:58, David Malcolm a
No problem, thanks for the explanations.
I joined the patch with the fixed commit message.
Le jeu. 2 mars 2023 à 22:58, David Malcolm a écrit :
> On Thu, 2022-12-15 at 08:34 +0100, Guillaume Gomez via Jit wrote:
> > Forgot it indeed, thanks for notifying me!
> >
> > I modified the commit
Ping David.
Le lun. 16 janv. 2023 à 15:08, Guillaume Gomez
a écrit :
> Ping David.
>
> Le jeu. 5 janv. 2023 à 23:37, Guillaume Gomez
> a écrit :
>
>> Ping David.
>>
>> Le sam. 24 déc. 2022 à 21:01, Guillaume Gomez
>> a écrit :
>>
>>> Ping David
>>>
>>> Le jeu. 15 déc. 2022 à 11:34, Guillaume
Ping David.
Le jeu. 5 janv. 2023 à 23:37, Guillaume Gomez
a écrit :
> Ping David.
>
> Le sam. 24 déc. 2022 à 21:01, Guillaume Gomez
> a écrit :
>
>> Ping David
>>
>> Le jeu. 15 déc. 2022 à 11:34, Guillaume Gomez
>> a écrit :
>>
>>> Forgot it indeed, thanks for notifying me!
>>>
>>> I modified
Ping David.
Le sam. 24 déc. 2022 à 21:01, Guillaume Gomez
a écrit :
> Ping David
>
> Le jeu. 15 déc. 2022 à 11:34, Guillaume Gomez
> a écrit :
>
>> Forgot it indeed, thanks for notifying me!
>>
>> I modified the commit message to add it and added it into this email.
>>
>> Le mer. 14 déc. 2022
Ping David
Le jeu. 15 déc. 2022 à 11:34, Guillaume Gomez
a écrit :
> Forgot it indeed, thanks for notifying me!
>
> I modified the commit message to add it and added it into this email.
>
> Le mer. 14 déc. 2022 à 16:12, Antoni Boucher a écrit :
>
>> Thanks!
>>
>> In your patch, you're missing
Forgot it indeed, thanks for notifying me!
I modified the commit message to add it and added it into this email.
Le mer. 14 déc. 2022 à 16:12, Antoni Boucher a écrit :
> Thanks!
>
> In your patch, you're missing this line at the end of the commit
> message:
>
>Signed-off-by: Guillaume
Hi,
This fixes bug 107999.
Thanks in advance for the review.
From e6db0cb107e54789095f4585dd279a2c984d2ca1 Mon Sep 17 00:00:00 2001
From: Guillaume Gomez
Date: Wed, 14 Dec 2022 14:28:22 +0100
Subject: [PATCH] Fix a failing test by updating its error string.
gcc/testsuite/ChangeLog:
*
Hi,
This patch fixes the following compilation error:
../.././c++tools/server.cc: In function ‘void server(bool, int,
module_resolver*)’:
../.././c++tools/server.cc:756:69: error: ‘readers’ was not declared
in this scope; did you mean ‘read’?
756 | if (active < 0 && sock_fd >= 0
22 matches
Mail list logo
