Re: [PATCH v2 1/2] Implement ASM_DECLARE_FUNCTION_NAME using ASM_OUTPUT_FUNCTION_LABEL

2024-01-12 Thread Jan-Benedict Glaw
On Tue, 2024-01-02 20:41:37 +0100, Ilya Leoshkevich wrote: > diff --git a/gcc/config/ia64/ia64.cc b/gcc/config/ia64/ia64.cc > index ac566efcf19..92d00bf922f 100644 > --- a/gcc/config/ia64/ia64.cc > +++ b/gcc/config/ia64/ia64.cc > @@ -3886,8 +3886,7 @@ ia64_expand_prologue (void) > /* Output the

Re: [patch,avr,applied] PR target/112952 Fix attribute "io" et al. handling.

2024-01-11 Thread Jan-Benedict Glaw
On Thu, 2024-01-04 17:28:02 +0100, Georg-Johann Lay wrote: > This fixes the avr-specific attributes io, io_low and address, > that are all basically the same except that io and io_low imply > assertions on allowed addressing modes. > --- a/gcc/config/avr/avr.cc > +++ b/gcc/config/avr/avr.cc

Re: [PATCH 3/6] arm: [MVE intrinsics] Add support for contiguous loads and stores

2023-11-23 Thread Jan-Benedict Glaw
On Thu, 2023-11-16 15:26:14 +, Christophe Lyon wrote: > diff --git a/gcc/config/arm/arm-mve-builtins-functions.h > b/gcc/config/arm/arm-mve-builtins-functions.h > index eba1f071af0..6d234a2dd7c 100644 > --- a/gcc/config/arm/arm-mve-builtins-functions.h > +++

Re: [PATCH] LoongArch: Adjust makefile dependency for loongarch headers.

2023-10-08 Thread Jan-Benedict Glaw
On Sat, 2023-10-07 16:50:14 +0800, Yang Yujie wrote: > gcc/ChangeLog: > > * config.gcc: Add loongarch-driver.h to tm_files. > * config/loongarch/loongarch.h: Do not include loongarch-driver.h. > * config/loongarch/t-loongarch: Append loongarch-multilib.h to $(GTM_H) >

Re: [PATCH] LoongArch: Reimplement multilib build option handling.

2023-10-07 Thread Jan-Benedict Glaw
Hi! On Sat, 2023-10-07 15:08:34 +0800, Xi Ruoyao wrote: > On Sat, 2023-10-07 at 11:41 +0800, Yang Yujie wrote: > > Thanks for the testing! > > > > This error seems to be difficult to reproduce since it is a makefile > > dependency > > problem.  I think appending loongarch-multilib.h to

Re: [PATCH] LoongArch: Reimplement multilib build option handling.

2023-10-04 Thread Jan-Benedict Glaw
Hi! On Wed, 2023-09-13 17:52:14 +0800, Yang Yujie wrote: > Library build options from --with-multilib-list used to be processed with > *self_spec, which missed the driver's initial canonicalization. This > caused limitations on CFLAGS override and the use of driver-only options > like

Re: [PATCH] Remove poly_int_pod

2023-10-02 Thread Jan-Benedict Glaw
Hi Richard, On Thu, 2023-09-28 10:55:46 +0100, Richard Sandiford wrote: > poly_int was written before the switch to C++11 and so couldn't > use explicit default constructors. This led to an awkward split > between poly_int_pod and poly_int. poly_int simply inherited from > poly_int_pod and

Re: [PATCH v6] RISC-V:Optimize the MASK opt generation

2023-10-01 Thread Jan-Benedict Glaw
On Mon, 2023-10-02 10:55:25 +0800, Kito Cheng wrote: > Hi Gerald: > > Thanks for reporting this issue, I just realized multidimensional > arrays are gawk extensions, could you try the attached patch to see if > it can resolve the issue? With your new patch, it works for me again using `mawk`

[PATCH] Fix code_helper unused argument warning for fr30

2023-08-17 Thread Jan-Benedict Glaw
Hi! fr30 is the only target defining GO_IF_LEGITIMATE_ADDRESS right now, in which case the `code_helper ch` argument to memory_address_addr_space_p() is unused and emits a new warning. gcc/ChangeLog: * recog.cc (memory_address_addr_space_p): Mark possibly unused argument as

Re: [PATCH] config-list.mk Darwin: Use --with-gnu-as

2023-08-16 Thread Jan-Benedict Glaw
Hi Rainer! On Tue, 2023-08-15 21:49:37 +0200, Rainer Orth wrote: > > config-list.mk Darwin: Use --with-gnu-as for mass-building tests > > > > As `config-list.mk` is probably mostly used on Linux system, where > > Apple's tools aren't around. Let's use --with-gnu-as instead to have > > an

[PATCH] config-list.mk Darwin: Use --with-gnu-as

2023-08-15 Thread Jan-Benedict Glaw
Hi! config-list.mk Darwin: Use --with-gnu-as for mass-building tests As `config-list.mk` is probably mostly used on Linux system, where Apple's tools aren't around. Let's use --with-gnu-as instead to have an useable assembler. contrib/ChangeLog: * config-list.mk (i686-apple-darwin):

[PATCH] config-list.mk i686-solaris2.11: Use --with-gnu-as

2023-08-15 Thread Jan-Benedict Glaw
Hi! i686-solaris2.11: Use --with-gnu-as for mass-building tests As `config-list.mk` is probably mostly used on Linux system, where Solaris's `as` isn't available, let's use GNU `as` as the default. contrib/ChangeLog: * config-list.mk (i686-solaris2.11): Use --with-gnu-as. diff --git

Re: [PATCH 2/3] ivopts: Call valid_mem_ref_p with code_helper [PR110248]

2023-08-14 Thread Jan-Benedict Glaw
On Fri, 2023-06-30 13:46:40 +0800, Kewen.Lin via Gcc-patches wrote: > Bootstrapped and regtested on x86_64-redhat-linux and > powerpc64{,le}-linux-gnu. > > Is it ok for trunk? [...] > diff --git a/gcc/recog.h b/gcc/recog.h > index badf8e3dc1c..c6ef619c5dd 100644 > --- a/gcc/recog.h > +++

Re: [PATCH v4 4/9] MIPS: Add bitwise instructions for mips16e2

2023-07-07 Thread Jan-Benedict Glaw
On Fri, 2023-07-07 16:38:51 +0800, 梅杰 wrote: > 在 2023/7/7 07:06, Jan-Benedict Glaw 写道: > > On Mon, 2023-06-19 16:29:53 +0800, Jie Mei > > wrote: > > > There are shortened bitwise instructions in the mips16e2 ASE, > > > for instance, ANDI, ORI/XORI, E

Re: [PATCH v4 4/9] MIPS: Add bitwise instructions for mips16e2

2023-07-06 Thread Jan-Benedict Glaw
Hi! On Mon, 2023-06-19 16:29:53 +0800, Jie Mei wrote: > There are shortened bitwise instructions in the mips16e2 ASE, > for instance, ANDI, ORI/XORI, EXT, INS etc. . > > This patch adds these instrutions with corresponding tests. [...] Starting with this patch, I see some new warning: [all

Re: [PATCH] Move substitute_and_fold over to use simple_dce_from_worklist

2023-06-26 Thread Jan-Benedict Glaw
Hi Andrew, On Mon, 2023-06-26 09:13:51 -0700, Andrew Pinski wrote: > On Sun, Jun 25, 2023 at 10:59 PM Jan-Benedict Glaw wrote: > > On Fri, 2023-05-05 08:17:19 -0700, Andrew Pinski via Gcc-patches > > wrote: > > > While looking into a different issue, I noticed that i

Re: [PATCH] Move substitute_and_fold over to use simple_dce_from_worklist

2023-06-25 Thread Jan-Benedict Glaw
Hi Andrew, On Fri, 2023-05-05 08:17:19 -0700, Andrew Pinski via Gcc-patches wrote: > While looking into a different issue, I noticed that it > would take until the second forwprop pass to do some > forward proping and it was because the ssa name was > used more than once but the second

GCC nvptx: Silence warning?

2023-06-23 Thread Jan-Benedict Glaw
Hi Tom! Building with newer GCC versions (I'm doing CI builds with -Werror), we might see warnings like this: /usr/lib/gcc-snapshot/bin/g++ -fno-PIE -c -g -O2 -DIN_GCC -DCROSS_DIRECTORY_STRUCTURE -fno-exceptions -fno-rtti -fasynchronous-unwind-tables -W -Wall -Wno-narrowing

Re: [COMMITTED] ada: Remove the body of System.Storage_Elements

2023-05-30 Thread Jan-Benedict Glaw
On Tue, 2023-05-30 09:05:43 +0100, Maciej W. Rozycki wrote: [Ada as a cross-compiler fails to build with a slightly-older compiler.] > Alternatively you can just bootstrap GCC under test natively first and > then use the newly-built compiler for all the cross builds you want to > verify. As

Re: [COMMITTED] ada: Remove the body of System.Storage_Elements

2023-05-29 Thread Jan-Benedict Glaw
On Mon, 2023-05-29 16:11:26 +0200, Marc Poulhiès wrote: > Jan-Benedict Glaw writes: > > (A full build log is at > > http://toolchain.lug-owl.de/laminar/jobs/gcc-aarch64-linux/74) > > > > Is this an issue with the patch? Or does it need a newer Ada compiler > > t

Re: [COMMITTED] ada: Remove the body of System.Storage_Elements

2023-05-29 Thread Jan-Benedict Glaw
Hi Eric! On Tue, 2023-05-23 10:08:26 +0200, Marc Poulhiès via Gcc-patches wrote: > From: Eric Botcazou > > All the subprograms declared in the unit have convention Intrinsic and > their current implementation makes some implicit assumptions that are > not valid universally, so it is replaced

[patch] mcore: Fix sprintf length warning

2023-05-22 Thread Jan-Benedict Glaw
Hi! One of the supplied argument strings is unneccesarily long (c-sky, using basically the same code, fixed it to a shorter length) and this fixes overflow warnings, as GCC fails to deduce that the full 256 bytes for load_op[] are not used at all. make[1]: Entering directory

Re: [PATCH] add glibc-stdint.h to vax and lm32 linux target (PR target/105525)

2023-05-22 Thread Jan-Benedict Glaw
Hi Mikael! On Mon, 2023-05-22 17:25:39 +0200, Mikael Pettersson wrote: > On Mon, May 22, 2023 at 3:57 PM Jan-Benedict Glaw wrote: > > On Mon, 2023-05-22 14:10:48 +0100, Maciej W. Rozycki > > wrote: > > > On Fri, 19 May 2023, Mikael Pettersson wrote: > > > &g

Re: [PATCH] add glibc-stdint.h to vax and lm32 linux target (PR target/105525)

2023-05-22 Thread Jan-Benedict Glaw
Hi! On Mon, 2023-05-22 14:10:48 +0100, Maciej W. Rozycki wrote: > On Fri, 19 May 2023, Mikael Pettersson wrote: > > The background is that I maintain a script to build GCC-based crosses to > > as many targets as I can, currently it supports 78 distinct processors and > > 82 triplets (four

Re: Rust: In 'type_for_mode' langhook also consider all 'int_n' modes/types (was: Modula-2 / Rust: Many targets failing)

2023-02-25 Thread Jan-Benedict Glaw
Hi Thomas, On Wed, 2023-02-22 12:25:01 +0100, Thomas Schwinge wrote: > On 2022-12-19T22:23:45+0100, Jan-Benedict Glaw wrote: > > Rust related issues > > = > > > > --target=msp430-elfbare > > ~ > > /va

Re: Rust: In 'type_for_mode' langhook also consider all 'int_n' modes/types (was: Modula-2 / Rust: Many targets failing)

2023-02-24 Thread Jan-Benedict Glaw
Hi Thomas / Arthur! On Wed, 2023-02-22 15:30:37 +0100, Arthur Cohen wrote: [..] > > > --target=msp430-elfbare > > > ~ > > > > > > /var/lib/laminar/run/gcc-msp430-elfbare/24/toolchain-build/./gcc/xgcc > > >

[patch] bpf: Fix double whitespace warning

2023-02-15 Thread Jan-Benedict Glaw
Hi! Since a recent commit, the BPF target produces a new warning due to two consecutive non-quoted spaces in a message. This'll fix it: gcc/ * config/bpf/bpf.cc (bpf_option_override): Fix doubled space. Ok? MfG, JBG diff --git a/gcc/config/bpf/bpf.cc b/gcc/config/bpf/bpf.cc index

Re: [PATCH] Add support for x86_64-*-gnu-* targets to build x86_64 gnumach/hurd

2023-02-01 Thread Jan-Benedict Glaw
Hi Flávio and Thomas! On Mon, 2023-01-30 16:44:29 +0100, Thomas Schwinge wrote: > On 2023-01-27T21:15:01-0500, Flávio Cruz wrote: > > Not sure what happened, but here's the patch as an attachment. Thanks for > > your patience. > > Thanks, that worked. Without any changes now pushed to master

Re: [COMMITTED] bpf: disable -fstack-protector in BPF

2023-01-28 Thread Jan-Benedict Glaw
On Tue, 2023-01-17 17:25:08 +0100, Jose E. Marchesi via Gcc-patches wrote: > The stack protector is not supported in BPF. This patch disables > -fstack-protector in bpf-* targets, along with the emission of a note > indicating that the feature is not supported in this platform. [...] > diff

Re: [PATCH 5/8 v2] middle-end: Add cltz_complement idiom recognition

2023-01-19 Thread Jan-Benedict Glaw
On Thu, 2022-12-22 17:42:16 +, Andrew Carlotti via Gcc-patches wrote: > New patch below, bootstrapped and regression tested on > aarch64-unknown-linux-gnu and x86_64-pc-linux-gnu - ok to merge? > diff --git a/gcc/tree-ssa-loop-niter.cc b/gcc/tree-ssa-loop-niter.cc > index >

Modula-2 / Rust: Many targets failing

2022-12-19 Thread Jan-Benedict Glaw
Hi! With the recent merges for Modula-2 and Rust, I see a good number of targets failing with --enable-languages=all, mostly due to issues with the Modula-2 driver. Modula-2 related issues = --target=x86_64-apple-darwin ~~

Re: [PATCH] tree-optimization/107852 - missed optimization with PHIs

2022-12-05 Thread Jan-Benedict Glaw
On Tue, 2022-11-29 14:30:22 +0100, Richard Biener via Gcc-patches wrote: > Bootstrapped and tested on x86_64-unknown-linux-gnu, pushed. > > PR tree-optimization/107852 > * tree-ssa-sccvn.cc (visit_phi): Use equivalences recorded > as predicated values to elide more redundant

Re: [PATCH] range-op: Implement floating point division fold_range [PR107569]

2022-11-21 Thread Jan-Benedict Glaw
Hi Jakub, On Fri, 2022-11-11 10:09:42 +0100, Jakub Jelinek via Gcc-patches wrote: > Here is the floating point division fold_range implementation, > as I wrote in the last mail, we could outline some of the common parts > into static methods with descriptive names and share them between >

Re: [PATCH v3] xtensa: Prepare the transition from Reload to LRA

2022-10-25 Thread Jan-Benedict Glaw
Hi! On Wed, 2022-10-19 17:16:24 +0900, Takayuki 'January June' Suwa via Gcc-patches wrote: > * gcc/config/xtensa/xtensa.md: Add two new split patterns: > - splits DImode immediate load into two SImode ones > - puts out-of-constraint SImode constants into the constant pool

Re: [committed] More infrastructure to avoid bogus RTL on H8

2022-10-25 Thread Jan-Benedict Glaw
Hi Jeff! On Mon, 2022-10-17 17:47:16 -0600, Jeff Law via Gcc-patches wrote: > --- a/gcc/config/h8300/h8300.cc > +++ b/gcc/config/h8300/h8300.cc > @@ -5531,6 +5531,32 @@ h8300_ok_for_sibcall_p (tree fndecl, tree) > >return 1; > } > + > +/* Return TRUE if OP is a PRE_INC or PRE_DEC > +

[ping] [PATCH] C-SKY: Fix unsigned comparison warning

2022-09-16 Thread Jan-Benedict Glaw
On Mon, 2022-09-12 14:19:23 +0200, Jan-Benedict Glaw wrote: > 2022-09-06 Jan-Benedict Glaw > > gcc/ChangeLog: > * config/csky/csky.h (FUNCTION_ARG_REGNO_P): Cast REGNO to (int) > to prevent warning. > > diff --git a/gcc/config/csky/csky.h b/gcc/confi

[COMMITTED] Fix unused variable warning (was: [PATCH 1/3] STABS: remove -gstabs and -gxcoff functionality)

2022-09-14 Thread Jan-Benedict Glaw
number/dpd -I../libdecnumber -I../../gcc/gcc/../libbacktrace -o mips.o -MT mips.o -MMD -MP -MF ./.deps/mips.TPo ../../gcc/gcc/config/mips/mips.cc ../../gcc/gcc/config/mips/mips.cc: In function 'void mips_option_override()': ../../gcc/gcc/config/mips/mips.cc:20021:10: error: unused

Re: [PATCH] Implement known/maybe fpclassify like API for frange.

2022-09-12 Thread Jan-Benedict Glaw
Hi Aldy! On Mon, 2022-09-12 15:12:46 +0200, Aldy Hernandez wrote: > On Mon, Sep 12, 2022 at 10:48 AM Jan-Benedict Glaw wrote: > > > > On Thu, 2022-09-08 12:56:24 +0200, Aldy Hernandez via Gcc-patches > > wrote: > > > > > From 795baa0b044953e9f198f49e37937

[PATCH] C-SKY: Fix unsigned comparison warning

2022-09-12 Thread Jan-Benedict Glaw
rror 1 The needed (int) cast is even mentioned in the comment above, so reinstate it here. 2022-09-06 Jan-Benedict Glaw gcc/ChangeLog: * config/csky/csky.h (FUNCTION_ARG_REGNO_P): Cast REGNO to (int) to prevent warning. diff --git a/gcc/config/csky/csky.h b/gcc/config/csky/csky.h

Re: [PATCH] Implement known/maybe fpclassify like API for frange.

2022-09-12 Thread Jan-Benedict Glaw
Hi Aldy! On Thu, 2022-09-08 12:56:24 +0200, Aldy Hernandez via Gcc-patches wrote: > From 795baa0b044953e9f198f49e379374d633f43b47 Mon Sep 17 00:00:00 2001 > From: Aldy Hernandez > Date: Thu, 8 Sep 2022 08:11:43 +0200 > Subject: [PATCH] Implement known/maybe fpclassify like API for frange. >

Re: [PATCH v3] Simplify memchr with small constant strings

2022-09-09 Thread Jan-Benedict Glaw
Hi! On Wed, 2022-09-07 14:00:25 +0200, Richard Biener wrote: > On Wed, Sep 7, 2022 at 12:58 PM Jan-Benedict Glaw wrote: > > ../../gcc/gcc/tree-ssa-forwprop.cc:1258:42: error: array subscript 1 is > > outside array bounds of 'tree_node* [1]' [-Werror=array-bounds] > > 12

[PATCH] mingw32: Fix warning, update documentation

2022-09-08 Thread Jan-Benedict Glaw
/gcc-x86_64-w64-mingw32/1/toolchain-build/gcc' make: *** [Makefile:4588: all-gcc] Error 2 Also, when TARGET_OVERRIDES_FORMAT_ATTRIBUTES is defined, TARGET_OVERRIDES_FORMAT_ATTRIBUTES_COUNT must be defined as well. Add that requirement to the docs. 2022-09-07 Jan-Benedict Glaw gcc

Re: [PATCH v3] Simplify memchr with small constant strings

2022-09-07 Thread Jan-Benedict Glaw
Hi! On Wed, 2022-07-13 09:50:14 -0700, H.J. Lu via Gcc-patches wrote: > When memchr is applied on a constant string of no more than the bytes of > a word, simplify memchr by checking each byte in the constant string. > > int f (int a) > { >return __builtin_memchr ("AE", a, 2) != 0; > } >

Re: [PATCH] Always default to DWARF2_DEBUG if not specified, warn about deprecated STABS

2022-09-07 Thread Jan-Benedict Glaw
Hi! On Mon, 2022-08-29 22:11:35 +0200, Jan-Benedict Glaw wrote: > On Sun, 2022-08-28 15:32:53 -0600, Jeff Law via Gcc-patches > wrote: > > On 8/28/2022 1:50 AM, Jan-Benedict Glaw wrote: > > > On Tue, 2021-09-21 16:25:19 +0200, Richard Biener via Gcc-patches > > &

[PATCH] msp430: Mark unused attribute

2022-09-06 Thread Jan-Benedict Glaw
'/var/lib/laminar/run/gcc-msp430-elf/1/toolchain-build/gcc' make: *** [Makefile:4584: all-gcc] Error 2 2022-09-06 Jan-Benedict Glaw gcc/ChangeLog: * config/msp430/msp430.cc (msp430_single_op_cost): Mark unused argument. diff --git a/gcc/config/msp430/msp430.cc b/gcc/config/msp430

[PATCH] bpf: Fix unused variable warning

2022-09-05 Thread Jan-Benedict Glaw
Hi! Building for for bpf-unknown-none target, recent GCCs will issue an unused variable warning as the REGNO_REG_CLASS macro doesn't actually use its argument. Reference the argument as (void) to silence the warning. .../gcc/configure --prefix=... --enable-werror-always --enable-languages=all

Re: [PATCH] Always default to DWARF2_DEBUG if not specified, warn about deprecated STABS

2022-08-29 Thread Jan-Benedict Glaw
Hi Jeff! On Sun, 2022-08-28 15:32:53 -0600, Jeff Law via Gcc-patches wrote: > On 8/28/2022 1:50 AM, Jan-Benedict Glaw wrote: > > On Tue, 2021-09-21 16:25:19 +0200, Richard Biener via Gcc-patches > > wrote: > > > This makes defaults.h choose DWARF2_DEBUG if

[PATCH] nvptx: Silence unused variable warning

2022-08-28 Thread Jan-Benedict Glaw
Hi! The nvptx backend defines ASM_OUTPUT_DEF along with ASM_OUTPUT_DEF_FROM_DECLS. Much like the rs6000 coff target, nvptx triggers an unused variable warning: /usr/lib/gcc-snapshot/bin/g++ -fno-PIE -c -g -O2 -DIN_GCC -DCROSS_DIRECTORY_STRUCTURE -fno-exceptions -fno-rtti

Re: [PATCH] Always default to DWARF2_DEBUG if not specified, warn about deprecated STABS

2022-08-28 Thread Jan-Benedict Glaw
On Tue, 2021-09-21 16:25:19 +0200, Richard Biener via Gcc-patches wrote: > This makes defaults.h choose DWARF2_DEBUG if PREFERRED_DEBUGGING_TYPE > is not specified by the target and errors out if DWARF DWARF is not supported. While I think the pdp11 bits arreved, the rest did not (yet). Just

Re: [PATCH] cr16: remove obsoleted port

2022-08-25 Thread Jan-Benedict Glaw
On Thu, 2022-08-25 14:50:12 +0200, Martin Liška wrote: > On 8/25/22 14:48, Jan-Benedict Glaw wrote: > > On Thu, 2022-08-25 10:38:30 +0200, Martin Liška wrote: > >> Remove the port that has been marked obsolete in GCC 12 change notes. > > > >> contrib/ChangeL

Re: [PATCH] cr16: remove obsoleted port

2022-08-25 Thread Jan-Benedict Glaw
On Thu, 2022-08-25 10:38:30 +0200, Martin Liška wrote: > Remove the port that has been marked obsolete in GCC 12 change notes. > contrib/ChangeLog: > > * config-list.mk: Remove cr16. Thanks for not forgetting this part! I hope the scripts will properly pick up the cr16 removal. We'll

Re: [Ada] Remove useless pragma Warnings Off from runtime units

2022-06-27 Thread Jan-Benedict Glaw
Hi! On Thu, 2022-05-12 12:40:09 +, Pierre-Marie de Rodat via Gcc-patches wrote: > GNAT does not issue a warning anymore on a postcondition of True (used > here to prevent inining inside GNATprove for proof). > > Tested on x86_64-pc-linux-gnu, committed on trunk > > gcc/ada/ > > *

Re: [PATCH] Always default to DWARF2_DEBUG if not specified, warn about deprecated STABS

2021-10-24 Thread Jan-Benedict Glaw
Hi Richard, On Sun, 2021-10-24 08:36:36 +0200, Richard Biener wrote: > On October 23, 2021 10:00:05 PM GMT+02:00, Jan-Benedict Glaw > wrote: > >On Tue, 2021-09-21 16:25:19 +0200, Richard Biener via Gcc-patches > > wrote: > >> I have built all targets from contrib/

Re: [PATCH] Always default to DWARF2_DEBUG if not specified, warn about deprecated STABS

2021-10-23 Thread Jan-Benedict Glaw
Hi Richard, On Tue, 2021-09-21 16:25:19 +0200, Richard Biener via Gcc-patches wrote: > I have built all targets from contrib/config-list.mk to make sure we > don't run into the #error and the following makes the STABS usage > explicit for pdp11 and hppa with SOM. I'm running build tests based

Re: [PATCH] Restore --param=max-fsm-thread-length

2021-10-20 Thread Jan-Benedict Glaw
On Wed, 2021-10-20 09:43:42 +0200, Aldy Hernandez via Gcc-patches wrote: > The removal of --param=max-fsm-thread-length is causing code > explosion. I thought that --param=max-fsm-thread-path-insns was a > better gague for path profitability than raw BB length, but it turns > out that we don't

Re: [PATCH] Cleanup --params for backward threader.

2021-10-19 Thread Jan-Benedict Glaw
Hi Aldy! On Thu, 2021-10-14 16:25:48 +0200, Aldy Hernandez via Gcc-patches wrote: > The new backward threader makes some of the --param knobs used to > control it questionable at best or no longer applicable at worst. > > The fsm-maximum-phi-arguments param is unused and can be removed. > >

Re: PING: [AVR] Fix unused argument warning

2021-10-05 Thread Jan-Benedict Glaw
Hi Jeff, On Tue, 2021-10-05 08:53:00 -0600, Jeff Law wrote: > On 10/5/2021 8:46 AM, Jan-Benedict Glaw wrote: > > On Thu, 2021-09-30 21:27:23 +0200, Jan-Benedict Glaw > > wrote: > > > gcc/ChangeLog: > > > > > > * common/config/avr/avr-common.c

PING: [LM32] Fix '"LINK_GCC_C_SEQUENCE_SPEC" redefined' warning

2021-10-05 Thread Jan-Benedict Glaw
Hi, On Thu, 2021-09-30 21:34:51 +0200, Jan-Benedict Glaw wrote: > gcc/ChangeLog: > > * config/lm32/uclinux-elf.h (LINK_GCC_C_SEQUENCE_SPEC): > Undefine before redefinition. > > diff --git a/gcc/config/lm32/uclinux-elf.h b/gcc/config/lm32/uclinux-elf.h &

PING: [AVR] Fix unused argument warning

2021-10-05 Thread Jan-Benedict Glaw
Hi, On Thu, 2021-09-30 21:27:23 +0200, Jan-Benedict Glaw wrote: > gcc/ChangeLog: > > * common/config/avr/avr-common.c (avr_handle_option): Mark > argument as ATTRIBUTE_UNUSED. > > diff --git a/gcc/common/config/avr/avr-common.c > b/gcc/common/config/avr

[LM32] Fix '"LINK_GCC_C_SEQUENCE_SPEC" redefined' warning

2021-09-30 Thread Jan-Benedict Glaw
Hi! When configuring GCC for --target=lm32-uclinux --enable-werror-always, it breaks here: [all 2021-09-30 08:55:55] /usr/lib/gcc-snapshot/bin/g++ -c -g -O2 -DIN_GCC -DCROSS_DIRECTORY_STRUCTURE -fno-exceptions -fno-rtti -fasynchronous-unwind-tables -W -Wall -Wno-narrowing -Wwrite-strings

[AVR] Fix unused argument warning

2021-09-30 Thread Jan-Benedict Glaw
Hi! Configuring GCC with --target=avr-elf --enable-werror-always, I see this warning that's easy to fix. The options are parsed with a lot of #ifdefs and it may actually just be unused. Let's just mark it as such. [all 2021-09-30 00:43:46] /usr/lib/gcc-snapshot/bin/g++ -fno-PIE -c -g -O2

Re: [PATCH] Add cr16-*-* to the list of obsoleted targets

2021-09-13 Thread Jan-Benedict Glaw
Hi! On Mon, 2021-09-13 11:58:59 +0200, Richard Biener wrote: > On Mon, 13 Sep 2021, Jan-Benedict Glaw wrote: > > contrib/ChangeLog: > > > > * config-list.mk (LIST): --enable-obsolete for cr16-elf. > > [...] > OK. Committed, thanks! MfG, JBG -- signature.asc Description: PGP signature

Re: [PATCH] Fix multi-statement define for alpha-dec-vms

2021-09-13 Thread Jan-Benedict Glaw
Hi! On Mon, 2021-09-13 11:11:30 +0200, Richard Biener wrote: > On Sun, Sep 12, 2021 at 8:12 PM Jan-Benedict Glaw wrote: > > gcc/ChangeLog: > > > > * config/alpha/vms.h (INIT_CUMULATIVE_ARGS): Wrap multi-statment > > define into a block. > OK.

Re: [PATCH] Add cr16-*-* to the list of obsoleted targets

2021-09-13 Thread Jan-Benedict Glaw
Hi Richard, On Mon, 2021-09-13 11:24:53 +0200, Richard Biener via Gcc-patches wrote: > This adds cr16-*-* to the list of obsoleted targets in config.gcc > > Approved by Jeff in another thread, pushed. cr16 has no maintainer and > it's still cc0. > > 2021-09-13 Richard Biener > > *

Re: [PATCH] Remove dbx.h, do not set PREFERRED_DEBUGGING_TYPE from dbxcoff.h, lynx.h

2021-09-12 Thread Jan-Benedict Glaw
Hi Richard, On Fri, 2021-09-10 08:02:00 +0200, Richard Biener via Gcc-patches wrote: > > On 9/9/2021 7:19 AM, Richard Biener via Gcc-patches wrote: > > > The patch also removes the PREFERRED_DEBUGGING_TYPE define from > > > lynx.h which always follows elfos.h already defaulting to DWARF, > > >

[PATCH] Fix multi-statement define for alpha-dec-vms

2021-09-12 Thread Jan-Benedict Glaw
Hi! While mass-building a cross-gcc, I noticed that for alpha-dec-vms/alpha64-dec-vms, recent GCC versions correctly throw a warning due to a multi-statement define that gets rippen in an if/else case: [all 2021-09-12 15:51:55] /usr/lib/gcc-snapshot/bin/g++ -fno-PIE -c -g -O2 -DIN_GCC

Re: [PATCH 0/13] v2 warning control by group and location (PR 74765)

2021-07-17 Thread Jan-Benedict Glaw
Hi Martin! On Fri, 2021-06-04 15:27:04 -0600, Martin Sebor wrote: > This is a revised patch series to add warning control by group and > location, updated based on feedback on the initial series. [...] My automated checking (in this case: Using Debian's "gcc-snapshot" package) indicates that

Re: pdp11: Fix warnings to allow compilation with a recent GCC and --enable-werror-always

2021-06-29 Thread Jan-Benedict Glaw
On Mon, 2021-06-28 16:17:13 +, Koning, Paul wrote: > > On Jun 28, 2021, at 11:33 AM, Jan-Benedict Glaw wrote: > > > > I'd like to install this patch to let the pdp11-aout configuration > > build again with eg. [...] > > Okay for master? > Yes, t

pdp11: Fix warnings to allow compilation with a recent GCC and --enable-werror-always

2021-06-28 Thread Jan-Benedict Glaw
Hi Paul! I'd like to install this patch to let the pdp11-aout configuration build again with eg. ../gcc/configure --target=pdp11-aout --enable-werror-always \ --enable-languages=all --disable-gcov --disable-shared \ --disable-threads --without-headers \

Re: [PATCH, arc]: Drop "register" keyword

2021-05-26 Thread Jan-Benedict Glaw
Hi Jukub & Richard, On Wed, 2021-05-26 14:47:20 +0200, Jakub Jelinek wrote: > On Wed, May 26, 2021 at 02:42:47PM +0200, Jan-Benedict Glaw wrote: > > The "register" keyword was removed in C++17, remove them to get the > > backen > > s/

[PATCH, arc]: Drop "register" keyword

2021-05-26 Thread Jan-Benedict Glaw
Hi! I'd like to commit the following patch. Okay for master? Thanks, Jan-Benedict arc: Remove useless register keyword The "register" keyword was removed in C++17, remove them to get the backen to build again. gcc/ * config/arc/arc.c

Re: [committed] amdgcn: Silence warnings in gcn.c

2021-03-18 Thread Jan-Benedict Glaw
Hi Andrew, On Thu, 2021-03-18 17:41:59 +, Andrew Stubbs wrote: > gcc/ChangeLog: > > (gcn_vectorize_vec_perm_const): Ensure perm is fully uninitialized. I guess "initialized" is ment here? MfG, JBG -- signature.asc Description: PGP signature

Re: GCC: v850-elf

2021-03-17 Thread Jan-Benedict Glaw
Hi Nick! On Wed, 2021-03-17 15:44:16 +, Nick Clifton wrote: > > However, next one is: > > > ../.././gcc/defaults.h:938: error: "PREFERRED_DEBUGGING_TYPE" redefined > > [-Werror] > >938 | #define PREFERRED_DEBUGGING_TYPE NO_DEBUG > > Ah - this is the same as the fix needed for the RX

Re: GCC: v850-elf

2021-03-17 Thread Jan-Benedict Glaw
On Tue, 2021-03-16 11:32:29 +, Nick Clifton wrote: > Hi Jan-Benedict, > > > With my re-started testing efforts, I've got another one for you I > > guess (`./configure --target=v850-elf && make all-gcc`): > > > > ../.././gcc/config/v850/v850.c: In function ‘char* > >

Re: [BUILDROBOT] RISC-V: ‘profile_probability’ has not been declared

2017-07-13 Thread Jan-Benedict Glaw
Hi Jeff! On Thu, 2017-07-13 14:43:52 -0600, Jeff Law <l...@redhat.com> wrote: > On 07/13/2017 02:39 PM, Jan-Benedict Glaw wrote: > > On Thu, 2017-06-29 14:27:41 +0200, Jan Hubicka <hubi...@ucw.cz> wrote: > >> this is second step of the profile main

[BUILDROBOT] RISC-V: ‘profile_probability’ has not been declared (was: Convert profile probabilities to new type)

2017-07-13 Thread Jan-Benedict Glaw
e: *** [all-gcc] Error 2 -- Jan-Benedict Glaw jbg...@lug-owl.de +49-172-7608481 Signature of: They that give up essential liberty to obtain temporary safety, the second : deserve neither liberty nor safety. (Ben Franklin) signature.asc Description: Digital signature

Re: [BUILDROBOT] error: format ‘%d’ expects argument of type ‘int’, but argument 3 has type ‘long int’ (was: [PATCH] [ARC] Recognise add_n and sub_n in combine again)

2017-06-25 Thread Jan-Benedict Glaw
Hi Graham, On Mon, 2017-06-12 11:40:39 +0200, Jan-Benedict Glaw <jbg...@lug-owl.de> wrote: > On Fri, 2017-05-12 20:14:23 +0100, Graham Markall > <graham.mark...@embecosm.com> wrote: > > Since the combine pass canonicalises shift-add insns using plus and > > ashif

[BUILDROBOT] No rule to make target '/home/jbglaw/repos/gcc/gcc/config/rs6000/e500.h', needed by 's-gtype' (was: [PATCH 01/14] rs6000: Remove TARGET_FPRS)

2017-06-12 Thread Jan-Benedict Glaw
tmp-options.h /bin/bash /home/jbglaw/repos/gcc/gcc/../move-if-change tmp-options.h options.h echo timestamp > s-options-h make[1]: *** No rule to make target '/home/jbglaw/repos/gcc/gcc/config/rs6000/e500.h', needed by 's-gtype'. Stop. make[1]: Leaving directory '/home/jbglaw/build/powerpc-rtems/buil

[BUILDROBOT] error: format ‘%d’ expects argument of type ‘int’, but argument 3 has type ‘long int’ (was: [PATCH] [ARC] Recognise add_n and sub_n in combine again)

2017-06-12 Thread Jan-Benedict Glaw
^ cc1plus: all warnings being treated as errors MfG, JBG -- Jan-Benedict Glaw jbg...@lug-owl.de +49-172-7608481 Signature of: God put me on earth to accomplish a certain number of the second :things. Right now I am so far behind I will never die. signature.asc Description: Digital signature

[BUILDROBOT] Maybe uninitialized warnings in mips targets (was: [PATCH] Fix PR79345, better uninit warnings for memory)

2017-03-18 Thread Jan-Benedict Glaw
http://toolchain.lug-owl.de/buildbot/show_build_details.php?id=699726 mips-netbsd: http://toolchain.lug-owl.de/buildbot/show_build_details.php?id=699750 MfG, JBG -- Jan-Benedict Glaw jbg...@lug-owl.de +49-172-7608481 Signature of: God put me on earth to accom

Re: [BUILDROBOT] arm-netbsdelf: Error during -fself-test (was: [PATCH] TS_OPTIMIZATION/TS_TARGET_OPTION need no chain/type)

2017-02-28 Thread Jan-Benedict Glaw
On Mon, 2017-02-27 09:19:51 +0100, Richard Biener <rguent...@suse.de> wrote: > On Mon, 27 Feb 2017, Jan-Benedict Glaw wrote: > > On Wed, 2017-01-11 16:28:33 +0100, Richard Biener <rguent...@suse.de> wrote: > > > On Wed, 11 Jan 2017, Richard Biener wrote: > > &g

[BUILDROBOT] arm-netbsdelf: Error during -fself-test (was: [PATCH] TS_OPTIMIZATION/TS_TARGET_OPTION need no chain/type)

2017-02-26 Thread Jan-Benedict Glaw
Please submit a full bug report, with preprocessed source if appropriate. Please include the complete backtrace with any bug report. See <https://gcc.gnu.org/bugs/> for instructions. Makefile:1932: recipe for target 's-selftest' failed Reverting your patch from current HEAD lets the self-te

[BUILDROBOT] [Ada] error: alignment of array elements is greater than element size (was: [PATCH] GIMPLE store merging pass)

2016-10-29 Thread Jan-Benedict Glaw
/jbglaw/src/toolchain/build' make: *** [all] Error 2 I bisected it down to this commit, though I don't know if it caused or uncovered the issue. MfG, JBG -- Jan-Benedict Glaw jbg...@lug-owl.de +49-172-7608481 signature.asc Description: Digital signature

Re: Fix missing FALLTHRU comments

2016-09-30 Thread Jan-Benedict Glaw
pha/predicates.md:184, too? /* ... fall through ... */ This showed up on my build robot recently. MfG, JBG -- Jan-Benedict Glaw jbg...@lug-owl.de +49-172-7608481 Signature of: Friends are relatives you make for yourself. the second : signature.asc Description: Digital signature

[BUILDROBOT] tic6x-uclinux: undefined reference to `gnu_libc_printf_pointer_format(tree_node*, char const**)' (was: [PATCH] - improve sprintf buffer overflow detection (middle-end/49905))

2016-09-26 Thread Jan-Benedict Glaw
Make-lang.in:84: recipe for target 'cc1' failed make[1]: *** [cc1] Error 1 make[1]: Leaving directory '/home/jbglaw/build/tic6x-uclinux/build-gcc/gcc' Makefile:4252: recipe for target 'all-gcc' failed make: *** [all-gcc] Error 2 Add another one for uClibc? MfG, JBG -- Jan-Benedict Glaw

[BUILDROBOT] vax-netbsdelf / vax-linux: ‘ELIMINABLE_REGS’ was not declared in this scope (was: [PATCH] Remove support for INITIAL_FRAME_POINTER_OFFSET)

2016-09-17 Thread Jan-Benedict Glaw
d > fixes a few bits > in the documentation. I'd say that part of the documentation is quite out of > sync, but I just > have to stop somewhere. > > > Bootstrapped and reg-tested on x86_64-pc-linux.gnu The vax backend doesn't yet define ELIMINABLE_REGS. MfG, JBG --

[BUILDROBOT] x86_64: Segmentation fault during -fself-test (was: Implement C _FloatN, _FloatNx types [version 6]

2016-08-22 Thread Jan-Benedict Glaw
://gcc.gnu.org/bugs.html> for instructions. make[1]: *** [s-selftest] Error 1 See eg. build http://toolchain.lug-owl.de/buildbot/show_build_details.php?id=608741 MfG, JBG -- Jan-Benedict Glaw jbg...@lug-owl.de +49-172-7608481 Signature of: We

Re: [BUILDROBOT] avr broken

2016-08-17 Thread Jan-Benedict Glaw
On Tue, 2016-08-16 14:26:38 -0400, Nathan Sidwell <nat...@acm.org> wrote: > On 08/16/16 13:04, Jan-Benedict Glaw wrote: > > > That'll probably work. But after all, I'm not an AVR maintainer > > (not even an user), but just running the Build Robot. > > Does your

[BUILDROBOT] avr broken (was: [PATCH 1/4] Cherry-pick fprofile-generate-atomic from google/gcc-4_9 branch)

2016-08-13 Thread Jan-Benedict Glaw
n expansion of macro ‘INT_TYPE_SIZE’ #define LONG_LONG_TYPE_SIZE (INT_TYPE_SIZE == 8 ? 32 : 64) ^ /home/jbglaw/repos/gcc/gcc/gcov-io.h:167:5: note: in expansion of macro ‘LONG_LONG_TYPE_SIZE’ #if LONG_LONG_TYPE_SIZE > 32 ^ Makefile:1096: recipe for target 'au

Re: [BUILDROBOT] Selftest failed for i686-wrs-vxworks

2016-07-06 Thread Jan-Benedict Glaw
) set WIND_BASE to a dummy value in contrib/config-list.mk (if not > already set) so that the vxworks targets are able to at least build all > of "gcc" without needing a vxworks install. I'd probably just do (b) and go for it. Easy, non-invasive fix. MfG, JBG -- Jan-Benedict Glaw jbg...@lug-owl.de +49-172-7608481 Signature of:Don't believe in miracles: Rely on them! the second : signature.asc Description: Digital signature

[BUILDROBOT] Selftest failed for i686-wrs-vxworks

2016-06-30 Thread Jan-Benedict Glaw
-- Jan-Benedict Glaw jbg...@lug-owl.de +49-172-7608481 Signature of: 17:44 <@uschebit> Evangelist ist doch ein Vertriebler the second : für unverkäufliche Produkte, oder? (#korsett, 20120821) signature.asc Description: Digital signature

Re: [PATCH] config-list.mk AIX update

2016-06-20 Thread Jan-Benedict Glaw
Of course, you're AIX maintainer after all. ;-) Just a nitpick: Right now, the old AIX configurations weren't marked as --enable-obsolete targets in gcc/config.gcc . So I suggest to add those there as well. MfG, JBG -- Jan-Benedict Glaw jbg...@lug-owl.de +49-1

[BUILDROBOT] Selftest failed for rs6000-ibm-aix4.3

2016-06-18 Thread Jan-Benedict Glaw
ildbot/show_build_details.php?id=572874, which is as simple as .../configure --enable-languages=c,c++ --target=rs6000-ibm-aix4.3 --without-headers --disable-threads MfG, JBG -- Jan-Benedict Glaw jbg...@lug-owl.de +49-172-7608481 Signature of: Alles sollte so einfa

[BUILDROBOT] MPS430 build problem due to new enum (was: [PATCH 2/2] Add edge predictions pruning)

2016-06-12 Thread Jan-Benedict Glaw
bb, !first_match ? NONE : IGNORED); ^ [...] The new `NONE' from your enum clashes with a NONE used in a MSP430 private enum. MfG, JBG -- Jan-Benedict Glaw jbg...@lug-owl.de +49-172-7608481 Signature of: They that give up essentia

Re: Patches to fix optimizer bug & C++ exceptions for GCC VAX backend

2016-04-04 Thread Jan-Benedict Glaw
ptimizer > not delete the insns. All of the other stuff can be worked on in > NetBSD-current and avoid bothering the 99% of people who subscribe > to gcc-patches who have no interest in the VAX backend. You should /for sure/ bother the gcc-patches people! Please keep Cc'ing patches to that mai

Re: Patches to fix optimizer bug & C++ exceptions for GCC VAX backend

2016-03-31 Thread Jan-Benedict Glaw
needed. MfG, JBG -- Jan-Benedict Glaw jbg...@lug-owl.de +49-172-7608481 Signature of: Ich hatte in letzter Zeit ein bißchen viel Realitycheck. the second : Langsam möchte ich mal wieder weiterträumen können. -- Maxim

Re: [PATCH, rs6000] Fix PR63354

2016-01-23 Thread Jan-Benedict Glaw
iled make[1]: *** [all-gcc] Error 2 make[1]: Leaving directory '/home/jbglaw/build-configlist_mk/powerpc-xilinx-eabi/build-gcc/mk/powerpc-xilinx-eabi' MfG, JBG -- Jan-Benedict Glaw jbg...@lug-owl.de +49-172-7608481 Signature of: Träume nicht von Deinem Leben: Lebe D

config-list.mk and obsoleted configurations (was: [BUILDROBOT] "error: null argument where non-null required" on multiple targets)

2015-12-17 Thread Jan-Benedict Glaw
On Thu, 2015-12-17 11:05:42 -0700, Jeff Law <l...@redhat.com> wrote: > On 12/16/2015 03:46 AM, Jan-Benedict Glaw wrote: > > Shall I bisect one of the cases anew, with the "Test value of > > _GLIBCXX_USE_C99_WCHAR not whether it is defined" patch that > > unco

Re: config-list.mk and obsoleted configurations

2015-12-17 Thread Jan-Benedict Glaw
On Thu, 2015-12-17 11:39:24 -0700, Jeff Law <l...@redhat.com> wrote: > On 12/17/2015 11:34 AM, Jan-Benedict Glaw wrote: > > On Thu, 2015-12-17 11:05:42 -0700, Jeff Law <l...@redhat.com> wrote: > > > On 12/16/2015 03:46 AM, Jan-Benedict Glaw wrote: > > >

Re: [BUILDROBOT] "error: null argument where non-null required" on multiple targets

2015-12-16 Thread Jan-Benedict Glaw
On Tue, 2015-12-15 10:43:58 -0700, Jeff Law <l...@redhat.com> wrote: > On 12/14/2015 01:07 PM, Jan-Benedict Glaw wrote: > >On Mon, 2015-12-14 18:54:28 +, Moore, Catherine > ><catherine_mo...@mentor.com> wrote: > >>>avr-rtems &g

  1   2   3   >