Re: [PATCH] cmpelim: recognize extra clobbers in insns

2020-08-28 Thread Pip Cet via Gcc-patches
On Mon, Aug 24, 2020 at 6:12 PM Jeff Law wrote: > On Thu, 2020-08-06 at 12:42 +0000, Pip Cet via Gcc-patches wrote: > > I've bootstrapped and run the test suite with the patch, without > > differences. > So it looks like Richard has given you some feedback and you've got some

Re: [PATCH] cmpelim: recognize extra clobbers in insns

2020-08-20 Thread Pip Cet via Gcc-patches
On Wed, Aug 19, 2020 at 11:05 AM Richard Sandiford wrote: > Sorry for the slow reply. Not a problem at all. Thank you for responding! > Pip Cet via Gcc-patches writes: > > I'm working on the AVR cc0 -> CCmode conversion (bug#92729). One > > problem is that the cmpelim p

[PATCH] cmpelim: recognize extra clobbers in insns

2020-08-06 Thread Pip Cet via Gcc-patches
I'm working on the AVR cc0 -> CCmode conversion (bug#92729). One problem is that the cmpelim pass is currently very strict in requiring insns of the form (parallel [(set (reg:SI) (op:SI ... ...)) (clobber (reg:CC REG_CC))]) when in fact AVR's insns often have the form (parallel [(set

Re: [PATCH] Prefer simple case changes in spelling suggestions

2020-06-05 Thread Pip Cet via Gcc-patches
David Malcolm writes: > On Sat, 2020-05-30 at 18:51 +, Pip Cet wrote: >> How's this? > > Thanks; looks good to me. Hopefully this doesn't clash with Tom's > patch. It doesn't, but I hope I got the commit message right this time. (I don't have git access, so if someone could commit this if

Re: [PATCH] Prefer simple case changes in spelling suggestions

2020-05-30 Thread Pip Cet via Gcc-patches
On Sat, May 30, 2020 at 5:06 PM David Malcolm wrote: > On Sat, 2020-05-30 at 13:40 +0000, Pip Cet via Gcc-patches wrote: > > I think we should just omit the triangle inequality test from the > > self-test, as in the attached patch. > > I like the idea, Thanks! > but ca

Re: [PATCH] Prefer simple case changes in spelling suggestions

2020-05-30 Thread Pip Cet via Gcc-patches
On Fri, May 29, 2020 at 6:21 PM Pip Cet wrote: > IIRC, minimum string alignment does not satisfy the triangle > inequality anyway, so test_metric_conditions should probably not > pretend to test it... I did remember correctly, though of course that should have been "optimal string alignment"

Re: [PATCH] Prefer simple case changes in spelling suggestions

2020-05-29 Thread Pip Cet via Gcc-patches
On Fri, May 29, 2020 at 6:02 PM Tom Tromey wrote: > This patch changes gcc's spell checker to prefer simple case changes > when possible. > > I tested this using the self-tests. A new self-test is also included. I think that's great, but it should be mentioned in the comment that the distance