.3:
... ...
Tested on powerpc as well as ran manual tests. Okay for google/4_9 branch?
Thanks,
Sharad
2014-09-15 Sharad Singhai sing...@google.com
Google Ref b/17114943
* l-ipo.c (promote_static_var_func): Update RTL with the unique name.
testsuite
-0800, Sharad Singhai sing...@google.com
wrote:
I am really sorry about the delay.
No worries; not exactly a severe issue. ;-)
I couldn't exactly reproduce the
warning which you described
Maybe the version of makeinfo is relevant?
$ makeinfo --version | head -n 1
makeinfo (GNU
.
Also I would appreciate the exact command which produces these warnings.
Thanks,
Sharad
2014-02-05 Sharad Singhai sing...@google.com
* doc/optinfo.texi: Fix order of nodes.
Index: doc/optinfo.texi
===
--- doc/optinfo.texi (revision
Committed documentation as r206161. Sorry about the delay.
Thanks,
Sharad
On Thu, Nov 28, 2013 at 10:03 AM, Martin Jambor mjam...@suse.cz wrote:
Hi,
On Tue, Aug 06, 2013 at 10:18:05AM -0700, Sharad Singhai wrote:
On Tue, Aug 6, 2013 at 10:10 AM, Martin Jambor mjam...@suse.cz wrote:
On Tue
I am really sorry, I forgot to add gcc internal documentation for dump
functions. Sorry about a very long delay.
The attached patch adds some documentation about how to use the new
dump infrastructure. This doc is attached to 'passes' documentation
node as that seemed the most logical place.
for the trunk?
Thanks,
Sharad
2013-10-29 Sharad Singhai sing...@google.com
PR middle-end/58134
* opts.c (common_handle_option): Remove deprecated option
-ftree-vectorizer-verbose.
* doc/invoke.texi (Debugging Options): Ditto.
* common.opt: Ditto.
* opts
On Fri, Aug 30, 2013 at 9:58 PM, Teresa Johnson tejohn...@google.com wrote:
Besides, we might also want to
use the same machinery (dump_printf_loc etc) for dump file dumping.
The current behavior of using '-details' to turn on opt-info-all
messages for dump files are not desirable.
On Tue, Aug 6, 2013 at 8:57 AM, Xinliang David Li davi...@google.com wrote:
On Tue, Aug 6, 2013 at 5:37 AM, Martin Jambor mjam...@suse.cz wrote:
Hi,
On Mon, Aug 05, 2013 at 10:37:00PM -0700, Teresa Johnson wrote:
This patch ports messages to the new dump framework,
It would be great this
On Tue, Aug 6, 2013 at 10:10 AM, Martin Jambor mjam...@suse.cz wrote:
On Tue, Aug 06, 2013 at 09:22:02AM -0700, Sharad Singhai wrote:
On Tue, Aug 6, 2013 at 8:57 AM, Xinliang David Li davi...@google.com wrote:
On Tue, Aug 6, 2013 at 5:37 AM, Martin Jambor mjam...@suse.cz wrote:
Hi
) || FLOAT_TYPE_P (expr_type)))
? OPT_Wreal_conversion
: OPT_Wconversion;
Also why did you put the warn_type code inside the default?
David
On Mon, Jun 24, 2013 at 10:03 PM, Sharad Singhai sing...@google.com wrote:
On Mon, Jun 24, 2013 at 9:14 PM, Xinliang David Li davi...@google.com
wrote:
To avoid
I reverted the earlier broken patch. I am including an updated patch
which warns only for real conversion, not for integral conversions. I
also updated the test case to include an integral conversion (int to
char) which doesn't emit the warning with the -Wreal-conversion flag.
Bootstrapped and
Hi,
This patch forward ports the -Wreal-conversion warning to
google/gcc-4_8 branch (google ref 39133-p2). I tweaked the patch a
little bit to avoid printing duplicate warnings when both -Wconversion
and -Wreal-conversion are specified. Also, I trimmed the test case to
avoid testing for
On Mon, Jun 24, 2013 at 9:14 PM, Xinliang David Li davi...@google.com wrote:
To avoid printing twice, can you just do
opt_type = (warn_conversion ? OPT_Wconversion : OPT_Wreal_conversion);
warning_at (loc, opt_type, ...);
Thanks for the suggestion. I have updated the enclosed patch and
On Tue, Jun 18, 2013 at 3:28 AM, Jan Hubicka hubi...@ucw.cz wrote:
Ping.
Th patch is OK, thanks!
I see you added gcov.exp file support, do you have a testcases?
Yes, I added support for verifying intermediate format in gcov.exp. I
also added a minimal testcase for intermediate format in
Ping.
Thanks,
Sharad
On Wed, Jun 5, 2013 at 11:18 AM, Sharad Singhai sing...@google.com wrote:
Ping.
Thanks,
Sharad
On Tue, May 28, 2013 at 11:35 AM, Sharad Singhai sing...@google.com wrote:
Sorry, my patch had bad formatting in one of the functions
(output_gcov_file). Here
Ping.
Thanks,
Sharad
On Tue, May 28, 2013 at 11:35 AM, Sharad Singhai sing...@google.com wrote:
Sorry, my patch had bad formatting in one of the functions
(output_gcov_file). Here is the corrected version.
Thanks,
Sharad
(2013-05-28sing...@google.com
* gcov.c (print_usage): Handle
.
(release_function): Relase demangled name.
(read_graph_file): Handle demangled name.
(output_lines): Ditto.
* doc/gcov.texi: Document gcov intermediate format.
testsuite/ChangeLog:
2013-05-28 Sharad Singhai sing...@google.com
* g++.dg/gcov/gcov-8.C: New testcase.
* lib/gcov.exp: Handle intermediate
.
(output_intermediate_file): New function.
(output_gcov_file): New function
(generate_results): Handle new option.
(release_function): Relase demangled name.
(read_graph_file): Handle demangled name.
(output_lines): Ditto.
* doc/gcov.texi: Document gcov intermediate format.
testsuite/ChangeLog:
2013-05-28 Sharad
On Fri, May 24, 2013 at 7:42 PM, Xinliang David Li davi...@google.com wrote:
On Fri, May 24, 2013 at 2:32 PM, Sharad Singhai sing...@google.com wrote:
if (flag_gcov_file)
{
- char *gcov_file_name
-= make_gcov_file_name (file_name, src-coverage.name
All tests passed. Committed as r199390 in google/gcc-4_8.
Thanks,
Sharad
On Tue, May 28, 2013 at 11:45 AM, Sharad Singhai sing...@google.com wrote:
On Fri, May 24, 2013 at 7:42 PM, Xinliang David Li davi...@google.com wrote:
On Fri, May 24, 2013 at 2:32 PM, Sharad Singhai sing...@google.com
Hi,
This patch forward ports r175134 from google/gcc-4.7 into
google/gcc-4.8. The intermediate format is a bit simplified. I am also
planning to propose this for trunk in a separate message.
Bootstrapped and tested on x86_64. Okay for google/gcc-4_8?
Thanks,
Sharad
2013-05-24 Sharad Singhai
This patch fixes an ICE in vectorization dump when section anchors are present.
Bootstrapped/tested on x86_64 and PPC 64 and found no new failures. OK
for trunk?
Thanks,
Sharad
2013-01-18 Sharad Singhai sing...@google.com
PR tree-optimization/55995
* dumpfile.c (dump_loc): Print location
6) do not forget the tree level unroller.
David
On Thu, Dec 13, 2012 at 6:15 PM, Sharad Singhai sing...@google.com wrote:
Hi,
As per discussion in http://gcc.gnu.org/ml/gcc/2012-12/msg00056.html,
the attached patch updates loop unroll passes to use new dump
infrastructure.
This patch
Hi,
As per discussion in http://gcc.gnu.org/ml/gcc/2012-12/msg00056.html,
the attached patch updates loop unroll passes to use new dump
infrastructure.
This patch filters relevant dump messages into the following
three categories
- optimized: an optimization was successfully applied
- missed:
On Tue, Oct 30, 2012 at 4:04 PM, Sharad Singhai sing...@google.com wrote:
Hi Jakub,
My -fopt-info pass filtering patch
(http://gcc.gnu.org/ml/gcc-patches/2012-10/msg02704.html) is being
reviewed and I hope to get this in by Nov. 5 for inclusion in gcc
4.8.0.
I just committed -fopt-info pass
I am really sorry about that. I am looking and will fix the breakage
or revert the patch shortly.
Thanks,
Sharad
On Thu, Nov 1, 2012 at 5:28 AM, Jakub Jelinek ja...@redhat.com wrote:
On Thu, Nov 01, 2012 at 12:52:04AM -0700, Sharad Singhai wrote:
On Tue, Oct 30, 2012 at 4:04 PM, Sharad Singhai
On Thu, Nov 1, 2012 at 9:44 AM, Diego Novillo dnovi...@google.com wrote:
On Thu, Nov 1, 2012 at 12:40 PM, Sharad Singhai sing...@google.com wrote:
I found the problem and the following patch fixes it. The issue with
my testing was that I was only looking at 'FAIL' lines but forgot to
tally
Hi Jakub,
My -fopt-info pass filtering patch
(http://gcc.gnu.org/ml/gcc-patches/2012-10/msg02704.html) is being
reviewed and I hope to get this in by Nov. 5 for inclusion in gcc
4.8.0.
Thanks,
Sharad
On Mon, Oct 29, 2012 at 10:56 AM, Jakub Jelinek ja...@redhat.com wrote:
Status
==
I'd
Added myself as write after approval maintainer in r192781.
Thanks,
Sharad
Index: ChangeLog
===
--- ChangeLog (revision 192779)
+++ ChangeLog (working copy)
@@ -1,3 +1,7 @@
+2012-10-24 Sharad Singhai sing...@google.com
As per discussion in http://gcc.gnu.org/ml/gcc/2012-10/msg00366.html.
I have applied the following obvious fix for rs6000 broken bootstrap.
2012-10-24 Sharad Singhai sing...@google.com
* config/rs6000/rs6000.c (rs6000_density_test): Use dump_enabled_p
instead of dump_kind_p
+cc richard.guent...@gmail.com
If it is approved, I will be happy to commit it for you.
Thanks,
Sharad
Sharad
On Tue, Oct 23, 2012 at 6:52 AM, Dominique Dhumieres domi...@lps.ens.fr wrote:
Following the changes in [PATCH] Add option for dumping to stderr
(issue6190057)
the tests
))
+ || ! cond_arg_set_in_bb (e3, e-dest))
e2 = thread_around_empty_block (e3,
dummy_cond,
handle_dominating_asserts,
Sharad
On Tue, Oct 23, 2012 at 4:48 PM, Sharad Singhai sing...@google.com wrote:
The trunk seems to be broken at r192749 due to this patch.
../../srctrunk
Committed in r192750.
Thanks,
Sharad
On Tue, Oct 23, 2012 at 2:46 PM, Mike Stump mikest...@comcast.net wrote:
On Oct 23, 2012, at 6:52 AM, Dominique Dhumieres domi...@lps.ens.fr wrote:
Following the changes in [PATCH] Add option for dumping to stderr
(issue6190057)
the tests
for trunk?
Thanks,
Sharad
2012-10-19 Sharad Singhai sing...@google.com
* dumpfile.c (dump_phase_enabled_p): Renamed dump_enabled_p. Update
all callers.
(dump_enabled_p): A new function to check if any of the dump files
is available.
(dump_kind_p): Remove check for current_function_decl. Add
are available.
I have bootstrapped and tested on x86_64. Okay for trunk?
Thanks,
Sharad
2012-10-18 Sharad Singhai sing...@google.com
* dumpfile.c (dump_enabled_phase): New function.
(dump_enabled_p): Rename to dump_enabled_phase. Update all callers.
A new function with the same name to check
, 2012 at 4:35 AM, Sharad Singhai sing...@google.com
wrote:
Thanks for the review. A couple of comments inline:
Some minor issues:
* c/c-decl.c (c_write_global_declarations): Use different
method to
determine if the dump has ben initialized.
* cp/decl2.c
I am sorry, I didn't enable all the languages. Will fix the fortran
test breakage shortly.
Thanks,
Sharad
Sharad
On Mon, Oct 1, 2012 at 4:50 AM, H.J. Lu hjl.to...@gmail.com wrote:
On Sun, Sep 30, 2012 at 11:36 PM, Sharad Singhai sing...@google.com wrote:
Resend to gcc-patches
I have
Okay, I am retesting without any special configs and with multilibs as
you suggested.
Thanks,
Sharad
On Mon, Oct 1, 2012 at 7:00 AM, Richard Guenther
richard.guent...@gmail.com wrote:
On Mon, Oct 1, 2012 at 3:55 PM, Sharad Singhai sing...@google.com wrote:
On Mon, Oct 1, 2012 at 6:52 AM, H.J
to install?
2012-10-01 Michael Meissner meiss...@linux.vnet.ibm.com
* config/rs6000/rs6000.c (toplevel): Include dumpfile.h.
(rs6000_density_test): Rework to accomidate 09-30 change by Sharad
Singhai.
* config/rs6000/t-rs6000 (rs6000.o): Add dumpfile.h
Here is a patch to fix test breakage caused by r191883. Bootstrapped
on x86_64 and tested with
make -k check RUNTESTFLAGS=--target_board=unix/\{,-m32\}.
Okay for trunk?
Thanks,
Sharad
2012-10-01 Sharad Singhai sing...@google.com
* tree-vect-stmts.c (vectorizable_operation): Add
I have mailed a patch to fix test failures caused by r191884. Waiting
for an okay.
http://gcc.gnu.org/ml/gcc-patches/2012-10/msg00109.html
Thanks,
Sharad
Sharad
On Mon, Oct 1, 2012 at 11:39 AM, Gabriel Dos Reis
g...@integrable-solutions.net wrote:
On Mon, Oct 1, 2012 at 1:27 PM, Michael
Thanks for the review. A couple of comments inline:
Some minor issues:
* c/c-decl.c (c_write_global_declarations): Use different method to
determine if the dump has ben initialized.
* cp/decl2.c (cp_write_global_declarations): Ditto.
*
Ping.
On Sep 18, 2012 8:43 AM, Xinliang David Li davi...@google.com wrote:
On Tue, Sep 18, 2012 at 1:48 AM, Sharad Singhai sing...@google.com wrote:
In response to the recent comments, I have updated the patch to do the
following:
- Remove pass handling from -fopt-info
- Support additional
, 2012 at 4:08 AM, Richard Guenther
richard.guent...@gmail.com wrote:
On Wed, Sep 12, 2012 at 6:46 PM, Xinliang David Li davi...@google.com wrote:
On Wed, Sep 12, 2012 at 3:30 AM, Richard Guenther
richard.guent...@gmail.com wrote:
On Wed, Sep 12, 2012 at 10:12 AM, Sharad Singhai sing...@google.com
Is -fopt-info-rtl-all also accepted?
Currently it is accepted. However, based on the recent comments, I am
going to remove the pass name from the flags.
It would be useful to have a good default for -fopt-info so that users
can get high level info about optimizations without having to
Ping.
Thanks,
Sharad
Sharad
On Wed, Sep 5, 2012 at 10:34 AM, Sharad Singhai sing...@google.com wrote:
Ping.
Thanks,
Sharad
Sharad
On Fri, Aug 24, 2012 at 1:06 AM, Sharad Singhai sing...@google.com wrote:
Sorry about the delay. Please see comments inline.
On Wed, Jul 4, 2012 at 6
Thanks for your comments. Responses inline.
On Wed, Jun 13, 2012 at 4:48 AM, Richard Guenther
richard.guent...@gmail.com wrote:
On Fri, Jun 8, 2012 at 7:16 AM, Sharad Singhai sing...@google.com wrote:
Okay, I have updated the attached patch so that the output from
-ftree-vectorizer-verbose
On Wed, Jun 13, 2012 at 4:48 AM, Richard Guenther
richard.guent...@gmail.com wrote:
On Fri, Jun 8, 2012 at 7:16 AM, Sharad Singhai sing...@google.com wrote:
Okay, I have updated the attached patch so that the output from
-ftree-vectorizer-verbose is considered diagnostic information
Ping.
Thanks,
Sharad
On Thu, Jun 7, 2012 at 10:16 PM, Sharad Singhai sing...@google.com wrote:
Okay, I have updated the attached patch so that the output from
-ftree-vectorizer-verbose is considered diagnostic information and is
always
sent to stderr. Other functionality remains unchanged
lower
precedence. Also this works as expected,
gcc -O2 -fdump-tree-pre=pre.txt -fdump-tree-all=stderr ...
It outputs PRE dump to pre.txt while the remaining tree dumps are
output on to stderr. Does it look okay?
Thanks,
Sharad
2012-05-09 Sharad Singhai sing...@google.com
-08 Sharad Singhai sing...@google.com
* doc/invoke.texi: Add documentation for new option.
* tree-dump.c (dump_stream_p): New function.
(dump_files): Update for new field.
(dump_switch_p_1): Handle user provided filenames.
(dump_begin): Likewise
dump goes to ira.dump.
Thanks,
Sharad
2012-05-09 Sharad Singhai sing...@google.com
* doc/invoke.texi: Add documentation for the new option.
* tree-dump.c (dump_get_standard_stream): New function.
(dump_files): Update for new field.
(dump_switch_p_1): Handle dump
, Sharad Singhai sing...@google.com wrote:
This is the first patch for planned improvements to dump
infrastructure. Please reference the discussion in
http://gcc.gnu.org/ml/gcc-patches/2011-10/msg02088.html.
The following small patch allows selective tree and rtl dumps on
stderr instead of named
be implemented in
form of -fdump-xxx-stderr.
Bootstrapped and tested on x86_64 with one added testcase. Okay for
trunk?
Thanks,
Sharad
2012-05-07 Sharad Singhai sing...@google.com
* doc/invoke.texi: Add documentation for new option.
* tree-dump.c (dump_begin): Handle stderr appropriately
Honza,
Sorry, I forgot about this. Could you please put this on your TODO list?
David,
While a proper fix is pending for the trunk, we need this interim fix
internally. Okay for google/main?
Thanks,
Sharad
On Sun, Oct 2, 2011 at 3:08 AM, Jan Hubicka hubi...@ucw.cz wrote:
I believe Richi opent
Sorry about the delay. I have updated the patch to output demangled
names under a new option (-m) and added a test case. Okay for trunk?
Sharad
2011-11-06 Sharad Singhai sing...@google.com
* doc/gcov.texi: Document gcov intermediate format.
* gcov.c (print_usage): Handle new
Since the updated patch already uses unmangled function names, is it
good to commit then?
Sharad
On Wed, Oct 19, 2011 at 1:48 AM, Jan Hubicka hubi...@ucw.cz wrote:
On Oct 18, 2011, at 4:19 PM, Sharad Singhai sing...@google.com wrote:
Okay, I liked the idea of self-descriptive tags. I have
Sorry, I misunderstood your comment. I see that you are asking for
unmangled function names whereas the current patch supports only
mangled names. I can print unmangled names under another option. Would
that work?
Thanks,
Sharad
On Wed, Oct 19, 2011 at 12:06 PM, Sharad Singhai sing...@google.com
On Wed, Oct 5, 2011 at 9:58 AM, Mike Stump mikest...@comcast.net wrote:
On Oct 5, 2011, at 12:47 AM, Sharad Singhai wrote:
This patch adds an intermediate coverage format (enabled via 'gcov
-i'). This is a compact format as it does not require source files.
I don't like any of the tags, I
BA:8,2
DA:7,1
I have bootstrapped and tested this patch on x86_64-linux. No new test
failures were observed.
Okay for trunk?
Thanks,
Sharad
2011-10-04 Sharad Singhai sing...@google.com
* doc/gcov.texi: Document gcov intermediate format.
* gcov.c (print_usage): Handle new
and regression tests passed.
Okay for google/gcc-4_6?
2011-09-30 Sharad Singhai sing...@google.com
* gcc.c (cc1_options): Added -fno-early-inlining for coverage.
Index: gcc.c
===
--- gcc.c (revision 179402)
+++ gcc.c
This patch adds an intermediate gcov text format which does not require
source code. This format can be used by lcov or other tools.
I have bootstrapped it on x86 and all tests pass. Okay for main?
Thanks,
Sharad
2011-06-13 Sharad Singhai sing...@google.com
Google Ref 3
This patch disables -ftracer for profile use. Okay for google/main?
Thanks,
Sharad
2011-04-28 Sharad Singhai sing...@google.com
Google Ref 40087
* opts.c (common_handle_option): Disable -ftracer for profile use.
* doc/invoke.texi: Update doc that -ftracer is no longer
This patch adds new parameters to control peeling when profile
feedback information is available.
For google/main.
Tested:
bootstrapped on x86_64.
2011-04-27 Sharad Singhai sing...@google.com
* gcc/params.def: Add new parameters to control peeling.
* gcc/tree-ssa-loop
Hi Diego,
Thanks for the quick feedback. Here is a an updated version of the patch.
2011-04-27 Sharad Singhai sing...@google.com
ChangeLog.google-main
* params.def: Add new parameters to control peeling.
* tree-ssa-loop-ivcanon.c (try_unroll_loop_completely): Use
66 matches
Mail list logo
