Re: [PATCH] lto-wrapper.c (copy_file): Fix resource leaks

2017-06-26 Thread Sylvestre Ledru
Le 16/05/2017 à 09:59, Sylvestre Ledru a écrit : > Le 15/05/2017 à 23:58, Jeff Law a écrit : >> On 05/14/2017 04:00 AM, Sylvestre Ledru wrote: >>> Add missing fclose >>> CID 1407987, 1407986 >>> >>> S >>> >>> >>> >>

Re: libdecnumber/bid/bid2dpd_dpd2bid.c: Simplify code

2017-06-26 Thread Sylvestre Ledru
Le 26/05/2017 à 15:34, Sylvestre Ledru a écrit : > Hello, > > The attach patch (dup.diff) performs the following changes: > > * bid/bid2dpd_dpd2bid.c: Remove identical code for different > branches (CID 1286836, 1286837, 1286838) > Remove some useless } els

libdecnumber/bid/bid2dpd_dpd2bid.c: Simplify code

2017-05-26 Thread Sylvestre Ledru
tab i attached the word diff to highlight the change. No functional changes! The identical code has been found by coverity. Thanks! S libdecnumber/ChangeLog: 2017-05-26 Sylvestre Ledru <sylves...@debian.org> * bid/bid2dpd_dpd2bid.c: Remove identical code for different branches (C

Re: [PATCH] lto-wrapper.c (copy_file): Fix resource leaks

2017-05-16 Thread Sylvestre Ledru
Le 15/05/2017 à 23:58, Jeff Law a écrit : > On 05/14/2017 04:00 AM, Sylvestre Ledru wrote: >> Add missing fclose >> CID 1407987, 1407986 >> >> S >> >> >> >> 0005-2017-05-14-Sylvestre-Ledru-sylvestre-debian.org.patch >> >> >> F

Re: [PATCH] plugin.c (try_init_one_plugin): Fix ressource leaks (CID 726637)

2017-05-14 Thread Sylvestre Ledru
Le 14/05/2017 à 12:40, Trevor Saunders a écrit : > On Sun, May 14, 2017 at 11:59:40AM +0200, Sylvestre Ledru wrote: >> Add missing dlclose() >> >> S >> >> >> From d0926b84047f281a29dc51bbd0a4bdda01a5c63f Mon Sep 17 00:00:00 2001 >> From: Sylvestre

[PATCH] lto-wrapper.c (copy_file): Fix resource leaks

2017-05-14 Thread Sylvestre Ledru
Add missing fclose CID 1407987, 1407986 S >From d255827a64012fb81937d6baa8534eabecf9b735 Mon Sep 17 00:00:00 2001 From: Sylvestre Ledru <sylves...@debian.org> Date: Sun, 14 May 2017 11:37:37 +0200 Subject: [PATCH 5/5] 2017-05-14 Sylvestre Ledru <sylves...@debian.org>

[PATCH] plugin.c (try_init_one_plugin): Fix ressource leaks (CID 726637)

2017-05-14 Thread Sylvestre Ledru
Add missing dlclose() S >From d0926b84047f281a29dc51bbd0a4bdda01a5c63f Mon Sep 17 00:00:00 2001 From: Sylvestre Ledru <sylves...@debian.org> Date: Sun, 14 May 2017 11:28:38 +0200 Subject: [PATCH 4/5] 2017-05-14 Sylvestre Ledru <sylves...@debian.org> * plugin.c (try_init_o

[PATCH] objc-runtime-shared-support.c - Identical code for different branches

2017-05-14 Thread Sylvestre Ledru
Hello, Now that Coverity is up and running, I am trying to fix some errors. Let's start a trivial one (same code in different branches) S >From 50248decd02bfac52ad64b64c972750489e2ffa0 Mon Sep 17 00:00:00 2001 From: Sylvestre Ledru <sylves...@debian.org> Date: Sun, 14 May 2017 10:55

Re: [Patch] PR55189 enable -Wreturn-type by default

2014-08-20 Thread Sylvestre Ledru
On 20/08/2014 00:02, Joseph S. Myers wrote: On Fri, 15 Aug 2014, Sylvestre Ledru wrote: It is indeed useless. I removed it. Thanks http://sylvestre.ledru.info/0001-Enable-warning-Wreturn-type-by-default.patch I don't think most of the testsuite changes in this patch should be needed, and we

Re: [Patch] PR55189 enable -Wreturn-type by default

2014-08-15 Thread Sylvestre Ledru
-08-13 Sylvestre Ledru sylves...@debian.org * c.opt: Enable -Wreturn-type by default Add -Wmissing-return: Warn whenever control may reach end of non-void function gcc/ChangeLog: 2014-08-13 Sylvestre Ledru sylves...@debian.org * doc/invoke.texi: Document new flag

Re: [Patch] PR55189 enable -Wreturn-type by default

2014-08-14 Thread Sylvestre Ledru
On 12/08/2014 19:48, Joseph S. Myers wrote: On Mon, 11 Aug 2014, Sylvestre Ledru wrote: The test Wmissing-return2.c only has one of the two warnings. But as per -Wreturn-type = Run both, and for backwards compatibility with the existing definition of -Wreturn-type, both warnings should

Re: [PATCH] Fix some typos

2014-08-13 Thread Sylvestre Ledru
On 12/08/2014 19:38, Marc Glisse wrote: On Tue, 12 Aug 2014, Sylvestre Ledru wrote: The patch fixes some typos found by Lintian, the Debian static analyzer. Did you check them yourself? Sure (but I am not a native English speaker). We end up with these information which doesn't seem correct

[PATCH] Fix some typos

2014-08-12 Thread Sylvestre Ledru
Hello The patch fixes some typos found by Lintian, the Debian static analyzer. (it is mainly the opportunity to test my commit permissions). Thanks, Sylvestre libstdc++-v3/ChangeLog: 2014-08-12 Sylvestre Ledru sylves...@debian.org * include/profile/impl/profiler_hash_func.h: Fix

Re: [Patch] PR55189 enable -Wreturn-type by default

2014-08-12 Thread Sylvestre Ledru
On 12/08/2014 19:48, Joseph S. Myers wrote: On Mon, 11 Aug 2014, Sylvestre Ledru wrote: The test Wmissing-return2.c only has one of the two warnings. But as per -Wreturn-type = Run both, and for backwards compatibility with the existing definition of -Wreturn-type, both warnings should

Re: [Patch] PR55189 enable -Wreturn-type by default

2014-08-11 Thread Sylvestre Ledru
On 31/07/2014 00:08, Joseph S. Myers wrote: On Mon, 7 Jul 2014, Sylvestre Ledru wrote: Hello, On 17/06/2014 19:41, Joseph S. Myers wrote: On Tue, 17 Jun 2014, Sylvestre Ledru wrote: OK. I will do that. We should test the following: * default = run just -Wreturn-type * -Wreturn-type

Re: [Patch] PR55189 enable -Wreturn-type by default

2014-07-20 Thread Sylvestre Ledru
Joseph, ping :) (I know you were in holidays) S On 07/07/2014 19:17, Sylvestre Ledru wrote: Hello, On 17/06/2014 19:41, Joseph S. Myers wrote: On Tue, 17 Jun 2014, Sylvestre Ledru wrote: OK. I will do that. We should test the following: * default = run just -Wreturn-type * -Wreturn

Re: [Patch] PR55189 enable -Wreturn-type by default

2014-07-07 Thread Sylvestre Ledru
Hello, On 17/06/2014 19:41, Joseph S. Myers wrote: On Tue, 17 Jun 2014, Sylvestre Ledru wrote: OK. I will do that. We should test the following: * default = run just -Wreturn-type * -Wreturn-type = Run both * -Wreturn-type + -Wmissing-return = Run both * -Wno-return-type + -Wmissing

Re: [Patch] PR55189 enable -Wreturn-type by default

2014-06-17 Thread Sylvestre Ledru
1b936c618c58dc0e899fa9f56013de48f7e4dcd6 Mon Sep 17 00:00:00 2001 From: Sylvestre Ledru sylves...@debian.org Date: Tue, 17 Jun 2014 18:48:29 +0200 Subject: [PATCH 2/2] Enable Wimplicit by default --- gcc/c-family/c.opt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gcc/c-family/c.opt b/gcc/c-family/c.opt index

Re: [Patch] PR55189 enable -Wreturn-type by default

2014-06-17 Thread Sylvestre Ledru
On 17/06/2014 19:15, Joseph S. Myers wrote: On Tue, 17 Jun 2014, Sylvestre Ledru wrote: On 05/06/2014 20:01, Joseph S. Myers wrote: Initially, I implemented -Wmissing-return to manage this case ( https://gcc.gnu.org/ml/gcc-patches/2014-01/msg00820.html ) but Jason suggested to remove

Re: [Patch] PR55189 enable -Wreturn-type by default

2014-06-05 Thread Sylvestre Ledru
On 05/06/2014 01:31, Joseph S. Myers wrote: On Wed, 4 Jun 2014, Sylvestre Ledru wrote: Hello, Finally, I have been able to update all tests with -Wreturn-type enabled by default. AFAIK, under GNU/Linux Debian Jessie 64 bits, there is no PASS-FAIL tests. Now, I would like to know if I can

[Patch] PR55189 enable -Wreturn-type by default

2014-06-04 Thread Sylvestre Ledru
://sylvestre.ledru.info/bordel/patch/0006-Update-OpenMP-tests-with-warning-return-type-enabled.patch Thanks, Sylvestre gcc/c-family/ChangeLog: 2014-06-04 Sylvestre Ledru sylves...@debian.org * c.opt: -Wreturn-type enabled by default From 650edb9943ba8b2afb4995e70f671d8fdc26e10a Mon Sep 17 00:00:00

Re: [Patch] PR55189 enable -Wreturn-type by default

2014-01-23 Thread Sylvestre Ledru
On 23/01/2014 10:48, Jason Merrill wrote: On 01/16/2014 02:44 PM, Jason Merrill wrote: To avoid spurious warnings on code with infinite loops we could add a simple check for infinite loops and suppress the warning in that case. Basically, if we see a loop with an always-true condition and no

Re: [Patch] PR55189 enable -Wreturn-type by default

2014-01-22 Thread Sylvestre Ledru
On 16/01/2014 11:44, Jason Merrill wrote: My preference would be to turn -Wreturn-type on by default, but not create the separate -Wmissing-return flag. As I argued in 2002, there should only be one flag. I don't have any opinion on the subject. The separate option or not is fine with me. I am

Enable -Wreturn-type by default ?

2013-11-12 Thread Sylvestre Ledru
Hello, I would like to propose the activation by default of -Wreturn-type. The main objective would to provide a warning for such code: int foo() { return; } For now, it is only enabled when we have -Wall: $ gcc -c foo.c $ gcc -Wall -c foo.c foo.c: In function ‘foo’: foo.c:2:2: