[PATCH] Respect TMPDIR value in contrib scripts

2018-02-18 Thread Yury Gribov
Hi all, This uses ${TMPDIR:-/tmp} instead of /tmp in scripts in contrib folder. Ok for trunk? -Y Respect-TMPDIR-1.patch Description: Binary data

Re: [PATCHv2][PR target/81535] Fix tests on Power

2018-02-16 Thread Yury Gribov
On Thu, Feb 15, 2018 at 8:13 PM, Yury Gribov <tetra2005.patc...@gmail.com> wrote: > Hi all, > > This is an updated version of patch for PR 81535. The patch was last > discussed in November. The new version addresses Segher's comments in > https://gcc.gnu.org/ml/gcc-patches/

[PATCHv2][PR target/81535] Fix tests on Power

2018-02-15 Thread Yury Gribov
Hi all, This is an updated version of patch for PR 81535. The patch was last discussed in November. The new version addresses Segher's comments in https://gcc.gnu.org/ml/gcc-patches/2017-08/msg00558.html The patch was tested on x86_64-pc-linux-gnu powerpc64-unknown-linux-gnu

Re: [PATCH][PR target/81535] Fix tests on Power

2017-11-25 Thread Yury Gribov
On Tue, Aug 8, 2017 at 12:32 AM, Segher Boessenkool <seg...@kernel.crashing.org> wrote: > Hi Yuri, > > Sorry I missed this. Please cc: me to prevent that from happening. Segher, Sorry, somehow I missed your reply! > On Fri, Jul 28, 2017 at 05:42:00AM +0100, Yury Gribov wr

[PATCH][PING][PR target/81535] Fix tests on Power

2017-08-04 Thread Yury Gribov
to prevent inlining introduced by recent PR56727 patch. I added Power-specific pattern in pr56727-2.c testcase and disabled testing on Power in pr56727-1.c. Tested on powerpc64-unknown-linux-gnu. Ok for trunk? -Y 2017-07-28 Yury Gribov <tetra2...@gmail.com> PR target

Re: [PING^4][PATCH v2] Generate reproducible output independently of the build-path

2017-08-04 Thread Yury Gribov
On Fri, Aug 4, 2017 at 1:32 PM, Matthias Klose wrote: > On 03.08.2017 12:05, Jeff Law wrote: >> On 08/02/2017 08:06 PM, Ximin Luo wrote: >>> Jeff Law: On 07/21/2017 10:15 AM, Ximin Luo wrote: > (Please keep me on CC, I am not subscribed) > > > Proposal >

Re: [PING^4][PATCH v2] Generate reproducible output independently of the build-path

2017-08-04 Thread Yury Gribov
On Thu, Aug 3, 2017 at 12:45 PM, Ximin Luo <infini...@pwned.gg> wrote: > Yury Gribov: >> On 03.08.2017 3:06, Ximin Luo wrote: >>> Jeff Law: >>>> On 07/21/2017 10:15 AM, Ximin Luo wrote: >>>>> (Please keep me on

Re: [RFC][PR 67336][PING^6] Verify pointers during stack unwind

2017-08-03 Thread Yury Gribov
On 03.08.2017 18:04, Florian Weimer wrote: * Yuri Gribov: I've rebased the previous patch to trunk per Andrew's suggestion. Original patch description/motivation/questions are in https://gcc.gnu.org/ml/gcc-patches/2017-06/msg01869.html What about the remaining TODOs? Yes, need to be fixed.

Re: [RFC][PR 67336][PING^6] Verify pointers during stack unwind

2017-08-03 Thread Yury Gribov
On Thu, Aug 3, 2017 at 4:28 PM, H.J. Lu <hjl.to...@gmail.com> wrote: > On Thu, Aug 3, 2017 at 8:25 AM, Jeff Law <l...@redhat.com> wrote: >> On 08/03/2017 08:17 AM, Yury Gribov wrote: >>> On Thu, Aug 3, 2017 at 2:01 PM, H.J. Lu <hjl.to...@gmail.com> wrote: >&

Re: [RFC][PR 67336][PING^6] Verify pointers during stack unwind

2017-08-03 Thread Yury Gribov
On Thu, Aug 3, 2017 at 3:55 PM, H.J. Lu <hjl.to...@gmail.com> wrote: > On Thu, Aug 3, 2017 at 7:17 AM, Yury Gribov <tetra2005.patc...@gmail.com> > wrote: >> On Thu, Aug 3, 2017 at 2:01 PM, H.J. Lu <hjl.to...@gmail.com> wrote: >>> On Thu, Aug 3, 2017

Re: [RFC][PR 67336][PING^6] Verify pointers during stack unwind

2017-08-03 Thread Yury Gribov
On Thu, Aug 3, 2017 at 2:01 PM, H.J. Lu <hjl.to...@gmail.com> wrote: > On Thu, Aug 3, 2017 at 5:52 AM, Yury Gribov <tetra2005.patc...@gmail.com> > wrote: >> On Thu, Aug 3, 2017 at 1:22 PM, H.J. Lu <hjl.to...@gmail.com> wrote: >>> On Wed, Aug 2, 2017

Re: [RFC][PR 67336][PING^6] Verify pointers during stack unwind

2017-08-03 Thread Yury Gribov
On Thu, Aug 3, 2017 at 1:22 PM, H.J. Lu <hjl.to...@gmail.com> wrote: > On Wed, Aug 2, 2017 at 9:29 PM, Yury Gribov <tetra2005.patc...@gmail.com> > wrote: >> On 02.08.2017 23:04, H.J. Lu wrote: >>> >>> On Wed, Aug 2, 2017 at 1:56 PM, Yury Grib

Re: [PING^4][PATCH v2] Generate reproducible output independently of the build-path

2017-08-02 Thread Yury Gribov
On 03.08.2017 3:06, Ximin Luo wrote: Jeff Law: On 07/21/2017 10:15 AM, Ximin Luo wrote: (Please keep me on CC, I am not subscribed) Proposal This patch series adds a new environment variable BUILD_PATH_PREFIX_MAP. When this is set, GCC will treat this as extra implicit

Re: [RFC][PR 67336][PING^6] Verify pointers during stack unwind

2017-08-02 Thread Yury Gribov
On 02.08.2017 23:04, H.J. Lu wrote: On Wed, Aug 2, 2017 at 1:56 PM, Yury Gribov <tetra2005.patc...@gmail.com> wrote: On 02.08.2017 21:48, H.J. Lu wrote: On Wed, Aug 2, 2017 at 1:39 PM, Yury Gribov <tetra2005.patc...@gmail.com> wrote: On 02.08.2017 20:02, Jeff Law wrote: On 0

Re: [RFC][PR 67336][PING^6] Verify pointers during stack unwind

2017-08-02 Thread Yury Gribov
On 02.08.2017 21:48, H.J. Lu wrote: On Wed, Aug 2, 2017 at 1:39 PM, Yury Gribov <tetra2005.patc...@gmail.com> wrote: On 02.08.2017 20:02, Jeff Law wrote: On 08/02/2017 12:47 PM, Jakub Jelinek wrote: On Wed, Aug 02, 2017 at 12:38:13PM -0600, Jeff Law wrote: On 07/17/2017 01:23 AM

Re: [RFC][PR 67336][PING^6] Verify pointers during stack unwind

2017-08-02 Thread Yury Gribov
On 02.08.2017 20:02, Jeff Law wrote: On 08/02/2017 12:47 PM, Jakub Jelinek wrote: On Wed, Aug 02, 2017 at 12:38:13PM -0600, Jeff Law wrote: On 07/17/2017 01:23 AM, Yuri Gribov wrote: I've rebased the previous patch to trunk per Andrew's suggestion. Original patch

[PATCH] Rewrite mklog in Python

2017-08-01 Thread Yury Gribov
, but it produces a reasonable # approximation. # # This is a straightforward adaptation of original Perl script. # # Author: Yury Gribov <tetra2...@gmail.com> import sys import re import os.path import os import getopt import tempfile import time import shutil from subprocess import Popen, PI

[PATCHv5][PR 57371] Remove useless floating point casts in comparisons

2017-07-30 Thread Yury Gribov
vious review. Rebased, bootstrapped and regtested on x64. Ok for trunk? -Y 2017-07-30 Yury Gribov <tetra2...@gmail.com> PR tree-optimization/57371 gcc/ * match.pd: New pattern. gcc/testsuite/ * testsuite/c-c++-common/pr57371-1.c: New test. * testsuite/c-c+

[PATCH][PR target/81535] Fix tests on Power

2017-07-27 Thread Yury Gribov
to prevent inlining introduced by recent PR56727 patch. I added Power-specific pattern in pr56727-2.c testcase and disabled testing on Power in pr56727-1.c. Tested on powerpc64-unknown-linux-gnu. Ok for trunk? -Y 2017-07-28 Yury Gribov <tetra2...@gmail.com> PR target

[PATCHv2][PING][PR 59521] Respect __builtin_expect in switch statements

2017-07-27 Thread Yury Gribov
an update of https://gcc.gnu.org/ml/gcc-patches/2017-07/msg01016.html , rebased and retested. Ok for trunk? -Y 2017-07-21 Yury Gribov <tetra2...@gmail.com> Martin Liska <mar...@gcc.gnu.org> PR middle-end/59521 gcc/ * predict.c (set_even_probabilities):

Re: [PATCH, DOC] Document ASAN_OPTIONS="halt_on_error" env variable.

2016-05-11 Thread Yury Gribov
On 05/11/2016 05:13 PM, Martin Liška wrote: Hello. It's bit confusing for a use that -fsanitize-recover=address does not recover an instrumented binary. As a default value of halt_on_error is set to 0 for address sanitizer, the binary fails on a first error. I'm the guy behind

Re: [PATCH, RFC] Introduce -fsanitize=use-after-scope

2016-05-06 Thread Yury Gribov
On 05/06/2016 03:38 PM, Jakub Jelinek wrote: On Fri, May 06, 2016 at 02:48:30PM +0300, Yury Gribov wrote: 6) As the use-after-scope stuff is already included in libsanitizer, no change is needed for the library Note that upstream seems to use a different cmdline interface. They don't have

Re: [PATCH, RFC] Introduce -fsanitize=use-after-scope

2016-05-06 Thread Yury Gribov
On 05/06/2016 02:04 PM, Martin Liška wrote: Hello. I've started working on the patch couple of month go, basically after a brief discussion with Jakub on IRC. I'm sending the initial version which can successfully run instrumented tramp3d, postgresql server and Inkscape. It catches the basic

Re: [PATCH] asan: Don't check frame numbers in the testsuite

2016-04-28 Thread Yury Gribov
On 04/28/2016 06:57 PM, Segher Boessenkool wrote: On various PowerPC configurations, the top frame is often mentioned twice in the backtrace, making many asan tests fail. I see no particular reason the asan tests want to check the frame number, so this patch makes it check for " #. " instead of

[PATCHv2][PR 67425] Fix docs for -frandom-seed

2015-12-29 Thread Yury Gribov
On 12/29/2015 08:05 PM, Sandra Loosemore wrote: On 12/29/2015 12:33 AM, Yury Gribov wrote: Hi all, this patch reverts invalid documentation change -frandom-seed which was introduced by myself in r216773 a year ago. I've checked the generated man and the only test for -frandom-seed (gcc.dg

[PATCH][PING][PR 67425] Fix docs for -frandom-seed

2015-12-28 Thread Yury Gribov
rom 23f8c38f593a18c5783949f7c2225b49685fedfc Mon Sep 17 00:00:00 2001 From: Yury Gribov <y.gri...@samsung.com> Date: Fri, 25 Dec 2015 13:57:28 +0300 Subject: [PATCH] Fix docs for -frandom-seed to allow string arguments. 2015-12-25 Yury Gribov <y.gri...@samsung.com> PR driver/67425 * common.op

Re: [PATCH 5/5] Fix intransitive comparison in dr_group_sort_cmp

2015-12-25 Thread Yury Gribov
On 12/19/2015 01:30 AM, Yuri Gribov wrote: On Fri, Dec 18, 2015 at 11:20 PM, Yury Gribov <y.gri...@samsung.com> wrote: On 12/17/2015 03:51 PM, Richard Biener wrote: On Thu, 17 Dec 2015, Yury Gribov wrote: On 12/17/2015 02:57 PM, Richard Biener wrote: On Thu, 17 Dec 2015, Yury Gribov

[PATCH][PR 67425] Fix docs for -frandom-seed

2015-12-25 Thread Yury Gribov
rom 23f8c38f593a18c5783949f7c2225b49685fedfc Mon Sep 17 00:00:00 2001 From: Yury Gribov <y.gri...@samsung.com> Date: Fri, 25 Dec 2015 13:57:28 +0300 Subject: [PATCH] Fix docs for -frandom-seed to allow string arguments. 2015-12-25 Yury Gribov <y.gri...@samsung.com> PR driver/67425 * common.op

Re: [PATCH 1/5] Fix asymmetric comparison functions

2015-12-18 Thread Yury Gribov
On 12/17/2015 03:04 PM, Yury Gribov wrote: On 12/17/2015 02:39 PM, Jakub Jelinek wrote: On Thu, Dec 17, 2015 at 11:58:30AM +0300, Yury Gribov wrote: 2015-12-17 Yury Gribov <tetra2...@gmail.com> * c-family/c-common.c (resort_field_decl_cmp): Make symmteric. * cp/c

Re: [PATCH 1/5] Fix asymmetric comparison functions

2015-12-18 Thread Yury Gribov
On 12/18/2015 11:07 PM, Jakub Jelinek wrote: On Fri, Dec 18, 2015 at 10:40:40PM +0300, Yury Gribov wrote: So it seems most people generally agree that self-comparisons (cmp(x,x) == 0) are useless and don't need to be checked or fixed. What about ensuring symmetry i.e. that cmp(x, y) == -cmp(y

Re: [PATCH 3/5] "Fix" intransitive comparison in reload_pseudo_compare_func

2015-12-18 Thread Yury Gribov
On 12/17/2015 10:36 PM, Vladimir Makarov wrote: On 12/17/2015 04:00 AM, Yury Gribov wrote: This patch fixes intransitive comparison in reload_pseudo_compare_func. Imagine the following situation: 1) bitmap_bit_p is unset for A and B but set for C 2) A < B (due to early ira_reg_class_max_nr

Re: [PATCH 5/5] Fix intransitive comparison in dr_group_sort_cmp

2015-12-18 Thread Yury Gribov
On 12/17/2015 03:51 PM, Richard Biener wrote: On Thu, 17 Dec 2015, Yury Gribov wrote: On 12/17/2015 02:57 PM, Richard Biener wrote: On Thu, 17 Dec 2015, Yury Gribov wrote: That's an interesting one. The original comparison function assumes that operand_equal_p(a,b) is true iff compare_tree

[PATCH 2/5] Fix more asymmetric comparison functions

2015-12-17 Thread Yury Gribov
, sort_locs_in_loop_postorder_cmp, find_ref_loc_in_loop_cmp and dr_group_sort_cmp /Yury >From 5716669d0b88265ee610ad139a0dc4152d1c20f3 Mon Sep 17 00:00:00 2001 From: Yury Gribov <tetra2...@gmail.com> Date: Sat, 12 Dec 2015 10:27:45 +0300 Subject: [PATCH 2/5] Fix more asymmetric comparison functions. 2

[PATCH 5/5] Fix intransitive comparison in dr_group_sort_cmp

2015-12-17 Thread Yury Gribov
should preserve the intended semantics (same approach taken in another comparison function in this file - comp_dr_with_seg_len_pair). Cc-ing Cong Hou and Richard who are the authours. /Yury From 7fb1fd8b2027a3a3e2d914f8bd000fe53bffe110 Mon Sep 17 00:00:00 2001 From: Yury Gribov <tetra2...@gmail.

[PATCH 3/5] "Fix" intransitive comparison in reload_pseudo_compare_func

2015-12-17 Thread Yury Gribov
easily happen that A > C (due to regno_assign_info comparison) which violates the transitiveness requirement of total ordering. Unfortunately I'm not sure how to properly fix this so Cc-ing Vladimir for help. /Yury From 83da5d11c4f013dd14c1ea0c1722c108d80f58ed Mon Sep 17 00:00:00 2001 From: Yu

[PATCH 4/5] Fix intransitive comparison in compare_access_positions

2015-12-17 Thread Yury Gribov
17 00:00:00 2001 From: Yury Gribov <tetra2...@gmail.com> Date: Sat, 12 Dec 2015 10:39:15 +0300 Subject: [PATCH 4/5] Fix intransitive comparison in compare_access_positions. 2015-12-17 Yury Gribov <tetra2...@gmail.com> * tree-sra.c (compare_access_positions): Make transitive. Error

[PATCH 1/5] Fix asymmetric comparison functions

2015-12-17 Thread Yury Gribov
* Richard for insert_phi_nodes_compare_var_infos, compare_case_labels * Steven for cmp_v_in_regset_pool /Yury >From bf924dca4ccc3f8640438400e923a4c508e898e0 Mon Sep 17 00:00:00 2001 From: Yury Gribov <tetra2...@gmail.com> Date: Sat, 12 Dec 2015 09:51:54 +0300 Subject: [PATCH 1/5] Fix a

[PATCH 0/5] Fix qsort comparison functions

2015-12-17 Thread Yury Gribov
Hi all, This patchset fixes bugs in comparison functions used in qsort(3). Standard requires comparison functions to satisfy certain symmetry/transitivity axioms ("total ordering" in http://pubs.opengroup.org/onlinepubs/009695399/functions/qsort.html). Violation triggers undefined behavior

Re: [PATCH 1/5] Fix asymmetric comparison functions

2015-12-17 Thread Yury Gribov
On 12/17/2015 02:39 PM, Jakub Jelinek wrote: On Thu, Dec 17, 2015 at 11:58:30AM +0300, Yury Gribov wrote: 2015-12-17 Yury Gribov <tetra2...@gmail.com> * c-family/c-common.c (resort_field_decl_cmp): Make symmteric. * cp/class.c (method_name_cmp):

Re: [PATCH 1/5] Fix asymmetric comparison functions

2015-12-17 Thread Yury Gribov
On 12/17/2015 02:58 PM, Andrey Belevantsev wrote: Hello, On 17.12.2015 11:58, Yury Gribov wrote: Some obvious symmetry fixes. Cc-ing * Andrey (Belevantsev) for bb_top_order_comparator Here, as Jakub mentioned, we assume that the argument addresses will never be equal, The problem

Re: [PATCH 1/5] Fix asymmetric comparison functions

2015-12-17 Thread Yury Gribov
On 12/17/2015 02:59 PM, Richard Biener wrote: On Thu, 17 Dec 2015, Yury Gribov wrote: On 12/17/2015 02:41 PM, Richard Biener wrote: On Thu, 17 Dec 2015, Yury Gribov wrote: Some obvious symmetry fixes. Cc-ing * Andrey (Belevantsev) for bb_top_order_comparator * Andrew (MacLeod

Re: [PATCH 5/5] Fix intransitive comparison in dr_group_sort_cmp

2015-12-17 Thread Yury Gribov
On 12/17/2015 02:57 PM, Richard Biener wrote: On Thu, 17 Dec 2015, Yury Gribov wrote: That's an interesting one. The original comparison function assumes that operand_equal_p(a,b) is true iff compare_tree(a, b) == 0. Unfortunately that's not true (functions are written by different authors

Re: [PATCH 1/5] Fix asymmetric comparison functions

2015-12-17 Thread Yury Gribov
On 12/17/2015 03:25 PM, Richard Biener wrote: On Thu, 17 Dec 2015, Yury Gribov wrote: On 12/17/2015 02:59 PM, Richard Biener wrote: On Thu, 17 Dec 2015, Yury Gribov wrote: On 12/17/2015 02:41 PM, Richard Biener wrote: On Thu, 17 Dec 2015, Yury Gribov wrote: Some obvious symmetry fixes

Re: [PATCH 1/5] Fix asymmetric comparison functions

2015-12-17 Thread Yury Gribov
On 12/17/2015 02:41 PM, Richard Biener wrote: On Thu, 17 Dec 2015, Yury Gribov wrote: Some obvious symmetry fixes. Cc-ing * Andrey (Belevantsev) for bb_top_order_comparator * Andrew (MacLeod) for compare_case_labels * Andrew (Pinski) for resort_field_decl_cmp * Diego for pair_cmp * Geoff

Re: Add fuzzing coverage support

2015-12-04 Thread Yury Gribov
On 12/04/2015 04:41 PM, Jakub Jelinek wrote: Hi! While this has been posted after stage1 closed and I'm not really happy that it missed the deadline, I'm willing to grant an exception, the patch is small enough that it is ok at this point of stage3. That said, next time please try to submit

Re: [PATCH 1/2] Libsanitizer merge from upstream r253555.

2015-11-24 Thread Yury Gribov
On 11/24/2015 02:55 PM, Maxim Ostapenko wrote: On 24/11/15 14:27, Jakub Jelinek wrote: On Tue, Nov 24, 2015 at 12:23:05PM +0100, Christophe Lyon wrote: On 24 November 2015 at 12:12, Jakub Jelinek wrote: On Tue, Nov 24, 2015 at 12:08:13PM +0100, Christophe Lyon wrote: Sure.

Re: Backport important ASan features from upstream.

2015-11-19 Thread Yury Gribov
asan is useless for aarch64 and should not be enabled at all. Linaro has stated several times that main reason for missing 48-bit support is lack of HW. Could Cavium provide them with ThunderX bot? Best regards, Yury Gribov

Re: [PATCH v2 6/6] Libsanitizer merge from upstream r250806 (was r249633).

2015-10-21 Thread Yury Gribov
there. Best regards, Yury Gribov

Re: [PATCH 1/7] Libsanitizer merge from upstream r249633.

2015-10-15 Thread Yury Gribov
On 10/14/2015 10:15 PM, Renato Golin wrote: On 14 October 2015 at 20:00, Andrew Pinski wrote: Then until that happens I think we should disable asan and tsan for AARCH64 for GCC. I can't comment on that, but we'll continue running the tests on our side on both 39 and 42

Re: [PATCH 1/7] Libsanitizer merge from upstream r249633.

2015-10-14 Thread Yury Gribov
On 10/14/2015 12:34 PM, Maxim Ostapenko wrote: On 14/10/15 10:54, Jakub Jelinek wrote: Do you plan to update the asan tests we have to reflect the changes in upstream? Hm, there aren't changes into instrumentation, so the only thing is new interceptors. If it is desirable, I can migrate some

Re: [PATCH 2/7] Libsanitizer merge from upstream r249633.

2015-10-14 Thread Yury Gribov
On 10/13/2015 02:16 PM, Maxim Ostapenko wrote: This patch introduces required compiler changes. Now, we don't version asan_init, we have a special __asan_version_mismatch_check_v[n] symbol for this. Also, asan_stack_malloc_[n] doesn't take a local stack as a second parameter anymore, so don't

Re: [PATCH] Make ubsan tests less picky about ansi escape codes in diagnostics.

2015-09-04 Thread Yury Gribov
On 09/03/2015 07:45 PM, Jonathan Roelofs wrote: On 9/3/15 10:17 AM, Jakub Jelinek wrote: On Thu, Sep 03, 2015 at 10:15:02AM -0600, Jonathan Roelofs wrote: +kcc, mrs Ping On 8/27/15 4:44 PM, Jonathan Roelofs wrote: The attached patch makes the ubsan tests agnostic to ansi escape codes in

[PATCH] Fix UBSan builtin types

2015-08-20 Thread Yury Gribov
doubt that bootstrap + full testsuite will add anything to this). Ok for trunk? Best regards, Yury Gribov commit d4747c9c7f78789ec7119fce07cd4526c4168ee0 Author: Yury Gribov y.gri...@samsung.com Date: Thu Aug 20 19:10:30 2015 +0300 2015-08-20 Yury Gribov y.gri...@samsung.com

Re: [RFC] COMDAT Safe Module Level Multi versioning

2015-05-19 Thread Yury Gribov
On 05/19/2015 09:16 AM, Sriraman Tallam wrote: We have the following problem with selectively compiling modules with -misa options and I have provided a solution to solve this. I would like to hear what you think. Multi versioning at module granularity is done by compiling a subset of modules

[PATCH] Backport fix for PR 64839 to GCC5 (commited)

2015-05-12 Thread Yury Gribov
On 04/13/2015 12:04 PM, Yury Gribov wrote: On 04/13/2015 12:03 PM, Yury Gribov wrote: Hi all, I've submitted a libsanitizer cherry-pick from LLVM to not require xdr.h on systems where it's not available. Pre-approved by Jakub in https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64839 . Forgot

Re: [PATCH][PING^2] Skip preprocessor directives in mklog

2015-05-12 Thread Yury Gribov
On 05/12/2015 06:57 PM, Trevor Saunders wrote: On Tue, May 12, 2015 at 06:33:28PM +0300, Yury Gribov wrote: On 05/12/2015 06:23 PM, Diego Novillo wrote: The patch looks fine to me. I'm not really involved in GCC development anymore. I would suggest that this script should be maintained

Re: [PINGv6][PATCH] ASan on unaligned accesses

2015-05-12 Thread Yury Gribov
On 05/12/2015 02:16 PM, Marat Zakirov wrote: On 04/07/2015 03:22 PM, Jakub Jelinek wrote: How are the automatic misaligned variables different from say heap allocated ones, or global vars etc.? No difference you are right Jakub. Shadow memory initialization for heap values and globals of

[PATCH][PING^2] Skip preprocessor directives in mklog

2015-05-12 Thread Yury Gribov
On 04/30/2015 12:03 PM, Yury Gribov wrote: On 04/21/2015 02:26 PM, Yury Gribov wrote: Hi all, Contrib/mklog is currently faked by preprocessor directives inside functions to produce invalid ChangeLog. The attached patch fixes this. Tested with my local mklog testsuite and http

Re: [PATCH][PING^2] Skip preprocessor directives in mklog

2015-05-12 Thread Yury Gribov
On 05/12/2015 06:23 PM, Diego Novillo wrote: The patch looks fine to me. I'm not really involved in GCC development anymore. I would suggest that this script should be maintained by whoever's been hacking on it the most. It's a simple script, so it shouldn't be hard to find a new maintainer for

[PATCH][PING] Skip preprocessor directives in mklog

2015-04-30 Thread Yury Gribov
On 04/21/2015 02:26 PM, Yury Gribov wrote: Hi all, Contrib/mklog is currently faked by preprocessor directives inside functions to produce invalid ChangeLog. The attached patch fixes this. Tested with my local mklog testsuite and http://paste.debian.net/167999/ . Ok to commit?

Re: [PATCH] Optionally sanitize globals in user-defined sections

2015-04-22 Thread Yury Gribov
On 04/19/2015 06:11 PM, Jakub Jelinek wrote: On Sun, Apr 19, 2015 at 10:54:57AM +0300, Yury Gribov wrote: On 04/17/2015 08:29 PM, Andi Kleen wrote: Yury Gribov y.gri...@samsung.com writes: + +static bool +section_sanitized_p (const char *sec) +{ + if (!sanitized_sections) +return false

Re: [PATCH] Optionally sanitize globals in user-defined sections

2015-04-22 Thread Yury Gribov
On 04/22/2015 11:31 AM, Yury Gribov wrote: On 04/19/2015 06:11 PM, Jakub Jelinek wrote: On Sun, Apr 19, 2015 at 10:54:57AM +0300, Yury Gribov wrote: On 04/17/2015 08:29 PM, Andi Kleen wrote: Yury Gribov y.gri...@samsung.com writes: + +static bool +section_sanitized_p (const char *sec

Re: [PATCH] Optionally sanitize globals in user-defined sections

2015-04-22 Thread Yury Gribov
On 04/22/2015 12:00 PM, Jakub Jelinek wrote: On Wed, Apr 22, 2015 at 11:43:53AM +0300, Yury Gribov wrote: @@ -272,7 +273,7 @@ along with GCC; see the file COPYING3. If not see static unsigned HOST_WIDE_INT asan_shadow_offset_value; static bool asan_shadow_offset_computed; -static const

[PATCH] Skip preprocessor directives in mklog

2015-04-21 Thread Yury Gribov
Author: Yury Gribov y.gri...@samsung.com Date: Tue Apr 21 14:17:23 2015 +0300 2015-04-21 Yury Gribov y.gri...@samsung.com * mklog: Ignore preprocessor directives. diff --git a/contrib/mklog b/contrib/mklog index f7974a7..455614b 100755 --- a/contrib/mklog +++ b/contrib/mklog

Re: [PATCH] 65479 - sanitizer stack trace missing frames past #0 on powerpc64

2015-04-20 Thread Yury Gribov
On 04/20/2015 09:23 PM, Jeff Law wrote: On 04/19/2015 07:48 PM, Martin Sebor wrote: The attached patch resolves the failures in a number of address sanitizer tests on powerpc64*-*-*-* discussed in bug 65479 (the failures in c-c++-common/asan/swapcontext-test-1.c reported in pr65643 remain

Re: [PATCH] 65479 - sanitizer stack trace missing frames past #0 on powerpc64

2015-04-20 Thread Yury Gribov
On 04/20/2015 09:43 PM, Jakub Jelinek wrote: On Mon, Apr 20, 2015 at 09:38:03PM +0300, Yury Gribov wrote: --- a/gcc/testsuite/ChangeLog +++ b/gcc/testsuite/ChangeLog @@ -1,3 +1,12 @@ +2015-04-19 Martin Sebormse...@redhat.com + +PR sanitizer/65479 +* gcc/testsuite/c-c++-common/asan

Re: [PATCH] Optionally sanitize globals in user-defined sections

2015-04-19 Thread Yury Gribov
On 04/17/2015 08:29 PM, Andi Kleen wrote: Yury Gribov y.gri...@samsung.com writes: + +static bool +section_sanitized_p (const char *sec) +{ + if (!sanitized_sections) +return false; + size_t len = strlen (sec); + const char *p = sanitized_sections; + while ((p = strstr (p, sec

[PATCH] Optionally sanitize globals in user-defined sections

2015-04-17 Thread Yury Gribov
Hi all, This patch adds an optional support for sanitizing user-defined sections. Usually this is a bad idea because ASan changes relative position of variables in section thus breaking user assumptions. But this is a desired feature for kernel which (ab)uses sections for various reasons

Re: [PATCH] Optionally sanitize globals in user-defined sections

2015-04-17 Thread Yury Gribov
On 04/17/2015 10:33 AM, Yury Gribov wrote: Hi all, This patch adds an optional support for sanitizing user-defined sections. Usually this is a bad idea because ASan changes relative position of variables in section thus breaking user assumptions. But this is a desired feature for kernel which

Re: [PATCH] Fix PR64839: libsanitizer shouldn't require rpc/xdr.h (commited)

2015-04-13 Thread Yury Gribov
On 04/13/2015 12:03 PM, Yury Gribov wrote: Hi all, I've submitted a libsanitizer cherry-pick from LLVM to not require xdr.h on systems where it's not available. Pre-approved by Jakub in https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64839 . Forgot to attach patch. Commited in r222043. commit

[PATCH] Fix PR64839: libsanitizer shouldn't require rpc/xdr.h (commited)

2015-04-13 Thread Yury Gribov
Hi all, I've submitted a libsanitizer cherry-pick from LLVM to not require xdr.h on systems where it's not available. Pre-approved by Jakub in https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64839 . -Y

Re: [PINGv2][PATCH] ASan phase place change

2015-03-11 Thread Yury Gribov
On 03/11/2015 10:43 AM, Marat Zakirov wrote: On 03/03/2015 10:36 AM, Marat Zakirov wrote: On 02/24/2015 03:49 PM, Marat Zakirov wrote: On 02/20/2015 03:07 PM, Jakub Jelinek wrote: On Fri, Feb 20, 2015 at 02:59:51PM +0300, Marat Zakirov wrote: Here is simple patch that moves asan phase

Re: [PATCH] optionally disable global check

2015-03-06 Thread Yury Gribov
On 03/06/2015 05:23 PM, Marat Zakirov wrote: Hi all! Currently !ASAN_GLOBALS disables red-zones for global variables but keeps their checks. This simple patch disables these checks too. --Marat Jakub, Given that this may be considered a bugfix for --param asan-globals, perhaps this is ok

[PATCHv2][PING][wwwdocs] Mention -freport-bug in release notes

2015-02-01 Thread Yury Gribov
On 01/26/2015 11:03 AM, Yury Gribov wrote: On 01/16/2015 12:18 PM, Yury Gribov wrote: This is a wwwdocs patch to changes.html to announce -freport-bug flag. Ok to commit? Hi all, Second version of patch with updates from Gerald Pfeifer. Ok to commit? Ping. -Y ? the Index: htdocs/gcc

[PATCH] Fix for PR64741 (UBSan/ASan integration)

2015-01-26 Thread Yury Gribov
cf083510ece7b7bde1ab5a41e293b5a6a5bb4550 Author: Yury Gribov y.gri...@samsung.com Date: Mon Jan 26 10:19:03 2015 +0300 2015-01-26 Yury Gribov y.gri...@samsung.com PR ubsan/64741 * ubsan.c (ubsan_type_descriptor): Update type size. diff --git a/gcc/ubsan.c b/gcc/ubsan.c index a9df290

[PATCHv2][wwwdocs] Mention -freport-bug in release notes

2015-01-26 Thread Yury Gribov
On 01/16/2015 12:18 PM, Yury Gribov wrote: This is a wwwdocs patch to changes.html to announce -freport-bug flag. Ok to commit? Hi all, Second version of patch with updates from Gerald Pfeifer. Ok to commit? -Y ? the Index: htdocs/gcc-5/changes.html

Re: [PATCH][wwwdocs] Mention -freport-bug in release notes

2015-01-18 Thread Yury Gribov
Hi Gerald, how about the following variation (which I have not committed yet)? The wording is good but the patch places the comment into gcc-ar section which is wrong. Perhaps make a separate section for driver like this? -Y Index: htdocs/gcc-5/changes.html

[PATCH][wwwdocs] Mention -freport-bug in release notes

2015-01-16 Thread Yury Gribov
Hi all, This is a wwwdocs patch to changes.html to announce -freport-bug flag. Ok to commit? -Y Index: htdocs/gcc-5/changes.html === RCS file: /cvs/gcc/wwwdocs/htdocs/gcc-5/changes.html,v retrieving revision 1.65 diff -c -r1.65

[PATCHv3][PING] New check and updates in check_GNU_style script

2014-12-25 Thread Yury Gribov
On 12/19/2014 11:14 AM, Yury Gribov wrote: Hi all, Attached patch adds new check (all blocks of 8 spaces are replaced with tabs) to contrib/check_GNU_style.sh. It also changes the script to allow reading patches from stdin and strengthens the Dot, space, space, new sentence. check. Is this ok

[PATCHv2][PING] New check and updates in check_GNU_style script

2014-12-19 Thread Yury Gribov
c099086a7325d5feca28630be5a569a7de027c93 Mon Sep 17 00:00:00 2001 From: Yury Gribov y.gri...@samsung.com Date: Thu, 11 Dec 2014 13:19:59 +0300 Subject: [PATCH] 2014-12-11 Yury Gribov y.gri...@samsung.com check_GNU_style.sh: Support patches coming from stdin, check that spaces are converted to tabs and make double

[PATCHv2] New check and updates in check_GNU_style script

2014-12-11 Thread Yury Gribov
c099086a7325d5feca28630be5a569a7de027c93 Mon Sep 17 00:00:00 2001 From: Yury Gribov y.gri...@samsung.com Date: Thu, 11 Dec 2014 13:19:59 +0300 Subject: [PATCH] 2014-12-11 Yury Gribov y.gri...@samsung.com check_GNU_style.sh: Support patches coming from stdin, check that spaces are converted to tabs and make double

Re: [PATCH] Fix asan sanopt optimization (PR sanitizer/64170)

2014-12-04 Thread Yury Gribov
On 12/04/2014 01:07 AM, Jakub Jelinek wrote: Hi! The following testcase ICEs, because base_checks vector contains stale statements, and can_remove_asan_check relies on them not to be there anymore (assumes that all statements in the vector dominate the current statement, if that is not true,

Re: [PINGv2][PATCH] Ignore alignment by option

2014-12-04 Thread Yury Gribov
On 12/04/2014 03:47 PM, Dmitry Vyukov wrote: size_in_bytes = -1 instrumentation is too slow to be the default in kernel. If we want to pursue this, I propose a different scheme. Handle 8+ byte accesses as 1/2/4 accesses. No changes to 1/2/4 access handling. Currently when we allocate, say,

Re: [PINGv2][PATCH] Ignore alignment by option

2014-12-04 Thread Yury Gribov
On 12/04/2014 05:04 PM, Dmitry Vyukov wrote: On Thu, Dec 4, 2014 at 4:48 PM, Yury Gribov y.gri...@samsung.com wrote: On 12/04/2014 03:47 PM, Dmitry Vyukov wrote: size_in_bytes = -1 instrumentation is too slow to be the default in kernel. If we want to pursue this, I propose a different

[PATCHv2] Enhance ASAN_CHECK optimization

2014-12-03 Thread Yury Gribov
On 11/25/2014 08:06 PM, Yury Gribov wrote: This patch improves current optimization of ASAN_CHECKS performed by sanopt pass. In addition to searching the sanitized pointer in asan_check_map, it also tries to search for definition of this pointer. This allows more checks to be dropped when

Re: [PATCHv2] Enhance ASAN_CHECK optimization

2014-12-03 Thread Yury Gribov
failed me. How about this one? I only checked asan.exp but the change looks really trivial (drop asan_can_optimize_checks and change asan_check_optimize). -Y From 3bca06f351ed9a7c34f74c30951a7b3cd4907e74 Mon Sep 17 00:00:00 2001 From: Yury Gribov y.gri...@samsung.com Date: Tue, 25 Nov 2014 11

[PATCHv5][PING^4] Vimrc config with GNU formatting

2014-11-28 Thread Yury Gribov
On 11/06/2014 01:31 PM, Yury Gribov wrote: On 10/21/2014 07:24 PM, Yury Gribov wrote: On 10/13/2014 02:26 PM, Yury Gribov wrote: On 10/02/2014 09:14 PM, Yury Gribov wrote: On 09/17/2014 09:08 PM, Yury Gribov wrote: On 09/16/2014 08:38 PM, Yury Gribov wrote: Hi all, This is the third

[PATCH] Enhance ASAN_CHECK optimization

2014-11-25 Thread Yury Gribov
2657 checks in Asan-bootstrapped GCC (out of ~500K). I've Asan-bootstrapped, bootstrapped and regtested on x64. Is this ok for stage3? Best regards, Yury From 85f65c403f132245e9efcc8a420269f8d631fae6 Mon Sep 17 00:00:00 2001 From: Yury Gribov y.gri...@samsung.com Date: Tue, 25 Nov 2014 11:49:11

[PATCHv2] Fix minimal alignment calculation for user-aligned types (PR63802)

2014-11-17 Thread Yury Gribov
On 11/17/2014 10:20 AM, Jakub Jelinek wrote: On Fri, Nov 14, 2014 at 06:15:16PM +, Joseph Myers wrote: On Fri, 14 Nov 2014, Jakub Jelinek wrote: On Fri, Nov 14, 2014 at 09:46:14AM +0300, Yury Gribov wrote: Hi all, This patch fixes https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63802

Re: [PATCH] -fsanitize-recover=list

2014-11-17 Thread Yury Gribov
As for the generated code, I'm at the stage where I can implement the following: if a single UBSan hander is used to report multiple error kinds (__ubsan_handle_type_mismatch is used for -fsanitize=null,alignment,object-size), and these kinds have different recoverability, then we emit two

Re: PATCH: PR bootstrap/63888: [5 Regression] bootstrap failed when configured with -with-build-config=bootstrap-asan --disable-werror

2014-11-16 Thread Yury Gribov
On 11/15/2014 09:34 PM, H.J. Lu wrote: GCC uses xstrndup/xstrdup throughout the source tree and those memory may not be freed explicitly before exut. LeakSanitizer isn't very useful here. This patch suppresses LeakSanitizer in bootstrap. OK for trunk? Right, I think until now everyone just

[PATCH] Fix minimal alignment calculation for user-aligned types (PR63802)

2014-11-13 Thread Yury Gribov
17 00:00:00 2001 From: Yury Gribov y.gri...@samsung.com Date: Thu, 13 Nov 2014 21:29:51 +0300 Subject: [PATCH] 2014-11-14 Yury Gribov y.gri...@samsung.com PR sanitizer/63802 gcc/ * stor-layout.c (min_align_of_type): Respect user alignment more. gcc/testsuite/ * c-c++-common/ubsan/pr63802.c

Re: [PATCH] Fix minimal alignment calculation for user-aligned types (PR63802)

2014-11-13 Thread Yury Gribov
On 11/14/2014 10:02 AM, Jakub Jelinek wrote: On Fri, Nov 14, 2014 at 09:46:14AM +0300, Yury Gribov wrote: Hi all, This patch fixes https://gcc.gnu.org/bugzilla/show_bug.cgi?id=63802 by only limiting minimal type alignment with BIGGEST_ALIGNMENT for types with no __attribute__((aligned

Re: [RFC PATCH] Optimize ASAN_CHECK checks

2014-11-12 Thread Yury Gribov
On 11/11/2014 08:42 PM, Jakub Jelinek wrote: On Wed, Nov 05, 2014 at 11:50:20AM +0100, Jakub Jelinek wrote: On Wed, Nov 05, 2014 at 11:29:19AM +0100, Marek Polacek wrote: On Wed, Nov 05, 2014 at 12:54:37PM +0300, Yury Gribov wrote: Are you going to work on ASan soon? I could rebase my

Re: PATCH: PR testsuite/63830: c-c++-common/asan/strlen-overflow-1.c fails on x32

2014-11-12 Thread Yury Gribov
On 11/12/2014 04:52 AM, H.J. Lu wrote: Hi, This patch updates c-c++-common/asan/strlen-overflow-1.c to avoid tail call on x32. Tested on Linux/x86-64/ia32/x32. OK to install? Thanks. H.J. --- 2014-11-11 H.J. Lu hongjiu...@intel.com PR testsuite/63830 *

Re: [RFC PATCH] Optimize ASAN_CHECK checks

2014-11-12 Thread Yury Gribov
On 11/12/2014 01:34 PM, Jakub Jelinek wrote: On Wed, Nov 12, 2014 at 12:18:31PM +0300, Yury Gribov wrote: --- gcc/sanopt.c.jj 2014-11-11 09:13:36.698280115 +0100 +++ gcc/sanopt.c2014-11-11 18:07:17.913539517 +0100 @@ -49,6 +49,7 @@ along with GCC; see the file COPYING3. #include

Re: [PATCH] Fix for mklog

2014-11-06 Thread Yury Gribov
On 11/06/2014 11:00 AM, Marat Zakirov wrote: - if ($doubtfunc) { - $idx = $line_idx; + $idx = $line_idx; # Skip line info in context diffs. - while ($is_context_diff $diff_lines[$idx + 1] =~ /^[-\*]{3} [0-9]/) { - ++$idx; -

Re: [PATCH] Fix for mklog

2014-11-06 Thread Yury Gribov
On 11/06/2014 12:07 PM, Yury Gribov wrote: On 11/06/2014 11:00 AM, Marat Zakirov wrote: -if ($doubtfunc) { -$idx = $line_idx; +$idx = $line_idx; # Skip line info in context diffs. -while ($is_context_diff $diff_lines[$idx + 1] =~ /^[-\*]{3} [0-9

[PATCHv5][PING^3] Vimrc config with GNU formatting

2014-11-06 Thread Yury Gribov
On 10/21/2014 07:24 PM, Yury Gribov wrote: On 10/13/2014 02:26 PM, Yury Gribov wrote: On 10/02/2014 09:14 PM, Yury Gribov wrote: On 09/17/2014 09:08 PM, Yury Gribov wrote: On 09/16/2014 08:38 PM, Yury Gribov wrote: Hi all, This is the third version of the patch. A list of changes since

Re: [PATCH] Optimize UBSAN_NULL checks, add sanopt.c

2014-11-05 Thread Yury Gribov
On 11/03/2014 05:27 PM, Marek Polacek wrote: Another shot at optimizing redundant UBSAN_NULL statements. This time we walk the dominator tree - that should result in more effective optimization - and keep a list of UBSAN_NULL statements that dominate the current block, see the comment before

  1   2   3   4   >