Re: [PATCH] Add D demangling support to libiberty

2014-10-14 Thread Joel Brobecker
Hello Ian, libiberty/ChangeLog 2014-08-05 Iain Buclaw ibuc...@gdcproject.org * Makefile.in (CFILES): Add d-demangle.c. (REQUIRED_OFILES): Add d-demangle.o. * cplus-dem.c (libiberty_demanglers): Add dlang_demangling case. (cplus_demangle): Likewise. * d-demangle.c:

Re: [PATCH] Add D demangling support to libiberty

2014-10-14 Thread Ian Lance Taylor
On Tue, Oct 14, 2014 at 7:12 AM, Joel Brobecker brobec...@adacore.com wrote: libiberty/ChangeLog 2014-08-05 Iain Buclaw ibuc...@gdcproject.org * Makefile.in (CFILES): Add d-demangle.c. (REQUIRED_OFILES): Add d-demangle.o. * cplus-dem.c (libiberty_demanglers): Add

Re: [PATCH] Add D demangling support to libiberty

2014-10-14 Thread Iain Buclaw
On 14 October 2014 15:28, Ian Lance Taylor i...@google.com wrote: On Tue, Oct 14, 2014 at 7:12 AM, Joel Brobecker brobec...@adacore.com wrote: libiberty/ChangeLog 2014-08-05 Iain Buclaw ibuc...@gdcproject.org * Makefile.in (CFILES): Add d-demangle.c. (REQUIRED_OFILES): Add

Re: [PATCH] Add D demangling support to libiberty

2014-10-14 Thread Joel Brobecker
I've just seen this, so I'll repeat what I've said in gdb patches too. The call to strtold is only needed to decode templates which have a floating point value encoded inside. This value may or may not have a greater than double precision. Replacing long double with double will be fine

Re: [PATCH] Add D demangling support to libiberty

2014-10-14 Thread Ian Lance Taylor
On Tue, Oct 14, 2014 at 10:07 AM, Joel Brobecker brobec...@adacore.com wrote: libiberty/ChangeLog: * d-demangle.c: Replace strtold with strtod in global comment. (strtold): Remove declaration. (strtod): New declaration. (dlang_parse_real): Declare value as

Re: [PATCH] Add D demangling support to libiberty

2014-10-14 Thread Iain Buclaw
On 14 October 2014 18:07, Joel Brobecker brobec...@adacore.com wrote: I've just seen this, so I'll repeat what I've said in gdb patches too. The call to strtold is only needed to decode templates which have a floating point value encoded inside. This value may or may not have a greater than

Re: [PATCH] Add D demangling support to libiberty

2014-10-14 Thread Joel Brobecker
libiberty/ChangeLog: * d-demangle.c: Replace strtold with strtod in global comment. (strtold): Remove declaration. (strtod): New declaration. (dlang_parse_real): Declare value as double instead of long double. Replace call to strtold by call

Re: [PATCH] Add D demangling support to libiberty

2014-09-23 Thread Iain Buclaw
On 19 September 2014 08:51, Iain Buclaw ibuc...@gdcproject.org wrote: On 4 August 2014 16:52, Ian Lance Taylor i...@google.com wrote: On Sun, Aug 3, 2014 at 11:12 AM, Iain Buclaw ibuc...@gdcproject.org wrote: - I haven't signed any copyright assignments to GCC. But I have papers from Donald

Re: [PATCH] Add D demangling support to libiberty

2014-09-23 Thread Ian Lance Taylor
On Fri, Sep 19, 2014 at 12:51 AM, Iain Buclaw ibuc...@gdcproject.org wrote: On 4 August 2014 16:52, Ian Lance Taylor i...@google.com wrote: On Sun, Aug 3, 2014 at 11:12 AM, Iain Buclaw ibuc...@gdcproject.org wrote: - I haven't signed any copyright assignments to GCC. But I have papers from

Re: [PATCH] Add D demangling support to libiberty

2014-09-19 Thread Iain Buclaw
On 4 August 2014 16:52, Ian Lance Taylor i...@google.com wrote: On Sun, Aug 3, 2014 at 11:12 AM, Iain Buclaw ibuc...@gdcproject.org wrote: - I haven't signed any copyright assignments to GCC. But I have papers from Donald ready to send across. Definitely necessary before we can consider

Re: [PATCH] Add D demangling support to libiberty

2014-08-05 Thread Iain Buclaw
Attached revision #2 of the patch. --- Add D demangling support for version 2 of the ABI. include/ChangeLog 2014-08-05 Iain Buclaw ibuc...@gdcproject.org * demangle.h (DMGL_DLANG): New macro. (DMGL_STYLE_MASK): Add DMGL_DLANG. (demangling_styles): Add dlang_demangling.

Re: [PATCH] Add D demangling support to libiberty

2014-08-04 Thread Ian Lance Taylor
On Sun, Aug 3, 2014 at 11:12 AM, Iain Buclaw ibuc...@gdcproject.org wrote: This adds a demangler for the D programming language to libiberty, intended to be used in GDB and Binutils. GDB already has a trimmed down implementation of this, but have been advised that here would be a better

Re: [PATCH] Add D demangling support to libiberty

2014-08-04 Thread Tom Tromey
Iain == Iain Buclaw ibuc...@gdcproject.org writes: Iain This adds a demangler for the D programming language to libiberty, Iain intended to be used in GDB and Binutils. GDB already has a trimmed Iain down implementation of this, but have been advised that here would be Iain a better location to

Re: [PATCH] Add D demangling support to libiberty

2014-08-04 Thread Iain Buclaw
On 4 August 2014 16:52, Ian Lance Taylor i...@google.com wrote: On Sun, Aug 3, 2014 at 11:12 AM, Iain Buclaw ibuc...@gdcproject.org wrote: This adds a demangler for the D programming language to libiberty, intended to be used in GDB and Binutils. GDB already has a trimmed down implementation

Re: [PATCH] Add D demangling support to libiberty

2014-08-04 Thread Iain Buclaw
On 4 August 2014 17:06, Tom Tromey tro...@redhat.com wrote: Iain == Iain Buclaw ibuc...@gdcproject.org writes: Iain This adds a demangler for the D programming language to libiberty, Iain intended to be used in GDB and Binutils. GDB already has a trimmed Iain down implementation of this, but

[PATCH] Add D demangling support to libiberty

2014-08-03 Thread Iain Buclaw
Hi, This adds a demangler for the D programming language to libiberty, intended to be used in GDB and Binutils. GDB already has a trimmed down implementation of this, but have been advised that here would be a better location to house it. Notes that I think are of interest / questions I have