Re: [PATCH] Allow `make tags` to work from top-level directory

[Jeff Law via Gcc-patches]

On 10/12/2021 1:56 PM, Eric Gallager wrote:

On Tue, Oct 12, 2021 at 9:18 AM Jeff Law  wrote:



On 10/11/2021 4:05 PM, Eric Gallager via Gcc-patches wrote:

On Thu, Oct 13, 2016 at 4:43 PM Eric Gallager  wrote:

On 10/13/16, Jeff Law  wrote:

On 10/06/2016 07:21 AM, Eric Gallager wrote:

The libdecnumber, libgcc, and libobjc subdirectories are missing TAGS
targets in their Makefiles. The attached patch causes them to be
skipped when running `make tags`.

ChangeLog entry:

2016-10-06  Eric Gallager  

   * Makefile.def: Mark libdecnumber, libgcc, and libobjc as missing
   TAGS target.
   * Makefile.in: Regenerate.


OK.  Please install.

Thanks,
Jeff


I'm still waiting to hear back from  about my request
for copyright assignment, which I'll need to get sorted out before I
can start committing stuff (like this patch).

Thanks,
Eric

Update: In the intervening years, I got my copyright assignment filed
and have recently become able to commit again; is your old approval
from 2016 still valid, Jeff, or do I need a re-approval?
Ref: https://gcc.gnu.org/legacy-ml/gcc-patches/2016-10/msg00370.html

It's still valid.  Just re-test and commit.

jeff

While re-testing, it seems that the `etags` command on my computer
can't be found any longer; I'm thinking gcc/Makefile.in should be
updated to stop hardcoding etags and use a variable that can be
overridden instead... should I do a separate patch for that, or
combine it with this one?

I think this will be simple enough that either way will be fine.

jeff

Re: [PATCH] Allow `make tags` to work from top-level directory

[Eric Gallager via Gcc-patches]

On Tue, Oct 12, 2021 at 3:56 PM Eric Gallager  wrote:
>
> On Tue, Oct 12, 2021 at 9:18 AM Jeff Law  wrote:
> >
> >
> >
> > On 10/11/2021 4:05 PM, Eric Gallager via Gcc-patches wrote:
> > > On Thu, Oct 13, 2016 at 4:43 PM Eric Gallager  
> > > wrote:
> > >> On 10/13/16, Jeff Law  wrote:
> > >>> On 10/06/2016 07:21 AM, Eric Gallager wrote:
> >  The libdecnumber, libgcc, and libobjc subdirectories are missing TAGS
> >  targets in their Makefiles. The attached patch causes them to be
> >  skipped when running `make tags`.
> > 
> >  ChangeLog entry:
> > 
> >  2016-10-06  Eric Gallager  
> > 
> >    * Makefile.def: Mark libdecnumber, libgcc, and libobjc as missing
> >    TAGS target.
> >    * Makefile.in: Regenerate.
> > 
> > >>> OK.  Please install.
> > >>>
> > >>> Thanks,
> > >>> Jeff
> > >>>
> > >>
> > >> I'm still waiting to hear back from  about my request
> > >> for copyright assignment, which I'll need to get sorted out before I
> > >> can start committing stuff (like this patch).
> > >>
> > >> Thanks,
> > >> Eric
> > > Update: In the intervening years, I got my copyright assignment filed
> > > and have recently become able to commit again; is your old approval
> > > from 2016 still valid, Jeff, or do I need a re-approval?
> > > Ref: https://gcc.gnu.org/legacy-ml/gcc-patches/2016-10/msg00370.html
> > It's still valid.  Just re-test and commit.
> >
> > jeff
>
> While re-testing, it seems that the `etags` command on my computer
> can't be found any longer; I'm thinking gcc/Makefile.in should be
> updated to stop hardcoding etags and use a variable that can be
> overridden instead... should I do a separate patch for that, or
> combine it with this one?

Well, anyways, this is what I've ended up committing for now:
https://gcc.gnu.org/git/?p=gcc.git;a=commitdiff;h=4ca446a46bef8c127d7aaeb2d4bb4625edc7f84e


patch-Makefile.diff
Description: Binary data

Re: [PATCH] Allow `make tags` to work from top-level directory

[Eric Gallager via Gcc-patches]

On Tue, Oct 12, 2021 at 9:18 AM Jeff Law  wrote:
>
>
>
> On 10/11/2021 4:05 PM, Eric Gallager via Gcc-patches wrote:
> > On Thu, Oct 13, 2016 at 4:43 PM Eric Gallager  wrote:
> >> On 10/13/16, Jeff Law  wrote:
> >>> On 10/06/2016 07:21 AM, Eric Gallager wrote:
>  The libdecnumber, libgcc, and libobjc subdirectories are missing TAGS
>  targets in their Makefiles. The attached patch causes them to be
>  skipped when running `make tags`.
> 
>  ChangeLog entry:
> 
>  2016-10-06  Eric Gallager  
> 
>    * Makefile.def: Mark libdecnumber, libgcc, and libobjc as missing
>    TAGS target.
>    * Makefile.in: Regenerate.
> 
> >>> OK.  Please install.
> >>>
> >>> Thanks,
> >>> Jeff
> >>>
> >>
> >> I'm still waiting to hear back from  about my request
> >> for copyright assignment, which I'll need to get sorted out before I
> >> can start committing stuff (like this patch).
> >>
> >> Thanks,
> >> Eric
> > Update: In the intervening years, I got my copyright assignment filed
> > and have recently become able to commit again; is your old approval
> > from 2016 still valid, Jeff, or do I need a re-approval?
> > Ref: https://gcc.gnu.org/legacy-ml/gcc-patches/2016-10/msg00370.html
> It's still valid.  Just re-test and commit.
>
> jeff

While re-testing, it seems that the `etags` command on my computer
can't be found any longer; I'm thinking gcc/Makefile.in should be
updated to stop hardcoding etags and use a variable that can be
overridden instead... should I do a separate patch for that, or
combine it with this one?

Re: [PATCH] Allow `make tags` to work from top-level directory

[Jeff Law via Gcc-patches]

On 10/11/2021 4:05 PM, Eric Gallager via Gcc-patches wrote:

On Thu, Oct 13, 2016 at 4:43 PM Eric Gallager  wrote:

On 10/13/16, Jeff Law  wrote:

On 10/06/2016 07:21 AM, Eric Gallager wrote:

The libdecnumber, libgcc, and libobjc subdirectories are missing TAGS
targets in their Makefiles. The attached patch causes them to be
skipped when running `make tags`.

ChangeLog entry:

2016-10-06  Eric Gallager  

  * Makefile.def: Mark libdecnumber, libgcc, and libobjc as missing
  TAGS target.
  * Makefile.in: Regenerate.


OK.  Please install.

Thanks,
Jeff



I'm still waiting to hear back from  about my request
for copyright assignment, which I'll need to get sorted out before I
can start committing stuff (like this patch).

Thanks,
Eric

Update: In the intervening years, I got my copyright assignment filed
and have recently become able to commit again; is your old approval
from 2016 still valid, Jeff, or do I need a re-approval?
Ref: https://gcc.gnu.org/legacy-ml/gcc-patches/2016-10/msg00370.html

It's still valid.  Just re-test and commit.

jeff

Re: [PATCH] Allow `make tags` to work from top-level directory

[Eric Gallager via Gcc-patches]

On Thu, Oct 13, 2016 at 4:43 PM Eric Gallager  wrote:
>
> On 10/13/16, Jeff Law  wrote:
> > On 10/06/2016 07:21 AM, Eric Gallager wrote:
> >> The libdecnumber, libgcc, and libobjc subdirectories are missing TAGS
> >> targets in their Makefiles. The attached patch causes them to be
> >> skipped when running `make tags`.
> >>
> >> ChangeLog entry:
> >>
> >> 2016-10-06  Eric Gallager  
> >>
> >>  * Makefile.def: Mark libdecnumber, libgcc, and libobjc as missing
> >>  TAGS target.
> >>  * Makefile.in: Regenerate.
> >>
> > OK.  Please install.
> >
> > Thanks,
> > Jeff
> >
>
>
> I'm still waiting to hear back from  about my request
> for copyright assignment, which I'll need to get sorted out before I
> can start committing stuff (like this patch).
>
> Thanks,
> Eric

Update: In the intervening years, I got my copyright assignment filed
and have recently become able to commit again; is your old approval
from 2016 still valid, Jeff, or do I need a re-approval?
Ref: https://gcc.gnu.org/legacy-ml/gcc-patches/2016-10/msg00370.html
Thanks,
Eric

Re: [PATCH] Allow `make tags` to work from top-level directory

[Eric Gallager]

On 10/13/16, Jeff Law  wrote:
> On 10/06/2016 07:21 AM, Eric Gallager wrote:
>> The libdecnumber, libgcc, and libobjc subdirectories are missing TAGS
>> targets in their Makefiles. The attached patch causes them to be
>> skipped when running `make tags`.
>>
>> ChangeLog entry:
>>
>> 2016-10-06  Eric Gallager  
>>
>>  * Makefile.def: Mark libdecnumber, libgcc, and libobjc as missing
>>  TAGS target.
>>  * Makefile.in: Regenerate.
>>
> OK.  Please install.
>
> Thanks,
> Jeff
>


I'm still waiting to hear back from  about my request
for copyright assignment, which I'll need to get sorted out before I
can start committing stuff (like this patch).

Thanks,
Eric

Re: [PATCH] Allow `make tags` to work from top-level directory

[Jeff Law]

On 10/06/2016 07:21 AM, Eric Gallager wrote:

The libdecnumber, libgcc, and libobjc subdirectories are missing TAGS
targets in their Makefiles. The attached patch causes them to be
skipped when running `make tags`.

ChangeLog entry:

2016-10-06  Eric Gallager  

* Makefile.def: Mark libdecnumber, libgcc, and libobjc as missing
TAGS target.
* Makefile.in: Regenerate.


OK.  Please install.

Thanks,
Jeff

[PATCH] Allow `make tags` to work from top-level directory

[Eric Gallager]

The libdecnumber, libgcc, and libobjc subdirectories are missing TAGS
targets in their Makefiles. The attached patch causes them to be
skipped when running `make tags`.

ChangeLog entry:

2016-10-06  Eric Gallager  

* Makefile.def: Mark libdecnumber, libgcc, and libobjc as missing
TAGS target.
* Makefile.in: Regenerate.
 Makefile.def |  9 ++---
 Makefile.in  | 62 +---
 2 files changed, 15 insertions(+), 56 deletions(-)

diff --git a/Makefile.def b/Makefile.def
index 4eea342..942b147 100644
--- a/Makefile.def
+++ b/Makefile.def
@@ -81,7 +81,8 @@ host_modules= { module= itcl; };
 host_modules= { module= ld; bootstrap=true; };
 host_modules= { module= libbacktrace; bootstrap=true; };
 host_modules= { module= libcpp; bootstrap=true; };
-host_modules= { module= libdecnumber; bootstrap=true; };
+host_modules= { module= libdecnumber; bootstrap=true;
+missing=TAGS; };
 host_modules= { module= libgui; };
 host_modules= { module= libiberty; bootstrap=true;

extra_configure_flags='@extra_host_libiberty_configure_flags@';};
@@ -151,11 +152,13 @@ target_modules = { module= liboffloadmic;
   
extra_configure_flags='@extra_liboffloadmic_configure_flags@'; };
 target_modules = { module= libssp; lib_path=.libs; };
 target_modules = { module= newlib; };
-target_modules = { module= libgcc; bootstrap=true; no_check=true; };
+target_modules = { module= libgcc; bootstrap=true; no_check=true;
+   missing=TAGS; };
 target_modules = { module= libbacktrace; };
 target_modules = { module= libquadmath; };
 target_modules = { module= libgfortran; };
-target_modules = { module= libobjc; };
+target_modules = { module= libobjc;
+   missing=TAGS; };
 target_modules = { module= libgo; };
 target_modules = { module= libtermcap; no_check=true;
missing=mostlyclean;
diff --git a/Makefile.in b/Makefile.in
index 3046489..1bd20b8 100644
--- a/Makefile.in
+++ b/Makefile.in
@@ -24399,23 +24399,8 @@ maybe-TAGS-libdecnumber:
 @if libdecnumber
 maybe-TAGS-libdecnumber: TAGS-libdecnumber
 
-TAGS-libdecnumber: \
-configure-libdecnumber 
-   @[ -f ./libdecnumber/Makefile ] || exit 0; \
-   r=`${PWD_COMMAND}`; export r; \
-   s=`cd $(srcdir); ${PWD_COMMAND}`; export s; \
-   $(HOST_EXPORTS) \
-   for flag in $(EXTRA_HOST_FLAGS) ; do \
- eval `echo "$$flag" | sed -e "s|^\([^=]*\)=\(.*\)|\1='\2'; export 
\1|"`; \
-   done; \
-   echo "Doing TAGS in libdecnumber"; \
-   (cd $(HOST_SUBDIR)/libdecnumber && \
- $(MAKE) $(BASE_FLAGS_TO_PASS) "AR=$${AR}" "AS=$${AS}" \
- "CC=$${CC}" "CXX=$${CXX}" "LD=$${LD}" "NM=$${NM}" \
- "RANLIB=$${RANLIB}" \
- "DLLTOOL=$${DLLTOOL}" "WINDRES=$${WINDRES}" 
"WINDMC=$${WINDMC}" \
- TAGS) \
- || exit 1
+# libdecnumber doesn't support TAGS.
+TAGS-libdecnumber:
 
 @endif libdecnumber
 
@@ -43600,24 +43585,8 @@ maybe-TAGS-target-libgcc:
 @if target-libgcc
 maybe-TAGS-target-libgcc: TAGS-target-libgcc
 
-TAGS-target-libgcc: \
-configure-target-libgcc 
-   @: $(MAKE); $(unstage)
-   @[ -f $(TARGET_SUBDIR)/libgcc/Makefile ] || exit 0; \
-   r=`${PWD_COMMAND}`; export r; \
-   s=`cd $(srcdir); ${PWD_COMMAND}`; export s; \
-   $(NORMAL_TARGET_EXPORTS) \
-   echo "Doing TAGS in $(TARGET_SUBDIR)/libgcc"; \
-   for flag in $(EXTRA_TARGET_FLAGS); do \
- eval `echo "$$flag" | sed -e "s|^\([^=]*\)=\(.*\)|\1='\2'; export 
\1|"`; \
-   done; \
-   (cd $(TARGET_SUBDIR)/libgcc && \
- $(MAKE) $(BASE_FLAGS_TO_PASS) "AR=$${AR}" "AS=$${AS}" \
- "CC=$${CC}" "CXX=$${CXX}" "LD=$${LD}" "NM=$${NM}" \
- "RANLIB=$${RANLIB}" \
- "DLLTOOL=$${DLLTOOL}" "WINDRES=$${WINDRES}" 
"WINDMC=$${WINDMC}" \
-  TAGS) \
- || exit 1
+# libgcc doesn't support TAGS.
+TAGS-target-libgcc:
 
 @endif target-libgcc
 
@@ -45432,24 +45401,8 @@ maybe-TAGS-target-libobjc:
 @if target-libobjc
 maybe-TAGS-target-libobjc: TAGS-target-libobjc
 
-TAGS-target-libobjc: \
-configure-target-libobjc 
-   @: $(MAKE); $(unstage)
-   @[ -f $(TARGET_SUBDIR)/libobjc/Makefile ] || exit 0; \
-   r=`${PWD_COMMAND}`; export r; \
-   s=`cd $(srcdir); ${PWD_COMMAND}`; export s; \
-   $(NORMAL_TARGET_EXPORTS) \
-   echo "Doing TAGS in $(TARGET_SUBDIR)/libobjc"; \
-   for flag in $(EXTRA_TARGET_FLAGS); do \
- eval `echo "$$flag" | sed -e "s|^\([^=]*\)=\(.*\)|\1='\2'; export 
\1|"`; \
-   done; \
-   (cd $(TARGET_SUBDIR)/libobjc && \
- $(MAKE) $(BASE_FLAGS_TO_PASS) "AR=$${AR}" "AS=$${AS}" \
- "CC=$${CC}" "CXX=$${CXX}" "LD=$${LD}" "NM=$${NM}" \
- "RANLIB=$${RANLIB}" \
- "DLLTOOL=$${DLLTOOL}" "WINDRES=$${WINDRES}" 
"WINDMC=$${WINDMC}" \
-