Re: [branches/google/gcc-4_6] Backported r179661 and 179662 from mainline. (issue 5989043)

2012-04-05 Thread Andrew Stubbs 

On 05/04/12 05:43, Michael Hope wrote:

Andrew, could you check that the Google guys have the final version of
your patch?


Yes, it looks fine to me.


Could you backport the fix to the 4.6 release branch if valid?  Better
than having the same patch in three places.


Ok, I'll need permission from a maintainer, I think.

Andrew

Re: [branches/google/gcc-4_6] Backported r179661 and 179662 from mainline. (issue 5989043)

2012-04-05 Thread Xinliang David Li 
ok for google branches

David

On Wed, Apr 4, 2012 at 8:56 PM,  asha...@chromium.org wrote:
 Reviewers: Diego Novillo, jingyu, davidxl,

 Message:
 Please take a look at this patch and tell me if it's OK for
 branches/google/gcc-4_6.

 Description:
 Backported the following patch from trunk:

 2011-10-07  Andrew Stubbs  a...@codesourcery.com

    gcc/
    * config/arm/predicates.md (shift_amount_operand): Remove constant
    range check.
    (shift_operator): Check range of constants for all shift operators.

    gcc/testsuite/
    * gcc.dg/pr50193-1.c: New file.
    * gcc.target/arm/shiftable.c: New file.


 Please review this at http://codereview.appspot.com/5989043/

 Affected files:
   M    .
  M     gcc/ChangeLog
  M     gcc/ChangeLog.google-4_6
  M     gcc/config/arm/predicates.md
  M     gcc/testsuite/ChangeLog
  A  +  gcc/testsuite/gcc.dg/pr50193-1.c
  A  +  gcc/testsuite/gcc.target/arm/shiftable.c

Re: [branches/google/gcc-4_6] Backported r179661 and 179662 from mainline. (issue 5989043)

2012-04-05 Thread asharif 

Committed as r186168.

http://codereview.appspot.com/5989043/

Re: [branches/google/gcc-4_6] Backported r179661 and 179662 from mainline. (issue 5989043)

2012-04-04 Thread Michael Hope 
On 5 April 2012 15:56,  asha...@chromium.org wrote:
 Reviewers: Diego Novillo, jingyu, davidxl,

 Message:
 Please take a look at this patch and tell me if it's OK for
 branches/google/gcc-4_6.

 Description:
 Backported the following patch from trunk:

 2011-10-07  Andrew Stubbs  a...@codesourcery.com

    gcc/
    * config/arm/predicates.md (shift_amount_operand): Remove constant
    range check.
    (shift_operator): Check range of constants for all shift operators.

    gcc/testsuite/
    * gcc.dg/pr50193-1.c: New file.
    * gcc.target/arm/shiftable.c: New file.


 Please review this at http://codereview.appspot.com/5989043/

 Affected files:
   M    .
  M     gcc/ChangeLog
  M     gcc/ChangeLog.google-4_6
  M     gcc/config/arm/predicates.md
  M     gcc/testsuite/ChangeLog
  A  +  gcc/testsuite/gcc.dg/pr50193-1.c
  A  +  gcc/testsuite/gcc.target/arm/shiftable.c

Andrew, could you check that the Google guys have the final version of
your patch?

Could you backport the fix to the 4.6 release branch if valid?  Better
than having the same patch in three places.

-- Michael