Re: [PATCH] PR77990 refactor unique_ptr to encapsulate tuple

2016-10-19 Thread Jonathan Wakely
On 17/10/16 14:37 +0100, Jonathan Wakely wrote: We are incorrectly requiring unique_ptr deleters to be copyable here: explicit unique_ptr(pointer __p) noexcept : _M_t(__p, deleter_type()) { } We could just do: explicit unique_ptr(pointer __p) noexcept : _M_t()

Re: [PATCH] PR77990 refactor unique_ptr to encapsulate tuple

2016-10-18 Thread Pedro Alves
On 10/18/2016 12:54 PM, Jonathan Wakely wrote: > I'll wait a bit longer for any objections, as the refactoring could be > seen as unnecessary churn, but I think it's valuable housekeeping. Having stared at std::unique_ptr a lot recently, I like this, FWIW. Thanks, Pedro Alves

Re: [PATCH] PR77990 refactor unique_ptr to encapsulate tuple

2016-10-18 Thread Jonathan Wakely
On 17/10/16 14:37 +0100, Jonathan Wakely wrote: We are incorrectly requiring unique_ptr deleters to be copyable here: explicit unique_ptr(pointer __p) noexcept : _M_t(__p, deleter_type()) { } We could just do: explicit unique_ptr(pointer __p) noexcept : _M_t()