Re: Please include ada-hurd.diff upstream (try2)

Svante Signell, on Wed 04 May 2016 23:25:28 +0200, wrote: > On Wed, 2016-05-04 at 23:06 +0200, Samuel Thibault wrote: > > Svante Signell, on Wed 04 May 2016 19:43:27 +0200, wrote: > > > May I comment on Debian way of apt-get source gcc-*: Doing that > > > does > > > not unpack the sources, neither

Re: Please include ada-hurd.diff upstream (try2)

On Wed, 2016-05-04 at 23:06 +0200, Samuel Thibault wrote: > Svante Signell, on Wed 04 May 2016 19:43:27 +0200, wrote: > > May I comment on Debian way of apt-get source gcc-*: Doing that > > does > > not unpack the sources, neither does it apply the patches, you have > > to > > unpack and patch

Re: Please include ada-hurd.diff upstream (try2)

Svante Signell, on Wed 04 May 2016 19:43:27 +0200, wrote: > May I comment on Debian way of apt-get source gcc-*: Doing that does > not unpack the sources, neither does it apply the patches, you have to > unpack and patch before you can change sources and update patches. Iv'e > patched the sources

Re: Please include ada-hurd.diff upstream (try2)

> I.e. the proposed change below. Applied on mainline and 6 branch. Please post patches as attachments instead of plain text though, this avoids nasty surprises from mail readers. -- Eric Botcazou

Re: Please include ada-hurd.diff upstream (try2)

On Wed, 2016-05-04 at 18:43 +0200, Svante Signell wrote: > OnSamuel Thibault, on Wed 04 May 2016 17:29:48 +0200, wrote: > > > > > -   --  From: /usr/include/unistd.h __getpagesize or > > > getpagesize?? > > > -   function Get_Page_Size return int; > > > +   --  From:

Re: Please include ada-hurd.diff upstream (try2)

On Wed, 2016-05-04 at 17:34 +0200, Samuel Thibault wrote: > Samuel Thibault, on Wed 04 May 2016 17:29:48 +0200, wrote: > > The gcc-6 build failed. I see that one of the change is: > > > > -   --  From: /usr/include/unistd.h __getpagesize or getpagesize?? > > -   function Get_Page_Size return int;

Re: Please include ada-hurd.diff upstream (try2)

> 2016-05-04 Samuel Thibault > > * s-osinte-gnu.ads: Make Get_Page_Size return int, and make it use > getpagesize instead of __getpagesize. > > --- a/src/gcc/ada/s-osinte-gnu.ads > +++ b/src/gcc/ada/s-osinte-gnu.ads > @@ -344,10 +344,9 @@ package

Re: Please include ada-hurd.diff upstream (try2)

Samuel Thibault, on Wed 04 May 2016 17:29:48 +0200, wrote: > The gcc-6 build failed. I see that one of the change is: > > - -- From: /usr/include/unistd.h __getpagesize or getpagesize?? > - function Get_Page_Size return int; > + -- From: /usr/include/i386-gnu/bits/shm.h __getpagesize or

Re: Please include ada-hurd.diff upstream (try2)

Hello Svante, The gcc-6 build failed. I see that one of the change is: - -- From: /usr/include/unistd.h __getpagesize or getpagesize?? - function Get_Page_Size return int; + -- From: /usr/include/i386-gnu/bits/shm.h __getpagesize or getpagesize?? + function Get_Page_Size return size_t;

Re: Please include ada-hurd.diff upstream (try2)

On Wed, 2016-04-27 at 09:41 +0200, Eric Botcazou wrote: > > > > Attaching the modified ada-hurd.diff. Maybe it is ready for inclusion in > > upstream now? > Upstream already contains the first set of changes though.  Here's what I > have  > installed on mainline and 6 branch (not sure it will be

Re: Please include ada-hurd.diff upstream (try2)

> Attaching the modified ada-hurd.diff. Maybe it is ready for inclusion in > upstream now? Upstream already contains the first set of changes though. Here's what I have installed on mainline and 6 branch (not sure it will be in the 6.1 release). 2016-04-27 Svante Signell

Re: Please include ada-hurd.diff upstream (try2)

> Attaching the modified ada-hurd.diff. Maybe it is ready for inclusion in > upstream now? Patch is OK, go ahead and commit it, thanks. > 2016-03-31 Svante Signell > > * gcc-interface/Makefile.in: Add support for x86 GNU/Hurd. > * s-osinte-gnu.ads:

Re: Please include ada-hurd.diff upstream (try2)

On Mon, 2016-04-25 at 11:50 +0200, Arnaud Charlet wrote: > > > > Is replacing > > > > +-- Copyright (C) 1991-1994, Florida State > > University-- > > +-- Copyright (C) 1995-2014, > > AdaCore -- > > +--  Copyright (C)

Re: Please include ada-hurd.diff upstream (try2)

> Is replacing > > +-- Copyright (C) 1991-1994, Florida State > University-- > +-- Copyright (C) 1995-2014, > AdaCore -- > +--  Copyright (C) 2015-2016, Free Software Foundation, > Inc. -- > > with only > > +--  

Re: Please include ada-hurd.diff upstream (try2)

On Tue, 2016-04-19 at 10:29 +0200, Arnaud Charlet wrote: > > > > The updated attachment was included in message > > https://gcc.gnu.org/ml/gcc-patches/2016-03/msg01659.html > You should just put a FSF copyright on s-osinte-gnu.adb > > OK with this change. Is replacing +-- Copyright

Re: Please include ada-hurd.diff upstream (try2)

> The updated attachment was included in message > https://gcc.gnu.org/ml/gcc-patches/2016-03/msg01659.html You should just put a FSF copyright on s-osinte-gnu.adb OK with this change. Arno

Re: Please include ada-hurd.diff upstream (try2)

ping! The updated attachment was included in message https://gcc.gnu.org/ml/gcc-patches/2016-03/msg01659.html On Thu, 2016-03-31 at 11:33 +0200, Svante Signell wrote: > On Thu, 2016-03-17 at 08:51 +0100, Arnaud Charlet wrote: > > > > > > > > > > > > > > > > > > > > The copyright notices

Re: Please include ada-hurd.diff upstream (try2)

On Thu, 2016-03-17 at 08:51 +0100, Arnaud Charlet wrote: > > > > > > > > The copyright notices are wrong (or at least incomplete). > > Hi, what is wrong then, copyright years and/or the text? > Both. The copyright year should include 2016 and the text should be > copyright FSF, not AdaCore.

Re: Please include ada-hurd.diff upstream (try2)

> > The copyright notices are wrong (or at least incomplete). > > Hi, what is wrong then, copyright years and/or the text? Both. The copyright year should include 2016 and the text should be copyright FSF, not AdaCore. Arno

Re: Please include ada-hurd.diff upstream (try2)

> Yes, you are right, somehow I submitted the old patch. Attached is the > updated one, with a proposed ChangeLog entry included. The copyright notices are wrong (or at least incomplete). Arno > > Thanks! > 2016-03-16 Svante Signell > > *

Re: Please include ada-hurd.diff upstream (try2)

Sorry for manually creating this mail. Replying to Arnauds message crashes my mail client (evolution). On Wed, 2016-03-16 at 11:53 +0100, Arnaud Charlet wrote: > Yes, you are right, somehow I submitted the old patch. Attached is the > updated one, with a proposed ChangeLog entry included. > >

Re: Please include ada-hurd.diff upstream (try2)

On Wed, 2016-03-16 at 11:53 +0100, Eric Botcazou wrote: > > > > Sorry for not supplying a ChangeLog yet, I've been busy lately with other > > things. Since there is another new file s-osinte-gnu.adb in the latest > > patch, that might be added too. > AFAICS there is only s-osinte-gnu.ads in the

Re: Please include ada-hurd.diff upstream (try2)

> Sorry for not supplying a ChangeLog yet, I've been busy lately with other > things. Since there is another new file s-osinte-gnu.adb in the latest > patch, that might be added too. AFAICS there is only s-osinte-gnu.ads in the posted patch. -- Eric Botcazou

Re: Please include ada-hurd.diff upstream (try2)

On Wed, 2016-03-16 at 11:08 +0100, Eric Botcazou wrote: > > > > Maybe the time has come now for a proper inclusion of Ada/Gnat support in > > gcc-* for GNU/Hurd. (Yes, I commit to maintain Ada in gcc for GNU/Hurd in > > the foreseeable future, according to my abilities). > > > > Attached is an

Re: Please include ada-hurd.diff upstream (try2)

> Maybe the time has come now for a proper inclusion of Ada/Gnat support in > gcc-* for GNU/Hurd. (Yes, I commit to maintain Ada in gcc for GNU/Hurd in > the foreseeable future, according to my abilities). > > Attached is an updated patch, now living e.g. in GNU/Debian versions of > gcc-5 and

Re: Please include ada-hurd.diff upstream (try2)

[adding Eric for review] On 02.03.2016 00:42, Svante Signell wrote: Hello, As time progresses, the ada-hurd.diff patch has now been living in Debian since gcc-4.6 and is now in gcc-5 and gcc-6. Last try to get it included upstream was in 2012, and 2014, e.g see