Re: [0/9] [middle-end] Add param to vec_perm_const hook to specify mode of input operand

(Sorry for the slow reply, was off on Friday) Richard Biener writes: > On Wed, May 25, 2022 at 10:24 PM Prathamesh Kulkarni > wrote: >> >> On Thu, 26 May 2022 at 00:37, Richard Biener >> wrote: > [...] >> > x86 now accepts V4SI V8SI permutes because we don’t ask it correctly and >> > thus my

Re: [0/9] [middle-end] Add param to vec_perm_const hook to specify mode of input operand

On Wed, May 25, 2022 at 10:24 PM Prathamesh Kulkarni wrote: > > On Thu, 26 May 2022 at 00:37, Richard Biener > wrote: [...] > > x86 now accepts V4SI V8SI permutes because we don’t ask it correctly and > > thus my naive attempt to use the new function API breaks . Not to mention > > the

Re: [0/9] [middle-end] Add param to vec_perm_const hook to specify mode of input operand

On Thu, 26 May 2022 at 00:37, Richard Biener wrote: > > > > > Am 25.05.2022 um 21:03 schrieb Prathamesh Kulkarni > > : > > > > On Wed, 25 May 2022 at 18:27, Richard Biener > > wrote: > >> > >>> On Tue, May 24, 2022 at 9:22 PM Prathamesh Kulkarni via Gcc-patches > >>> wrote: > >>> > >>> On

Re: [0/9] [middle-end] Add param to vec_perm_const hook to specify mode of input operand

> Am 25.05.2022 um 21:03 schrieb Prathamesh Kulkarni > : > > On Wed, 25 May 2022 at 18:27, Richard Biener > wrote: >> >>> On Tue, May 24, 2022 at 9:22 PM Prathamesh Kulkarni via Gcc-patches >>> wrote: >>> >>> On Tue, 24 May 2022 at 14:50, Richard Sandiford >>> wrote:

Re: [0/9] [middle-end] Add param to vec_perm_const hook to specify mode of input operand

On Wed, 25 May 2022 at 18:27, Richard Biener wrote: > > On Tue, May 24, 2022 at 9:22 PM Prathamesh Kulkarni via Gcc-patches > wrote: > > > > On Tue, 24 May 2022 at 14:50, Richard Sandiford > > wrote: > > > > > > Prathamesh Kulkarni writes: > > > > diff --git a/gcc/doc/tm.texi b/gcc/doc/tm.texi

Re: [0/9] [middle-end] Add param to vec_perm_const hook to specify mode of input operand

On Tue, May 24, 2022 at 9:22 PM Prathamesh Kulkarni via Gcc-patches wrote: > > On Tue, 24 May 2022 at 14:50, Richard Sandiford > wrote: > > > > Prathamesh Kulkarni writes: > > > diff --git a/gcc/doc/tm.texi b/gcc/doc/tm.texi > > > index c5006afc00d..0a3c733ada9 100644 > > > ---

Re: [0/9] [middle-end] Add param to vec_perm_const hook to specify mode of input operand

On Tue, 24 May 2022 at 14:50, Richard Sandiford wrote: > > Prathamesh Kulkarni writes: > > diff --git a/gcc/doc/tm.texi b/gcc/doc/tm.texi > > index c5006afc00d..0a3c733ada9 100644 > > --- a/gcc/doc/tm.texi > > +++ b/gcc/doc/tm.texi > > @@ -6088,14 +6088,18 @@ for the given scalar type

Re: [0/9] [middle-end] Add param to vec_perm_const hook to specify mode of input operand

Prathamesh Kulkarni writes: > diff --git a/gcc/doc/tm.texi b/gcc/doc/tm.texi > index c5006afc00d..0a3c733ada9 100644 > --- a/gcc/doc/tm.texi > +++ b/gcc/doc/tm.texi > @@ -6088,14 +6088,18 @@ for the given scalar type @var{type}. > @var{is_packed} is false if the scalar > access using

Re: [0/9] [middle-end] Add param to vec_perm_const hook to specify mode of input operand

On Mon, 23 May 2022 at 18:14, Richard Sandiford wrote: > > Prathamesh Kulkarni writes: > > On Wed, 18 May 2022 at 17:27, Richard Sandiford > > wrote: > >> > >> Prathamesh Kulkarni writes: > >> > Hi, > >> > The attached patch adds another parameter machine_mode op_mode to > >> > vec_perm_const

Re: [0/9] [middle-end] Add param to vec_perm_const hook to specify mode of input operand

Prathamesh Kulkarni writes: > On Wed, 18 May 2022 at 17:27, Richard Sandiford > wrote: >> >> Prathamesh Kulkarni writes: >> > Hi, >> > The attached patch adds another parameter machine_mode op_mode to >> > vec_perm_const >> > hook to specify mode of input operands. The motivation for doing

Re: [0/9] [middle-end] Add param to vec_perm_const hook to specify mode of input operand

On Wed, 18 May 2022 at 17:27, Richard Sandiford wrote: > > Prathamesh Kulkarni writes: > > Hi, > > The attached patch adds another parameter machine_mode op_mode to > > vec_perm_const > > hook to specify mode of input operands. The motivation for doing this > > is PR96463, > > where we create

Re: [0/9] [middle-end] Add param to vec_perm_const hook to specify mode of input operand

On Wed, May 18, 2022 at 9:08 AM Prathamesh Kulkarni via Gcc-patches wrote: > > Hi, > The attached patch adds another parameter machine_mode op_mode to > vec_perm_const > hook to specify mode of input operands. The motivation for doing this > is PR96463, > where we create vec_perm_expr of the

Re: [0/9] [middle-end] Add param to vec_perm_const hook to specify mode of input operand

Prathamesh Kulkarni writes: > Hi, > The attached patch adds another parameter machine_mode op_mode to > vec_perm_const > hook to specify mode of input operands. The motivation for doing this > is PR96463, > where we create vec_perm_expr of the form: > lhs = vec_perm_expr > where lhs and rhs have

Re: [0/9] [middle-end] Add param to vec_perm_const hook to specify mode of input operand

Hi Prathamesh, I am just looking at this as it interacts with a change I am trying to make, but I'm not a reviewer so take my comments with a pinch of salt ;) I copied in bits of your patch below to comment. > -@deftypefn {Target Hook} bool TARGET_VECTORIZE_VEC_PERM_CONST (machine_mode

[0/9] [middle-end] Add param to vec_perm_const hook to specify mode of input operand

Hi, The attached patch adds another parameter machine_mode op_mode to vec_perm_const hook to specify mode of input operands. The motivation for doing this is PR96463, where we create vec_perm_expr of the form: lhs = vec_perm_expr where lhs and rhs have different vector types but same element type