Re: [10/32] Remove global call sets: combine.c

2019-09-29 Thread Segher Boessenkool
On Sun, Sep 29, 2019 at 04:32:13PM -0600, Jeff Law wrote: > On 9/25/19 9:52 AM, Richard Sandiford wrote: > > gcc/ > > * combine.c: Include function-abi.h. > > (record_dead_and_set_regs): Use insn_callee_abi to get the ABI > > of the target of call insns. Invalidate partially-clobbered

Re: [10/32] Remove global call sets: combine.c

2019-09-29 Thread Jeff Law
On 9/25/19 9:52 AM, Richard Sandiford wrote: > Segher Boessenkool writes: >> Hi Richard, >> >> Sorry this too me so long to get back to. >> >> On Thu, Sep 12, 2019 at 08:51:59AM +0100, Richard Sandiford wrote: >>> Segher Boessenkool writes: On Wed, Sep 11, 2019 at 08:08:38PM +0100, Richard

Re: [10/32] Remove global call sets: combine.c

2019-09-25 Thread Segher Boessenkool
On Wed, Sep 25, 2019 at 04:52:14PM +0100, Richard Sandiford wrote: > Segher Boessenkool writes: > > On Thu, Sep 12, 2019 at 08:51:59AM +0100, Richard Sandiford wrote: > >> Segher Boessenkool writes: > >> > It is not such a great name like that. Since its children are > >> > very_long_names, it

Re: [10/32] Remove global call sets: combine.c

2019-09-25 Thread Richard Sandiford
Segher Boessenkool writes: > Hi Richard, > > Sorry this too me so long to get back to. > > On Thu, Sep 12, 2019 at 08:51:59AM +0100, Richard Sandiford wrote: >> Segher Boessenkool writes: >> > On Wed, Sep 11, 2019 at 08:08:38PM +0100, Richard Sandiford wrote: >> >>hard_reg_set_iterator

Re: [10/32] Remove global call sets: combine.c

2019-09-19 Thread Segher Boessenkool
Hi Richard, Sorry this too me so long to get back to. On Thu, Sep 12, 2019 at 08:51:59AM +0100, Richard Sandiford wrote: > Segher Boessenkool writes: > > On Wed, Sep 11, 2019 at 08:08:38PM +0100, Richard Sandiford wrote: > >>hard_reg_set_iterator hrsi; > >> -

Re: [10/32] Remove global call sets: combine.c

2019-09-12 Thread Richard Sandiford
Segher Boessenkool writes: > On Wed, Sep 11, 2019 at 08:08:38PM +0100, Richard Sandiford wrote: >>hard_reg_set_iterator hrsi; >> - EXECUTE_IF_SET_IN_HARD_REG_SET (regs_invalidated_by_call, 0, i, hrsi) >> + EXECUTE_IF_SET_IN_HARD_REG_SET (abi.full_and_partial_reg_clobbers (), >>

Re: [10/32] Remove global call sets: combine.c

2019-09-11 Thread Segher Boessenkool
On Wed, Sep 11, 2019 at 08:08:38PM +0100, Richard Sandiford wrote: >hard_reg_set_iterator hrsi; > - EXECUTE_IF_SET_IN_HARD_REG_SET (regs_invalidated_by_call, 0, i, hrsi) > + EXECUTE_IF_SET_IN_HARD_REG_SET (abi.full_and_partial_reg_clobbers (), > +

[10/32] Remove global call sets: combine.c

2019-09-11 Thread Richard Sandiford
There shouldn't be many cases in which a useful hard register is live across a call before RA, so we might as well keep things simple and invalidate partially-clobbered registers here, in case the values they hold leak into the call-clobbered part. In principle this is a bug fix for