Re: [C++ PATCH] Don't redefine __* builtins (PR c++/84724, take 2)

2018-03-09 Thread Jason Merrill
OK. On Fri, Mar 9, 2018 at 6:05 AM, Jakub Jelinek wrote: > On Thu, Mar 08, 2018 at 04:06:24PM -0500, Jason Merrill wrote: >> On Thu, Mar 8, 2018 at 1:01 PM, Jakub Jelinek wrote: >> > The C FE just warns and doesn't override builtins, but C++ FE >> > on say

[C++ PATCH] Don't redefine __* builtins (PR c++/84724, take 2)

2018-03-09 Thread Jakub Jelinek
On Thu, Mar 08, 2018 at 04:06:24PM -0500, Jason Merrill wrote: > On Thu, Mar 8, 2018 at 1:01 PM, Jakub Jelinek wrote: > > The C FE just warns and doesn't override builtins, but C++ FE > > on say int __builtin_trap (); will override the builtin, so later > > builtin_decl_explicit

Re: [C++ PATCH] Don't redefine __* builtins (PR c++/84724)

2018-03-08 Thread Jason Merrill
On Thu, Mar 8, 2018 at 1:01 PM, Jakub Jelinek wrote: > The C FE just warns and doesn't override builtins, but C++ FE > on say int __builtin_trap (); will override the builtin, so later > builtin_decl_explicit will return the bogus user function which e.g. > doesn't have any

[C++ PATCH] Don't redefine __* builtins (PR c++/84724)

2018-03-08 Thread Jakub Jelinek
Hi! The C FE just warns and doesn't override builtins, but C++ FE on say int __builtin_trap (); will override the builtin, so later builtin_decl_explicit will return the bogus user function which e.g. doesn't have any merged attributes, can have different arguments or return type etc. This patch