[C++ PATCH] Fix ICE with inline asm and MODIFY_EXPR/preinc/predec in output operand (PR c++/84961, take 2)

2018-03-21 Thread Jakub Jelinek
On Wed, Mar 21, 2018 at 01:01:38PM -0400, Jason Merrill wrote: > >> Hmm, it would be nice to share this with the similar patterns in > >> unary_complex_lvalue and cp_build_modify_expr. > > > You mean just outline the > > if (TREE_SIDE_EFFECTS (TREE_OPERAND (lhs, 0))) > > lhs =

Re: [C++ PATCH] Fix ICE with inline asm and MODIFY_EXPR/preinc/predec in output operand (PR c++/84961, take 2)

2018-03-21 Thread Jason Merrill
OK. On Wed, Mar 21, 2018 at 1:47 PM, Jakub Jelinek wrote: > On Wed, Mar 21, 2018 at 01:01:38PM -0400, Jason Merrill wrote: >> >> Hmm, it would be nice to share this with the similar patterns in >> >> unary_complex_lvalue and cp_build_modify_expr. >> >> > You mean just outline