Re: [C++ PATCH] Fix some -Wused-but-set-variable regressions (PR c++/82728, PR c++/82799, PR c++/83690)

2018-01-11 Thread Jason Merrill
On Wed, Jan 10, 2018 at 11:59 AM, Jason Merrill wrote: > On Wed, Jan 10, 2018 at 11:56 AM, Jakub Jelinek wrote: >> On Wed, Jan 10, 2018 at 11:52:16AM -0500, Jason Merrill wrote: >>> On Fri, Jan 5, 2018 at 5:14 PM, Jakub Jelinek wrote: >>> >

Re: [C++ PATCH] Fix some -Wused-but-set-variable regressions (PR c++/82728, PR c++/82799, PR c++/83690)

2018-01-10 Thread Jason Merrill
On Wed, Jan 10, 2018 at 11:56 AM, Jakub Jelinek wrote: > On Wed, Jan 10, 2018 at 11:52:16AM -0500, Jason Merrill wrote: >> On Fri, Jan 5, 2018 at 5:14 PM, Jakub Jelinek wrote: >> > Jason's recent change removed a mark_rvalue_use call from constant_value_1, >>

Re: [C++ PATCH] Fix some -Wused-but-set-variable regressions (PR c++/82728, PR c++/82799, PR c++/83690)

2018-01-10 Thread Jakub Jelinek
On Wed, Jan 10, 2018 at 11:52:16AM -0500, Jason Merrill wrote: > On Fri, Jan 5, 2018 at 5:14 PM, Jakub Jelinek wrote: > > Jason's recent change removed a mark_rvalue_use call from constant_value_1, > > which unfortunately regressed quite a few cases where > >

Re: [C++ PATCH] Fix some -Wused-but-set-variable regressions (PR c++/82728, PR c++/82799, PR c++/83690)

2018-01-10 Thread Jason Merrill
On Fri, Jan 5, 2018 at 5:14 PM, Jakub Jelinek wrote: > Jason's recent change removed a mark_rvalue_use call from constant_value_1, > which unfortunately regressed quite a few cases where > -Wunused-but-set-variable now has false positives. > The easiest fix seems to be just

[C++ PATCH] Fix some -Wused-but-set-variable regressions (PR c++/82728, PR c++/82799, PR c++/83690)

2018-01-05 Thread Jakub Jelinek
Hi! Jason's recent change removed a mark_rvalue_use call from constant_value_1, which unfortunately regressed quite a few cases where -Wunused-but-set-variable now has false positives. The easiest fix seems to be just deal with the -Wunused-but-set-variable issue at that point.