Re: [C++ Patch] PR 70540 ("[4.9/5/6 Regression] ICE on invalid code in cxx_incomplete_type_diagnostic...")

2016-04-21 Thread Jason Merrill
OK for trunk and 6.2. Jason

[Ping] [C++ Patch] PR 70540 ("[4.9/5/6 Regression] ICE on invalid code in cxx_incomplete_type_diagnostic...")

2016-04-21 Thread Paolo Carlini
Hi, On 14/04/2016 11:50, Paolo Carlini wrote: Hi, in this regression we ICE during error recovery after an additional redundant error message. I think it's one of those cases (we have got quite a few elsewhere, in semantics.c too) when it's better to immediately return error_mark_node when

[C++ Patch] PR 70540 ("[4.9/5/6 Regression] ICE on invalid code in cxx_incomplete_type_diagnostic...")

2016-04-14 Thread Paolo Carlini
Hi, in this regression we ICE during error recovery after an additional redundant error message. I think it's one of those cases (we have got quite a few elsewhere, in semantics.c too) when it's better to immediately return error_mark_node when mark_used returns false, even if we aren't in a