Re: [C++ committed] Fix ICE with -Wshadow=compatible-local (PR c++/81640)

2017-08-04 Thread Jakub Jelinek
On Fri, Aug 04, 2017 at 12:50:36PM -0400, Jason Merrill wrote: > On Wed, Aug 2, 2017 at 3:38 AM, Jakub Jelinek wrote: > > I've bootstrapped/regtested the following patch last night and committed > > after preapproval from Nathan, though of course a question is if > >

Re: [C++ committed] Fix ICE with -Wshadow=compatible-local (PR c++/81640)

2017-08-04 Thread Jason Merrill
On Wed, Aug 2, 2017 at 3:38 AM, Jakub Jelinek wrote: > I've bootstrapped/regtested the following patch last night and committed > after preapproval from Nathan, though of course a question is if > lookup_fnfields_slot/lookup_fnfields_slot_nolazy shouldn't have > if

[C++ committed] Fix ICE with -Wshadow=compatible-local (PR c++/81640)

2017-08-02 Thread Jakub Jelinek
Hi! The r250440 change removed two spots that ensured that for !CLASS_TYPE_P (type) it returned -1 (from the idx routines that are gone now) and eventually NULL from the non-idx ones. I've bootstrapped/regtested a change with various assertions that showed that except for this testcase and spot