Re: [C PATCH] remove goto in c_parser_sizeof_expression

2014-05-01 Thread Joseph S. Myers
On Fri, 25 Apr 2014, Marek Polacek wrote: On Thu, Apr 24, 2014 at 03:27:42PM -0600, Jeff Law wrote: On 02/24/14 12:28, Marek Polacek wrote: On Tue, Feb 25, 2014 at 12:01:25AM +0530, Prathamesh Kulkarni wrote: Replaced tab by 4 spaces before error_at. * c-parser.c

Re: [C PATCH] remove goto in c_parser_sizeof_expression

2014-05-01 Thread Jeff Law
On 04/25/14 01:18, Marek Polacek wrote: On Thu, Apr 24, 2014 at 03:27:42PM -0600, Jeff Law wrote: On 02/24/14 12:28, Marek Polacek wrote: On Tue, Feb 25, 2014 at 12:01:25AM +0530, Prathamesh Kulkarni wrote: Replaced tab by 4 spaces before error_at. * c-parser.c (c_parser_sizeof_expression):

Re: [C PATCH] remove goto in c_parser_sizeof_expression

2014-04-25 Thread Marek Polacek
On Thu, Apr 24, 2014 at 03:27:42PM -0600, Jeff Law wrote: On 02/24/14 12:28, Marek Polacek wrote: On Tue, Feb 25, 2014 at 12:01:25AM +0530, Prathamesh Kulkarni wrote: Replaced tab by 4 spaces before error_at. * c-parser.c (c_parser_sizeof_expression): Remove goto sizeof_expr. Looks good

Re: [C PATCH] remove goto in c_parser_sizeof_expression

2014-04-24 Thread Jeff Law
On 02/24/14 12:28, Marek Polacek wrote: On Tue, Feb 25, 2014 at 12:01:25AM +0530, Prathamesh Kulkarni wrote: Replaced tab by 4 spaces before error_at. * c-parser.c (c_parser_sizeof_expression): Remove goto sizeof_expr. Looks good now, but I can't approve it. Thanks, Applied to the trunk.

Re: [C PATCH] remove goto in c_parser_sizeof_expression

2014-02-24 Thread Prathamesh Kulkarni
On Sun, Feb 23, 2014 at 1:18 AM, Marek Polacek pola...@redhat.com wrote: On Sun, Feb 23, 2014 at 12:19:49AM +0530, Prathamesh Kulkarni wrote: Is this fine ? No, there still are some formatting issues. Index: gcc/c/c-parser.c

Re: [C PATCH] remove goto in c_parser_sizeof_expression

2014-02-24 Thread Marek Polacek
On Mon, Feb 24, 2014 at 11:08:27PM +0530, Prathamesh Kulkarni wrote: I apologize for bothering with stupid mistakes. No problem, it takes some time to get up to speed. + mark_exp_read (expr.value); + if (TREE_CODE (expr.value) == COMPONENT_REF + DECL_C_BIT_FIELD (TREE_OPERAND

Re: [C PATCH] remove goto in c_parser_sizeof_expression

2014-02-24 Thread Prathamesh Kulkarni
On Mon, Feb 24, 2014 at 11:28 PM, Marek Polacek pola...@redhat.com wrote: On Mon, Feb 24, 2014 at 11:08:27PM +0530, Prathamesh Kulkarni wrote: I apologize for bothering with stupid mistakes. No problem, it takes some time to get up to speed. + mark_exp_read (expr.value); + if (TREE_CODE

Re: [C PATCH] remove goto in c_parser_sizeof_expression

2014-02-24 Thread Marek Polacek
On Tue, Feb 25, 2014 at 12:01:25AM +0530, Prathamesh Kulkarni wrote: Replaced tab by 4 spaces before error_at. * c-parser.c (c_parser_sizeof_expression): Remove goto sizeof_expr. Looks good now, but I can't approve it. Thanks, Marek

Re: [C PATCH] remove goto in c_parser_sizeof_expression

2014-02-24 Thread Joseph S. Myers
On Mon, 24 Feb 2014, Marek Polacek wrote: On Tue, Feb 25, 2014 at 12:01:25AM +0530, Prathamesh Kulkarni wrote: Replaced tab by 4 spaces before error_at. * c-parser.c (c_parser_sizeof_expression): Remove goto sizeof_expr. Looks good now, but I can't approve it. Thanks, I think all the

Re: [C PATCH] remove goto in c_parser_sizeof_expression

2014-02-24 Thread Jeff Law
On 02/24/14 12:28, Marek Polacek wrote: On Tue, Feb 25, 2014 at 12:01:25AM +0530, Prathamesh Kulkarni wrote: Replaced tab by 4 spaces before error_at. * c-parser.c (c_parser_sizeof_expression): Remove goto sizeof_expr. Looks good now, but I can't approve it. Thanks, Unless this fixes a

[C PATCH] remove goto in c_parser_sizeof_expression

2014-02-22 Thread Prathamesh Kulkarni
Not sure if this a good idea, but it seemed to me that goto sizeof_expr; wasn't really required in c_parser_sizeof_expression. Bootstrapped and regression tested on x8_64-unknown-linux-gnu Ok for trunk ? * c-parser.c (c_parser_sizeof_expression): Remove goto sizeof_expr; Thanks and Regards,

Re: [C PATCH] remove goto in c_parser_sizeof_expression

2014-02-22 Thread Prathamesh Kulkarni
On Sat, Feb 22, 2014 at 10:34 PM, Prathamesh Kulkarni bilbotheelffri...@gmail.com wrote: Not sure if this a good idea, but it seemed to me that goto sizeof_expr; wasn't really required in c_parser_sizeof_expression. Bootstrapped and regression tested on x8_64-unknown-linux-gnu Ok for trunk ?

Re: [C PATCH] remove goto in c_parser_sizeof_expression

2014-02-22 Thread Marek Polacek
On Sat, Feb 22, 2014 at 10:34:13PM +0530, Prathamesh Kulkarni wrote: Not sure if this a good idea, but it seemed to me that goto sizeof_expr; wasn't really required in c_parser_sizeof_expression. Bootstrapped and regression tested on x8_64-unknown-linux-gnu Ok for trunk ? * c-parser.c

Re: [C PATCH] remove goto in c_parser_sizeof_expression

2014-02-22 Thread Prathamesh Kulkarni
On Sat, Feb 22, 2014 at 11:44 PM, Marek Polacek pola...@redhat.com wrote: On Sat, Feb 22, 2014 at 10:34:13PM +0530, Prathamesh Kulkarni wrote: Not sure if this a good idea, but it seemed to me that goto sizeof_expr; wasn't really required in c_parser_sizeof_expression. Bootstrapped and

Re: [C PATCH] remove goto in c_parser_sizeof_expression

2014-02-22 Thread Marek Polacek
On Sun, Feb 23, 2014 at 12:19:49AM +0530, Prathamesh Kulkarni wrote: Is this fine ? No, there still are some formatting issues. Index: gcc/c/c-parser.c === --- gcc/c/c-parser.c (revision 207916) +++ gcc/c/c-parser.c (working