Re: [Java PATCH] Generate declarations in jvgenmain.c

2014-10-07 Thread Andrew Haley
On 06/10/14 22:00, Mark Wielaard wrote: If no java maintainer responds, try CCing java-patc...@gcc.gnu.org to draw their attention. Please. I can't see the patch here. Andrew.

[Java PATCH] Generate declarations in jvgenmain.c

2014-10-07 Thread Marek Polacek
[CCing java-patches now] Java testsuite breaks with -std=gnu11 as a default and/or with -Wimplicit-function-declaration on, since the jvgenmain.c program that generates a C file containing 'main' function which calls either 'JvRunMainName' or 'JvRunMain' does not generate forward declarations

Re: [Java PATCH] Generate declarations in jvgenmain.c

2014-10-07 Thread Marek Polacek
On Mon, Oct 06, 2014 at 11:00:48PM +0200, Mark Wielaard wrote: On Mon, Oct 06, 2014 at 11:54:00AM +0200, Marek Polacek wrote: Java testsuite breaks with -std=gnu11 as a default and/or with -Wimplicit-function-declaration on, since the jvgenmain.c program that generates a C file containing

Re: [Java PATCH] Generate declarations in jvgenmain.c

2014-10-07 Thread Andrew Haley
On 10/07/2014 09:31 AM, Marek Polacek wrote: Bootstrapped/regtested on x86_64-linux, ok for trunk? OK, thanks. Andrew.

Re: [Java PATCH] Generate declarations in jvgenmain.c

2014-10-07 Thread Tom Tromey
Marek == Marek Polacek pola...@redhat.com writes: Marek [CCing java-patches now] Marek Java testsuite breaks with -std=gnu11 as a default and/or with Marek -Wimplicit-function-declaration on I don't recall how one gets warnings when compiling this generated code, but if it is generally

Re: [Java PATCH] Generate declarations in jvgenmain.c

2014-10-07 Thread Marek Polacek
On Tue, Oct 07, 2014 at 10:03:26AM -0600, Tom Tromey wrote: Marek == Marek Polacek pola...@redhat.com writes: Marek [CCing java-patches now] Marek Java testsuite breaks with -std=gnu11 as a default and/or with Marek -Wimplicit-function-declaration on I don't recall how one gets warnings

Re: [Java PATCH] Generate declarations in jvgenmain.c

2014-10-07 Thread Tom Tromey
Marek I saw declarations of JvRunMain{,Name} with no parameters and with Marek some parameters. Oh yeah, duh. Marek So I decided to make it prototype-less function Marek declaration for now. I think we don't have to worry about Marek -Wstrict-prototypes for now. Thanks for looking. Tom

[Java PATCH] Generate declarations in jvgenmain.c

2014-10-06 Thread Marek Polacek
Java testsuite breaks with -std=gnu11 as a default and/or with -Wimplicit-function-declaration on, since the jvgenmain.c program that generates a C file containing 'main' function which calls either 'JvRunMainName' or 'JvRunMain' does not generate forward declarations for these functions. The

Re: [Java PATCH] Generate declarations in jvgenmain.c

2014-10-06 Thread Mark Wielaard
On Mon, Oct 06, 2014 at 11:54:00AM +0200, Marek Polacek wrote: Java testsuite breaks with -std=gnu11 as a default and/or with -Wimplicit-function-declaration on, since the jvgenmain.c program that generates a C file containing 'main' function which calls either 'JvRunMainName' or 'JvRunMain'