Re: [PATCH, Fortran, Coarray, v1] Add support for failed images

Hi Christophe, The testcase is not expected to output anything. So only the exit code should be set to zero. I called libgfortrans exit-function to quit the program. I am not aware that I need to do more. Happy for any insight what goes wrong. There are also issues on hpux, but I think they

Re: [PATCH, Fortran, Coarray, v1] Add support for failed images

On 9 March 2017 at 09:45, Andre Vehreschild wrote: > Hi Christophe, > > you are right, that error message does not help a bit. Can you manually > compile > and execute the testcase? Does it print "ERROR STOP: This statement should not > be reached."? > > If not what does > >

Re: [PATCH, Fortran, Coarray, v1] Add support for failed images

Hi Christophe, you are right, that error message does not help a bit. Can you manually compile and execute the testcase? Does it print "ERROR STOP: This statement should not be reached."? If not what does fail_image_2 && echo "yes" || echo "no" print? It should be "yes" - Andre On Wed, 8

Re: [PATCH, Fortran, Coarray, v1] Add support for failed images

Hi, On 5 March 2017 at 12:41, Andre Vehreschild wrote: > Hi Jerry, > > thanks for seconding my read of the standard and reviewing so quickly. > Committed as r245900. > I've noticed that the new test: gfortran.dg/coarray/fail_image_2.f08 -fcoarray=single -O2 -latomic execution

Re: [PATCH, Fortran, Coarray, v1] Add support for failed images

Hi Jerry, thanks for seconding my read of the standard and reviewing so quickly. Committed as r245900. Regards, Andre On Sat, 4 Mar 2017 15:06:25 -0800 Jerry DeLisle wrote: > On 03/04/2017 09:58 AM, Andre Vehreschild wrote: > > Hi all, > > > > attached patch

Re: [PATCH, Fortran, Coarray, v1] Add support for failed images

On 03/04/2017 09:58 AM, Andre Vehreschild wrote: > Hi all, > > attached patch polishes the one begun by Alessandro. It adds documentation and > fixes the style issues. Furthermore did I try to interpret the standard > according to the FAIL IMAGE statement. IMHO should it just quit the executable

Re: [PATCH, Fortran, Coarray, v1] Add support for failed images

Hi Alessandro, Yes of course. I planned to. Sorry that I forgot. - Andre Am 4. März 2017 20:51:58 MEZ schrieb Alessandro Fanfarillo : >Hi Andre, >thanks for your work on the patch. I agree with you about exit(0) >statement in libcaf_single. >Could you please add my

Re: [PATCH, Fortran, Coarray, v1] Add support for failed images

Hi Andre, thanks for your work on the patch. I agree with you about exit(0) statement in libcaf_single. Could you please add my name and contact (Alessandro Fanfarillo ) below yours in the changelog? Thanks, Alessandro 2017-03-04 10:58 GMT-07:00 Andre Vehreschild

[PATCH, Fortran, Coarray, v1] Add support for failed images

Hi all, attached patch polishes the one begun by Alessandro. It adds documentation and fixes the style issues. Furthermore did I try to interpret the standard according to the FAIL IMAGE statement. IMHO should it just quit the executable without any error code. The caf_single library emits "FAIL