Re: [PATCH, PPC] Fix PR88343.

2018-12-05 Thread Segher Boessenkool
On Wed, Dec 05, 2018 at 05:10:07PM +, Iain Sandoe wrote: > Hi, > > The PR is about unnecessary saves of the pic base register, it shows on m32 > Linux and m32/m64 Darwin. > > The fix is to check that we are in a pic mode and that the picbase has > actually been used. > As a bonus, some

[PATCH, PPC] Fix PR88343.

2018-12-05 Thread Iain Sandoe
Hi, The PR is about unnecessary saves of the pic base register, it shows on m32 Linux and m32/m64 Darwin. The fix is to check that we are in a pic mode and that the picbase has actually been used. As a bonus, some #ifdef’d TARGET_MACHO code is no longer required. Tested on power7,