Re: [PATCH, nvptx] Expand OpenACC child function arguments to use CUDA params space

2019-11-26 Thread Chung-Lin Tang
On 2019/11/8 8:55 PM, Chung-Lin Tang wrote: On 2019/10/8 10:05 PM, Thomas Schwinge wrote: Hi Chung-Lin! While we're all waiting for Tom to comment on this;-)  -- here's another item I realized: On 2019-09-10T19:41:59+0800, Chung-Lin Tang  wrote: The libgomp nvptx plugin changes are also 

Re: [PATCH, nvptx] Expand OpenACC child function arguments to use CUDA params space

2019-11-08 Thread Chung-Lin Tang
On 2019/10/8 10:05 PM, Thomas Schwinge wrote: Hi Chung-Lin! While we're all waiting for Tom to comment on this;-) -- here's another item I realized: On 2019-09-10T19:41:59+0800, Chung-Lin Tang wrote: The libgomp nvptx plugin changes are also quite contained, with lots of now unneeded [...]

Re: [PATCH, nvptx] Expand OpenACC child function arguments to use CUDA params space

2019-10-09 Thread Tom de Vries
On 01-10-2019 14:45, Chung-Lin Tang wrote: > Index: gcc/config/nvptx/nvptx.c > === > --- gcc/config/nvptx/nvptx.c (revision 276406) > +++ gcc/config/nvptx/nvptx.c (working copy) > @@ -68,6 +68,10 @@ > #include "attribs.h" >

Re: [PATCH, nvptx] Expand OpenACC child function arguments to use CUDA params space

2019-10-09 Thread Tom de Vries
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On 08-10-2019 16:05, Thomas Schwinge wrote: > Hi Chung-Lin! > > While we're all waiting for Tom to comment on this ;-) Ack, thanks for the ping ... > -- here's another item I realized: > > On 2019-09-10T19:41:59+0800, Chung-Lin Tang > wrote: >>

Re: [PATCH, nvptx] Expand OpenACC child function arguments to use CUDA params space

2019-10-08 Thread Thomas Schwinge
Hi Chung-Lin! While we're all waiting for Tom to comment on this ;-) -- here's another item I realized: On 2019-09-10T19:41:59+0800, Chung-Lin Tang wrote: > The libgomp nvptx plugin changes are also quite contained, with lots of > now unneeded [...] code deleted (since we no longer first

Re: [PATCH, nvptx] Expand OpenACC child function arguments to use CUDA params space

2019-10-01 Thread Chung-Lin Tang
On 2019/9/24 6:43 PM, Chung-Lin Tang wrote: --- gcc/config/nvptx/nvptx.c(revision 275493) +++ gcc/config/nvptx/nvptx.c(working copy) +static void +nvptx_expand_to_rtl_hook (void) +{ +  /* For utilizing CUDA .param kernel arguments, we detect and modify + the gimple of offloaded 

Re: [PATCH, nvptx] Expand OpenACC child function arguments to use CUDA params space

2019-09-24 Thread Chung-Lin Tang
Hi Thomas, thanks for the review. On 2019/9/20 12:28 AM, Thomas Schwinge wrote: This new implementation works by modifying the GIMPLE for child functions directly at the very start (before, actually) of RTL expansion That's now near the other end of the pipeline.;-) What's the motivation for

Re: [PATCH, nvptx] Expand OpenACC child function arguments to use CUDA params space

2019-09-19 Thread Thomas Schwinge
Hi Chung-Lin! On 2019-09-10T19:41:59+0800, Chung-Lin Tang wrote: > this is a completely new implementation of an earlier optimization > that Cesar submitted: > https://gcc.gnu.org/ml/gcc-patches/2017-12/msg01202.html Thanks for your re-work! > The objective is to transform the original

[PATCH, nvptx] Expand OpenACC child function arguments to use CUDA params space

2019-09-10 Thread Chung-Lin Tang
Hi Tom, this is a completely new implementation of an earlier optimization that Cesar submitted: https://gcc.gnu.org/ml/gcc-patches/2017-12/msg01202.html The objective is to transform the original single-record-pointer argument form (OpenMP/pthreads originated) to multiple scalar parameters,