Re: [PATCH, rs6000 V3] Add Power 8 support to vec_revb

2017-11-01 Thread Segher Boessenkool
Hi Carl, On Fri, Oct 27, 2017 at 09:49:04AM -0700, Carl Love wrote: > > > +;; Swap all bytes in each element of vector > > > +(define_expand "revb_" > > > + [(set (match_operand:VEC_A 0 "vsx_register_operand") > > > + (bswap:VEC_A (match_operand:VEC_A 1 "vsx_register_operand")))] > > > + "TARGET

Re: [PATCH, rs6000 V3] Add Power 8 support to vec_revb

2017-10-27 Thread Carl Love
Segher: I still have issues with the . > > +(define_mode_attr VSX_XXBR [(V16QI "q") > > + (V8HI "h") > > + (V4SI "w") > > + (V4SF "w") > > + (V2DF "d") > > + (V2DI "d") > > + (V1TI "q")]

Re: [PATCH, rs6000 V3] Add Power 8 support to vec_revb

2017-10-26 Thread Segher Boessenkool
Hi Carl, On Mon, Oct 23, 2017 at 08:36:03AM -0700, Carl Love wrote: > The mode attribute wd will not work > for the define expand as the V16QI maps to "b" not "q". So I do need to > have VSX_XXBR. Why is that a problem? Why do you want to swap the order of the whole vector instead of changing t

Re: [PATCH, rs6000 V3] Add Power 8 support to vec_revb

2017-10-23 Thread Carl Love
GCC maintainers: I have fixed the change log lines as mentioned by Segher. I removed the changes to swap_selector_for_mode() and instead created swap_endianess_selector_for_mode(). The mode attribute wd will not work for the define expand as the V16QI maps to "b" not "q". So I do need to have V