Re: [PATCH][1/2] GIMPLE Frontend, C FE parts (and GIMPLE parser)

On Fri, 11 Nov 2016, Richard Biener wrote: > Is the original patch with the change below ok for trunk? Yes. -- Joseph S. Myers jos...@codesourcery.com

Re: [PATCH][1/2] GIMPLE Frontend, C FE parts (and GIMPLE parser)

On Thu, 10 Nov 2016, Joseph Myers wrote: > On Fri, 28 Oct 2016, Richard Biener wrote: > > > +/* Parse a gimple expression. > > + > > + gimple-expression: > > + gimple-unary-expression > > + gimple-call-statement > > + gimple-binary-expression > > + gimple-assign-expression > >

Re: [PATCH][1/2] GIMPLE Frontend, C FE parts (and GIMPLE parser)

On Thu, 10 Nov 2016, Richard Biener wrote: > I'll address those comments. As you did not have any comments on the > c-parser.[CH] parts does that mean you are fine with them? That is, > does the above constitute a complete review of the patch? I am fine with the c-parser.[ch] parts. --

Re: [PATCH][1/2] GIMPLE Frontend, C FE parts (and GIMPLE parser)

On November 10, 2016 6:38:12 PM GMT+01:00, Joseph Myers wrote: >On Fri, 28 Oct 2016, Richard Biener wrote: > >> +/* Parse a gimple expression. >> + >> + gimple-expression: >> + gimple-unary-expression >> + gimple-call-statement >> + gimple-binary-expression

Re: [PATCH][1/2] GIMPLE Frontend, C FE parts (and GIMPLE parser)

On Fri, 28 Oct 2016, Richard Biener wrote: > +/* Parse a gimple expression. > + > + gimple-expression: > + gimple-unary-expression > + gimple-call-statement > + gimple-binary-expression > + gimple-assign-expression > + gimple-cast-expression I don't see any comments

Re: [PATCH][1/2] GIMPLE Frontend, C FE parts (and GIMPLE parser)

On Mon, Nov 7, 2016 at 2:24 AM, Richard Biener wrote: > The issue with moving is that I failed to export the definition of > c_parser in c-parser.h due to gengtype putting vec > handlers into gtype-c.h but not gtype-objc.h and thus objc bootstrap > fails :/ > >

Re: [PATCH][1/2] GIMPLE Frontend, C FE parts (and GIMPLE parser)

On November 9, 2016 5:45:32 PM GMT+01:00, Joseph Myers wrote: >On Wed, 9 Nov 2016, Richard Biener wrote: > >> I'll push back c_parser to the header and put inlines I need to >export >> there as well. >> >> Joseph, is this (with regard to the inlines) your preference as

Re: [PATCH][1/2] GIMPLE Frontend, C FE parts (and GIMPLE parser)

On Wed, 9 Nov 2016, Richard Biener wrote: > I'll push back c_parser to the header and put inlines I need to export > there as well. > > Joseph, is this (with regard to the inlines) your preference as well? I'm not clear what the proposal is. If some patch is now proposed different from what

Re: [PATCH][1/2] GIMPLE Frontend, C FE parts (and GIMPLE parser)

On Mon, 7 Nov 2016, Richard Biener wrote: > On Mon, 7 Nov 2016, Richard Biener wrote: > > > On Fri, 4 Nov 2016, Jakub Jelinek wrote: > > > > > Hi! > > > > > > Just 2 nits: > > > > > > On Fri, Oct 28, 2016 at 01:46:57PM +0200, Richard Biener wrote: > > > > +/* Return a pointer to the Nth token

Re: [PATCH][1/2] GIMPLE Frontend, C FE parts (and GIMPLE parser)

On Mon, 7 Nov 2016, Richard Biener wrote: > On Fri, 4 Nov 2016, Jakub Jelinek wrote: > > > Hi! > > > > Just 2 nits: > > > > On Fri, Oct 28, 2016 at 01:46:57PM +0200, Richard Biener wrote: > > > +/* Return a pointer to the Nth token in PARERs tokens_buf. */ > > > > PARSERs ? > > Fixed. > >

Re: [PATCH][1/2] GIMPLE Frontend, C FE parts (and GIMPLE parser)

On Fri, 4 Nov 2016, Jakub Jelinek wrote: > Hi! > > Just 2 nits: > > On Fri, Oct 28, 2016 at 01:46:57PM +0200, Richard Biener wrote: > > +/* Return a pointer to the Nth token in PARERs tokens_buf. */ > > PARSERs ? Fixed. > > @@ -454,7 +423,7 @@ c_lex_one_token (c_parser *parser, c_token

Re: [PATCH][1/2] GIMPLE Frontend, C FE parts (and GIMPLE parser)

Hi! Just 2 nits: On Fri, Oct 28, 2016 at 01:46:57PM +0200, Richard Biener wrote: > +/* Return a pointer to the Nth token in PARERs tokens_buf. */ PARSERs ? > @@ -454,7 +423,7 @@ c_lex_one_token (c_parser *parser, c_token *token) > /* Return a pointer to the next token from PARSER, reading it

[PING][PATCH][1/2] GIMPLE Frontend, C FE parts (and GIMPLE parser)

On Fri, 28 Oct 2016, Richard Biener wrote: > > These are the C (and ObjC) Frontend changes required by the GIMPLE > Frontend which is now itself contained in c/gimple-parser.[ch]. > > Most changes are due to a new c-parser.h header where we export > stuff from the C parser that the GIMPLE

[PATCH][1/2] GIMPLE Frontend, C FE parts (and GIMPLE parser)

These are the C (and ObjC) Frontend changes required by the GIMPLE Frontend which is now itself contained in c/gimple-parser.[ch]. Most changes are due to a new c-parser.h header where we export stuff from the C parser that the GIMPLE frontend requires. Other changes include new __GIMPLE and