Re: [PATCH][AArch64] PR target/84748: Mark *compare_cstore_insn as clobbering CC reg

2018-04-10 Thread Kyrill Tkachov
On 08/03/18 13:32, James Greenhalgh wrote: On Wed, Mar 07, 2018 at 05:39:41PM +, Kyrill Tkachov wrote: Hi all, In this wrong-code PR the combine pass ends up moving a CC-using instruction past a *compare_cstore_insn insn_and_split. After reload the *compare_cstore_insn splitter ends up g

Re: [PATCH][AArch64] PR target/84748: Mark *compare_cstore_insn as clobbering CC reg

2018-03-08 Thread James Greenhalgh
On Wed, Mar 07, 2018 at 05:39:41PM +, Kyrill Tkachov wrote: > Hi all, > > In this wrong-code PR the combine pass ends up moving a CC-using instruction > past a *compare_cstore_insn > insn_and_split. After reload the *compare_cstore_insn splitter ends up > generating a SUBS instruction that >

[PATCH][AArch64] PR target/84748: Mark *compare_cstore_insn as clobbering CC reg

2018-03-07 Thread Kyrill Tkachov
Hi all, In this wrong-code PR the combine pass ends up moving a CC-using instruction past a *compare_cstore_insn insn_and_split. After reload the *compare_cstore_insn splitter ends up generating a SUBS instruction that clobbers the condition flags, and things go bad. The solution is simple, th