Re: [PATCH][AArch64] Use REG_P and CONST_INT_P instead of GET_CODE + comparison

2014-08-06 Thread Richard Earnshaw
On 05/08/14 12:18, Kyrill Tkachov wrote:
 Hi all,
 
 This is a cleanup to replace usages of GET_CODE (x) == CONST_INT with 
 CONST_INT_P (x) and GET_CODE (x) == REG with REG_P (x). No functional 
 changes.
 
 Tested on aarch64-none-elf and bootstrapped on aarch64-linux.
 
 Ok for trunk?
 
 Thanks,
 Kyrill
 
 2014-08-05  Kyrylo Tkachov  kyrylo.tkac...@arm.com
 
  * config/aarch64/aarch64.c (aarch64_classify_address): Use REG_P and
  CONST_INT_P instead of GET_CODE and compare.
  (aarch64_select_cc_mode): Likewise.
  (aarch64_print_operand): Likewise.
  (aarch64_rtx_costs): Likewise.
  (aarch64_simd_valid_immediate): Likewise.
  (aarch64_simd_check_vect_par_cnst_half): Likewise.
  (aarch64_simd_emit_pair_result_insn): Likewise.
 
 
OK.

R.




[PATCH][AArch64] Use REG_P and CONST_INT_P instead of GET_CODE + comparison

2014-08-05 Thread Kyrill Tkachov

Hi all,

This is a cleanup to replace usages of GET_CODE (x) == CONST_INT with 
CONST_INT_P (x) and GET_CODE (x) == REG with REG_P (x). No functional 
changes.


Tested on aarch64-none-elf and bootstrapped on aarch64-linux.

Ok for trunk?

Thanks,
Kyrill

2014-08-05  Kyrylo Tkachov  kyrylo.tkac...@arm.com

* config/aarch64/aarch64.c (aarch64_classify_address): Use REG_P and
CONST_INT_P instead of GET_CODE and compare.
(aarch64_select_cc_mode): Likewise.
(aarch64_print_operand): Likewise.
(aarch64_rtx_costs): Likewise.
(aarch64_simd_valid_immediate): Likewise.
(aarch64_simd_check_vect_par_cnst_half): Likewise.
(aarch64_simd_emit_pair_result_insn): Likewise.commit 5b8fd4ebe8229c61159d3a18ef2cba5b8b78933a
Author: Kyrylo Tkachov kyrylo.tkac...@arm.com
Date:   Mon Aug 4 12:11:29 2014 +0100

[AArch64] Use REG_P and CONST_INT_P instead of GET_CODE

diff --git a/gcc/config/aarch64/aarch64.c b/gcc/config/aarch64/aarch64.c
index f434680..df55f61 100644
--- a/gcc/config/aarch64/aarch64.c
+++ b/gcc/config/aarch64/aarch64.c
@@ -3253,11 +3253,11 @@ aarch64_classify_address (struct aarch64_address_info *info,
   op1 = XEXP (x, 1);
 
   if (! strict_p
-	   GET_CODE (op0) == REG
+	   REG_P (op0)
 	   (op0 == virtual_stack_vars_rtx
 	  || op0 == frame_pointer_rtx
 	  || op0 == arg_pointer_rtx)
-	   GET_CODE (op1) == CONST_INT)
+	   CONST_INT_P (op1))
 	{
 	  info-type = ADDRESS_REG_IMM;
 	  info-base = op0;
@@ -3545,7 +3545,7 @@ aarch64_select_cc_mode (RTX_CODE code, rtx x, rtx y)
  the comparison will have to be swapped when we emit the assembly
  code.  */
   if ((GET_MODE (x) == SImode || GET_MODE (x) == DImode)
-   (GET_CODE (y) == REG || GET_CODE (y) == SUBREG)
+   (REG_P (y) || GET_CODE (y) == SUBREG)
(GET_CODE (x) == ASHIFT || GET_CODE (x) == ASHIFTRT
 	  || GET_CODE (x) == LSHIFTRT
 	  || GET_CODE (x) == ZERO_EXTEND || GET_CODE (x) == SIGN_EXTEND))
@@ -3554,7 +3554,7 @@ aarch64_select_cc_mode (RTX_CODE code, rtx x, rtx y)
   /* Similarly for a negated operand, but we can only do this for
  equalities.  */
   if ((GET_MODE (x) == SImode || GET_MODE (x) == DImode)
-   (GET_CODE (y) == REG || GET_CODE (y) == SUBREG)
+   (REG_P (y) || GET_CODE (y) == SUBREG)
(code == EQ || code == NE)
GET_CODE (x) == NEG)
 return CC_Zmode;
@@ -3714,7 +3714,7 @@ aarch64_print_operand (FILE *f, rtx x, char code)
   {
 	int n;
 
-	if (GET_CODE (x) != CONST_INT
+	if (!CONST_INT_P (x)
 	|| (n = exact_log2 (INTVAL (x)  ~7)) = 0)
 	  {
 	output_operand_lossage (invalid operand for '%%%c', code);
@@ -3744,7 +3744,7 @@ aarch64_print_operand (FILE *f, rtx x, char code)
 	int n;
 
 	/* Print N such that 2^N == X.  */
-	if (GET_CODE (x) != CONST_INT || (n = exact_log2 (INTVAL (x)))  0)
+	if (!CONST_INT_P (x) || (n = exact_log2 (INTVAL (x)))  0)
 	  {
 	output_operand_lossage (invalid operand for '%%%c', code);
 	return;
@@ -3756,7 +3756,7 @@ aarch64_print_operand (FILE *f, rtx x, char code)
 
 case 'P':
   /* Print the number of non-zero bits in X (a const_int).  */
-  if (GET_CODE (x) != CONST_INT)
+  if (!CONST_INT_P (x))
 	{
 	  output_operand_lossage (invalid operand for '%%%c', code);
 	  return;
@@ -3767,7 +3767,7 @@ aarch64_print_operand (FILE *f, rtx x, char code)
 
 case 'H':
   /* Print the higher numbered register of a pair (TImode) of regs.  */
-  if (GET_CODE (x) != REG || !GP_REGNUM_P (REGNO (x) + 1))
+  if (!REG_P (x) || !GP_REGNUM_P (REGNO (x) + 1))
 	{
 	  output_operand_lossage (invalid operand for '%%%c', code);
 	  return;
@@ -3841,7 +3841,7 @@ aarch64_print_operand (FILE *f, rtx x, char code)
 
 case 'X':
   /* Print bottom 16 bits of integer constant in hex.  */
-  if (GET_CODE (x) != CONST_INT)
+  if (!CONST_INT_P (x))
 	{
 	  output_operand_lossage (invalid operand for '%%%c', code);
 	  return;
@@ -5111,7 +5111,7 @@ aarch64_rtx_costs (rtx x, int code, int outer ATTRIBUTE_UNUSED,
 	op1 = SUBREG_REG (op1);
 	  if ((GET_CODE (op1) == ZERO_EXTEND
 	   || GET_CODE (op1) == SIGN_EXTEND)
-	   GET_CODE (XEXP (op0, 1)) == CONST_INT
+	   CONST_INT_P (XEXP (op0, 1))
 	   (GET_MODE_BITSIZE (GET_MODE (XEXP (op1, 0)))
 		  = INTVAL (XEXP (op0, 1
 	op1 = XEXP (op1, 0);
@@ -7680,7 +7680,7 @@ aarch64_simd_valid_immediate (rtx op, enum machine_mode mode, bool inverse,
   unsigned HOST_WIDE_INT elpart;
   unsigned int part, parts;
 
-  if (GET_CODE (el) == CONST_INT)
+  if (CONST_INT_P (el))
 {
   elpart = INTVAL (el);
   parts = 1;
@@ -7986,7 +7986,7 @@ aarch64_simd_check_vect_par_cnst_half (rtx op, enum machine_mode mode,
   rtx elt_op = XVECEXP (op, 0, i);
   rtx elt_ideal = XVECEXP (ideal, 0, i);
 
-  if (GET_CODE (elt_op) != CONST_INT
+  if (!CONST_INT_P (elt_op)
 	  || INTVAL (elt_ideal) != INTVAL (elt_op))
 	return false;
 }
@@ -7999,7 +7999,7 @@ void