RE: [PATCH][GCC][mid-end] Fix PR85123 incorrect copies

2018-04-06 Thread Tamar Christina
lan Modra <amo...@gmail.com>; Tamar > Christina <tamar.christ...@arm.com>; nd <n...@arm.com>; > l...@redhat.com; i...@airs.com; berg...@vnet.ibm.com > Subject: Re: [PATCH][GCC][mid-end] Fix PR85123 incorrect copies > > On Fri, 6 Apr 2018, Eric Botcazou wrote: >

RE: [PATCH][GCC][mid-end] Fix PR85123 incorrect copies

2018-04-06 Thread Tamar Christina
>; nd <n...@arm.com>; > l...@redhat.com; i...@airs.com; berg...@vnet.ibm.com > Subject: Re: [PATCH][GCC][mid-end] Fix PR85123 incorrect copies > > On Fri, 6 Apr 2018, Eric Botcazou wrote: > > > > I wonder if it's best to revert the original regression c

Re: [PATCH][GCC][mid-end] Fix PR85123 incorrect copies

2018-04-06 Thread Richard Biener
On Fri, 6 Apr 2018, Eric Botcazou wrote: > > I wonder if it's best to revert the original regression causing patch > > and look for a proper solution in the GCC 9 timeframe? > > Probably the best course of action indeed, as changes in this area need to be > thoroughly tested on various targets

Re: [PATCH][GCC][mid-end] Fix PR85123 incorrect copies

2018-04-06 Thread Eric Botcazou
> I wonder if it's best to revert the original regression causing patch > and look for a proper solution in the GCC 9 timeframe? Probably the best course of action indeed, as changes in this area need to be thoroughly tested on various targets to cover all the cases. -- Eric Botcazou

Re: [PATCH][GCC][mid-end] Fix PR85123 incorrect copies

2018-04-06 Thread Richard Biener
On Fri, 6 Apr 2018, Alan Modra wrote: > On Thu, Apr 05, 2018 at 01:29:06PM +0100, Tamar Christina wrote: > > diff --git a/gcc/expr.c b/gcc/expr.c > > index > > 00660293f72e5441a6421a280b04c57fca2922b8..7daeb8c91d758edf0b3dc37f6927380b6f3df877 > > 100644 > > --- a/gcc/expr.c > > +++ b/gcc/expr.c

Re: [PATCH][GCC][mid-end] Fix PR85123 incorrect copies

2018-04-05 Thread Alan Modra
On Thu, Apr 05, 2018 at 01:29:06PM +0100, Tamar Christina wrote: > diff --git a/gcc/expr.c b/gcc/expr.c > index > 00660293f72e5441a6421a280b04c57fca2922b8..7daeb8c91d758edf0b3dc37f6927380b6f3df877 > 100644 > --- a/gcc/expr.c > +++ b/gcc/expr.c > @@ -2749,7 +2749,7 @@ copy_blkmode_to_reg

[PATCH][GCC][mid-end] Fix PR85123 incorrect copies

2018-04-05 Thread Tamar Christina
Hi All, This patch fixes the code generation for copy_blkmode_to_reg by calculating the bitsize per iteration doing the maximum copy allowed that does not read more than the amount of bits left to copy. This fixes the bad code generation reported and also still produces better code in most