On Wed, Jun 24, 2015 at 10:33 AM, Fan You youfan.n...@gmail.com wrote:
Hi,
Here is the revised patch including all the test case.
This can also be seen at https://github.com/Noeyfan/gcc-1 on branch
shared_arrays
Any comments?
I ran `git diff c7248656569bb0b4549f5c1ed347f7e028a15664
Hi,
Here is the revised patch including all the test case.
This can also be seen at https://github.com/Noeyfan/gcc-1 on branch
shared_arrays
Any comments?
2015-06-23 12:19 GMT+08:00 Tim Shen tims...@google.com:
On Sun, Jun 21, 2015 at 3:50 AM, Tim Shen tims...@google.com wrote:
Quickly
On 16/06/15 21:15 +0800, Fan You wrote:
You will also need to write new tests (under testsuite/experimental/)
to check that your new code works as intended.
Is there any pattern or rules I should follow when writing testcase, or I
can just refer to 20_util/* and add some array specified
On 14/06/15 23:45 +0800, Fan You wrote:
This is the revised patch.
Bootstrapped and Tested on Darwin 10.9.4. with testsuite 20_util/*
Great, it's *very* important that you can run the tests, so we know
your changes haven't broken the existing code.
You will also need to write new tests
On Thu, Jun 11, 2015 at 8:32 AM, Fan You youfan.n...@gmail.com wrote:
Hi,
This is my first patch for GSoC project: extend shared_ptr to support
arrays.
+ using element_type = _Tp[N];
using element_type = typename std::remove_extent_t_Tp; ?
using _Deleter_type = typename
On 11/06/15 23:43 -0700, Tim Shen wrote:
+ using element_type = _Tp[N];
using element_type = typename std::remove_extent_t_Tp; ?
Well at that point in the file we're inside the
__shared_ptr__libfund_v1_Tp[N] specialization, so it could be
simply:
+ using element_type = _Tp;
Hi,
This is my first patch for GSoC project: extend shared_ptr to support arrays.
Changes are made in these files:
* libstdc++-v3/include/bits/shared_ptr_base.h : Renamed
_Sp_counted_deleter to _Sp_counted_array, changed _shared_count
construct from _Sp_counted_ptr to _Sp_counted_array. Added
On 11/06/15 23:32 +0800, Fan You wrote:
Any comments?
I haven't looked at the patch yet, but please CC all libstdc++ patches
to the libstdc++ list as well as gcc-patches, thanks.
On 11/06/15 23:32 +0800, Fan You wrote:
Hi,
This is my first patch for GSoC project: extend shared_ptr to support
arrays.
Changes are made in these files:
* libstdc++-v3/include/bits/shared_ptr_base.h : Renamed _Sp_counted_deleter
to _Sp_counted_array, changed _shared_count construct from
