Re: [PATCH][aarch64] Fix error calls in aarch64 code so they can be tranlated

2017-09-22 Thread Martin Sebor
On 09/22/2017 11:54 AM, Steve Ellcey wrote: In my view, the ideal message would use the same form as in the source code. But I suspect that's not easy to determine at all sites where the message is being formatted, so the next best thing is to avoid using the keyword and fall back on the

Re: [PATCH][aarch64] Fix error calls in aarch64 code so they can be tranlated

2017-09-22 Thread Steve Ellcey
> In my view, the ideal message would use the same form as in > the source code.  But I suspect that's not easy to determine at > all sites where the message is being formatted, so the next best > thing is to avoid using the keyword and fall back on the general > term. > > Martin > > PS If

Re: [PATCH][aarch64] Fix error calls in aarch64 code so they can be tranlated

2017-09-21 Thread Martin Sebor
On 09/20/2017 05:36 PM, Steve Ellcey wrote: On Tue, 2017-09-19 at 10:49 -0600, Martin Sebor wrote: On 09/19/2017 09:54 AM, Steve Ellcey wrote: On Tue, 2017-09-19 at 09:50 +0200, Frédéric Marchal wrote: error (is_pragma ? G_("missing name in %<#pragma target\(\"%s=\")%>")

Re: [PATCH][aarch64] Fix error calls in aarch64 code so they can be tranlated

2017-09-20 Thread Steve Ellcey
On Tue, 2017-09-19 at 10:49 -0600, Martin Sebor wrote: > On 09/19/2017 09:54 AM, Steve Ellcey wrote: > > On Tue, 2017-09-19 at 09:50 +0200, Frédéric Marchal wrote: > > >  > > > > > > > >    error (is_pragma > > > >   ? G_("missing name in %<#pragma target\(\"%s=\")%>") > > > >   :

Re: [PATCH][aarch64] Fix error calls in aarch64 code so they can be tranlated

2017-09-19 Thread Martin Sebor
On 09/19/2017 09:54 AM, Steve Ellcey wrote: On Tue, 2017-09-19 at 09:50 +0200, Frédéric Marchal wrote: On lundi 18 septembre 2017 13 h 20 min 25 s CEST Martin Sebor wrote: I haven't looked at all of them but from the few I have seen it seems that rephrasing the messages along the following

Re: [PATCH][aarch64] Fix error calls in aarch64 code so they can be tranlated

2017-09-19 Thread Steve Ellcey
On Tue, 2017-09-19 at 09:50 +0200, Frédéric Marchal wrote: > On lundi 18 septembre 2017 13 h 20 min 25 s CEST Martin Sebor wrote: > >  > > I haven't looked at all of them but from the few I have seen it > > seems that rephrasing the messages along the following lines would > > be a way to get

Re: [PATCH][aarch64] Fix error calls in aarch64 code so they can be tranlated

2017-09-19 Thread Frédéric Marchal
On lundi 18 septembre 2017 13 h 20 min 25 s CEST Martin Sebor wrote: > On 09/18/2017 12:26 PM, Steve Ellcey wrote: > > This patch is for PR target/79868, where some aarch64 diagnostics are > > said to be not translatable due to how they are implemented. See the > > bug report for more details on

Re: [PATCH][aarch64] Fix error calls in aarch64 code so they can be tranlated

2017-09-18 Thread Martin Sebor
On 09/18/2017 12:26 PM, Steve Ellcey wrote: This patch is for PR target/79868, where some aarch64 diagnostics are said to be not translatable due to how they are implemented. See the bug report for more details on why the current setup of passing the string 'pragma' or 'attribute' doesn't work.

[PATCH][aarch64] Fix error calls in aarch64 code so they can be tranlated

2017-09-18 Thread Steve Ellcey
This patch is for PR target/79868, where some aarch64 diagnostics are said to be not translatable due to how they are implemented.  See the bug report for more details on why the current setup of passing the string 'pragma' or 'attribute' doesn't work. This patch fixes it, unfortunately by