Re: [PATCH][aarch64] Fix pr81356 - copy empty string with wrz, not a ldrb/strb

2017-11-20 Thread Steve Ellcey
On Mon, 2017-11-20 at 15:24 +0100, Christophe Lyon wrote: >  > As a result of this patch, we now have: > XPASS: gfortran.dg/pr45636.f90   -O   scan-tree-dump-times forwprop2 > "memset" 0 > instead of: > XFAIL: gfortran.dg/pr45636.f90   -O   scan-tree-dump-times forwprop2 > "memset" 0 (found 2

Re: [PATCH][aarch64] Fix pr81356 - copy empty string with wrz, not a ldrb/strb

2017-11-20 Thread Christophe Lyon
On 17 November 2017 at 22:41, James Greenhalgh wrote: > On Fri, Sep 15, 2017 at 07:22:39PM +0100, Steve Ellcey wrote: >> PR 81356 points out that doing a __builtin_strcpy of an empty string on >> aarch64 does a copy from memory instead of just writing out a zero byte. >>

Re: [PATCH][aarch64] Fix pr81356 - copy empty string with wrz, not a ldrb/strb

2017-11-17 Thread James Greenhalgh
On Fri, Sep 15, 2017 at 07:22:39PM +0100, Steve Ellcey wrote: > PR 81356 points out that doing a __builtin_strcpy of an empty string on > aarch64 does a copy from memory instead of just writing out a zero byte. > In looking at this I found that it was because of >

Re: [PATCH][aarch64] Fix pr81356 - copy empty string with wrz, not a ldrb/strb

2017-11-15 Thread Steve Ellcey
re-re-ping. Steve Ellcey sell...@cavium.com On Tue, 2017-10-24 at 11:16 -0700, Steve Ellcey wrote: > Re-ping. > > Steve Ellcey > sell...@cavium.com > > On Mon, 2017-09-25 at 10:36 -0700, Steve Ellcey wrote: > > > > Ping. > > > > Steve Ellcey > > sell...@cavium.com > > > > > > On Fri,

Re: [PATCH][aarch64] Fix pr81356 - copy empty string with wrz, not a ldrb/strb

2017-10-24 Thread Steve Ellcey
Re-ping. Steve Ellcey sell...@cavium.com On Mon, 2017-09-25 at 10:36 -0700, Steve Ellcey wrote: > Ping. > > Steve Ellcey > sell...@cavium.com > > > On Fri, 2017-09-15 at 11:22 -0700, Steve Ellcey wrote: > > > > PR 81356 points out that doing a __builtin_strcpy of an empty string on > >

Re: [PATCH][aarch64] Fix pr81356 - copy empty string with wrz, not a ldrb/strb

2017-10-03 Thread Qing Zhao
I think the change is good. But I don’t have the permission for approval… Qing > On Sep 25, 2017, at 12:36 PM, Steve Ellcey wrote: > > Ping. > > Steve Ellcey > sell...@cavium.com > > > On Fri, 2017-09-15 at 11:22 -0700, Steve Ellcey wrote: >> PR 81356 points out that

Re: [PATCH][aarch64] Fix pr81356 - copy empty string with wrz, not a ldrb/strb

2017-09-25 Thread Steve Ellcey
Ping. Steve Ellcey sell...@cavium.com On Fri, 2017-09-15 at 11:22 -0700, Steve Ellcey wrote: > PR 81356 points out that doing a __builtin_strcpy of an empty string on > aarch64 does a copy from memory instead of just writing out a zero byte. > In looking at this I found that it was because of >

[PATCH][aarch64] Fix pr81356 - copy empty string with wrz, not a ldrb/strb

2017-09-15 Thread Steve Ellcey
PR 81356 points out that doing a __builtin_strcpy of an empty string on aarch64 does a copy from memory instead of just writing out a zero byte. In looking at this I found that it was because of aarch64_use_by_pieces_infrastructure_p, which returns false for STORE_BY_PIECES.  The comment says: