Re: [PATCH] (v2) Add a "compact" mode to print_rtx_function

2016-11-25 Thread Dominik Vogt
On Tue, Nov 22, 2016 at 10:38:42AM -0500, David Malcolm wrote: > On Tue, 2016-11-22 at 15:45 +0100, Jakub Jelinek wrote: > > On Tue, Nov 22, 2016 at 03:38:04PM +0100, Bernd Schmidt wrote: > > > On 11/22/2016 02:37 PM, Jakub Jelinek wrote: > > > > Can't it be done only if xloc.file contains any

Re: [PATCH] (v2) Add a "compact" mode to print_rtx_function

2016-11-22 Thread David Malcolm
On Tue, 2016-11-22 at 15:45 +0100, Jakub Jelinek wrote: > On Tue, Nov 22, 2016 at 03:38:04PM +0100, Bernd Schmidt wrote: > > On 11/22/2016 02:37 PM, Jakub Jelinek wrote: > > > Can't it be done only if xloc.file contains any fancy characters? > > > > Sure, but why? Strings generally get emitted

Re: [PATCH] (v2) Add a "compact" mode to print_rtx_function

2016-11-22 Thread Jakub Jelinek
On Tue, Nov 22, 2016 at 03:38:04PM +0100, Bernd Schmidt wrote: > On 11/22/2016 02:37 PM, Jakub Jelinek wrote: > >Can't it be done only if xloc.file contains any fancy characters? > > Sure, but why? Strings generally get emitted with quotes around them, I > don't see a good reason for filenames to

Re: [PATCH] (v2) Add a "compact" mode to print_rtx_function

2016-11-22 Thread Dominik Vogt
On Tue, Nov 22, 2016 at 09:25:03AM -0500, David Malcolm wrote: > On Tue, 2016-11-22 at 14:37 +0100, Jakub Jelinek wrote: > > On Tue, Nov 22, 2016 at 02:32:39PM +0100, Bernd Schmidt wrote: > > > On 11/22/2016 02:18 PM, Dominik Vogt wrote: > > > > > > > > @@ -284,7 +292,7 @@

Re: [PATCH] (v2) Add a "compact" mode to print_rtx_function

2016-11-22 Thread Bernd Schmidt
On 11/22/2016 02:37 PM, Jakub Jelinek wrote: Can't it be done only if xloc.file contains any fancy characters? Sure, but why? Strings generally get emitted with quotes around them, I don't see a good reason for filenames to be different, especially if it makes the output easier to parse.

Re: [PATCH] (v2) Add a "compact" mode to print_rtx_function

2016-11-22 Thread David Malcolm
On Tue, 2016-11-22 at 14:37 +0100, Jakub Jelinek wrote: > On Tue, Nov 22, 2016 at 02:32:39PM +0100, Bernd Schmidt wrote: > > On 11/22/2016 02:18 PM, Dominik Vogt wrote: > > > > > > @@ -284,7 +292,7 @@ print_rtx_operand_code_i (const_rtx in_rtx, > > > > int idx) > > > > if (INSN_HAS_LOCATION

Re: [PATCH] (v2) Add a "compact" mode to print_rtx_function

2016-11-22 Thread Jakub Jelinek
On Tue, Nov 22, 2016 at 02:32:39PM +0100, Bernd Schmidt wrote: > On 11/22/2016 02:18 PM, Dominik Vogt wrote: > > >>@@ -284,7 +292,7 @@ print_rtx_operand_code_i (const_rtx in_rtx, int idx) > >> if (INSN_HAS_LOCATION (in_insn)) > >>{ > >> expanded_location xloc = insn_location

Re: [PATCH] (v2) Add a "compact" mode to print_rtx_function

2016-11-22 Thread Bernd Schmidt
On 11/22/2016 02:18 PM, Dominik Vogt wrote: @@ -284,7 +292,7 @@ print_rtx_operand_code_i (const_rtx in_rtx, int idx) if (INSN_HAS_LOCATION (in_insn)) { expanded_location xloc = insn_location (in_insn); - fprintf (outfile, " %s:%i", xloc.file, xloc.line); +

Re: [PATCH] (v2) Add a "compact" mode to print_rtx_function

2016-11-22 Thread Dominik Vogt
On Wed, Oct 12, 2016 at 04:37:26PM -0400, David Malcolm wrote: > On Wed, 2016-10-12 at 19:31 +0200, Bernd Schmidt wrote: > > On 10/12/2016 07:48 PM, David Malcolm wrote: > > > This patch implements a "compact" mode for print_rtx_function, > > > implementing most of the ideas above. > > > > > >

Re: [PATCH] (v2) Add a "compact" mode to print_rtx_function

2016-10-13 Thread Bernd Schmidt
On 10/12/2016 10:37 PM, David Malcolm wrote: It didn't pass, due to this change: (print_rtx_operand_code_i): When printing source locations, wrap xloc.file in quotes. [...snip...] [...] The following is a revised version of the patch which updates this test case. Also ok. This

[PATCH] (v2) Add a "compact" mode to print_rtx_function

2016-10-12 Thread David Malcolm
On Wed, 2016-10-12 at 19:31 +0200, Bernd Schmidt wrote: > On 10/12/2016 07:48 PM, David Malcolm wrote: > > This patch implements a "compact" mode for print_rtx_function, > > implementing most of the ideas above. > > > > Example of output can be seen here: > >