Re: [PATCH] ASAN: do not rewrite param for DECL_NOT_GIMPLE_REG_P.

2020-05-12 Thread H.J. Lu via Gcc-patches
On Tue, May 12, 2020 at 11:57 AM H.J. Lu wrote: > > On Tue, May 12, 2020 at 1:12 AM Richard Biener via Gcc-patches > wrote: > > > > On Tue, May 12, 2020 at 9:04 AM Martin Liška wrote: > > > > > > On 5/11/20 2:44 PM, Richard Biener wrote: > > > > Hmm, I think the fix is to clear

Re: [PATCH] ASAN: do not rewrite param for DECL_NOT_GIMPLE_REG_P.

2020-05-12 Thread H.J. Lu via Gcc-patches
On Tue, May 12, 2020 at 1:12 AM Richard Biener via Gcc-patches wrote: > > On Tue, May 12, 2020 at 9:04 AM Martin Liška wrote: > > > > On 5/11/20 2:44 PM, Richard Biener wrote: > > > Hmm, I think the fix is to clear DECL_NOT_GIMPLE_REG_P instead > > > where the code clears TREE_ADDRESSABLE of

Re: [PATCH] ASAN: do not rewrite param for DECL_NOT_GIMPLE_REG_P.

2020-05-12 Thread Richard Biener via Gcc-patches
On Tue, May 12, 2020 at 9:04 AM Martin Liška wrote: > > On 5/11/20 2:44 PM, Richard Biener wrote: > > Hmm, I think the fix is to clear DECL_NOT_GIMPLE_REG_P instead > > where the code clears TREE_ADDRESSABLE of 'arg' > > Ah, you are right. There's a patch that I've just tested. > > Patch can

Re: [PATCH] ASAN: do not rewrite param for DECL_NOT_GIMPLE_REG_P.

2020-05-12 Thread Martin Liška
On 5/11/20 2:44 PM, Richard Biener wrote: Hmm, I think the fix is to clear DECL_NOT_GIMPLE_REG_P instead where the code clears TREE_ADDRESSABLE of 'arg' Ah, you are right. There's a patch that I've just tested. Patch can bootstrap on x86_64-linux-gnu and survives regression tests. Ready to

Re: [PATCH] ASAN: do not rewrite param for DECL_NOT_GIMPLE_REG_P.

2020-05-11 Thread Richard Biener via Gcc-patches
On Mon, May 11, 2020 at 1:26 PM Martin Liška wrote: > > Hi. > > Starting from r11-165-geb72dc663e9070b2 we should not rewrite parameters that > have DECL_NOT_GIMPLE_REG_P set to true. > > Patch can bootstrap on x86_64-linux-gnu and survives regression tests. > > Ready to be installed? Hmm, I

[PATCH] ASAN: do not rewrite param for DECL_NOT_GIMPLE_REG_P.

2020-05-11 Thread Martin Liška
Hi. Starting from r11-165-geb72dc663e9070b2 we should not rewrite parameters that have DECL_NOT_GIMPLE_REG_P set to true. Patch can bootstrap on x86_64-linux-gnu and survives regression tests. Ready to be installed? Thanks, Martin gcc/ChangeLog: 2020-05-11 Martin Liska PR