Re: [PATCH] Backport gettext fixes to get rid of warnings on macOS

2018-09-18 Thread Jeff Law
On 9/6/18 4:36 AM, Simon Marchi wrote: > On 2018-08-01 03:58 PM, Simon Marchi wrote: >> This patch was tested to build binutils-gdb on GNU/Linux and macOS. It can >> be >> applied to the gcc repo too, after fixing some trivial merge conflicts >> (someone >> else will need to do it, as I don't

Re: [PATCH] Backport gettext fixes to get rid of warnings on macOS

2018-09-06 Thread Simon Marchi
On 2018-08-01 03:58 PM, Simon Marchi wrote: > This patch was tested to build binutils-gdb on GNU/Linux and macOS. It can be > applied to the gcc repo too, after fixing some trivial merge conflicts > (someone > else will need to do it, as I don't have push access to gcc). Although I > think >

Re: [PATCH] Backport gettext fixes to get rid of warnings on macOS

2018-08-02 Thread Simon Marchi
On 2018-08-02 13:44, Tom Tromey wrote: "Simon" == Simon Marchi writes: Simon> intl/ChangeLog: Simon> * libgnuintl.h (_INTL_MAY_RETURN_STRING_ARG, gettext, dgettext, Simon> dcgettext, ngettext, dngettext, dcngettext): Backport changes Simon> from upstream gettext. Thanks, I

Re: [PATCH] Backport gettext fixes to get rid of warnings on macOS

2018-08-02 Thread Tom Tromey
> "Simon" == Simon Marchi writes: Simon> intl/ChangeLog: Simon> * libgnuintl.h (_INTL_MAY_RETURN_STRING_ARG, gettext, dgettext, Simon> dcgettext, ngettext, dngettext, dcngettext): Backport changes Simon> from upstream gettext. Thanks, I think you should check this in. Tom

Re: [PATCH] Backport gettext fixes to get rid of warnings on macOS

2018-08-01 Thread Simon Marchi
On 2018-08-01 10:58, Simon Marchi wrote: This patch was tested to build binutils-gdb on GNU/Linux and macOS. It can be applied to the gcc repo too, after fixing some trivial merge conflicts (someone else will need to do it, as I don't have push access to gcc). Although I think it is

[PATCH] Backport gettext fixes to get rid of warnings on macOS

2018-08-01 Thread Simon Marchi
This patch was tested to build binutils-gdb on GNU/Linux and macOS. It can be applied to the gcc repo too, after fixing some trivial merge conflicts (someone else will need to do it, as I don't have push access to gcc). Although I think it is relatively low-risk, building gcc on macOS was not