Re: [PATCH] Character length cleanup for Coarray Fortran library

2018-02-22 Thread Janne Blomqvist
On Thu, Feb 22, 2018 at 11:46 AM, Janne Blomqvist wrote: > On Thu, Feb 22, 2018 at 2:36 AM, Damian Rouson > wrote: >> Hi Janne, >> >> To be more specific, the new OpenCoarrays test failures after applying the >> patch are the following

Re: [PATCH] Character length cleanup for Coarray Fortran library

2018-02-22 Thread Janne Blomqvist
On Thu, Feb 22, 2018 at 2:36 AM, Damian Rouson wrote: > Hi Janne, > > To be more specific, the new OpenCoarrays test failures after applying the > patch are the following ones: > > image_fail_test_1 (Timeout) > image_fail_and_sync_test_2 (Timeout) >

Re: [PATCH] Character length cleanup for Coarray Fortran library

2018-02-21 Thread Damian Rouson
Hi Janne, To be more specific, the new OpenCoarrays test failures after applying the patch are the following ones:  image_fail_test_1 (Timeout)  image_fail_and_sync_test_2 (Timeout)  image_fail_and_sync_test_3 (Timeout)  image_fail_and_get_test_1 (Timeout) There

Re: [PATCH] Character length cleanup for Coarray Fortran library

2018-02-21 Thread Izaak Beekman
Reach out to Damian or me if you encounter any frustration. You should be all set with a recent version of CMake and MPICH or OpenMPI installed. It should look something like: git clone https://github.com/sourceryinstitute/OpenCoarrays cd OpenCoarrays mkdir build cd build export

Re: [PATCH] Character length cleanup for Coarray Fortran library

2018-02-21 Thread Janne Blomqvist
On Wed, Feb 21, 2018 at 10:18 PM, Damian Rouson wrote: > > > > > On February 21, 2018 at 11:35:47 AM, Janne Blomqvist > (blomqvist.ja...@gmail.com(mailto:blomqvist.ja...@gmail.com)) wrote: > >> PING >> >> Is anybody planning to work on this on the opencoarrays side?

Re: [PATCH] Character length cleanup for Coarray Fortran library

2018-02-21 Thread Janne Blomqvist
PING Is anybody planning to work on this on the opencoarrays side? Or do you prefer that this is just committed and you can sort it out on your own schedule? On Sat, Feb 10, 2018 at 11:20 PM, Janne Blomqvist wrote: > On Sat, Feb 10, 2018 at 9:34 PM, Damian Rouson >

Re: [PATCH] Character length cleanup for Coarray Fortran library

2018-02-21 Thread Damian Rouson
  On February 21, 2018 at 11:35:47 AM, Janne Blomqvist (blomqvist.ja...@gmail.com(mailto:blomqvist.ja...@gmail.com)) wrote: > PING > > Is anybody planning to work on this on the opencoarrays side? Or do > you prefer that this is just committed and you can sort it out on your > own

Re: [PATCH] Character length cleanup for Coarray Fortran library

2018-02-10 Thread Janne Blomqvist
On Sat, Feb 10, 2018 at 9:34 PM, Damian Rouson wrote: > > I’ll try applying the patch and testing it. As such, I'm sure that will fail as the patch changes the coarray API and thus needs corresponding changes on the OpenCoarrays side as well. > I have about a 50%

Re: [PATCH] Character length cleanup for Coarray Fortran library

2018-02-10 Thread Damian Rouson
  I’ll try applying the patch and testing it.  I have about a 50% success rate with getting patches to apply cleanly.  Is this available on an svn or git branch that I can just checkout rather than attempting to apply the patch?  I find that process to be much more reliable.  Going forward,

Re: [PATCH] Character length cleanup for Coarray Fortran library

2018-02-09 Thread Steve Kargl
On Fri, Feb 09, 2018 at 06:10:46PM +0200, Janne Blomqvist wrote: > Following the change to use size_t for Fortran character lengths (PR > 78534), this patch modifies the Coarray ABI in a similar way. The > single-image implementation that is included in libgfortran is > updated, but this needs

[PATCH] Character length cleanup for Coarray Fortran library

2018-02-09 Thread Janne Blomqvist
Following the change to use size_t for Fortran character lengths (PR 78534), this patch modifies the Coarray ABI in a similar way. The single-image implementation that is included in libgfortran is updated, but this needs corresponding work in the OpenCoarray library as well for multi-image