Re: [PATCH] Do not copy NULL string with memcpy.

2020-06-05 Thread Richard Biener via Gcc-patches
On June 4, 2020 10:22:55 PM GMT+02:00, Alexandre Oliva wrote: >On Jun 3, 2020, Martin Liška wrote: > >> On 6/3/20 5:58 AM, Alexandre Oliva wrote: >>> Please let me know if you'd prefer me to take this PR over. > >> Yes, please take a look. > >Here's what I've regstrapped on x86_64-linux-gnu.

Re: [PATCH] Do not copy NULL string with memcpy.

2020-06-04 Thread Alexandre Oliva
On Jun 3, 2020, Martin Liška wrote: > On 6/3/20 5:58 AM, Alexandre Oliva wrote: >> Please let me know if you'd prefer me to take this PR over. > Yes, please take a look. Here's what I've regstrapped on x86_64-linux-gnu. It makes both memcpy calls conditional, and reorders the length

Re: [PATCH] Do not copy NULL string with memcpy.

2020-06-02 Thread Martin Liška
On 6/3/20 5:58 AM, Alexandre Oliva wrote: Please let me know if you'd prefer me to take this PR over. Yes, please take a look. Martin

Re: [PATCH] Do not copy NULL string with memcpy.

2020-06-02 Thread Alexandre Oliva
Hello, Martin, On Jun 2, 2020, Martin Liška wrote: > The problem happens when we generate temp file > for .res file. Tested locally with the problematic > options. Thanks for looking into this. > Ready for master? Erhm, no, I don't think that's correct. With local analysis, the length

[PATCH] Do not copy NULL string with memcpy.

2020-06-02 Thread Martin Liška
The problem happens when we generate temp file for .res file. Tested locally with the problematic options. Ready for master? Thanks, Martin gcc/ChangeLog: PR driver/95456 * gcc.c (do_spec_1): Append to tempfile only when input_basename != NULL. --- gcc/gcc.c | 2 +- 1