Re: [PATCH] Emit DW_AT_inline for C++17 inline variables (take 2)

2016-11-01 Thread Mark Wielaard
On Wed, 2016-11-02 at 00:08 +0100, Mark Wielaard wrote: > That seemed to have been the last usage of origin_die in gen_variable_die. > So removing that caused: > > /home/mark/src/gcc/gcc/dwarf2out.c: In function ‘void gen_variable_die(tree, > tree, dw_die_ref)’: >

Re: [PATCH] Emit DW_AT_inline for C++17 inline variables (take 2)

2016-11-01 Thread Mark Wielaard
On Tue, Nov 01, 2016 at 01:20:23PM -0400, Jason Merrill wrote: > On Tue, Nov 1, 2016@12:10 PM, Jakub Jelinek wrote: > > + && !get_AT (var_die, DW_AT_inline) > > + && (origin_die == NULL || get_AT (origin_die, DW_AT_inline) == > > NULL) > > Can we drop this

Re: [PATCH] Emit DW_AT_inline for C++17 inline variables (take 2)

2016-11-01 Thread Jason Merrill
On Tue, Nov 1, 2016 at 12:10 PM, Jakub Jelinek wrote: > + && !get_AT (var_die, DW_AT_inline) > + && (origin_die == NULL || get_AT (origin_die, DW_AT_inline) == NULL) Can we drop this repetition (here and for DW_AT_const_expr)? get_AT should look through

[PATCH] Emit DW_AT_inline for C++17 inline variables (take 2)

2016-11-01 Thread Jakub Jelinek
On Mon, Oct 31, 2016 at 10:38:40AM -0400, Jason Merrill wrote: > > The current DWARF 5 wording is: > > "If the variable entry represents the defining declaration for a C++ static > > data > > member of a structure, class or union, the entry has a DW_AT_specification > > attribute, whose value is

Re: [PATCH] Emit DW_AT_inline for C++17 inline variables

2016-10-31 Thread Jason Merrill
On Mon, Oct 31, 2016 at 10:25 AM, Jakub Jelinek wrote: > On Mon, Oct 31, 2016 at 09:52:28AM -0400, Jason Merrill wrote: >> On 10/14/2016 01:33 PM, Jakub Jelinek wrote: >> >This also uses the infrastructure of the langhook patch I've sent earlier. >> >It emits (if not strict

Re: [PATCH] Emit DW_AT_inline for C++17 inline variables

2016-10-31 Thread Jakub Jelinek
On Mon, Oct 31, 2016 at 09:52:28AM -0400, Jason Merrill wrote: > On 10/14/2016 01:33 PM, Jakub Jelinek wrote: > >This also uses the infrastructure of the langhook patch I've sent earlier. > >It emits (if not strict dwarf) DW_AT_inline on explicit or implicit inline > >variables, and also tweaks

Re: [PATCH] Emit DW_AT_inline for C++17 inline variables

2016-10-31 Thread Jason Merrill
On 10/14/2016 01:33 PM, Jakub Jelinek wrote: This also uses the infrastructure of the langhook patch I've sent earlier. It emits (if not strict dwarf) DW_AT_inline on explicit or implicit inline variables, and also tweaks dwarf2out so that for inline static data members we consider in-class

[PATCH] Emit DW_AT_inline for C++17 inline variables

2016-10-14 Thread Jakub Jelinek
Hi! This also uses the infrastructure of the langhook patch I've sent earlier. It emits (if not strict dwarf) DW_AT_inline on explicit or implicit inline variables, and also tweaks dwarf2out so that for inline static data members we consider in-class declarations as definitions (emit