Re: [PATCH] Ensure noce_convert_multiple_sets handles only multiple sets (PR rtl-optimization/69570)

2016-02-01 Thread Richard Biener
On February 1, 2016 9:26:38 PM GMT+01:00, Jakub Jelinek wrote: >On Mon, Feb 01, 2016 at 09:39:19AM +0100, Steven Bosscher wrote: >> Browny points for opting out of the loop over all insns in the basic >> block when count > limit. > >Like this? >Bootstrapped/regtested on

Re: [PATCH] Ensure noce_convert_multiple_sets handles only multiple sets (PR rtl-optimization/69570)

2016-02-01 Thread Jakub Jelinek
On Mon, Feb 01, 2016 at 09:39:19AM +0100, Steven Bosscher wrote: > Browny points for opting out of the loop over all insns in the basic > block when count > limit. Like this? Bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk? 2016-02-01 Jakub Jelinek

Re: [PATCH] Ensure noce_convert_multiple_sets handles only multiple sets (PR rtl-optimization/69570)

2016-02-01 Thread Steven Bosscher
On Mon, Feb 1, 2016 at 9:32 AM, Jakub Jelinek wrote: > Bootstrapped/regtested on > {x86_64,i686,ppc64,ppc64le,s390,s390x,aarch64}-linux, > ok for trunk? OK. Browny points for opting out of the loop over all insns in the basic block when count > limit. Ciao! Steven

[PATCH] Ensure noce_convert_multiple_sets handles only multiple sets (PR rtl-optimization/69570)

2016-02-01 Thread Jakub Jelinek
Hi! While looking at this PR (which is most likely a reg-stack or RA bug triggered by the ifcvt noce_convert_multiple_sets additions), I've noticed that despite the "multiple_sets" in the name it actually attempts to handle not just multiple sets, but also the single set case, which is already