Re: [PATCH] Fix C++ ref op= ICE in the gimplifier with -g (PR c++/84704)

2018-03-06 Thread Jakub Jelinek
On Tue, Mar 06, 2018 at 08:56:14AM +0100, Richard Biener wrote: > > Maybe a better fix if we run into this would be to make create_tmp_var_raw > > create DECL_NAMELESS decls and make sure we don't print names of > > DECL_NAMELESS variables in -fdump-final-insns= dumps? > > They are already

Re: [PATCH] Fix C++ ref op= ICE in the gimplifier with -g (PR c++/84704)

2018-03-05 Thread Richard Biener
On Tue, 6 Mar 2018, Jakub Jelinek wrote: > On Tue, Mar 06, 2018 at 02:28:40AM -0300, Alexandre Oliva wrote: > > On Mar 5, 2018, Jakub Jelinek wrote: > > > > > * tree.c (stabilize_reference_1): Return save_expr (e) for > > > STATEMENT_LIST even if it doesn't have

Re: [PATCH] Fix C++ ref op= ICE in the gimplifier with -g (PR c++/84704)

2018-03-05 Thread Jakub Jelinek
On Tue, Mar 06, 2018 at 02:28:40AM -0300, Alexandre Oliva wrote: > On Mar 5, 2018, Jakub Jelinek wrote: > > > * tree.c (stabilize_reference_1): Return save_expr (e) for > > STATEMENT_LIST even if it doesn't have side-effects. > > I'm concerned about codegen

Re: [PATCH] Fix C++ ref op= ICE in the gimplifier with -g (PR c++/84704)

2018-03-05 Thread Alexandre Oliva
On Mar 5, 2018, Jakub Jelinek wrote: > * tree.c (stabilize_reference_1): Return save_expr (e) for > STATEMENT_LIST even if it doesn't have side-effects. I'm concerned about codegen differences in case the statement list is created because of debug stmts not

[PATCH] Fix C++ ref op= ICE in the gimplifier with -g (PR c++/84704)

2018-03-05 Thread Jakub Jelinek
Hi! The following testcase ICEs, because ARRAY_REF on lhs of op= has a statement list with no side-effects as index (containing DEBUG_BEGIN_STMT and integer_zero_node), stabilize_reference does nothing to it (as it has no side-effects), then the array ref is unshared in unshare_body